Re: [PATCH v2 2/6] Fix test_login in test_user_browser.py

[Andrew Donnellan]

On 04/08/16 16:10, Daniel Axtens wrote:

It tried to use the pbkdf2 hash as the password. Use the username instead, as 
that
is what create_user sets.

Then it compared the test user username to testuser, rather than the username, 
which
is dynamically generated. Compare to the generated username.

Signed-off-by: Daniel Axtens 


All looks good.

Reviewed-by: Andrew Donnellan 

--
Andrew Donnellan  OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com  IBM Australia Limited

___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork

[PATCH v2 2/6] Fix test_login in test_user_browser.py

[Daniel Axtens]

It tried to use the pbkdf2 hash as the password. Use the username instead, as 
that
is what create_user sets.

Then it compared the test user username to testuser, rather than the username, 
which
is dynamically generated. Compare to the generated username.

Signed-off-by: Daniel Axtens 
---
 patchwork/tests/test_user_browser.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/patchwork/tests/test_user_browser.py 
b/patchwork/tests/test_user_browser.py
index 13503f50d959..d09b3413e737 100644
--- a/patchwork/tests/test_user_browser.py
+++ b/patchwork/tests/test_user_browser.py
@@ -36,7 +36,7 @@ class LoginTestCase(SeleniumTestCase):
 def test_login(self):
 self.get(reverse('auth_login'))
 self.enter_text('username', self.user.username)
-self.enter_text('password', self.user.password)
+self.enter_text('password', self.user.username)
 self.click('input[value="Login"]')
 dropdown = self.wait_until_visible('a.dropdown-toggle strong')
-self.assertEqual(dropdown.text, 'testuser')
+self.assertEqual(dropdown.text, self.user.username)
-- 
2.7.4

___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork