Re: [PD] Large File Support on Linux (was: readsf fails to read 32 bits float wav)

2013-03-16 Thread Charles Goyard
Hi,

after some research, it seems more related to the size of the file after
all. I thought the problem was 32 bits files because it worked when I
converted them to 16 bits. But it was just the file size dropped under
2gb.

To sum up: a file over about 2Gb fails to open. This is related to how
Linux handles large files on 32 bits systems.

On my test patch I get the done bang as soon as I send the start
message.

Reading the code, it looks like the s_path.c/sys_open() oflags is
missing O_LARGEFILE support. pd-extended and pd-l2ork suffer from the
same.

Am I right there's no Large File Support for pd on 32 bits Linux ? If so
that's a major shortcoming, and something a bit heavy to fix. Does it
work out of the box on 64 bits linux ?

Thanks,

-- 
Charles

Hans-Christoph Steiner wrote:
 
 Sounds like it, especially if you can reproduce it everytime.  File a
 bug report and include as simple a patch as possible to reproduce the
 issue, and the soundfile.
 
  today I noticed a readsf~ (on vanilla) opening a 5 wave file containing
  32 bits float audio fails silently. The doc says 4 bytes is unavailable
  for AIFF, but I use WAVE.
  
  The file is a 5 channels WAVE file with 5 tracks 32bits float at 48kHz.
  
  Converting the audio to 16 bits PCM works.
  
  Is that a bug ? On vanilla 0.44.

___
Pd-list@iem.at mailing list
UNSUBSCRIBE and account-management - 
http://lists.puredata.info/listinfo/pd-list


Re: [PD] Large File Support on Linux (was: readsf fails to read 32 bits float wav)

2013-03-16 Thread Charles Goyard
Darn, I just found there's a feature request for just that from IOhannes
pending since 2007.

https://sourceforge.net/tracker/index.php?func=detailaid=1638701group_id=55736atid=478073

Cheers,
-- 
Charles


Charles Goyard wrote:
 Hi,
 
 after some research, it seems more related to the size of the file after
 all. I thought the problem was 32 bits files because it worked when I
 converted them to 16 bits. But it was just the file size dropped under
 2gb.
 
 To sum up: a file over about 2Gb fails to open. This is related to how
 Linux handles large files on 32 bits systems.
 
 On my test patch I get the done bang as soon as I send the start
 message.
 
 Reading the code, it looks like the s_path.c/sys_open() oflags is
 missing O_LARGEFILE support. pd-extended and pd-l2ork suffer from the
 same.
 
 Am I right there's no Large File Support for pd on 32 bits Linux ? If so
 that's a major shortcoming, and something a bit heavy to fix. Does it
 work out of the box on 64 bits linux ?
 
 Thanks,
 
 -- 
 Charles
 
 Hans-Christoph Steiner wrote:
  
  Sounds like it, especially if you can reproduce it everytime.  File a
  bug report and include as simple a patch as possible to reproduce the
  issue, and the soundfile.
  
   today I noticed a readsf~ (on vanilla) opening a 5 wave file containing
   32 bits float audio fails silently. The doc says 4 bytes is unavailable
   for AIFF, but I use WAVE.
   
   The file is a 5 channels WAVE file with 5 tracks 32bits float at 48kHz.
   
   Converting the audio to 16 bits PCM works.
   
   Is that a bug ? On vanilla 0.44.

___
Pd-list@iem.at mailing list
UNSUBSCRIBE and account-management - 
http://lists.puredata.info/listinfo/pd-list


Re: [PD] Large File Support on Linux (was: readsf fails to read 32 bits float wav)

2013-03-16 Thread Miller Puckette
It's in the source - but Pd has to be compiled with '_LARGEFILE64_SOURCE'
defined for this to work.  Through 0.43 the configure script I was using
was checking for this somehow (too complicted for me to understand how).

Anyhow, this is a bug all right - thanks for reporting it!

... and can you tell me what OS you're on so I can check if I'm actually
fixing it?

thanks
Miller



On Sat, Mar 16, 2013 at 10:57:46PM +0100, Charles Goyard wrote:
 Darn, I just found there's a feature request for just that from IOhannes
 pending since 2007.
 
 https://sourceforge.net/tracker/index.php?func=detailaid=1638701group_id=55736atid=478073
 
 Cheers,
 -- 
 Charles
 
 
 Charles Goyard wrote:
  Hi,
  
  after some research, it seems more related to the size of the file after
  all. I thought the problem was 32 bits files because it worked when I
  converted them to 16 bits. But it was just the file size dropped under
  2gb.
  
  To sum up: a file over about 2Gb fails to open. This is related to how
  Linux handles large files on 32 bits systems.
  
  On my test patch I get the done bang as soon as I send the start
  message.
  
  Reading the code, it looks like the s_path.c/sys_open() oflags is
  missing O_LARGEFILE support. pd-extended and pd-l2ork suffer from the
  same.
  
  Am I right there's no Large File Support for pd on 32 bits Linux ? If so
  that's a major shortcoming, and something a bit heavy to fix. Does it
  work out of the box on 64 bits linux ?
  
  Thanks,
  
  -- 
  Charles
  
  Hans-Christoph Steiner wrote:
   
   Sounds like it, especially if you can reproduce it everytime.  File a
   bug report and include as simple a patch as possible to reproduce the
   issue, and the soundfile.
   
today I noticed a readsf~ (on vanilla) opening a 5 wave file containing
32 bits float audio fails silently. The doc says 4 bytes is unavailable
for AIFF, but I use WAVE.

The file is a 5 channels WAVE file with 5 tracks 32bits float at 48kHz.

Converting the audio to 16 bits PCM works.

Is that a bug ? On vanilla 0.44.
 
 ___
 Pd-list@iem.at mailing list
 UNSUBSCRIBE and account-management - 
 http://lists.puredata.info/listinfo/pd-list

___
Pd-list@iem.at mailing list
UNSUBSCRIBE and account-management - 
http://lists.puredata.info/listinfo/pd-list