Re: [pdt-dev] H2 index in DLTK
Hi Roy, - Roy Ganor wrote: > Hi Alex, > Moving to the h2-based index by default makes perfectly sense as many > PDT users reported significant performance improvements. It will also > make the people worked on this method very happy ;) > > We don't have any internal tests for this method but all tests that > currently work on top of the h2-indexing itself should provide a good > picture on possible flaws. > > Several questions that cross my mind: > 1. Will DLTK bundle/maintain the basic index mechanism (not the > h2-one). Can we make it as an extra feature like h2-index is now? That's why I am touching it: I would like to avoid having 2 index implementations. > 2. Since currently h2 database is available in a more updated version > as confirmed by Eclipse IP process (1.117) it will make sense to not > bundle h2 inside the plugin/feature but leave adopters to use whatever > version they want. I always was for making h2.jar available externally :) But we need to check that Helios build can find it somewhere. > 3. There is a nice framework (org.eclipse.test.performance) that > Michael contributed that checks for performance regressions. It will > be nice to run it under the two methods and provide a benchmark. Do > you think DLTK build system can monitor changes and provide it? org.eclipse.test.performance can compare performance metrics of different versions(builds) of the same tests. We tried it for some time, but it's disabled now to reduce build time. > 4. Using the h2-based index is a big step forward, however there is > always a place for improvement. Since PDT is currently the (only > AFAIK) one that adopts this plugin, it makes sense to consult in this > forum before changes are done. Definitely we'll discuss the changes first. > > Best regards, > Roy > -Original Message- > From: pdt-dev-boun...@eclipse.org [mailto:pdt-dev-boun...@eclipse.org] > On Behalf Of Alex Panchenko > Sent: Monday, March 01, 2010 5:34 PM > To: PDT Developers > Subject: [pdt-dev] H2 index in DLTK > > Hi all, > > I was looking if it makes sense to move all DLTK indexing into H2. > And if DLTK will go this way probably I'll make some changes to these > plugins. > Do you have any concerns about it? > > And the related question: do you have any standalone unit tests for > the index implementation? > > Thank you, > Alex > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev > > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev
RE: [pdt-dev] H2 index in DLTK
Hi Alex, Moving to the h2-based index by default makes perfectly sense as many PDT users reported significant performance improvements. It will also make the people worked on this method very happy ;) We don't have any internal tests for this method but all tests that currently work on top of the h2-indexing itself should provide a good picture on possible flaws. Several questions that cross my mind: 1. Will DLTK bundle/maintain the basic index mechanism (not the h2-one). Can we make it as an extra feature like h2-index is now? 2. Since currently h2 database is available in a more updated version as confirmed by Eclipse IP process (1.117) it will make sense to not bundle h2 inside the plugin/feature but leave adopters to use whatever version they want. 3. There is a nice framework (org.eclipse.test.performance) that Michael contributed that checks for performance regressions. It will be nice to run it under the two methods and provide a benchmark. Do you think DLTK build system can monitor changes and provide it? 4. Using the h2-based index is a big step forward, however there is always a place for improvement. Since PDT is currently the (only AFAIK) one that adopts this plugin, it makes sense to consult in this forum before changes are done. Best regards, Roy -Original Message- From: pdt-dev-boun...@eclipse.org [mailto:pdt-dev-boun...@eclipse.org] On Behalf Of Alex Panchenko Sent: Monday, March 01, 2010 5:34 PM To: PDT Developers Subject: [pdt-dev] H2 index in DLTK Hi all, I was looking if it makes sense to move all DLTK indexing into H2. And if DLTK will go this way probably I'll make some changes to these plugins. Do you have any concerns about it? And the related question: do you have any standalone unit tests for the index implementation? Thank you, Alex ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev
[pdt-dev] H2 index in DLTK
Hi all, I was looking if it makes sense to move all DLTK indexing into H2. And if DLTK will go this way probably I'll make some changes to these plugins. Do you have any concerns about it? And the related question: do you have any standalone unit tests for the index implementation? Thank you, Alex ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev
Re: [pdt-dev] Extending the project wizard
I don't think if that's really necessary. I've something like this working now, by extending the PHPProjectCreationWizard, and overriding the addPages() method, where i added my custom page. If you need to add stuff to specific pages, you can extend the specific page too and override createControl(Composite parent) method. Do you think this approach has disadvantages ? best -robert On Mar 1, 2010, at 3:02 PM, Alex Panchenko wrote: > Hi Robert, > > Not yet. I'll try to find some time for it during March. > Thanks for reminder :) > > Regards, > Alex > > - Original Message - > From: "Robert Gruendler" > To: "PDT Developers" > Sent: Thursday, February 25, 2010 2:31:37 AM GMT +06:00 Almaty, Novosibirsk > Subject: Re: [pdt-dev] Extending the project wizard > > Hi Alex, > > is the refactoring regarding the ProjectWizard done ? > > thanks! > > -robert > > > On Nov 14, 2009, at 4:17 AM, Alex Panchenko wrote: > >> Hi, >> >> The plan is to move some code parts from TCL project wizard into base DLTK >> project wizard. >> I hope to do it before Christmas. >> >> Regards, >> Alex >> >> - Original Message - >> From: "Robert Gründler" >> To: pdt-dev@eclipse.org >> Sent: Saturday, November 14, 2009 1:41:44 AM GMT +06:00 Almaty, Novosibirsk >> Subject: Re: [pdt-dev] Extending the project wizard >> >> Hi again, >> >> the DLTK team recommended me to have a look at the TCL Project Creation >> wizard, however, it simply >> extends the dltk project wizard, which means i would need to implement >> the Project wizard for the framework >> completely by scratch, plus re-implement the functionality the php >> project wizard provides right now. >> >> Are there any plans for the near future to implement either the >> wizard-extension points or the solution >> recommended by Konstantin using the facet project framework? >> >> best >> >> -robert >> >> >> >> >> Am 11/6/09 6:45 PM, schrieb Michael Spector: >>> I think it's a question to DLTK team, since PDT extends DLTK's project >>> wizard. >>> >>> Best regards, >>> Michael >>> >>> On Fri, Nov 6, 2009 at 7:37 PM, Konstantin Komissarchik >>> wrote: >>> PDT Team, As a side note, has there been any further thoughts on utilizing faceted project framework in PDT? Using the framework would give extenders like Robert a natural way to build on PDT projects with little effort on the part of PDT. - Konstantin -Original Message- From: pdt-dev-boun...@eclipse.org [mailto:pdt-dev-boun...@eclipse.org] On Behalf Of Robert Gründler Sent: Friday, November 06, 2009 9:32 AM To: pdt-dev@eclipse.org Subject: [pdt-dev] Extending the project wizard Hi, i would like to extend the php project wizard, but according to this post to the mailing list, the phpwizardpages extension is not used anymore: http://dev.eclipse.org/newslists/news.eclipse.tools.pdt/msg03659.html Does anoyne know if it's possible to add some UI elements to the pdt "New Project..." wizard ? thanks ! -robert ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev No virus found in this incoming message. Checked by AVG - www.avg.com Version: 8.5.425 / Virus Database: 270.14.51/2482 - Release Date: 11/06/09 07:38:00 ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> ___ >>> pdt-dev mailing list >>> pdt-dev@eclipse.org >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> >> >> ___ >> pdt-dev mailing list >> pdt-dev@eclipse.org >> https://dev.eclipse.org/mailman/listinfo/pdt-dev >> ___ >> pdt-dev mailing list >> pdt-dev@eclipse.org >> https://dev.eclipse.org/mailman/listinfo/pdt-dev > > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev
Re: [pdt-dev] Extending the project wizard
Hi Robert, Not yet. I'll try to find some time for it during March. Thanks for reminder :) Regards, Alex - Original Message - From: "Robert Gruendler" To: "PDT Developers" Sent: Thursday, February 25, 2010 2:31:37 AM GMT +06:00 Almaty, Novosibirsk Subject: Re: [pdt-dev] Extending the project wizard Hi Alex, is the refactoring regarding the ProjectWizard done ? thanks! -robert On Nov 14, 2009, at 4:17 AM, Alex Panchenko wrote: > Hi, > > The plan is to move some code parts from TCL project wizard into base DLTK > project wizard. > I hope to do it before Christmas. > > Regards, > Alex > > - Original Message - > From: "Robert Gründler" > To: pdt-dev@eclipse.org > Sent: Saturday, November 14, 2009 1:41:44 AM GMT +06:00 Almaty, Novosibirsk > Subject: Re: [pdt-dev] Extending the project wizard > > Hi again, > > the DLTK team recommended me to have a look at the TCL Project Creation > wizard, however, it simply > extends the dltk project wizard, which means i would need to implement > the Project wizard for the framework > completely by scratch, plus re-implement the functionality the php > project wizard provides right now. > > Are there any plans for the near future to implement either the > wizard-extension points or the solution > recommended by Konstantin using the facet project framework? > > best > > -robert > > > > > Am 11/6/09 6:45 PM, schrieb Michael Spector: >> I think it's a question to DLTK team, since PDT extends DLTK's project >> wizard. >> >> Best regards, >> Michael >> >> On Fri, Nov 6, 2009 at 7:37 PM, Konstantin Komissarchik >> wrote: >> >>> PDT Team, >>> >>> As a side note, has there been any further thoughts on utilizing faceted >>> project framework in PDT? Using the framework would give extenders like >>> Robert a natural way to build on PDT projects with little effort on the part >>> of PDT. >>> >>> - Konstantin >>> >>> >>> -Original Message- >>> From: pdt-dev-boun...@eclipse.org [mailto:pdt-dev-boun...@eclipse.org] On >>> Behalf Of Robert Gründler >>> Sent: Friday, November 06, 2009 9:32 AM >>> To: pdt-dev@eclipse.org >>> Subject: [pdt-dev] Extending the project wizard >>> >>> Hi, >>> >>> i would like to extend the php project wizard, but according to this post >>> to the mailing list, the phpwizardpages extension is not used anymore: >>> >>> http://dev.eclipse.org/newslists/news.eclipse.tools.pdt/msg03659.html >>> >>> Does anoyne know if it's possible to add some UI elements to the >>> pdt "New Project..." wizard ? >>> >>> >>> thanks ! >>> >>> >>> -robert >>> ___ >>> pdt-dev mailing list >>> pdt-dev@eclipse.org >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> >>> No virus found in this incoming message. >>> Checked by AVG - www.avg.com >>> Version: 8.5.425 / Virus Database: 270.14.51/2482 - Release Date: 11/06/09 >>> 07:38:00 >>> >>> ___ >>> pdt-dev mailing list >>> pdt-dev@eclipse.org >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> >>> >> ___ >> pdt-dev mailing list >> pdt-dev@eclipse.org >> https://dev.eclipse.org/mailman/listinfo/pdt-dev >> > > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev > ___ > pdt-dev mailing list > pdt-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/pdt-dev ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev ___ pdt-dev mailing list pdt-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/pdt-dev
