Re: [pdt-dev] Code formatter contribution for PDT

2013-05-20 Thread Robert Gründler
great, thanks for the info.



On Mon, May 20, 2013 at 11:22 AM, Jacek Pospychała <
jacek.pospych...@gmail.com> wrote:

> yes.
> It already went through IP review and was added to the nightly builds,
> so there's nothing to stop it from Kepler.
>
> On Mon, May 20, 2013 at 11:13 AM, Robert Gründler 
> wrote:
> > one more question: Will the new formatter be released with Kepler?
> >
> >
> > regards
> >
> > -robert
> >
> >
> >
> >
> >
> > On Wed, May 15, 2013 at 8:43 AM, Robert Gründler 
> > wrote:
> >>
> >> Cool, thanks a lot for the info.
> >>
> >>
> >> The formatter has one major advantage over the one written by atlanto:
> it
> >> supports region based formatting.
> >>
> >> I've noticed it has the same issue like the pdt-eg formatter, it doesn't
> >> preserve indentation for fluent interface calls, e.g:
> >>
> >>
> >> $this
> >> ->getMockBuilder('SomeClass')
> >> ->disableOriginalConstructor()
> >> ->getMock()
> >> ;
> >>
> >> will be formatted to:
> >>
> >> $this->getMockBuilder('SomeClass')
> >> ->disableOriginalConstructor()
> >> ->getMock();
> >>
> >>
> >> But that's minor i guess ;)
> >>
> >>
> >> -robert
> >>
> >>
> >>
> >>
> >> On Mon, May 13, 2013 at 10:18 PM, Seva Lapsha 
> >> wrote:
> >>>
> >>> That's great news!
> >>>
> >>>
> >>> On Mon, May 13, 2013 at 3:43 PM, Jacek Pospychała
> >>>  wrote:
> 
>  hi,
> 
>  I'd like to draw your attention to this bugzilla:
>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=407768
> 
>  There's a new code formatter contribution for PDT. It's now scheduled
>  for IP review and after that is highly likely to be included into PDT.
> 
>  Early adopters and PDT extenders, please don't hesitate to give it a
>  try and share your feedback!
> 
>  thanks
> 
>  Jacek
>  ___
>  pdt-dev mailing list
>  pdt-dev@eclipse.org
>  https://dev.eclipse.org/mailman/listinfo/pdt-dev
> >>>
> >>>
> >>>
> >>> ___
> >>> pdt-dev mailing list
> >>> pdt-dev@eclipse.org
> >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
> >>>
> >>
> >>
> >>
> >> --
> >> phone +43 676 64 57 240
> >>
> >> Zieglergasse 65/6
> >> 1070 Vienna
> >> Austria
> >>
> >> twitter.com/pulse00
> >> github.com/pulse00
> >
> >
> >
> >
> > --
> > phone +43 676 64 57 240
> >
> > Zieglergasse 65/6
> > 1070 Vienna
> > Austria
> >
> > twitter.com/pulse00
> > github.com/pulse00
> >
> > ___
> > pdt-dev mailing list
> > pdt-dev@eclipse.org
> > https://dev.eclipse.org/mailman/listinfo/pdt-dev
> >
> ___
> pdt-dev mailing list
> pdt-dev@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>



-- 
phone +43 676 64 57 240

Zieglergasse 65/6
1070 Vienna
Austria

twitter.com/pulse00
github.com/pulse00
___
pdt-dev mailing list
pdt-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/pdt-dev


Re: [pdt-dev] Code formatter contribution for PDT

2013-05-20 Thread Jacek Pospychała
yes.
It already went through IP review and was added to the nightly builds,
so there's nothing to stop it from Kepler.

On Mon, May 20, 2013 at 11:13 AM, Robert Gründler  wrote:
> one more question: Will the new formatter be released with Kepler?
>
>
> regards
>
> -robert
>
>
>
>
>
> On Wed, May 15, 2013 at 8:43 AM, Robert Gründler 
> wrote:
>>
>> Cool, thanks a lot for the info.
>>
>>
>> The formatter has one major advantage over the one written by atlanto: it
>> supports region based formatting.
>>
>> I've noticed it has the same issue like the pdt-eg formatter, it doesn't
>> preserve indentation for fluent interface calls, e.g:
>>
>>
>> $this
>> ->getMockBuilder('SomeClass')
>> ->disableOriginalConstructor()
>> ->getMock()
>> ;
>>
>> will be formatted to:
>>
>> $this->getMockBuilder('SomeClass')
>> ->disableOriginalConstructor()
>> ->getMock();
>>
>>
>> But that's minor i guess ;)
>>
>>
>> -robert
>>
>>
>>
>>
>> On Mon, May 13, 2013 at 10:18 PM, Seva Lapsha 
>> wrote:
>>>
>>> That's great news!
>>>
>>>
>>> On Mon, May 13, 2013 at 3:43 PM, Jacek Pospychała
>>>  wrote:

 hi,

 I'd like to draw your attention to this bugzilla:
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=407768

 There's a new code formatter contribution for PDT. It's now scheduled
 for IP review and after that is highly likely to be included into PDT.

 Early adopters and PDT extenders, please don't hesitate to give it a
 try and share your feedback!

 thanks

 Jacek
 ___
 pdt-dev mailing list
 pdt-dev@eclipse.org
 https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>>
>>>
>>>
>>> ___
>>> pdt-dev mailing list
>>> pdt-dev@eclipse.org
>>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>>
>>
>>
>>
>> --
>> phone +43 676 64 57 240
>>
>> Zieglergasse 65/6
>> 1070 Vienna
>> Austria
>>
>> twitter.com/pulse00
>> github.com/pulse00
>
>
>
>
> --
> phone +43 676 64 57 240
>
> Zieglergasse 65/6
> 1070 Vienna
> Austria
>
> twitter.com/pulse00
> github.com/pulse00
>
> ___
> pdt-dev mailing list
> pdt-dev@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>
___
pdt-dev mailing list
pdt-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/pdt-dev


Re: [pdt-dev] Code formatter contribution for PDT

2013-05-20 Thread Robert Gründler
one more question: Will the new formatter be released with Kepler?


regards

-robert





On Wed, May 15, 2013 at 8:43 AM, Robert Gründler wrote:

> Cool, thanks a lot for the info.
>
>
> The formatter has one major advantage over the one written by atlanto: it
> supports region based formatting.
>
> I've noticed it has the same issue like the pdt-eg formatter, it doesn't
> preserve indentation for fluent interface calls, e.g:
>
>
> $this
> ->getMockBuilder('SomeClass')
> ->disableOriginalConstructor()
> ->getMock()
> ;
>
> will be formatted to:
>
> $this->getMockBuilder('SomeClass')
> ->disableOriginalConstructor()
> ->getMock();
>
>
> But that's minor i guess ;)
>
>
> -robert
>
>
>
>
> On Mon, May 13, 2013 at 10:18 PM, Seva Lapsha wrote:
>
>> That's great news!
>>
>>
>> On Mon, May 13, 2013 at 3:43 PM, Jacek Pospychała <
>> jacek.pospych...@gmail.com> wrote:
>>
>>> hi,
>>>
>>> I'd like to draw your attention to this bugzilla:
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=407768
>>>
>>> There's a new code formatter contribution for PDT. It's now scheduled
>>> for IP review and after that is highly likely to be included into PDT.
>>>
>>> Early adopters and PDT extenders, please don't hesitate to give it a
>>> try and share your feedback!
>>>
>>> thanks
>>>
>>> Jacek
>>> ___
>>> pdt-dev mailing list
>>> pdt-dev@eclipse.org
>>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>>
>>
>>
>> ___
>> pdt-dev mailing list
>> pdt-dev@eclipse.org
>> https://dev.eclipse.org/mailman/listinfo/pdt-dev
>>
>>
>
>
> --
> phone +43 676 64 57 240
>
> Zieglergasse 65/6
> 1070 Vienna
> Austria
>
> twitter.com/pulse00
> github.com/pulse00
>



-- 
phone +43 676 64 57 240

Zieglergasse 65/6
1070 Vienna
Austria

twitter.com/pulse00
github.com/pulse00
___
pdt-dev mailing list
pdt-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/pdt-dev