[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #16 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #15 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-26 14:24:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #14 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #8 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #10 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #8 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

--- Comment #9 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #11 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

--- Comment #12 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #10 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

--- Comment #11 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #10 from Fedora Update System  ---
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/perl-Text-Fuzzy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #5 from Denis Fateyev  ---
Ok, will do. Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #6 from Upstream Release Monitoring 
 ---
dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903941

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #1 from Petr Šabata  ---
* Missing builddeps: gcc, perl-devel

* I'm not sure $LDFLAGS contains anything; consider using %{?__global_ldflags}.

* Consider packaging the examples directory as %doc.

* Again, you could drop the coreutils build dep if you modify the find calls.

* And again, this module also technically requires Test::More 0.88+.  Don't
  worry about it; I'm just mentioning it for completeness :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Petr Šabata  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
   Assignee|nob...@fedoraproject.org|psab...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #2 from Upstream Release Monitoring 
 ---
dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903164

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #3 from Denis Fateyev  ---
(In reply to Petr Šabata from comment #1)
> * Missing builddeps: gcc, perl-devel

Added.

> * I'm not sure $LDFLAGS contains anything; consider using
> %{?__global_ldflags}.

In RHEL7 it contains not much though:
  # rpm -E '%{?__global_ldflags}'
  -Wl,-z,relro

Although the changed version should fit everything:
  export LDFLAGS="%{?__global_ldflags} -Wl,-z,now -Wl,--as-needed"

> * Consider packaging the examples directory as %doc.

Added.

> * And again, this module also technically requires Test::More 0.88+.  Don't
>   worry about it; I'm just mentioning it for completeness :)

Well, since epel7 has 0.98 (and Fedoras even newer) I initially dropped it; but
returned back for now.

Updated version:
Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec
SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Petr Šabata  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Petr Šabata  ---
Almost there :)

* Some of the example scripts are executable.
  chmod a-x -c examples/*pl

* rpmlint complains about the script interpreter for them, too.
  perl -pi -e 's|#!.*$|#!/usr/bin/perl|' examples/*pl


I'm going to approve this review now but, please, fix these before building
the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305263

Denis Fateyev  changed:

   What|Removed |Added

 CC||perl-devel@lists.fedoraproj
   ||ect.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org