Re: What is the Value of t/0-signature.t?

2006-03-09 Thread Andreas J. Koenig
> On Thu, 9 Mar 2006 12:51:02 -0800, chromatic <[EMAIL PROTECTED]> said:

  > Hi all,
  > In http://rt.cpan.org/Ticket/Display.html?id=17934, a Test::MockObject user 
  > dislikes the t/0-signature.t test that always runs.

I have filed a couple of bug reports against distributions with a
wrong signature and I have even released such myself. Now, with a
combination of having t/0-signature.t and a dependency from 'release'
to 'disttest', this cannot happen.

qed:)
-- 
andreas


Re: What is the Value of t/0-signature.t?

2006-03-09 Thread Adam Kennedy

I've started to do a little bit of work on Module::Signature.

The main problem seemed to be that it will install even if it's 
configuration cannot be confirmed, when I think it might be preferable 
to not install at all if it cannot be confirmed.


I've also move Module::Signature into the Module::Install repository 
(which seems to be fast becoming an orphanage for collaboratively 
maintaining installation toolchain modules without a strongly active 
author).


So if anyone already has commit for Module::Install and can think of 
small improvemens to make, you should be able to help fix Module::Signature.


Adam K

Yuval Kogman wrote:

On Thu, Mar 09, 2006 at 12:51:02 -0800, chromatic wrote:


Hi all,

In http://rt.cpan.org/Ticket/Display.html?id=17934, a Test::MockObject user 
dislikes the t/0-signature.t test that always runs.  If the user does not 
have Module::Signature installed, no tests run.  If the user does have 
Module::Signature installed but not configured properly, the test will fail.



The problem with these is that Module::Signature fails when it
should warn if the key is not present in the user's keyring.

If this technical issue is solved then regardless of whether or not
signature tests are useless (i think they are, but then again i also
think i have some modules with Test::Distribution that checks
that... so I am a hypocrit ;-) the usability of these tests will be
good enough.

(I'm CCing audrey so that she'll know I'm dissing her module ;-)



Re: What is the Value of t/0-signature.t?

2006-03-09 Thread Yuval Kogman
On Thu, Mar 09, 2006 at 12:51:02 -0800, chromatic wrote:
> Hi all,
> 
> In http://rt.cpan.org/Ticket/Display.html?id=17934, a Test::MockObject user 
> dislikes the t/0-signature.t test that always runs.  If the user does not 
> have Module::Signature installed, no tests run.  If the user does have 
> Module::Signature installed but not configured properly, the test will fail.

The problem with these is that Module::Signature fails when it
should warn if the key is not present in the user's keyring.

If this technical issue is solved then regardless of whether or not
signature tests are useless (i think they are, but then again i also
think i have some modules with Test::Distribution that checks
that... so I am a hypocrit ;-) the usability of these tests will be
good enough.

(I'm CCing audrey so that she'll know I'm dissing her module ;-)

-- 
 ()  Yuval Kogman <[EMAIL PROTECTED]> 0xEBD27418  perl hacker &
 /\  kung foo master: /me beats up some cheese: neeyah!



pgplZzUEPZqRa.pgp
Description: PGP signature


What is the Value of t/0-signature.t?

2006-03-09 Thread chromatic
Hi all,

In http://rt.cpan.org/Ticket/Display.html?id=17934, a Test::MockObject user 
dislikes the t/0-signature.t test that always runs.  If the user does not 
have Module::Signature installed, no tests run.  If the user does have 
Module::Signature installed but not configured properly, the test will fail.

If it is the case that CPAN and CPANPLUS check signatures, if the user has the 
proper modules installed, is there value in including this test with signed 
distributions?

-- c