Re: Test labels

2004-12-08 Thread Mark Stosberg
 On Mon, Dec 06, 2004 at 10:28:45PM -0600, Andy Lester wrote:
 I think even better than 
 
   ok( $expr, name );
 
 or
 
   ok( $expr, comment );
 
 is
 
   ok( $expr, label );
 
 RJBS points out that comment implies not really worth doing, and I
 still don't like name because it implies (to me) a unique identifier.
 We also talked about description, but description is just s
 overloaded.

I prefer name or label to comment. 

Name does not imply 'unique' for me, just like 'John Smith' 
is not expected to a unique name of a person. 

Mark

-- 
http://mark.stosberg.com/ 



Re: Test labels

2004-12-07 Thread H.Merijn Brand
On Tue 07 Dec 2004 05:28, Andy Lester [EMAIL PROTECTED] wrote:
 I think even better than 
 
   ok( $expr, name );
 
 or
 
   ok( $expr, comment );
 
 is
 
   ok( $expr, label );

or ok ($expr, indicator);
or ok ($expr, tag);

for me the name/comment/label/tag/indicator/... is just a tag (which does not
have to be unique) to be able to find back my test in the test script. As long
as all tests run fine, you don't read them, so tag sounds best to me

 RJBS points out that comment implies not really worth doing, and I
 still don't like name because it implies (to me) a unique identifier.
 We also talked about description, but description is just s
 overloaded.

-- 
H.Merijn BrandAmsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.5,  5.9.x, and 809 on  HP-UX 10.20  11.00, 11i,
   AIX 4.3, AIX 5.2, SuSE 9.1, and Win2k.  http://www.cmve.net/~merijn/
http:[EMAIL PROTECTED]/   [EMAIL PROTECTED]
send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org




Re: Test labels

2004-12-07 Thread Stevan Little
I don't really agree that comment implies not really worth doing. I 
think
those inclined to not put a name/comment/label on their test will not 
do it
whatever we end up calling it. IMO the only way to get people to do it 
would
be to make it required, and I don't think that is a good idea.

I like label, but to me that also implies a (somewhat-less-than-name) 
unique identifier.

I also like H. Merjin's suggestions of tag, however it might be 
confusing to the more
web-inclinded. (Tag as in shirt-tag, not as in HTML-tag)

Personally I use them like comments, so that makes the most sense to me.
Steve
On Dec 6, 2004, at 11:28 PM, Andy Lester wrote:
I think even better than
  ok( $expr, name );
or
  ok( $expr, comment );
is
  ok( $expr, label );
RJBS points out that comment implies not really worth doing,
and I still don't like name because it implies (to me) a unique 
identifier.
We also talked about description, but description is just s
overloaded.

Thoughts?
xoxo,
Andy
--
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance