Re: OT: Script Review Process

[John_Wunderlich]

Ed;

I don't know that I'd want a code review on every script I write! I'm all for consistency and quality controls, but reviewing everything kind of takes away from one of the reasons that I use perl for in the first place. That being said, anything that I write that is for production use is put into a source control and versioning system (we use MKS, but whatever). That makes it visible to other developers, and allows for the how do we maintain it after he's run over by a bus problem. Major production systems are a product of team development and are peer reviewd. It works for us but TMTOWTDI

John








[EMAIL PROTECTED]
Sent by: [EMAIL PROTECTED]
2002/10/16 05:43 PM


To:[EMAIL PROTECTED]
cc:
Subject:OT: Script Review Process





My organization writes a lot of scripts - mostly, but not totally, in perl.
Some of the stuff we do is quick and dirty one-time use and some of the
code we write drives full-blown web applications. We also have varying
degrees of skill and knowledge which of course leads to varying degrees of
code quality. What we don't have, but would like to, is some sort of
centralized code review committee to make sure that all our code is meeting
some minimal level of quality. Does anyone out there have any sage wisdom
to pass along or some good links to get me started?

Thanks,
Ed


___
Perl-Win32-Users mailing list
[EMAIL PROTECTED]
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs




**
This e-mail and any files transmitted with it are considered 
confidential and are intended solely for the use of the 
individual or entity to whom they are addressed (intended).  
This communication is subject to agent/client privilege. 
If you are not the intended recipient (received in error) or 
the person responsible for delivering the e-mail to the 
intended recipient, be advised that you have received this 
e-mail in error and that any use, dissemination, forwarding, 
printing or copying of this e-mail is strictly prohibited.  If 
you have received this e-mail in error please notify the 
sender immediately.

**

RE: OT: Script Review Process

[Aaron Trevena]

There has been some recent discussions at use.perl.org (in the journals)
about code review, the conclusion being that it can be very rewarding if
applied well.

The first thing to decide is the goals of the review :
is it to ensure guidelines and standards are followed (in which case some
elements can be automated) ?
Is it to ensure that the code is of a certain quality, and if so how would
that quality be defined?
finally how and when would it be done ?

I have seen very little code reviewing done in anger - once I reviewed some
of the near-legendary Acme's code discovered that I needed to get a better
understanding of Map, the other time I just ran some code past one of the
more senior developers and he pointed out any problems he saw.

This shows that often your more senior developers won't get their code
reviewed well if at all, and that junior developers can gain as much from
decent training as from review.

I think one of the great things at a previous employer was that Seminars
were held weekly on the technonology (HTML::Templates one week, CMS design
another), and code was run past senior developers occasionally.

When you combine this with documentation standards (we were working on that)
and coding standards/guidelines (like always use strict and -wT, always pass
by reference, avoid hash/array slices, always use /x and comments in regex's
over a certain length, always use stantard configuration modules where
possible, etc) you can have a very high quality of code and ensure that the
work is a) rewarding for developers and b) of a decent quality so less time
is spent wasting time/money firefighting.

regards,

A.


___
Perl-Win32-Users mailing list
[EMAIL PROTECTED]
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs