[Perl/perl5] 36a088: embed.fnc - remove redundant deprecate_xxx() macro...
Branch: refs/heads/yves/removed_redundant_decl Home: https://github.com/Perl/perl5 Commit: 36a0884647f96e24e91395af1015f70f56b8f95b https://github.com/Perl/perl5/commit/36a0884647f96e24e91395af1015f70f56b8f95b Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M embed.fnc M proto.h Log Message: --- embed.fnc - remove redundant deprecate_xxx() macro declarations autodoc.pl gets unhappy if you document a macro in place and ALSO list it in embed.fnc. The warnings it produce tend to get crowded out from a parallel make, but @iabyn noticed and (rightly) complained. This removes the redundant definitions.
[Perl/perl5] d231d7: t/porting/test_testlist.t - test that we test the ...
Branch: refs/heads/yves/more_testlist_testing Home: https://github.com/Perl/perl5 Commit: d231d751c705f47ef75d8e6d67f12d5d99e1fd5d https://github.com/Perl/perl5/commit/d231d751c705f47ef75d8e6d67f12d5d99e1fd5d Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M MANIFEST M t/TEST M t/harness A t/porting/test_testlist.t Log Message: --- t/porting/test_testlist.t - test that we test the same thing with t/harness and t/TEST Also that we test everything expected in MANIFEST. Also includes some fixups to t/TEST to deal with the fact that List/Util is not anymore the name of a distribution even though it is the name of an extension. Same for Cwd.
[Perl/perl5]
Branch: refs/heads/yves/more_testlist_testing Home: https://github.com/Perl/perl5
[Perl/perl5]
Branch: refs/heads/yves/regex_engine_tweaks_for_iabyn Home: https://github.com/Perl/perl5
[Perl/perl5] 1ed8aa: pp_ctl.c - don't overallocate paren buffers in rxr...
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 1ed8aa9fdf7c8713cc895a86e3f9f22f89dfd200 https://github.com/Perl/perl5/commit/1ed8aa9fdf7c8713cc895a86e3f9f22f89dfd200 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M pp_ctl.c M regexp.h Log Message: --- pp_ctl.c - don't overallocate paren buffers in rxres_save(). This was added as part of a different fix and was not properly reverted when that fix was put on hold. This should only be applied if we do adopt the patch which adds "start_new" and "end_new" to the regexp_paren_pair structure. Commit: b16c8aa582a2f6fe12c09c7eb93ada71b0d85300 https://github.com/Perl/perl5/commit/b16c8aa582a2f6fe12c09c7eb93ada71b0d85300 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M regcomp.h M regcomp_internal.h Log Message: --- regcomp.h - document RE_PESSIMISTIC_PARENS and VOLATILE_REF defines These two defines are related to each other, and even though VOLATILE_REF is not explicitly used in regexec.c which would require it being placed in regcomp.h, it is implicitly, and RE_PESSIMISTIC_PARENS *is* used in regexec.c. So put them both in regcomp.h and document them together. This adds copious documentation for what they both are for. RE_PESSIMISTIC_PARENS is effectively a "build option" (although intended for debugging regex engine bugs only). VOLATILE_REF is the name of a flag which is used to mark REF nodes as requiring special backtracking support in regexec.c Commit: 4e8d2a44ec279a3ec8c930baf1b5396ed7f7eb5a https://github.com/Perl/perl5/commit/4e8d2a44ec279a3ec8c930baf1b5396ed7f7eb5a Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M t/re/re_tests Log Message: --- t/re/re_tests - fixup version for change Commit: ee28315c4f7ca8c3a906dd002aa63bdc067c3425 https://github.com/Perl/perl5/commit/ee28315c4f7ca8c3a906dd002aa63bdc067c3425 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M regexp.h Log Message: --- regexp.h - document lastcp and cp in regmatch_state and standardized member order, and line up comments and struct members and other whitspace fixes. The internal tabs and messed up layout was hurting my eyes. Commit: 0d5b46c9e4cecc121ba79df380cde0ae037d16f7 https://github.com/Perl/perl5/commit/0d5b46c9e4cecc121ba79df380cde0ae037d16f7 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M pod/perldiag.pod M regcomp.c Log Message: --- regcomp.c - throw an error if we have more U16_MAX open parens. We use U16 for various internal logic related to parens. If we exceed this count stuff is going to go silently wrong. Might as well throw a proper error during compilation to detect this. Commit: 4d51d5bc07c99bc5811ccbae1503b27d813e0743 https://github.com/Perl/perl5/commit/4d51d5bc07c99bc5811ccbae1503b27d813e0743 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M dist/Devel-PPPort/parts/embed.fnc M embed.fnc M embed.h M perl.h M proto.h M regen/embed.pl M regexec.c Log Message: --- regen/embed.pl - change _aDEPTH and _pDEPTH to not have a leading underbar The leading underbar is reserved by C. These defines are debugging only "recursion" depth related counters injected into the function macro wrappers when a function is marked as 'W', much the same way that aTHX_ and pTHX_ are when building under threaded builds. The functions are expected to incremented the depth parameter themselves. Note that "recursion" is quoted above because in practice currently they are only used by the regex engine when recursing virtually, and they do not relate to true C stack related recursion. (But they could be used for tracking C level recursion under debugging if someone needed it.) Commit: b3703faa10166966785f9e5de78ffc972823a979 https://github.com/Perl/perl5/commit/b3703faa10166966785f9e5de78ffc972823a979 Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M embed.fnc M embed.h M proto.h M regexec.c Log Message: --- regexec.c - convert CAPTURE_CLEAR into an inline static function This makes it easier to debug, and type checks parameters and the like. It does make it somewhat slower in debug mode, but so what. Commit: b6b3bfb8b86974050b15778fdd27d1b2580ad80a https://github.com/Perl/perl5/commit/b6b3bfb8b86974050b15778fdd27d1b2580ad80a Author: Yves Orton Date: 2023-03-19 (Sun, 19 Mar 2023) Changed paths: M embed.fnc M embed.h M proto.h M regexec.c Log Message: --- regexec.c - convert UNWIND_PAREN() into an inline static function This makes it easier to debug, and type checks parameters and the like. It does make it somewhat slower in debug mode, but
[Perl/perl5] 4e0f29: Mark vtbl argument in sv_unmagicext const
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 4e0f29b2722407db1a7a662bb226850576c7aca4 https://github.com/Perl/perl5/commit/4e0f29b2722407db1a7a662bb226850576c7aca4 Author: Leon Timmermans Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M embed.fnc M proto.h M sv.c Log Message: --- Mark vtbl argument in sv_unmagicext const Commit: 7e782439cfcb8fc251201ee657e2e330ba944500 https://github.com/Perl/perl5/commit/7e782439cfcb8fc251201ee657e2e330ba944500 Author: Leon Timmermans Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M dist/Devel-PPPort/parts/embed.fnc M dist/Devel-PPPort/parts/inc/magic Log Message: --- Mark vtbl argument in sv_unmagicext const in PPPort as well Compare: https://github.com/Perl/perl5/compare/260e30211bac...7e782439cfcb
[Perl/perl5] 260e30: proto.h - fixup remove unneeded define
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 260e30211bacb8994ba95f8149e9ca43d093d397 https://github.com/Perl/perl5/commit/260e30211bacb8994ba95f8149e9ca43d093d397 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M proto.h Log Message: --- proto.h - fixup remove unneeded define This is build product from a make regen.
[Perl/perl5]
Branch: refs/heads/yves/deprecation_subcategories Home: https://github.com/Perl/perl5
[Perl/perl5] b27367: regcomp_internal.h - make unused macros for deprec...
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: b27367cd9b0173682dfe824a2d1d8d70c6f538c0 https://github.com/Perl/perl5/commit/b27367cd9b0173682dfe824a2d1d8d70c6f538c0 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M regcomp_internal.h Log Message: --- regcomp_internal.h - make unused macros for deprecation warnings take category as parameter we should have a deprecation category per type of deprecation Commit: 905584a6fe44cfcb198cc15af5e082ceb57ccf85 https://github.com/Perl/perl5/commit/905584a6fe44cfcb198cc15af5e082ceb57ccf85 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M embed.fnc M embed.h M proto.h M utf8.c Log Message: --- utf8.c - add category parameter to unused warn_on_first_deprecated_use function Commit: d81b4f9331172ed96e5382fe1e1091e9d4b85495 https://github.com/Perl/perl5/commit/d81b4f9331172ed96e5382fe1e1091e9d4b85495 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M lib/warnings.pm M pod/perldiag.pod M regen/warnings.pl M toke.c M warnings.h Log Message: --- warnings.pm - support deprecated::smartmatch category Currently we seem to lack a way to have a subcategory under deprecated. It seems reasonable to me that people might want to disable a specific subcategory warning while leaving the rest in place. This patch allows that. Note that both no warnings "deprecated"; and no warnings "deprecated::smartmatch"; work to disable the warning. Deprecated warnings shouldn't be "all or nothing", they should be specific and targetted. Commit: 21b005c93f9d47fdacd6d19b6e4bd297b891ab41 https://github.com/Perl/perl5/commit/21b005c93f9d47fdacd6d19b6e4bd297b891ab41 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M lib/warnings.pm M pod/perldiag.pod M pp_ctl.c M regen/warnings.pl M warnings.h Log Message: --- warnings.pm - add deprecated::dot_in_inc warings category Instead of using a generic warnings category switch to fine grained control. Commit: 25991c51d4866aeef3eeef13c1dc562fff82d7e4 https://github.com/Perl/perl5/commit/25991c51d4866aeef3eeef13c1dc562fff82d7e4 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M lib/warnings.pm M pod/perldiag.pod M regcomp.c M regen/warnings.pl M warnings.h Log Message: --- warnings.pm - support deprecated::unicode_property_name category This category is only used in the regex engine, we should be able to disable it specifically, as it seems like we will never actually remove demove support for the things it warns about. Commit: 25676a74796a9afdbb6efe609bbfc7e223921fae https://github.com/Perl/perl5/commit/25676a74796a9afdbb6efe609bbfc7e223921fae Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M lib/warnings.pm M pod/perldiag.pod M regen/warnings.pl M toke.c M warnings.h Log Message: --- warnings.pm - add deprecated::apostrophe_as_package_separator as new deprecation category This category is about use of apostrophe as a package separator, eg for things like "Test::More::isn't()". Commit: 71e49ade7b75dfc7d9e1cd013ddd9558a739e722 https://github.com/Perl/perl5/commit/71e49ade7b75dfc7d9e1cd013ddd9558a739e722 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M lib/warnings.pm M pod/perldiag.pod M regen/warnings.pl M toke.c M warnings.h Log Message: --- warnings.pm - add deprecated::delimiter_will_be_paired category Some delimiters are considered deprecated because in the future they will be used as part of a paired delimiter. This adds a new category for these cases. Commit: 2d8fceed5417cb8fcc169f35f36ea58b7bb9cded https://github.com/Perl/perl5/commit/2d8fceed5417cb8fcc169f35f36ea58b7bb9cded Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M handy.h M lib/warnings.pm M pod/perldiag.pod M pp_ctl.c M regen/warnings.pl M warnings.h Log Message: --- warnings.pm - add deprecated::goto_construct category This category applies to attempts to goto the internals of a block construct. Commit: b689ed93d1ae924a59738611b98517cbe071b1ab https://github.com/Perl/perl5/commit/b689ed93d1ae924a59738611b98517cbe071b1ab Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M handy.h M lib/warnings.pm M op.c M pod/perldiag.pod M regen/warnings.pl M warnings.h Log Message: --- warnings.pm - add deprecated::version_downgrade category This also fixes the version_downgrade to show the correct version that version downgrades will be removed in. Commit:
[Perl/perl5] 5753ce: t/lib/GH_15109 - rename to t/lib/caller
Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 5753ce0b56169a13e14034a26daefe8eafe8d614
https://github.com/Perl/perl5/commit/5753ce0b56169a13e14034a26daefe8eafe8d614
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M MANIFEST
R t/lib/GH_15109/Apack.pm
R t/lib/GH_15109/Bpack.pm
R t/lib/GH_15109/Cpack.pm
R t/lib/GH_15109/Foo.pm
A t/lib/caller/Apack.pm
A t/lib/caller/Bpack.pm
A t/lib/caller/Cpack.pm
A t/lib/caller/Foo.pm
M t/op/caller.t
Log Message:
---
t/lib/GH_15109 - rename to t/lib/caller
I want to use these modules in other tests, so changing the name
makes sense.
Commit: e2e830cd93e16aedc6c6225069eeb7bdfc431a43
https://github.com/Perl/perl5/commit/e2e830cd93e16aedc6c6225069eeb7bdfc431a43
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M regen/mg_vtable.pl
Log Message:
---
regen/mg_vtable.pl - rename confusing var %sig to %vtable_conf
Commit: 6dd040ff2f6f01a817731d112756188ddb541a18
https://github.com/Perl/perl5/commit/6dd040ff2f6f01a817731d112756188ddb541a18
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M embed.fnc
M embed.h
M proto.h
M sv.h
M sv_inline.h
Log Message:
---
sv.h - add SvREFCNT_dec_set_NULL()
and also SvREFCNT_dec_ret_NULL() which is used to implement
SvREFCNT_dec_set_NULL(). The set_NULL() macro is intended to
be used to replace code like this:
if (sv) {
SvREFCNT_dec_NN(sv);
sv = NULL;
}
The function form just facilitates it, and can be used in situations
where returning NULL after decrementing a refcount would be reduce
code complexity.
Commit: c5e777577e67bd04dabd02ea5f0419d64db968e8
https://github.com/Perl/perl5/commit/c5e777577e67bd04dabd02ea5f0419d64db968e8
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M pod/perldiag.pod
Log Message:
---
pod/perldiag.pod - provide full path to issues tracker
https://github.com/Perl/perl5/issues shows the list of open issues,
whereas https://github.com/Perl/perl5/issues/new/choose is where someone
can create a new ticket.
Commit: 98f6c100d916f65d489eb1ef4fb8aa60825a736c
https://github.com/Perl/perl5/commit/98f6c100d916f65d489eb1ef4fb8aa60825a736c
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M dist/threads-shared/lib/threads/shared.pm
M dist/threads-shared/shared.xs
Log Message:
---
threads-shared - fixup typo in comment
Commit: 2f920c2f73ae58b754ccf1d897f1104e0cc3a4c6
https://github.com/Perl/perl5/commit/2f920c2f73ae58b754ccf1d897f1104e0cc3a4c6
Author: Yves Orton
Date: 2023-03-18 (Sat, 18 Mar 2023)
Changed paths:
M MANIFEST
M embed.fnc
M embed.h
M ext/XS-APItest/APItest.pm
M ext/XS-APItest/APItest.xs
A ext/XS-APItest/t/mortal_destructor.t
M mg_names.inc
M mg_raw.h
M mg_vtable.h
M pod/perldiag.pod
M pod/perlguts.pod
M proto.h
M regen/mg_vtable.pl
M scope.c
M scope.h
Log Message:
---
scope.c - add mortal_destructor_sv() and mortal_svfunc_x()
The function SAVEDESTRUCTOR_X() (save_destructor_x) can be used to
execute a C function at the end of the current psuedo-block. Prior to
this patch there was no "mortal" equivalent that would execute at the
end of the current statement. We offer a collection of functions which
are intended to free SV's at either point in time, but only support
callbacks at the end of the current pseudo-block.
This patch adds two such functions, "mortal_destructor_sv" which can be
used to trigger a perl code reference to execute at the end of the
current statement, and "mortal_svfunc_x" which can be used to trigger an
SVFUNC_t C function at the end of the current statement.
Both functions differ from save_destructor_x() in that instead of
supporting a void pointer argument they both require their argument to
be some sort of SV pointer. The Perl callback function triggered by
"mortal_destructor_sv" may be provided no arguments, a single argument
or a list of arguments, depending on the type of argument provided to
mortal_destructor_sv(): when the argument is a raw AV (with no SV ref
wrapping it), then the contents of the AV are passed in as a list of
arguments. When the argument is anything else but NULL, the argument is
provided as a single argument, and when it is NULL the perl function is
called with no arguments.
Both functions are implemented on top of a mortal SV (unseen by the
user) which has PERL_MAGIC_destruct magic associated with it, which
triggers the destructor behavior when the SV is freed.
Both functions are provided with macros to match the normal SAVExx()
API, with MORTALDESTRUCTOR_SV() wrapping mortal_destructor_sv() and
MORTALSVFUNC_X() wrapping mortal_svfunc_x().
The heart of this logic cribbed
[Perl/perl5]
Branch: refs/heads/yves/require_hook_rebased Home: https://github.com/Perl/perl5
[Perl/perl5] e06adb: pp_ctl.c - don't overallocate paren buffers in rxr...
Branch: refs/heads/yves/regex_engine_tweaks_for_iabyn Home: https://github.com/Perl/perl5 Commit: e06adb63fc1db5faf582d59e2273d003b9202886 https://github.com/Perl/perl5/commit/e06adb63fc1db5faf582d59e2273d003b9202886 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M pp_ctl.c M regexp.h Log Message: --- pp_ctl.c - don't overallocate paren buffers in rxres_save(). This was added as part of a different fix and was not properly reverted when that fix was put on hold. This should only be applied if we do adopt the patch which adds "start_new" and "end_new" to the regexp_paren_pair structure. Commit: a92c736a384ec193605a15b6263e7ff4f36556c1 https://github.com/Perl/perl5/commit/a92c736a384ec193605a15b6263e7ff4f36556c1 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M regcomp.h M regcomp_internal.h Log Message: --- regcomp.h - document RE_PESSIMISTIC_PARENS and VOLATILE_REF defines These two defines are related to each other, and even though VOLATILE_REF is not explicitly used in regexec.c which would require it being placed in regcomp.h, it is implicitly, and RE_PESSIMISTIC_PARENS *is* used in regexec.c. So put them both in regcomp.h and document them together. This adds copious documentation for what they both are for. RE_PESSIMISTIC_PARENS is effectively a "build option" (although intended for debugging regex engine bugs only). VOLATILE_REF is the name of a flag which is used to mark REF nodes as requiring special backtracking support in regexec.c Commit: 0024c201fcb2772f19a30b703ca3b692a5dd1439 https://github.com/Perl/perl5/commit/0024c201fcb2772f19a30b703ca3b692a5dd1439 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M t/re/re_tests Log Message: --- t/re/re_tests - fixup version for change Commit: 0edf11d75c3e30e430986ce905013a745b3ba730 https://github.com/Perl/perl5/commit/0edf11d75c3e30e430986ce905013a745b3ba730 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M regexp.h Log Message: --- regexp.h - document lastcp and cp in regmatch_state and standardized member order, and line up comments and struct members and other whitspace fixes. The internal tabs and messed up layout was hurting my eyes. Commit: 150a193b8fd8381bec4e591a69828acf1fa8c0bd https://github.com/Perl/perl5/commit/150a193b8fd8381bec4e591a69828acf1fa8c0bd Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M pod/perldiag.pod M regcomp.c Log Message: --- regcomp.c - throw an error if we have more U16_MAX open parens. We use U16 for various internal logic related to parens. If we exceed this count stuff is going to go silently wrong. Might as well throw a proper error during compilation to detect this. Commit: ce86dd3aa1f214c251080036e4735c422f576a82 https://github.com/Perl/perl5/commit/ce86dd3aa1f214c251080036e4735c422f576a82 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M dist/Devel-PPPort/parts/embed.fnc M embed.fnc M embed.h M perl.h M proto.h M regen/embed.pl M regexec.c Log Message: --- regen/embed.pl - change _aDEPTH and _pDEPTH to not have a leading underbar The leading underbar is reserved by C. These defines are debugging only "recursion" depth related counters injected into the function macro wrappers when a function is marked as 'W', much the same way that aTHX_ and pTHX_ are when building under threaded builds. The functions are expected to incremented the depth parameter themselves. Note that "recursion" is quoted above because in practice currently they are only used by the regex engine when recursing virtually, and they do not relate to true C stack related recursion. (But they could be used for tracking C level recursion under debugging if someone needed it.) Commit: 3372f5901ed384fa4389bcb210045a66a0b5ffbd https://github.com/Perl/perl5/commit/3372f5901ed384fa4389bcb210045a66a0b5ffbd Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M embed.fnc M embed.h M proto.h M regexec.c Log Message: --- regexec.c - convert CAPTURE_CLEAR into an inline static function This makes it easier to debug, and type checks parameters and the like. It does make it somewhat slower in debug mode, but so what. Commit: f77d478532ab9ab28b5b1dc90e4246539715c911 https://github.com/Perl/perl5/commit/f77d478532ab9ab28b5b1dc90e4246539715c911 Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M embed.fnc M embed.h M proto.h M regexec.c Log Message: --- regexec.c - convert UNWIND_PAREN() into an inline static function This makes it easier to debug, and type checks parameters and the like. It does make it
[Perl/perl5] 518846: t/TEST - chomp manifest during read
Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 518846582427d7105e0c07610c06a78a5e77b08c https://github.com/Perl/perl5/commit/518846582427d7105e0c07610c06a78a5e77b08c Author: Yves Orton Date: 2023-03-18 (Sat, 18 Mar 2023) Changed paths: M t/TEST Log Message: --- t/TEST - chomp manifest during read If we chomp we return 2177 tests, if we don't we return 1808 tests.
