Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 80c1f1e45e8ef8c27d170fae7ade41971fe20218 https://github.com/Perl/perl5/commit/80c1f1e45e8ef8c27d170fae7ade41971fe20218 Author: Tony Cook <t...@develop-help.com> Date: 2022-08-31 (Wed, 31 Aug 2022)
Changed paths: M pp_hot.c M t/lib/warnings/pp_hot Log Message: ----------- only clear the stream error state in readline() for glob() This would previously clear the stream error state in any case where sv_gets() failed and the error state was set. This included normal files, which meant that the fact that an error occurred was no longer reflected in the stream state. For reads from ARGV this was a no-op, since nextargv() re-opens the input stream by calling do_open6() which closes the old input stream silently. For glob() (and really only for miniperl, since File::Glob is used for a full perl) leaving the stream in an error state could be confusing for the error reporting done when do_close() fails, since it would fail if the stream has an error state, but we report it as the underlying pclose() failing due to the child process failing in some way. Since this now leaves the error state on the stream, the close() calls in the test updated by this commit would fail, changing its output. Since the result of those closes didn't seem related to the purpose of the test, I changed it not throw an error on either close() failing. Commit: 0b602161d2f4c5e6b22144e9f8b9f8128a35f440 https://github.com/Perl/perl5/commit/0b602161d2f4c5e6b22144e9f8b9f8128a35f440 Author: Tony Cook <t...@develop-help.com> Date: 2022-08-31 (Wed, 31 Aug 2022) Changed paths: M t/op/readline.t Log Message: ----------- test that <> doesn't clear the stream error state Compare: https://github.com/Perl/perl5/compare/02cf5fb76fa9...0b602161d2f4