[Perl/perl5] b3a0a5: gv.c - use SVf_QUOTEDPREFIX in error message

2022-08-26 Thread Yves Orton via perl5-changes
  Branch: refs/heads/yves/quoted_prefix_followup
  Home:   https://github.com/Perl/perl5
  Commit: b3a0a5e1356f495dc935458a9ee5b38085e130f8
  
https://github.com/Perl/perl5/commit/b3a0a5e1356f495dc935458a9ee5b38085e130f8
  Author: Yves Orton 
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
M gv.c

  Log Message:
  ---
  gv.c - use SVf_QUOTEDPREFIX in error message

I overlooked this case when SVf_QUOTEDPREFIX was introduced




[Perl/perl5] b3a0a5: gv.c - use SVf_QUOTEDPREFIX in error message

2022-08-26 Thread Yves Orton via perl5-changes
  Branch: refs/heads/yves/move_endif
  Home:   https://github.com/Perl/perl5
  Commit: b3a0a5e1356f495dc935458a9ee5b38085e130f8
  
https://github.com/Perl/perl5/commit/b3a0a5e1356f495dc935458a9ee5b38085e130f8
  Author: Yves Orton 
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
M gv.c

  Log Message:
  ---
  gv.c - use SVf_QUOTEDPREFIX in error message

I overlooked this case when SVf_QUOTEDPREFIX was introduced


  Commit: f1886e10a63297209ad9c385b054717c4a089d8b
  
https://github.com/Perl/perl5/commit/f1886e10a63297209ad9c385b054717c4a089d8b
  Author: Yves Orton 
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
M perl.h

  Log Message:
  ---
  perl.h - move defines out of incorrect ifdef

Not sure how that happened in the original commit, but the
PERL_RAND_SEED related defines should not be conditional on anything
related to doubles.


  Commit: ebc2efe6583f7cf7ea29a7f94f7b7887a75ad3a7
  
https://github.com/Perl/perl5/commit/ebc2efe6583f7cf7ea29a7f94f7b7887a75ad3a7
  Author: Yves Orton 
  Date:   2022-08-26 (Fri, 26 Aug 2022)

  Changed paths:
M gv.c
M pod/perldiag.pod
M pp_sys.c
M t/lib/warnings/gv
M t/op/tie.t
M t/run/fresh_perl.t

  Log Message:
  ---
  error messages - do not repeat class names twice in our error messages

Showing the classname twice in the error message just increases
cognitive load understanding the message when the class/package name
is more than a few components long, and can easily make what should be
a simple one line error message wrap and be unreadable.

We can simply replace the second invocation of the class name by saying
"it" instead, and that is what this patch does. It is still friendly,
but not repetitive.

Thus:


Compare: https://github.com/Perl/perl5/compare/b3a0a5e1356f%5E...ebc2efe6583f