Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: c0c43c4cee85ee37cce9a0d8073adf058bc10dff https://github.com/Perl/perl5/commit/c0c43c4cee85ee37cce9a0d8073adf058bc10dff Author: Richard Leach <richardle...@users.noreply.github.com> Date: 2023-09-06 (Wed, 06 Sep 2023)
Changed paths: M class.c Log Message: ----------- pp_initfield: no need to extend av, should be the desired size This was probably an accidental leftover after an early pull request changed AV creation to `av = newAV_alloc_x(count)` just above the removed line. Commit: f357b86a6592ee8216c004039cbbb51ffa14f78f https://github.com/Perl/perl5/commit/f357b86a6592ee8216c004039cbbb51ffa14f78f Author: Richard Leach <richardle...@users.noreply.github.com> Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M class.c Log Message: ----------- Perl_class_wrap_method_body: simple push to newly-created AV Since the AV has just been created and is simple in nature, there's no need to do a full-blown `av_push`. Technically, that's still overkill. Simplification could be taken further by creating the `fieldmap` AV with `PadnamelistMAX(pnl) - 2` items (when that is a >0 value), then directly assigning values into elements. But it's not clear (to me) if that would be worth doing. Compare: https://github.com/Perl/perl5/compare/008ae6a0ef7f...f357b86a6592