Branch: refs/heads/yves/ws_cleanup_headers Home: https://github.com/Perl/perl5 Commit: e56662350ea9ee09c9350d730bccb0bc873c41c9 https://github.com/Perl/perl5/commit/e56662350ea9ee09c9350d730bccb0bc873c41c9 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022)
Changed paths: M regen/regcomp.pl Log Message: ----------- regen/regcomp.pl - make robust to line continuations in header files I noticed that tests fail if some of these defines are changed to use a line continuation. This fixes the problem. For instance, some of the defines that are parsed by this code are rather long and if they get broken into a multiline statement with C pre processor style line continuations they would get dropped from regnodes.h and our debug output. Commit: 973818450085ba252f62de9b5da13f389b4d2ce7 https://github.com/Perl/perl5/commit/973818450085ba252f62de9b5da13f389b4d2ce7 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M ext/XS-APItest/t/locale.t Log Message: ----------- XS-APItest/t/locale.t - deal with indented values properly The old code used a regex that would split on exactly one space, so if the data was changed to have more than one then it would get absorbed into the name that was parsed out of the header file, leading the code to test for things like "FOO ", which of course don't exist. Likely this could have caused other issues too, but the defines in practice are single symbols. Commit: 76c64ff8c77b5f75be8b61684e6ab1cd81b2ba47 https://github.com/Perl/perl5/commit/76c64ff8c77b5f75be8b61684e6ab1cd81b2ba47 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M XSUB.h Log Message: ----------- XSUB.h - line up properly and make sure they are shorter than 80 cols Commit: 4addb626fc2761bbf7ee11d093733364b11df27f https://github.com/Perl/perl5/commit/4addb626fc2761bbf7ee11d093733364b11df27f Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M handy.h Log Message: ----------- handy.h - remove unused macros None of these are used anymore. See c62fdeb784c7643c90d2ea8c2ec0f03a548da338 for more details. Commit: 692ba0cb3995b218bfe347ee6226f3e685337bff https://github.com/Perl/perl5/commit/692ba0cb3995b218bfe347ee6226f3e685337bff Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M perlio.h Log Message: ----------- perlio.h - break long comment line Commit: c01cbf1e7dba16ca9c704458b029113fc93711bc https://github.com/Perl/perl5/commit/c01cbf1e7dba16ca9c704458b029113fc93711bc Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M cop.h Log Message: ----------- cop.h - fix incorrect var name in comment (PL_in_eval) Someone missed an '_' in the name in the comment, the correct name is 'PL_in_eval' not 'PL in_eval'. Commit: ae0d07ff1b746c59427b9a7d80703d264764681c https://github.com/Perl/perl5/commit/ae0d07ff1b746c59427b9a7d80703d264764681c Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M handy.h Log Message: ----------- handy.h - join a comment together into one line a later commit will resplit this again Commit: d6a81c18925345c4b96adb14595f8be54cc41804 https://github.com/Perl/perl5/commit/d6a81c18925345c4b96adb14595f8be54cc41804 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M utfebcdic.h Log Message: ----------- utfebcdic.h - fix comment indent Commit: 48e625667652cc6f9d6013eb462d5ae7ddbea1b0 https://github.com/Perl/perl5/commit/48e625667652cc6f9d6013eb462d5ae7ddbea1b0 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M handy.h Log Message: ----------- handy.h - fix typo in comment Commit: d70eb7f02ebc8145ed5afdb1c306a401148c060d https://github.com/Perl/perl5/commit/d70eb7f02ebc8145ed5afdb1c306a401148c060d Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M intrpvar.h Log Message: ----------- intrpvar.h - break comment over multiple lines Commit: 5aa1ca03acb9498e0202eb02c5246e138b52de9b https://github.com/Perl/perl5/commit/5aa1ca03acb9498e0202eb02c5246e138b52de9b Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M pad.h Log Message: ----------- pad.h - reword comment to be more legible The prevous verbiage ended the comment with the term "padnamelist *", which put the "*" right next to the end comment marker, which was a bit confusing. This wording put the * in the middle of the sentence where it is clear it is not a mistake. Also note that the previous text used tabs internally, and so this change /looks/ like it is off indent, it is not, it is lined up with the surrounding lines. Commit: 786484c7d3c3a305f4fab51368543a85a069788c https://github.com/Perl/perl5/commit/786484c7d3c3a305f4fab51368543a85a069788c Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M intrpvar.h Log Message: ----------- intrpvar.h - reword comment to be easier to understand and wrap. The old text was difficult to wrap and a little disjointed in terms of readibility. This captures the same essence but in a more concise and easier to wrap form. Commit: 20b5abea0aa7f7d526c940063df6a28e699faf11 https://github.com/Perl/perl5/commit/20b5abea0aa7f7d526c940063df6a28e699faf11 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M zaphod32_hash.h Log Message: ----------- zaphod32_hash.h - rework comment to be more legible Commit: decb12149ca1651ae0ca3fe61bb23f2304faa87a https://github.com/Perl/perl5/commit/decb12149ca1651ae0ca3fe61bb23f2304faa87a Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M regen/regcomp.pl Log Message: ----------- regen/regcomp.pl - deal with multiline comment Changing a long single line comment to a multiline comment would cause the comment to be dropped from regnodes.h. This ensures the comment is included in the regnodes output. Commit: d4af4a8a0837bcf16846696097d43d7478f82482 https://github.com/Perl/perl5/commit/d4af4a8a0837bcf16846696097d43d7478f82482 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M util.h Log Message: ----------- util.h - remove slash to make line easier to autowrap later Commit: b79955a86d036a2a85fb81b3527d9ebb2a6b4a67 https://github.com/Perl/perl5/commit/b79955a86d036a2a85fb81b3527d9ebb2a6b4a67 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M cv.h Log Message: ----------- cv.h - remove left sidecomment star Commit: adef511c19f027ebac9fab7c42a85066b0e342ad https://github.com/Perl/perl5/commit/adef511c19f027ebac9fab7c42a85066b0e342ad Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M EXTERN.h Log Message: ----------- EXTERN.h - Add whitespace to comment to make more readable Makes it a bit more clear that this is documenting two things. Commit: 65eef621b22c6910d3599af04874a6042d7fdefc https://github.com/Perl/perl5/commit/65eef621b22c6910d3599af04874a6042d7fdefc Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M op_reg_common.h Log Message: ----------- op_reg_common.h - break long defines Commit: 33663075b9667771eb48c1e0c12c2c3e8d1add51 https://github.com/Perl/perl5/commit/33663075b9667771eb48c1e0c12c2c3e8d1add51 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M gv.h Log Message: ----------- gv.h - mark the unused GVf flag with a RESERVED define this make the table layout of the defines more obvious. Commit: ad55a53efe06ecb4765b2a7f70899bbbf293ac9c https://github.com/Perl/perl5/commit/ad55a53efe06ecb4765b2a7f70899bbbf293ac9c Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M pad.h M perl.h Log Message: ----------- perl.h - break up * lined comment leaders and pod comments Having half of the comment have the * on the left side is confusing for humans and especially so for programs. Split the two style into two comments. Commit: 081e92f8962d313a12fd4b0987770a02c228ef4e https://github.com/Perl/perl5/commit/081e92f8962d313a12fd4b0987770a02c228ef4e Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M INTERN.h M XSUB.h M av.h M cop.h M cv.h M dosish.h M fakesdio.h M gv.h M handy.h M hv.h M inline.h M intrpvar.h M invlist_inline.h M iperlsys.h M mg.h M mydtrace.h M op.h M pad.h M parser.h M perl.h M perl_inc_macro.h M perl_siphash.h M perlio.h M perliol.h M perlstatic.h M perlvars.h M pp.h M regcomp.h M regexp.h M sbox32_hash.h M scope.h M sv.h M thread.h M unixish.h M utf8.h M utfebcdic.h M util.h M vutil.h Log Message: ----------- WS Cleanup Stage #1 - simple ws fixups Commit: 68e3ae61b949c674a4c19b510f12d284c31129f0 https://github.com/Perl/perl5/commit/68e3ae61b949c674a4c19b510f12d284c31129f0 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M handy.h Log Message: ----------- WS Cleanup Stage #2 - remove right stars from comments Commit: a54c532b4997fad8ac4337c4da568ddf807df72b https://github.com/Perl/perl5/commit/a54c532b4997fad8ac4337c4da568ddf807df72b Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M XSUB.h M av.h M cop.h M cv.h M gv.h M handy.h M hv.h M hv_func.h M hv_macro.h M inline.h M iperlsys.h M mg.h M op.h M pad.h M perl.h M perl_inc_macro.h M pp.h M regcomp.h M regexp.h M sbox32_hash.h M scope.h M sv.h M sv_inline.h M unixish.h M utf8.h M zaphod32_hash.h Log Message: ----------- WS Cleanup Stage #3 - break multiline define Commit: 7bcbee5c7cf08e1f782e1b557f3c9d9eaabdfcb0 https://github.com/Perl/perl5/commit/7bcbee5c7cf08e1f782e1b557f3c9d9eaabdfcb0 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M XSUB.h M av.h M cop.h M cv.h M dosish.h M gv.h M handy.h M hv.h M hv_func.h M hv_macro.h M inline.h M invlist_inline.h M iperlsys.h M mg.h M mydtrace.h M op.h M op_reg_common.h M pad.h M parser.h M perl.h M perl_inc_macro.h M perl_siphash.h M pp.h M regcomp.h M regexp.h M sbox32_hash.h M scope.h M sv.h M sv_inline.h M thread.h M unixish.h M utf8.h M utfebcdic.h M util.h M vutil.h M zaphod32_hash.h Log Message: ----------- WS Cleanup Stage #4 - fix line continuation and related ws issues Commit: 22fe3ee68ba99b1c074244950d873c95c486ed4c https://github.com/Perl/perl5/commit/22fe3ee68ba99b1c074244950d873c95c486ed4c Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M XSUB.h M cop.h M cv.h M dosish.h M gv.h M handy.h M hv.h M hv_func.h M hv_macro.h M inline.h M invlist_inline.h M iperlsys.h M op.h M op_reg_common.h M perl.h M perl_inc_macro.h M perlvars.h M pp.h M regcomp.h M regexp.h M sbox32_hash.h M scope.h M sv.h M thread.h M utf8.h M utfebcdic.h M util.h M vutil.h M zaphod32_hash.h Log Message: ----------- WS Cleanup Stage #5 - break long define For long define statements put the replacement part on their own line. Also wrap comments on long lines. Commit: b858d24a39177d6fed45c13b69ab8b4923a87ef5 https://github.com/Perl/perl5/commit/b858d24a39177d6fed45c13b69ab8b4923a87ef5 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M EXTERN.h M INTERN.h M XSUB.h M av.h M cop.h M cv.h M dosish.h M fakesdio.h M form.h M gv.h M handy.h M hv.h M hv_func.h M hv_macro.h M inline.h M intrpvar.h M invlist_inline.h M iperlsys.h M mg.h M mydtrace.h M nostdio.h M op.h M op_reg_common.h M pad.h M parser.h M perl.h M perl_inc_macro.h M perl_langinfo.h M perl_siphash.h M perlapi.h M perlio.h M perliol.h M perlsdio.h M perlstatic.h M perlvars.h M pp.h M regcomp.h M regexp.h M reginline.h M sbox32_hash.h M scope.h M sv.h M sv_inline.h M thread.h M time64_config.h M unixish.h M utf8.h M utfebcdic.h M util.h M vutil.h M zaphod32_hash.h Log Message: ----------- WS Cleanup Stage #6 - reflow C comments (1) Commit: 05a09082be28677fb6add5483d3118f1a0a8123f https://github.com/Perl/perl5/commit/05a09082be28677fb6add5483d3118f1a0a8123f Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M EXTERN.h M INTERN.h M XSUB.h M av.h M cop.h M cv.h M dosish.h M fakesdio.h M form.h M gv.h M handy.h M hv.h M hv_func.h M hv_macro.h M inline.h M intrpvar.h M invlist_inline.h M iperlsys.h M mg.h M nostdio.h M op.h M op_reg_common.h M pad.h M parser.h M perl.h M perl_inc_macro.h M perl_langinfo.h M perlio.h M perliol.h M perlvars.h M pp.h M regcomp.h M regexp.h M sbox32_hash.h M scope.h M sv.h M sv_inline.h M thread.h M time64.h M unixish.h M utf8.h M utfebcdic.h M util.h M vutil.h M zaphod32_hash.h Log Message: ----------- WS Cleanup Stage #7 - line up simple defs Commit: 6bf0828f4501efc49181a61c42ee05bb4d62b93b https://github.com/Perl/perl5/commit/6bf0828f4501efc49181a61c42ee05bb4d62b93b Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M av.h M cop.h M handy.h M hv_macro.h M op.h M op_reg_common.h M perl.h M regcomp.h M regexp.h M sv.h M util.h Log Message: ----------- WS Cleanup Stage #8 - join short continuations Commit: 52c7eb65a940cde48b19627645019b4edb9a0e99 https://github.com/Perl/perl5/commit/52c7eb65a940cde48b19627645019b4edb9a0e99 Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M av.h M cop.h M gv.h M hv.h M malloc_ctl.h M mg.h M op.h M pad.h M parser.h M perl.h M perliol.h M regcomp.h M regexp.h M sv.h M sv_inline.h M time64.h Log Message: ----------- WS Cleanup Stage #9 - reformat structs Commit: 0b3bc3d83234df2ade171741eb6014c193afeffd https://github.com/Perl/perl5/commit/0b3bc3d83234df2ade171741eb6014c193afeffd Author: Yves Orton <demer...@gmail.com> Date: 2022-11-05 (Sat, 05 Nov 2022) Changed paths: M cop.h M cv.h M dosish.h M form.h M gv.h M handy.h M hv.h M op.h M pad.h M parser.h M perl.h M regcomp.h M regexp.h M sv.h M sv_inline.h M utf8.h M util.h Log Message: ----------- WS Cleanup Stage #10 - reflow C comments (2) Compare: https://github.com/Perl/perl5/compare/2532de36f759...0b3bc3d83234