Re: [perl.git] branch blead updated. v5.27.5-404-gcfd95a3749

[Craig A. Berry]

> On Nov 16, 2017, at 11:32 PM, Karl Williamson  wrote:
> 
> On 11/16/2017 09:41 PM, Craig A. Berry wrote:
>> On 11/16/17 11:55 AM, Karl Williamson wrote:
>>> In perl.git, the branch blead has been updated
>>> 
>>> 
>>>  
>>> 
>>> - Log -
>>> commit cfd95a374972942cba5e8afc019dc6019815b45c
>>> Author: Karl Williamson 
>>> Date:   Tue Nov 14 21:41:25 2017 -0700
>>> 
>>>  Remove UTF16 functions from public access
>> This breaks linking the XS::APITest extension on VMS and will probably
>> do the same on AIX or anything else with a strict linker. The docs in
>> embed.fnc say:
>> :   E  Visible to extensions included in the Perl core:
>> :
>> : in embed.h, change "#ifdef PERL_CORE"
>> : into   "#if defined(PERL_CORE) || defined(PERL_EXT)"
>> :
>> :  To be usable from dynamically loaded extensions, either:
>> : 1) must be static to its containing file ("i" or "s" flag); or
>> : 2) be combined with the "X" flag.
>> Neither 1 nor 2 was done in this case. A wild guess would be that X is
>> required or that XS::APITest, whose name implies that it has something
>> to do with testing the API, might need changes to track removals from
>> the API.
> 
> X is added in 73d689df0b635676359707f9eaa2ce012ada9fd7

Thanks, that did the trick.


Craig A. Berry

"... getting out of a sonnet is much more
 difficult than getting in."
 Brad Leithauser

Re: [perl.git] branch blead updated. v5.27.5-404-gcfd95a3749

[Karl Williamson]

On 11/16/2017 09:41 PM, Craig A. Berry wrote:

On 11/16/17 11:55 AM, Karl Williamson wrote:

In perl.git, the branch blead has been updated

 



- Log -
commit cfd95a374972942cba5e8afc019dc6019815b45c
Author: Karl Williamson 
Date:   Tue Nov 14 21:41:25 2017 -0700

 Remove UTF16 functions from public access


This breaks linking the XS::APITest extension on VMS and will probably
do the same on AIX or anything else with a strict linker. The docs in
embed.fnc say:

:   E  Visible to extensions included in the Perl core:
:
: in embed.h, change "#ifdef PERL_CORE"
: into   "#if defined(PERL_CORE) || defined(PERL_EXT)"
:
:  To be usable from dynamically loaded extensions, either:
: 1) must be static to its containing file ("i" or "s" flag); or
: 2) be combined with the "X" flag.

Neither 1 nor 2 was done in this case. A wild guess would be that X is
required or that XS::APITest, whose name implies that it has something
to do with testing the API, might need changes to track removals from
the API.



X is added in 73d689df0b635676359707f9eaa2ce012ada9fd7

Re: [perl.git] branch blead updated. v5.27.5-404-gcfd95a3749

[Craig A. Berry]

On 11/16/17 11:55 AM, Karl Williamson wrote:

In perl.git, the branch blead has been updated



- Log -
commit cfd95a374972942cba5e8afc019dc6019815b45c
Author: Karl Williamson 
Date:   Tue Nov 14 21:41:25 2017 -0700

 Remove UTF16 functions from public access


This breaks linking the XS::APITest extension on VMS and will probably
do the same on AIX or anything else with a strict linker. The docs in
embed.fnc say:

:   E  Visible to extensions included in the Perl core:
:
: in embed.h, change "#ifdef PERL_CORE"
: into   "#if defined(PERL_CORE) || defined(PERL_EXT)"
:
:  To be usable from dynamically loaded extensions, either:
: 1) must be static to its containing file ("i" or "s" flag); or
: 2) be combined with the "X" flag.

Neither 1 nor 2 was done in this case. A wild guess would be that X is
required or that XS::APITest, whose name implies that it has something
to do with testing the API, might need changes to track removals from
the API.

[perl.git] branch blead updated. v5.27.5-404-gcfd95a3749

[Karl Williamson]

In perl.git, the branch blead has been updated



- Log -
commit cfd95a374972942cba5e8afc019dc6019815b45c
Author: Karl Williamson 
Date:   Tue Nov 14 21:41:25 2017 -0700

Remove UTF16 functions from public access

See thread starting at
http://nntp.perl.org/group/perl.perl5.porters/247120

I don't believe this needs a perldelta, as the functions weren't
documented, hence are not supposed to be used, and in fact are not used
in cpan.

---

Summary of changes:
 embed.fnc | 4 ++--
 embed.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/embed.fnc b/embed.fnc
index 6269498ec7..fc0e1e4571 100644
--- a/embed.fnc
+++ b/embed.fnc
@@ -1795,8 +1795,8 @@ p |void   |utilize|int aver|I32 floor|NULLOK OP* 
version|NN OP* idop|NULLOK OP* a
 ApM|void   |_force_out_malformed_utf8_message  \
|NN const U8 *const p|NN const U8 * const e|const U32 flags \
|const bool die_here
-Ap |U8*|utf16_to_utf8  |NN U8* p|NN U8 *d|I32 bytelen|NN I32 *newlen
-Ap |U8*|utf16_to_utf8_reversed|NN U8* p|NN U8 *d|I32 bytelen|NN I32 
*newlen
+Ep |U8*|utf16_to_utf8  |NN U8* p|NN U8 *d|I32 bytelen|NN I32 *newlen
+Ep |U8*|utf16_to_utf8_reversed|NN U8* p|NN U8 *d|I32 bytelen|NN I32 
*newlen
 AdpPR  |STRLEN |utf8_length|NN const U8* s|NN const U8 *e
 AipdR  |IV |utf8_distance  |NN const U8 *a|NN const U8 *b
 AipdRn |U8*|utf8_hop   |NN const U8 *s|SSize_t off
diff --git a/embed.h b/embed.h
index 46c59b5b4e..2c047fb6d8 100644
--- a/embed.h
+++ b/embed.h
@@ -729,8 +729,6 @@
 #define unpackstring(a,b,c,d,e)Perl_unpackstring(aTHX_ a,b,c,d,e)
 #define unsharepvn(a,b,c)  Perl_unsharepvn(aTHX_ a,b,c)
 #define upg_version(a,b)   Perl_upg_version(aTHX_ a,b)
-#define utf16_to_utf8(a,b,c,d) Perl_utf16_to_utf8(aTHX_ a,b,c,d)
-#define utf16_to_utf8_reversed(a,b,c,d)
Perl_utf16_to_utf8_reversed(aTHX_ a,b,c,d)
 #define utf8_distance(a,b) Perl_utf8_distance(aTHX_ a,b)
 #define utf8_hop   Perl_utf8_hop
 #define utf8_hop_back  Perl_utf8_hop_back
@@ -939,6 +937,8 @@
 #define sv_only_taint_gmagic   S_sv_only_taint_gmagic
 #define swash_fetch(a,b,c) Perl_swash_fetch(aTHX_ a,b,c)
 #define swash_init(a,b,c,d,e)  Perl_swash_init(aTHX_ a,b,c,d,e)
+#define utf16_to_utf8(a,b,c,d) Perl_utf16_to_utf8(aTHX_ a,b,c,d)
+#define utf16_to_utf8_reversed(a,b,c,d)
Perl_utf16_to_utf8_reversed(aTHX_ a,b,c,d)
 #define validate_proto(a,b,c,d)Perl_validate_proto(aTHX_ a,b,c,d)
 #define vivify_defelem(a)  Perl_vivify_defelem(aTHX_ a)
 #define yylex()Perl_yylex(aTHX)

-- 
Perl5 Master Repository