Change 18572 by rgs@rgs-home on 2003/01/22 21:40:21 Integrate change 18448 from maint-5.8 : Subject: Partial Data::Dumper patch From: Richard Clamp <[EMAIL PROTECTED]> Date: Sat, 4 Jan 2003 00:52:47 +0000 Message-ID: <[EMAIL PROTECTED]> Subject: Re: Partial Data::Dumper patch From: Slaven Rezic <[EMAIL PROTECTED]> Date: 04 Jan 2003 02:48:08 +0100 Message-ID: <[EMAIL PROTECTED]>
Affected files ... ... //depot/perl/ext/Data/Dumper/Dumper.xs#45 integrate ... //depot/perl/ext/Data/Dumper/t/dumper.t#9 integrate Differences ... ==== //depot/perl/ext/Data/Dumper/Dumper.xs#45 (text) ==== Index: perl/ext/Data/Dumper/Dumper.xs --- perl/ext/Data/Dumper/Dumper.xs#44~18541~ Tue Jan 21 14:08:51 2003 +++ perl/ext/Data/Dumper/Dumper.xs Wed Jan 22 13:40:21 2003 @@ -753,7 +753,7 @@ return 1; } } - else { + else if (val != &PL_sv_undef) { SV *namesv; namesv = newSVpvn("\\", 1); sv_catpvn(namesv, name, namelen); ==== //depot/perl/ext/Data/Dumper/t/dumper.t#9 (xtext) ==== Index: perl/ext/Data/Dumper/t/dumper.t --- perl/ext/Data/Dumper/t/dumper.t#8~16390~ Sat May 4 08:47:49 2002 +++ perl/ext/Data/Dumper/t/dumper.t Wed Jan 22 13:40:21 2003 @@ -67,11 +67,11 @@ $Data::Dumper::Useperl = 1; if (defined &Data::Dumper::Dumpxs) { print "### XS extension loaded, will run XS tests\n"; - $TMAX = 357; $XS = 1; + $TMAX = 363; $XS = 1; } else { print "### XS extensions not loaded, will NOT run XS tests\n"; - $TMAX = 180; $XS = 0; + $TMAX = 183; $XS = 0; } print "1..$TMAX\n"; @@ -1353,3 +1353,19 @@ TEST q(Data::Dumper->Dumpxs([\\%foo])), "XS quotekeys == 0 for utf8 flagged ASCII" if $XS; } +############# 358 +{ + $WANT = <<'EOT'; +#$VAR1 = [ +# undef, +# undef, +# 1 +#]; +EOT + @foo = (); + $foo[2] = 1; + TEST q(Data::Dumper->Dump([\@foo])), 'Richard Clamp, Message-Id: +<[EMAIL PROTECTED]>'; + TEST q(Data::Dumper->Dumpxs([\@foo])) if $XS; +} + + End of Patch.