Re: [EMAIL PROTECTED] Constant.t fix for VMS.

2005-08-19 Thread John E. Malmberg

Andy Lester wrote:

-  rename $makefile_rename, $makefile
+  rename $makefile_rename, $makefile . $makefile_ext
 or die Can't rename '$makefile_rename' to '$makefile': $!;



Shouldn't that be

or die Can't rename '$makefile_rename' to '$makefile$makefile_ext': $!


Something like that.  I forgot about fixing the error message after I 
fixed what was causing the error.


I won't have time to do anything about that for at least 9 hours from now.

-John
[EMAIL PROTECTED]
Personal Opinion Only


Re: [EMAIL PROTECTED] Constant.t fix for VMS.

2005-08-19 Thread Michael G Schwern
On Thu, Aug 18, 2005 at 08:49:52PM -0400, John E. Malmberg wrote:
 This test script was not using the same names for the VMS specific files 
 descrip.mms and descrip.mms_old that the rest of Makemaker was doing.

ExtUtils::Constant is not part of MakeMaker.


-- 
Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern



[EMAIL PROTECTED] Constant.t fix for VMS.

2005-08-18 Thread John E. Malmberg
This test script was not using the same names for the VMS specific files 
descrip.mms and descrip.mms_old that the rest of Makemaker was doing.


-John
[EMAIL PROTECTED]
Personal Opinion Only
--- lib/ExtUtils/t/Constant.t_25305 Thu Aug 18 20:33:20 2005
+++ lib/ExtUtils/t/Constant.t   Thu Aug 18 20:30:23 2005
@@ -48,7 +48,7 @@
 # Renamed by make clean
 my $makefile = ($^O eq 'VMS' ? 'descrip' : 'Makefile');
 my $makefile_ext = ($^O eq 'VMS' ? '.mms' : '');
-my $makefile_rename = $makefile . ($^O eq 'VMS' ? '.mms' : '.old');
+my $makefile_rename = $makefile . ($^O eq 'VMS' ? '.mms_old' : '.old');
 
 my $output = output;
 my $package = ExtTest;
@@ -250,7 +250,7 @@
 
   check_for_bonus_files ('.', @$files, $output, $makefile_rename, '.', '..');
 
-  rename $makefile_rename, $makefile
+  rename $makefile_rename, $makefile . $makefile_ext
 or die Can't rename '$makefile_rename' to '$makefile': $!;
 
   unlink $output or warn Can't unlink '$output': $!;


Re: [EMAIL PROTECTED] Constant.t fix for VMS.

2005-08-18 Thread Andy Lester

-  rename $makefile_rename, $makefile
+  rename $makefile_rename, $makefile . $makefile_ext
 or die Can't rename '$makefile_rename' to '$makefile': $!;


Shouldn't that be

or die Can't rename '$makefile_rename' to '$makefile$makefile_ext': $!

xoa


--
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance