* embed.fnc: Adding many NN and NULLOK flags. I'm down to 280 or so
pointer parameters to clean up. In at least one case, I fixed one that
was wrong (force_list).
* doio.c: Consting
* op.c: Fixed some indents. Hoisted a check for non-null outside of an
if-then chain, to improve readability. Added a couple of consts.
* pp_ctl.c: Consting.
* regcomp.c: Consting.
* regexec.c: Consting.
* sv.c: Fixed indenting.
* util.c: Consting.
xoxo,
Andy
--
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance
diff -pur bleadperl/doio.c bw/trunk/doio.c
--- bleadperl/doio.c2005-07-24 18:04:46.0 -0500
+++ bw/trunk/doio.c 2005-07-28 11:26:53.0 -0500
@@ -747,7 +747,7 @@ Perl_nextargv(pTHX_ register GV *gv)
#endif
Uid_t fileuid;
Gid_t filegid;
-IO *io = GvIOp(gv);
+IO * const io = GvIOp(gv);
if (!PL_argvoutgv)
PL_argvoutgv = gv_fetchpv(ARGVOUT,TRUE,SVt_PVIO);
@@ -802,9 +802,9 @@ Perl_nextargv(pTHX_ register GV *gv)
continue;
}
if (*PL_inplace) {
- char *star = strchr(PL_inplace, '*');
+ const char *star = strchr(PL_inplace, '*');
if (star) {
- char *begin = PL_inplace;
+ const char *begin = PL_inplace;
sv_setpvn(sv, , 0);
do {
sv_catpvn(sv, begin, star - begin);
@@ -2333,7 +2333,7 @@ PerlIO *
Perl_start_glob (pTHX_ SV *tmpglob, IO *io)
{
dVAR;
-SV *tmpcmd = NEWSV(55, 0);
+SV * const tmpcmd = NEWSV(55, 0);
PerlIO *fp;
ENTER;
SAVEFREESV(tmpcmd);
diff -pur bleadperl/embed.fnc bw/trunk/embed.fnc
--- bleadperl/embed.fnc 2005-07-28 08:33:40.0 -0500
+++ bw/trunk/embed.fnc 2005-07-28 14:00:16.0 -0500
@@ -239,7 +239,7 @@ ApdR|char* |fbm_instr |NN unsigned char
|NN SV* littlesv|U32 flags
p |char* |find_script|const char *scriptname|bool dosearch \
|const char **search_ext|I32 flags
-p |OP*|force_list |NN OP* arg
+p |OP*|force_list |NULLOK OP* arg
p |OP*|fold_constants |NN OP* arg
Afpd |char* |form |NN const char* pat|...
Ap |char* |vform |NN const char* pat|NULLOK va_list* args
@@ -297,7 +297,7 @@ Apd |SV** |hv_store |HV* tb|const char*
Apd|HE*|hv_store_ent |HV* tb|SV* key|SV* val|U32 hash
ApM|SV** |hv_store_flags |HV* tb|const char* key|I32 klen|SV* val \
|U32 hash|int flags
-Apd|void |hv_undef |HV* tb
+Apd|void |hv_undef |NULLOK HV* tb
ApP|I32|ibcmp |NN const char* a|NN const char* b|I32 len
ApP|I32|ibcmp_locale |NN const char* a|NN const char* b|I32 len
Apd|I32|ibcmp_utf8 |NN const char* a|char **pe1|UV l1|bool u1|NN
const char* b|char **pe2|UV l2|bool u2
@@ -309,7 +309,7 @@ Ap |void |init_tm|struct tm *ptm
pd |U32|intro_my
ApPR |char* |instr |NN const char* big|NN const char* little
pR |bool |io_close |NN IO* io|bool not_implicit
-pR |OP*|invert |OP* cmd
+pR |OP*|invert |NULLOK OP* cmd
dpR|bool |is_gv_magical |NN const char *name|STRLEN len|U32 flags
ApR|I32|is_lvalue_sub
ApPR |U32|to_uni_upper_lc|U32 c
@@ -502,7 +502,7 @@ Apa |OP*|newCONDOP |I32 flags|NN OP* fi
Apd|CV*|newCONSTSUB|NULLOK HV* stash|NULLOK const char*
name|NULLOK SV* sv
Ap |void |newFORM|I32 floor|NULLOK OP* o|NULLOK OP* block
Apa|OP*|newFOROP |I32 flags|char* label|line_t forline \
- |OP* sclr|OP* expr|OP*block|OP*cont
+ |NULLOK OP* sv|OP* expr|OP*block|OP*cont
Apa|OP*|newLOGOP |I32 optype|I32 flags|OP* left|OP* right
Apa|OP*|newLOOPEX |I32 type|OP* label
Apa|OP*|newLOOPOP |I32 flags|I32 debuggable|OP* expr|OP* block
@@ -510,15 +510,15 @@ Apa |OP*|newNULLLIST
Apa|OP*|newOP |I32 optype|I32 flags
Ap |void |newPROG|NN OP* o
Apa|OP*|newRANGE |I32 flags|OP* left|OP* right
-Apa|OP*|newSLICEOP |I32 flags|OP* subscript|OP* listop
-Apa|OP*|newSTATEOP |I32 flags|char* label|OP* o
+Apa|OP*|newSLICEOP |I32 flags|NULLOK OP* subscript|NULLOK OP*
listop
+Apa|OP*|newSTATEOP |I32 flags|NULLOK char* label|NULLOK OP* o
Ap |CV*|newSUB |I32 floor|OP* o|OP* proto|OP* block
Apd|CV*|newXS |NN const char* name|NN XSUBADDR_t f|NN const
char* filename
Apda |AV*|newAV
Apa|OP*|newAVREF |NN OP* o
Apa|OP*|newBINOP |I32 type|I32 flags|OP* first|OP* last
-Apa|OP*|newCVREF |I32 flags|OP* o
-Apa|OP*|newGVOP|I32
