Re: [perl #24808] [PATCH] Fix for remaining PPC JIT failures

[Leopold Toetsch]

Jeff Clites <[EMAIL PROTECTED]> wrote:

> Attached are patches to fix the remaining "make testj" failures on Mac
> OS X (i.e., ppc jit). These fixes are relative to my previously
> submitted patch with other ppc jit fixes, [perl #24789].

Thanks, applied,
leo

Re: [perl #24808] [PATCH] Fix for remaining PPC JIT failures

[Jeff Clites]

On Jan 5, 2004, at 5:45 AM, Leopold Toetsch wrote:

Jeff Clites <[EMAIL PROTECTED]> wrote:
Attached are patches to fix the remaining "make testj" failures on Mac
OS X (i.e., ppc jit). These fixes are relative to my previously
submitted patch with other ppc jit fixes, [perl #24789].
... which still seems to be missing.
Yeah, I inquired about that ("Patch submission gone missing?" of 
1/1/2004), and Robert Spier indicated that it was in the RT moderation 
queue. If it doesn't show up in a bit, I'll re-send that patch 
submission directly to the list.

JEff

Re: [perl #24808] [PATCH] Fix for remaining PPC JIT failures

[Leopold Toetsch]

Jeff Clites <[EMAIL PROTECTED]> wrote:
> Attached are patches to fix the remaining "make testj" failures on Mac
> OS X (i.e., ppc jit). These fixes are relative to my previously
> submitted patch with other ppc jit fixes, [perl #24789].

... which still seems to be missing. Could you rediff all against
current please.

leo

[perl #24808] [PATCH] Fix for remaining PPC JIT failures

[via RT]

# New Ticket Created by  Jeff Clites 
# Please include the string:  [perl #24808]
# in the subject line of all future correspondence about this issue. 
# http://rt.perl.org/rt3/Ticket/Display.html?id=24808 >


Attached are patches to fix the remaining "make testj" failures on Mac 
OS X (i.e., ppc jit). These fixes are relative to my previously 
submitted patch with other ppc jit fixes, [perl #24789].

Notes:

1) ppc/jit_emit.h -- Augmented Parrot_jit_begin to handle the restart 
case (to forward branch to the correct initial op), fixed 
Parrot_jit_cpcf_op to update the appropriate registers in the case of 
an inter-segment branch, and implemented Parrot_jit_restart_op. This 
fixes all of the remaining testj failures on Mac OS X (except for the 
arithmetics.t failure, fixed below).

2) t/op/interp.t -- Enabled threading tests on darwin.

3) src/spf_render.c -- Added one line to prevent "-0.0" on platforms 
which get this from negating zero. (This fix is in the sprintf-ish code 
because the sign bit on zero only makes a difference when printing, not 
in mathematical operations.) This fixes the failure of test 7 of 
t/op/arithmetics.t on platforms on which it was failing for this 
reason.


After applying these fixes (and those from [perl #24789]), all JIT 
tests pass on Mac OS X:

All tests successful, 28 subtests skipped.
Files=61, Tests=1021, 79 wallclock secs (25.51 cusr + 20.62 csys = 
46.13 CPU)

JEff



interp_t.patch
Description: Binary data


ppc-jit_emit_h.patch
Description: Binary data


spf_render_c.patch
Description: Binary data