[perl #40998] [PATCH] Fix build error on Win32
On Fri Dec 01 11:31:22 2006, [EMAIL PROTECTED] wrote: OK, so no one seems interested. Certainly on my part, lack of time rather than lack of interest. Anyway, the attached patch in this message is a better version of the previous one. It checks for a white space in build_dir and makes the value short path only when a space exists. Thank you, applied in r16120. While I agree that quoting paths is probably a nicer solution, this patch is here now and deals with the problem at hand. Thanks again - take care, Jonathan
Re: [perl #40998] [PATCH] Fix build error on Win32
OK, so no one seems interested.
Anyway, the attached patch in this message is a
better version of the previous one.
It checks for a white space in build_dir and makes the value
short path only when a space exists.
Nikolay Ananiev [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Ron Blaschke [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Nikolay Ananiev (via RT) wrote:
# New Ticket Created by Nikolay Ananiev
# Please include the string: [perl #40998]
# in the subject line of all future correspondence about this issue.
# URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40998
When build_dir contains spaces the build process fails.
The fix is to translate build_dir to a short path name.
In my opinion it would be better to escape/quote the relevant paths
properly. I think the short file names were introduced for backwards
compatibility, as a kludge. Besides, they are ugly to read. ;-)
Ron
If we use quotes, we'll have to refactor some of the scripts in the build
tree,
because there are many concatenations and currently they won't work
if we use quotes on build_dir. There's one more way. We can check
build_dir
and use short path names only if there are spaces.
begin 666 win32build.patch
[EMAIL PROTECTED](-O;F9I9R]I;FET+VAI;G1S+VUS=VEN,S(NT-CT]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T-BTM+2!C;VYF:6O:6YI=]H:6YTR]MW=I;C,R
M+G!M2AR979IVEO;B [EMAIL PROTECTED]BLK*R!C;VYF:6O:6YI=]H:6YTR]M
MW=I;C,R+G!M2AW;W)K:6YG(-O'DI#0I 0 M-PV(LT+#@0$ -B!P
M86-K86=E(EN:70Z.FAI;G1S.CIMW=I;C,R.PH@B!UV4@W1R:6-T.PHK
M=7-E(%=I;C,R.PH@B!S=6(@G5NW1E H@PI 0 M,CL-B K,[EMAIL PROTECTED],3(@
M0$ -B @( @( @(UA:V5?8R @( @( @( @(#T^(D*%!%4DPI(UE
M()C:1IB!S:EF=! 05)'5CL@WES=5M(%PG)A-04M%*5PG+! 05)'
[EMAIL PROTECTED] D)#\@/[EMAIL PROTECTED])RP*( @( @( @;F-I;EB7VQI;FM?97AT
MF$@/3X@)RUD968ZW)C+VQI8FYC:5]T97-T+F1E9BLB @( @*3L**R @
M( **R @(!M2 D8G5I;1?9ER(#T@)-O;F8M/F1A=$M/F=E=@G8G5I
M;1?9ER)RD[BL@( @BL@( @:68H))U:6QD7V1IB!^/2 O7',O*2![
MBL@( @( @(1C;VYF+3YD871A+3YS970H8G5I;1?9ER(#T^(%=I;C,R
M.CI'9713:]R=%!A=A.86UE*1B=6EL9%]D:7(I*3L**R @(!]B *( @
4(!I9B H)ES7VUS=F,I('L*( H`
`
end
Re: [perl #40998] [PATCH] Fix build error on Win32
Ron Blaschke [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Nikolay Ananiev (via RT) wrote: # New Ticket Created by Nikolay Ananiev # Please include the string: [perl #40998] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40998 When build_dir contains spaces the build process fails. The fix is to translate build_dir to a short path name. In my opinion it would be better to escape/quote the relevant paths properly. I think the short file names were introduced for backwards compatibility, as a kludge. Besides, they are ugly to read. ;-) Ron If we use quotes, we'll have to refactor some of the scripts in the build tree, because there are many concatenations and currently they won't work if we use quotes on build_dir. There's one more way. We can check build_dir and use short path names only if there are spaces.
Re: [perl #40998] [PATCH] Fix build error on Win32
Nikolay Ananiev (via RT) wrote: # New Ticket Created by Nikolay Ananiev # Please include the string: [perl #40998] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40998 When build_dir contains spaces the build process fails. The fix is to translate build_dir to a short path name. In my opinion it would be better to escape/quote the relevant paths properly. I think the short file names were introduced for backwards compatibility, as a kludge. Besides, they are ugly to read. ;-) Ron
[perl #40998] [PATCH] Fix build error on Win32
# New Ticket Created by Nikolay Ananiev # Please include the string: [perl #40998] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40998 When build_dir contains spaces the build process fails. The fix is to translate build_dir to a short path name. win32build.patch Description: Binary data
