Re: [svn:parrot] r18369 - in trunk: config/gen/platform/cygwin config/gen/platform/generic config/gen/platform/netbsd config/gen/platform/openbsd config/gen/platform/solaris src src/jit/ppc src/jit/su

2007-05-06 Thread Paul Cochrane

On 01/05/07, Nicholas Clark [EMAIL PROTECTED] wrote:

Given that that file starts:

/*
  This is a version (aka dlmalloc) of malloc/free/realloc written by
  Doug Lea and released to the public domain.  Use, modify, and
  redistribute this code without permission or acknowledgment in any
  way you wish.  Send questions, comments, complaints, performance
  data, etc to [EMAIL PROTECTED]


possibly it should be exempt from coding standards.


Agreed.  The file has been set exempt from the coding standards in r18434.

Paul


Re: [svn:parrot] r18369 - in trunk: config/gen/platform/cygwin config/gen/platform/generic config/gen/platform/netbsd config/gen/platform/openbsd config/gen/platform/solaris src src/jit/ppc src/jit/su

2007-05-01 Thread Nicholas Clark
 Date: Tue May  1 06:29:35 2007
 New Revision: 18369
 
 Modified:

trunk/src/malloc.c

 Modified: trunk/src/malloc.c
 ==

[3168 lines of diff]

Given that that file starts:

/*
  This is a version (aka dlmalloc) of malloc/free/realloc written by
  Doug Lea and released to the public domain.  Use, modify, and
  redistribute this code without permission or acknowledgment in any
  way you wish.  Send questions, comments, complaints, performance
  data, etc to [EMAIL PROTECTED]


possibly it should be exempt from coding standards.

Also, did it have any local modifications?
And why does Parrot needs its own malloc?

Nicholas Clark


Re: [svn:parrot] r18369 - in trunk: config/gen/platform/cygwin config/gen/platform/generic config/gen/platform/netbsd config/gen/platform/openbsd config/gen/platform/solaris src src/jit/ppc src/jit/su

2007-05-01 Thread Steve Peters
On Tue, May 01, 2007 at 10:52:19PM +0100, Nicholas Clark wrote:
  Date: Tue May  1 06:29:35 2007
  New Revision: 18369
  
  Modified:
 
 trunk/src/malloc.c
 
  Modified: trunk/src/malloc.c
  ==
 
 [3168 lines of diff]
 
 Given that that file starts:
 
 /*
   This is a version (aka dlmalloc) of malloc/free/realloc written by
   Doug Lea and released to the public domain.  Use, modify, and
   redistribute this code without permission or acknowledgment in any
   way you wish.  Send questions, comments, complaints, performance
   data, etc to [EMAIL PROTECTED]
 
 
 possibly it should be exempt from coding standards.
 
 Also, did it have any local modifications?
 And why does Parrot needs its own malloc?
 

According to our file, our version in 2.7.2.  The current free version is
2.8.3.  Obviously, if we need to keep this file, we should get up to the 
most recent version.  I wouldn't however, mess with it much to make it 
pass coding standards, since that would make it much more difficult to 
patch to keep up to date with the original.

Steve Peters
[EMAIL PROTECTED]