Re: [PATCH] Re: Register stacks organization

[Leopold Toetsch]

Luke Palmer [EMAIL PROTECTED] wrote:
 Leopold Toetsch writes:

 I'm working on yet another scheme at the moment, with a special op that
 pushes and clears simultaneously, to see if I can avoid copying
 altogether!  It costs another indirection in the core registers,

That would be a major change especially for prederefed and JIT code too.

 But we'll see what the benchmarks say.

Yep.

 Fixed in included patch.

Thanks, applied.

 - the COW flags is only reset on one user of 2 provocing even
   more unneeded ocpies.

 Again, I don't think this is hurting us.  If there's another copy, it's
 in a continuation.

We got that problem on *all* stacks, not only register frames used in
Continuations.

 Luke

leo

Re: [PATCH] Re: Register stacks organization

[Luke Palmer]

Luke Palmer writes:
  
 -memcpy(buf-data.bufstart, chunk-data.bufstart, stack-chunk_size);
 +memcpy(buf-data.bufstart, chunk-data.bufstart, 
 +stack-frame_size * FRAMES_PER_CHUNK);

Silly me -- left over from benchmarks.  Of course I mean:

+   memcpy(buf-data.bufstart, chunk-data.bufstart,
+   stack-frame_size * chunk-used);

Luke