Re: [PATCH] format warning in key.c

[Bryan C. Warnock]

On Monday 21 January 2002 19:06, Dan Sugalski wrote:
> Commits in areas you (the generic you, here)
> have some responsibility for (Brent with the RE code, Jeff Goff for
> PMC stuff, Melvin for IO, for example) can also go in if you're
> comfortable with them. 

That should probably be amended with "only" in there somewhere.  Perhaps in 
multiple places.  (Commits in one area that are depending on or dictating 
design in another should probably get some sort of feedback, too.)


-- 
Bryan C. Warnock
[EMAIL PROTECTED]

Re: [PATCH] format warning in key.c [APPLIED]

[Dan Sugalski]

At 11:10 PM + 1/21/02, Nicholas Clark wrote:
>We do mandate an ANSI conformant C compiler, don't we?
>
>Appended patch cures these warnings:

Oh, and applied. Thanks.
-- 

Dan

--"it's like this"---
Dan Sugalski  even samurai
[EMAIL PROTECTED] have teddy bears and even
   teddy bears get drunk

Re: [PATCH] format warning in key.c

[Dan Sugalski]

At 3:56 PM -0800 1/21/02, Steve Fink wrote:
>All of your last several patches look good to me. Didn't Dan give you
>commit rights yet? I'm pretty sure he intended to. Dan was also going
>to have a discussion of commit policy -- when should we just commit,
>and when should we discuss first -- as soon as he gets more settled,
>but my vote would be to commit all these cleanup patches. (Including
>the unsigned characters but signed digits one.)

All patches that clean up warnings, style gaffes, and add correct 
comments can just go in. Commits in areas you (the generic you, here) 
have some responsibility for (Brent with the RE code, Jeff Goff for 
PMC stuff, Melvin for IO, for example) can also go in if you're 
comfortable with them. The rest use your judgement cautiously, and if 
you're not sure pop a note to the list and we can go from there.
-- 

Dan

--"it's like this"---
Dan Sugalski  even samurai
[EMAIL PROTECTED] have teddy bears and even
   teddy bears get drunk

Re: [PATCH] format warning in key.c

[Dan Sugalski]

At 11:10 PM + 1/21/02, Nicholas Clark wrote:
>We do mandate an ANSI conformant C compiler, don't we?

Yep. If we haven't given you commit rights, go over to dev.perl.org 
and get an account. Then mail me the account name and we'll fix that.
-- 

Dan

--"it's like this"---
Dan Sugalski  even samurai
[EMAIL PROTECTED] have teddy bears and even
   teddy bears get drunk

Re: [PATCH] format warning in key.c

[Steve Fink]

All of your last several patches look good to me. Didn't Dan give you
commit rights yet? I'm pretty sure he intended to. Dan was also going
to have a discussion of commit policy -- when should we just commit,
and when should we discuss first -- as soon as he gets more settled,
but my vote would be to commit all these cleanup patches. (Including
the unsigned characters but signed digits one.)

[PATCH] format warning in key.c

[Nicholas Clark]

We do mandate an ANSI conformant C compiler, don't we?

Appended patch cures these warnings:

key.c: In function `debug_key':
key.c:29: warning: int format, INTVAL arg (arg 3)
key.c:33: warning: int format, INTVAL arg (arg 3)
key.c:33: warning: int format, INTVAL arg (arg 4)
key.c:36: warning: int format, INTVAL arg (arg 3)
key.c:36: warning: int format, INTVAL arg (arg 4)


Nicholas Clark
-- 
ENOJOB http://www.ccl4.org/~nick/CV.html

--- key.c.orig  Mon Jan 14 20:32:54 2002
+++ key.c   Mon Jan 21 23:09:06 2002
@@ -26,14 +26,14 @@
 debug_key (struct Parrot_Interp* interpreter, KEY* key) {
   INTVAL i;
   fprintf(stderr," *** key %p\n",key);
-  fprintf(stderr," *** size %d\n",key->size);
+  fprintf(stderr," *** size " INTVAL_FMT "\n",key->size);
   for(i=0;isize;i++) {
 INTVAL type = key->keys[i].type;
 if(type == enum_key_bucket) {
-  fprintf(stderr," *** Bucket %d type %d\n",i,type);
+  fprintf(stderr," *** Bucket " INTVAL_FMT " type " INTVAL_FMT "\n",i,type);
 }
 else if(type != enum_key_undef) {
-  fprintf(stderr," *** Other %d type %d\n",i,type);
+  fprintf(stderr," *** Other " INTVAL_FMT " type " INTVAL_FMT "\n",i,type);
 }
   }
 }