Re: [perl #15962] [PATCH] avoid uninit warning in Configure

2002-08-03 Thread Nicholas Clark

On Sat, Aug 03, 2002 at 02:53:22PM +, Jarkko Hietaniemi wrote:
> # New Ticket Created by  Jarkko Hietaniemi 
> # Please include the string:  [perl #15962]
> # in the subject line of all future correspondence about this issue. 
> # http://rt.perl.org/rt2/Ticket/Display.html?id=15962 >
> 
> 
> Not all places have COMSPEC.

Thanks, applied.

:-)

Nicholas Clark
-- 
Even better than the real thing:http://nms-cgi.sourceforge.net/



[perl #15962] [PATCH] avoid uninit warning in Configure

2002-08-03 Thread via RT

# New Ticket Created by  Jarkko Hietaniemi 
# Please include the string:  [perl #15962]
# in the subject line of all future correspondence about this issue. 
# http://rt.perl.org/rt2/Ticket/Display.html?id=15962 >


Not all places have COMSPEC.

--- lib/Parrot/Configure/Step.pm.dist   2002-08-03 17:50:40.0 +0300
+++ lib/Parrot/Configure/Step.pm2002-08-03 17:51:06.0 +0300
@@ -16,7 +16,7 @@
gen   => ['genfile']
 );

-my $redir_err = ($ENV{COMSPEC} =~ /command\.com/i) ? "" : "2>&1";
+my $redir_err = (($ENV{COMSPEC} || "")=~ /command\.com/i) ? "" : "2>&1";
 
 #Configure::Data->get('key')
 #Configure::Data->set('key', 'value')

-- 
$jhi++; # http://www.iki.fi/jhi/
# There is this special biologist word we use for 'stable'.
# It is 'dead'. -- Jack Cohen