Re: [petsc-dev] Nested XML logging and stages

[Smith, Barry F.]

  I am fine with the suggested changes. 

> On May 13, 2018, at 1:06 PM, Lisandro Dalcin  wrote:
> 
> It took me a while to figure out why my xml -log_view was empty. Nested XML
> logging and push/pop user-defined stages simply does not work, the
> implementation cannot cope with this usage pattern.
> 
> Would it be OK to at ignore push/pop stages if XML is on, and then log
> everything in the main stage, to at least get an non-empty xml log file? I
> guess this would require a private global flag.
> 
> Now that I am on it, could we add a command line option to set the XML
> logging threshold? I would like to pass -log_threshold 0 to get everything,
> but surprisingly "0" is not a good value, NaNs are generated. So I guess we
> need something like PetscMax(threshold,1e-10).
> 
> Why PetscLogView_Nested() calls PetscLogNestedEnd() ? While convenient and
> quick to implement, it smells like bad API usage.

  I don't see a nice alternative.

   Barry

> 
> -- 
> Lisandro Dalcin
> 
> Research Scientist
> Computer, Electrical and Mathematical Sciences & Engineering (CEMSE)
> Extreme Computing Research Center (ECRC)
> King Abdullah University of Science and Technology (KAUST)
> http://ecrc.kaust.edu.sa/
> 
> 4700 King Abdullah University of Science and Technology
> al-Khawarizmi Bldg (Bldg 1), Office # 0109
> Thuwal 23955-6900, Kingdom of Saudi Arabia
> http://www.kaust.edu.sa
> 
> Office Phone: +966 12 808-0459

Re: [petsc-dev] Install location for MPIUNI mpi.h

[Jed Brown]

Looks good to me, so pulled into my branch.

Satish Balay  writes:

> I have the following changes in balay/mpiuni-include/jed
>
> - mpi.mod -> mpiuni.mod 
>
> - remove -Iinclde/petsc/mpiuni
>
> If ok - they can be pulled into jed/mpiuni-include/maint
>
> Satish
>
> On Wed, 25 Apr 2018, Satish Balay wrote:
>
>> On Wed, 25 Apr 2018, Jed Brown wrote:
>> 
>> > Bitbucket keeps saying "Something went wrong while creating your pull
>> > request." but you can look at the branch
>> > 
>> > https://bitbucket.org/petsc/petsc/branch/jed/mpiuni-include/maint
>> > 
>> > @balay Can we simply remove the MPIUNI includes from MPI.py or should we
>> > remove it later?
>> 
>> Best to remove now - to check if there are issues?
>> 
>> also Fix mpif.h usage code?
>> 
>> There is also mpi.mod - that might need renaming [to comply with not 
>> installing in /usr/include?]
>> 
>> So rename to mpiuni.mod? [and rename mpi.h to mpiuni.h etc?]
>> 
>> 
>> Looks like this change is more of a 'master change'..
>> 
>> 
>> >  What --download packages are supported when using
>> > MPIUNI?  I don't see any examples.
>> 
>> Yeah - our tests are basic here. I don't remember if any externalpackages 
>> compiled with mpiuni
>> 
>> Satish
>> 

Re: [petsc-dev] Install location for MPIUNI mpi.h

[Satish Balay]

I have the following changes in balay/mpiuni-include/jed

- mpi.mod -> mpiuni.mod 

- remove -Iinclde/petsc/mpiuni

If ok - they can be pulled into jed/mpiuni-include/maint

Satish

On Wed, 25 Apr 2018, Satish Balay wrote:

> On Wed, 25 Apr 2018, Jed Brown wrote:
> 
> > Bitbucket keeps saying "Something went wrong while creating your pull
> > request." but you can look at the branch
> > 
> > https://bitbucket.org/petsc/petsc/branch/jed/mpiuni-include/maint
> > 
> > @balay Can we simply remove the MPIUNI includes from MPI.py or should we
> > remove it later?
> 
> Best to remove now - to check if there are issues?
> 
> also Fix mpif.h usage code?
> 
> There is also mpi.mod - that might need renaming [to comply with not 
> installing in /usr/include?]
> 
> So rename to mpiuni.mod? [and rename mpi.h to mpiuni.h etc?]
> 
> 
> Looks like this change is more of a 'master change'..
> 
> 
> >  What --download packages are supported when using
> > MPIUNI?  I don't see any examples.
> 
> Yeah - our tests are basic here. I don't remember if any externalpackages 
> compiled with mpiuni
> 
> Satish
>