Re: [petsc-dev] SeqSBAIJ v. MPISBAIJ

[Smith, Barry F. via petsc-dev]

  Pierre,

Your code did expose another error, I have pushed a fix in the same branch*.

  Stefano,

I think you are partially right about the sizes of a SBAIJ matrix. I think 
it is ok for the number of columns to be greater than the number of rows (no 
information is lost or missing) but one cannot have more rows than columns 
(because there is no place to store the information for those final rows). I 
have added error checks and documents for this.

  Thanks

   Barry

* As mentioned above your example doesn't make sense because has more rows than 
columns. 


> On Aug 3, 2019, at 9:11 AM, Stefano Zampini  wrote:
> 
> Pierre,
> 
> The SBAIJ format is for square matrices, it doesn’t make sense for 
> rectangular matrices
> Anyway, I have found few bugs with SBAIJ, please have a look at 
> https://bitbucket.org/petsc/petsc/branch/stefano_zampini/sbaij-example
> 
> Stefano
> 
>> On Aug 2, 2019, at 6:00 PM, Pierre Jolivet via petsc-dev 
>>  wrote:
>> 
>> 
> 

Re: [petsc-dev] Is master broken?

[Karl Rupp via petsc-dev]

Hi Mark,

it's fine if you just double-check that all your fixes are in master 
when you're back :-)


Best regards and enjoy your vacation,
Karli


On 8/3/19 8:47 PM, Mark Adams wrote:

Karl,
Did you want me to do anything at this point? (on vacation this week) I 
will verify that master is all fixed if you get all my stuff integrated 
when I get back to work in a week.

Thanks,
Mark

On Sat, Aug 3, 2019 at 10:50 AM Karl Rupp > wrote:


If you ignore the initial ViennaCL-related commits and check against
current master (that just received cherry-picked updates from your PR),
then there are really only a few commits left that are not yet
integrated.

(I'll extract two more PRs on Monday, so master will soon have your
fixes in.)

Best regards,
Karli


On 8/3/19 5:21 AM, Balay, Satish wrote:
 > I've attempted to rebase this branch over latest master - and pushed
 > my changes to branch mark/gamg-fix-viennacl-rebased-v2
 >
 > You might want to check each of your commits in this branch to see if
 > they are ok. I had to add one extra commit - to make it match 'merge
 > of mark/gamg-fix-viennacl-rebased and master'.
 >
 > This branch has 21 commits. I think its best if you can collapse them
 > into reasonable chunks of changes. [presumably a single commit
for all
 > the changes is not the correct thing here. But the current set of 21
 > commits are all over the place]
 >
 > If you are able to migrate to this branch - its best to delete
the old
 > one [i.e origin/mark/gamg-fix-viennacl-rebased]
 >
 > Satish
 >
 > On Fri, 2 Aug 2019, Mark Adams via petsc-dev wrote:
 >
 >> I have been cherry-picking, etc, branch
mark/gamg-fix-viennacl-rebased and
 >> it is very messed up. Can someone please update this branch when
all the
 >> fixes are settled down? eg, I am seeing dozens of modified files
that I
 >> don't know anything about and I certainly don't want to put in a
PR for
 >> them.
 >>
 >> I also seem to lose my pinToCPU method for cuda matrices. I don't
 >> understand how that conflicted with anyone else but it did.
 >>
 >> Thanks,
 >> Mark
 >>
 >

Re: [petsc-dev] SeqSBAIJ v. MPISBAIJ

[Smith, Barry F. via petsc-dev]

   Pierre,

I have fixed this bug in 
https://bitbucket.org/petsc/petsc/pull-requests/1941/fix-bug-in-matmpisbaijsetpreallocationcsr/diff

Thanks for reporting and especially providing the test case

   Barry

> On Aug 1, 2019, at 6:49 PM, Smith, Barry F. via petsc-dev 
>  wrote:
> 
> 
>  Yes it is a bug, working on it now. 
> 
> 
>> On Aug 1, 2019, at 9:13 AM, Pierre Jolivet via petsc-dev 
>>  wrote:
>> 
>> Hello,
>> The attached example is a little confusing for me.
>> How come I don’t get the same matrix out-of-the-box?
>> For me, the “correct” matrix is the SeqSBAIJ, how can I get 
>> MatMPISBAIJSetPreallocationCSR to assemble the same matrix?
>> Do I have to resort to first assembling SeqSBAIJ matrices and then calling 
>> MatCreateMPIMatConcatenateSeqMat if I don’t want to play around with my 
>> input arrays?
>> 
>> Thanks,
>> Pierre
>> 
>> 
> 

Re: [petsc-dev] Is master broken?

[Mark Adams via petsc-dev]

Karl,
Did you want me to do anything at this point? (on vacation this week) I
will verify that master is all fixed if you get all my stuff integrated
when I get back to work in a week.
Thanks,
Mark

On Sat, Aug 3, 2019 at 10:50 AM Karl Rupp  wrote:

> If you ignore the initial ViennaCL-related commits and check against
> current master (that just received cherry-picked updates from your PR),
> then there are really only a few commits left that are not yet integrated.
>
> (I'll extract two more PRs on Monday, so master will soon have your
> fixes in.)
>
> Best regards,
> Karli
>
>
> On 8/3/19 5:21 AM, Balay, Satish wrote:
> > I've attempted to rebase this branch over latest master - and pushed
> > my changes to branch mark/gamg-fix-viennacl-rebased-v2
> >
> > You might want to check each of your commits in this branch to see if
> > they are ok. I had to add one extra commit - to make it match 'merge
> > of mark/gamg-fix-viennacl-rebased and master'.
> >
> > This branch has 21 commits. I think its best if you can collapse them
> > into reasonable chunks of changes. [presumably a single commit for all
> > the changes is not the correct thing here. But the current set of 21
> > commits are all over the place]
> >
> > If you are able to migrate to this branch - its best to delete the old
> > one [i.e origin/mark/gamg-fix-viennacl-rebased]
> >
> > Satish
> >
> > On Fri, 2 Aug 2019, Mark Adams via petsc-dev wrote:
> >
> >> I have been cherry-picking, etc, branch mark/gamg-fix-viennacl-rebased
> and
> >> it is very messed up. Can someone please update this branch when all the
> >> fixes are settled down? eg, I am seeing dozens of modified files that I
> >> don't know anything about and I certainly don't want to put in a PR for
> >> them.
> >>
> >> I also seem to lose my pinToCPU method for cuda matrices. I don't
> >> understand how that conflicted with anyone else but it did.
> >>
> >> Thanks,
> >> Mark
> >>
> >
>

Re: [petsc-dev] Is master broken?

[Karl Rupp via petsc-dev]

If you ignore the initial ViennaCL-related commits and check against 
current master (that just received cherry-picked updates from your PR), 
then there are really only a few commits left that are not yet integrated.


(I'll extract two more PRs on Monday, so master will soon have your 
fixes in.)


Best regards,
Karli


On 8/3/19 5:21 AM, Balay, Satish wrote:

I've attempted to rebase this branch over latest master - and pushed
my changes to branch mark/gamg-fix-viennacl-rebased-v2

You might want to check each of your commits in this branch to see if
they are ok. I had to add one extra commit - to make it match 'merge
of mark/gamg-fix-viennacl-rebased and master'.

This branch has 21 commits. I think its best if you can collapse them
into reasonable chunks of changes. [presumably a single commit for all
the changes is not the correct thing here. But the current set of 21
commits are all over the place]

If you are able to migrate to this branch - its best to delete the old
one [i.e origin/mark/gamg-fix-viennacl-rebased]

Satish

On Fri, 2 Aug 2019, Mark Adams via petsc-dev wrote:


I have been cherry-picking, etc, branch mark/gamg-fix-viennacl-rebased and
it is very messed up. Can someone please update this branch when all the
fixes are settled down? eg, I am seeing dozens of modified files that I
don't know anything about and I certainly don't want to put in a PR for
them.

I also seem to lose my pinToCPU method for cuda matrices. I don't
understand how that conflicted with anyone else but it did.

Thanks,
Mark