Re: [petsc-dev] CI format failure

2020-09-24 Thread Barry Smith 

  Everything in PETSc is open source and anyone is free to add/improve 
features. 

  The only issue is that verifying the code is ok must be quick, if there are 
errors it is fine that the rule takes more time to nicely print out details of 
the problem.

  Barry


> On Sep 24, 2020, at 12:25 PM, Junchao Zhang  wrote:
> 
> It is better the tool can also print out line and column numbers and reasons 
> why it is wrong.
> 
> --Junchao Zhang
> 
> 
> On Thu, Sep 24, 2020 at 11:16 AM Satish Balay via petsc-dev 
> mailto:petsc-dev@mcs.anl.gov>> wrote:
> The relevant part:
> 
> No space after if, for or while -
> include/petscaijdevice.h
> 
> Satish
> 
> On Thu, 24 Sep 2020, Mark Adams wrote:
> 
> > I have a failure here but I can't see what the problem is:
> > 
> > https://gitlab.com/petsc/petsc/-/jobs/755956828 
> > 
> > 
> > Am I missing something?
> > 
> > Thanks,
> > Mark
> > 
>

Re: [petsc-dev] CI format failure

2020-09-24 Thread Junchao Zhang 
It is better the tool can also print out line and column numbers and
reasons why it is wrong.

--Junchao Zhang


On Thu, Sep 24, 2020 at 11:16 AM Satish Balay via petsc-dev <
petsc-dev@mcs.anl.gov> wrote:

> The relevant part:
>
> No space after if, for or while -
> include/petscaijdevice.h
>
> Satish
>
> On Thu, 24 Sep 2020, Mark Adams wrote:
>
> > I have a failure here but I can't see what the problem is:
> >
> > https://gitlab.com/petsc/petsc/-/jobs/755956828
> >
> > Am I missing something?
> >
> > Thanks,
> > Mark
> >
>
>

Re: [petsc-dev] CI format failure

2020-09-24 Thread Satish Balay via petsc-dev 
The relevant part:

No space after if, for or while -
include/petscaijdevice.h

Satish

On Thu, 24 Sep 2020, Mark Adams wrote:

> I have a failure here but I can't see what the problem is:
> 
> https://gitlab.com/petsc/petsc/-/jobs/755956828
> 
> Am I missing something?
> 
> Thanks,
> Mark
>

[petsc-dev] CI format failure

2020-09-24 Thread Mark Adams 
I have a failure here but I can't see what the problem is:

https://gitlab.com/petsc/petsc/-/jobs/755956828

Am I missing something?

Thanks,
Mark