Re: [pgAdmin4]: Fix for RM #3248

[Dave Page]

Thanks, applied.

On Thu, Apr 5, 2018 at 7:49 AM, Neel Patel 
wrote:

> Hi,
>
> Please find updated patch after fixing the comments.
> Review it and let me know for comments.
>
> Thanks,
> Neel Patel
>
> On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel 
> wrote:
>
>> Thanks Murtuza & Khushboo.
>> I will send updated patch.
>>
>> Thanks,
>> Neel Patel
>>
>> On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Neel,
>>>
>>> Add below code to the top (around line no 8) in
>>> alertify.pgadmin.defaults.js file will solve the problem.
>>>
>>> alertify.defaults.closable = false;
>>>
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Neel,

 Can we make the change in wrapper instead of changing every where?
 File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch for the fix of RM #3248 - we have modified
> alertify confirm dialog to modal dialog.
>
> Do review it and let me know for comments.
>
> Thanks,
> Neel Patel
>


>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4]: Fix for RM #3248

[Neel Patel]

Hi,

Please find updated patch after fixing the comments.
Review it and let me know for comments.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel 
wrote:

> Thanks Murtuza & Khushboo.
> I will send updated patch.
>
> Thanks,
> Neel Patel
>
> On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Neel,
>>
>> Add below code to the top (around line no 8) in
>> alertify.pgadmin.defaults.js file will solve the problem.
>>
>> alertify.defaults.closable = false;
>>
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Neel,
>>>
>>> Can we make the change in wrapper instead of changing every where?
>>> File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel >> > wrote:
>>>
 Hi,

 Please find attached patch for the fix of RM #3248 - we have modified
 alertify confirm dialog to modal dialog.

 Do review it and let me know for comments.

 Thanks,
 Neel Patel

>>>
>>>
>>
>


RM_3248_v2.patch
Description: Binary data

Re: [pgAdmin4]: Fix for RM #3248

[Neel Patel]

Thanks Murtuza & Khushboo.
I will send updated patch.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Neel,
>
> Add below code to the top (around line no 8) in
> alertify.pgadmin.defaults.js file will solve the problem.
>
> alertify.defaults.closable = false;
>
>
> Thanks,
> Khushboo
>
> On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Neel,
>>
>> Can we make the change in wrapper instead of changing every where?
>> File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel 
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for the fix of RM #3248 - we have modified
>>> alertify confirm dialog to modal dialog.
>>>
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>

Re: [pgAdmin4]: Fix for RM #3248

[Khushboo Vashi]

Neel,

Add below code to the top (around line no 8) in
alertify.pgadmin.defaults.js file will solve the problem.

alertify.defaults.closable = false;


Thanks,
Khushboo

On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Neel,
>
> Can we make the change in wrapper instead of changing every where?
> File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached patch for the fix of RM #3248 - we have modified
>> alertify confirm dialog to modal dialog.
>>
>> Do review it and let me know for comments.
>>
>> Thanks,
>> Neel Patel
>>
>
>

Re: [pgAdmin4]: Fix for RM #3248

[Murtuza Zabuawala]

Hi Neel,

Can we make the change in wrapper instead of changing every where?
File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel 
wrote:

> Hi,
>
> Please find attached patch for the fix of RM #3248 - we have modified
> alertify confirm dialog to modal dialog.
>
> Do review it and let me know for comments.
>
> Thanks,
> Neel Patel
>

[pgAdmin4]: Fix for RM #3248

[Neel Patel]

Hi,

Please find attached patch for the fix of RM #3248 - we have modified
alertify confirm dialog to modal dialog.

Do review it and let me know for comments.

Thanks,
Neel Patel


RM_3248.patch
Description: Binary data