[pgadmin-hackers] SVN Commit by dpage: r7555 - trunk/www
Author: dpage Date: 2009-01-15 08:46:56 + (Thu, 15 Jan 2009) New Revision: 7555 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7555view=rev Log: Redirect hits for the archives which we no longer host ourselves Modified: trunk/www/.htaccess -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7556 - trunk/www
Author: dpage Date: 2009-01-15 08:48:55 + (Thu, 15 Jan 2009) New Revision: 7556 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7556view=rev Log: Update the readme to remove references to the old archives Modified: trunk/www/README.txt -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More on sizing
Dave Page a écrit :
On Mon, Jan 12, 2009 at 11:58 PM, Guillaume Lelarge
guilla...@lelarge.info wrote:
Hi,
Dave Page a écrit :
Hi,
Opening dlgJob/dlgStep/dlgSchedule with it's default size on Windows
leaves the SQL textbox the wrong size and the Read Only checkbox
obscured. Resizing the dialog fixes it in all cases.
This patch should fix this. It needs more code cleaning in some dialogs,
but it should work. Can you check on your issue? Thanks.
Yup, that seems to do the job.
Here is the new version, based on the previous patch. There's a lot more
work on the different .xrc files. It fixes some issues on GTK and some
others on Mac.
I checked this patch on each platform (GTK, Mac, Windows) for each
dialog I could. These dialogs weren't part of it:
* dlgPackage and dlgSynonym (I would need an EDB server for this).
* dlgRep* (I would need to setup Slony support on pgAdmin).
Anyways, there's still some stuff to do:
* dlgServer needs to be that size to work on GTK. But no component can
grow on it, so in the two other platforms, there's a big void. We can
avoid this with a growable DB restriction field.
* and default sizing.
For default sizing, there's quite a lot of different sizes.
List of different widths:
width | count
---+---
248 | 1
300 | 1
288 | 1
200 | 1
205 | 2
268 | 2
220 | 3
214 | 5
218 |40
(9 lines)
We should have only two different widths: 220 (51) and 300 (5).
List of different heights:
height | count
+---
133 | 1
330 | 1
320 | 1
270 | 1
166 | 1
300 | 2
250 | 2
83 | 2
200 | 2
280 | 2
310 | 3
198 | 3
290 | 3
260 | 3
113 | 5
138 | 5
240 |19
(17 lignes)
Three different heights seem better: 330 (16), 250 (27) and 150 (14).
Comments?
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
Index: pgadmin/agent/dlgJob.cpp
===
--- pgadmin/agent/dlgJob.cpp (révision 7554)
+++ pgadmin/agent/dlgJob.cpp (copie de travail)
@@ -218,10 +218,10 @@
returncode = dlgProperty::Go(modal);
-#ifdef __WXMAC__
-wxSizeEvent event(wxSize(GetSize().GetWidth() - 20, GetSize().GetHeight() + 200));
-OnChangeSize(event);
-#endif
+// This fixes a UI glitch on MacOS X
+// Because of the new layout code, the Columns pane doesn't size itself properly
+SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
+SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
return returncode;
}
Index: pgadmin/dlg/dlgIndexConstraint.cpp
===
--- pgadmin/dlg/dlgIndexConstraint.cpp (révision 7554)
+++ pgadmin/dlg/dlgIndexConstraint.cpp (copie de travail)
@@ -95,14 +95,7 @@
cbTablespace-SetSelection(0);
}
-int returnCode = dlgIndexBase::Go(modal);
-
-#ifdef __WXMAC__
-wxSizeEvent event(wxSize(GetSize().GetWidth() - 25, GetSize().GetHeight() + 200));
-OnChangeSize(event);
-#endif
-
-return returnCode;
+return dlgIndexBase::Go(modal);
}
Index: pgadmin/dlg/dlgProperty.cpp
===
--- pgadmin/dlg/dlgProperty.cpp (révision 7554)
+++ pgadmin/dlg/dlgProperty.cpp (copie de travail)
@@ -321,6 +321,12 @@
return ShowModal();
else
Show(true);
+
+// This fixes a UI glitch on MacOS X and Windows
+// Because of the new layout code, the Privileges pane don't size itself properly
+SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
+SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
+
return 0;
}
Index: pgadmin/dlg/dlgFunction.cpp
===
--- pgadmin/dlg/dlgFunction.cpp (révision 7554)
+++ pgadmin/dlg/dlgFunction.cpp (copie de travail)
@@ -160,7 +160,6 @@
int dlgFunction::Go(bool modal)
{
-int returncode;
isBackendMinVer84 = connection-BackendMinimumVersion(8, 4);
if (function)
@@ -387,14 +386,7 @@
SetupVarEditor(1);
-returncode = dlgSecurityProperty::Go(modal);
-
-// This fixes a UI glitch on MacOS X and Windows
-// Because of the new layout code, the Privileges pane don't size itself properly
-SetSize(GetSize().GetWidth()+1, GetSize().GetHeight());
-SetSize(GetSize().GetWidth()-1, GetSize().GetHeight());
-
-return returncode;
+return dlgSecurityProperty::Go(modal);
}
#ifdef __WXMAC__
Index: pgadmin/dlg/dlgTable.cpp
===
--- pgadmin/dlg/dlgTable.cpp (révision 7554)
+++ pgadmin/dlg/dlgTable.cpp (copie de travail)
@@ -146,8 +146,6 @@
int dlgTable::Go(bool modal)
{
-int returncode;
-
if (!table)
cbOwner-Append(wxT());
AddGroups();
@@ -498,14 +496,7 @@
[pgadmin-hackers] SVN Commit by guillaume: r7557 - in trunk/pgadmin3/pgadmin: agent dlg ui
Author: guillaume Date: 2009-01-15 17:41:19 + (Thu, 15 Jan 2009) New Revision: 7557 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7557view=rev Log: Fix a lot of UI issues on GTK and Mac. Standardize dialod sizes. Modified: trunk/pgadmin3/pgadmin/agent/dlgJob.cpp trunk/pgadmin3/pgadmin/dlg/dlgDatabase.cpp trunk/pgadmin3/pgadmin/dlg/dlgFunction.cpp trunk/pgadmin3/pgadmin/dlg/dlgIndex.cpp trunk/pgadmin3/pgadmin/dlg/dlgIndexConstraint.cpp trunk/pgadmin3/pgadmin/dlg/dlgPackage.cpp trunk/pgadmin3/pgadmin/dlg/dlgProperty.cpp trunk/pgadmin3/pgadmin/dlg/dlgReassignDropOwned.cpp trunk/pgadmin3/pgadmin/dlg/dlgSchema.cpp trunk/pgadmin3/pgadmin/dlg/dlgSequence.cpp trunk/pgadmin3/pgadmin/dlg/dlgServer.cpp trunk/pgadmin3/pgadmin/dlg/dlgTable.cpp trunk/pgadmin3/pgadmin/dlg/dlgTablespace.cpp trunk/pgadmin3/pgadmin/dlg/dlgTextSearchConfiguration.cpp trunk/pgadmin3/pgadmin/dlg/dlgTextSearchDictionary.cpp trunk/pgadmin3/pgadmin/dlg/dlgView.cpp trunk/pgadmin3/pgadmin/ui/dlgAddFavourite.xrc trunk/pgadmin3/pgadmin/ui/dlgAggregate.xrc trunk/pgadmin3/pgadmin/ui/dlgCast.xrc trunk/pgadmin3/pgadmin/ui/dlgCheck.xrc trunk/pgadmin3/pgadmin/ui/dlgColumn.xrc trunk/pgadmin3/pgadmin/ui/dlgConversion.xrc trunk/pgadmin3/pgadmin/ui/dlgDatabase.xrc trunk/pgadmin3/pgadmin/ui/dlgDirectDbg.xrc trunk/pgadmin3/pgadmin/ui/dlgDomain.xrc trunk/pgadmin3/pgadmin/ui/dlgEditGridOptions.xrc trunk/pgadmin3/pgadmin/ui/dlgForeignKey.xrc trunk/pgadmin3/pgadmin/ui/dlgFunction.xrc trunk/pgadmin3/pgadmin/ui/dlgGroup.xrc trunk/pgadmin3/pgadmin/ui/dlgHbaConfig.xrc trunk/pgadmin3/pgadmin/ui/dlgIndex.xrc trunk/pgadmin3/pgadmin/ui/dlgIndexConstraint.xrc trunk/pgadmin3/pgadmin/ui/dlgJob.xrc trunk/pgadmin3/pgadmin/ui/dlgLanguage.xrc trunk/pgadmin3/pgadmin/ui/dlgOperator.xrc trunk/pgadmin3/pgadmin/ui/dlgPackage.xrc trunk/pgadmin3/pgadmin/ui/dlgPgpassConfig.xrc trunk/pgadmin3/pgadmin/ui/dlgRepCluster.xrc trunk/pgadmin3/pgadmin/ui/dlgRepClusterUpgrade.xrc trunk/pgadmin3/pgadmin/ui/dlgRepListen.xrc trunk/pgadmin3/pgadmin/ui/dlgRepNode.xrc trunk/pgadmin3/pgadmin/ui/dlgRepPath.xrc trunk/pgadmin3/pgadmin/ui/dlgRepSequence.xrc trunk/pgadmin3/pgadmin/ui/dlgRepSet.xrc trunk/pgadmin3/pgadmin/ui/dlgRepSetMerge.xrc trunk/pgadmin3/pgadmin/ui/dlgRepSetMove.xrc trunk/pgadmin3/pgadmin/ui/dlgRepSubscription.xrc trunk/pgadmin3/pgadmin/ui/dlgRepTable.xrc trunk/pgadmin3/pgadmin/ui/dlgRole.xrc trunk/pgadmin3/pgadmin/ui/dlgRule.xrc trunk/pgadmin3/pgadmin/ui/dlgSchedule.xrc trunk/pgadmin3/pgadmin/ui/dlgSchema.xrc trunk/pgadmin3/pgadmin/ui/dlgSequence.xrc trunk/pgadmin3/pgadmin/ui/dlgServer.xrc trunk/pgadmin3/pgadmin/ui/dlgStep.xrc trunk/pgadmin3/pgadmin/ui/dlgSynonym.xrc trunk/pgadmin3/pgadmin/ui/dlgTable.xrc trunk/pgadmin3/pgadmin/ui/dlgTablespace.xrc trunk/pgadmin3/pgadmin/ui/dlgTextSearchConfiguration.xrc trunk/pgadmin3/pgadmin/ui/dlgTextSearchDictionary.xrc trunk/pgadmin3/pgadmin/ui/dlgTextSearchParser.xrc trunk/pgadmin3/pgadmin/ui/dlgTextSearchTemplate.xrc trunk/pgadmin3/pgadmin/ui/dlgTrigger.xrc trunk/pgadmin3/pgadmin/ui/dlgType.xrc trunk/pgadmin3/pgadmin/ui/dlgUser.xrc trunk/pgadmin3/pgadmin/ui/dlgView.xrc trunk/pgadmin3/pgadmin/ui/xrcDialogs.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More on sizing
Dave Page a écrit : On Thu, Jan 15, 2009 at 5:02 PM, Guillaume Lelarge guilla...@lelarge.info wrote: sounds good to me - please go ahead with the changes. Here it is. Please commit and we can all test as and when possible (I'm pretty busy atm). I have no doubt it's an improvement. Done, thanks. I've changed the wiki page (http://wiki.postgresql.org/wiki/PgAdmin_Internals#Property_page_dialogue_layout) to show the new standardized dialog height and size. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Adjustment of a query window
Hi. I think that it is hard to use the graphical query builder of a query window. Then, I make one proposal. 1. When the pane has chosen the SQL editor. It has output and a scratch pad. http://winpg.jp/~saito/pgAdmin/20090113_QB_No1.png 2. When the pane has chosen the graphical query builder. It excepts output and a scratch pad. http://winpg.jp/~saito/pgAdmin/20090113_QB_No2.png I think that it is kind to a user by appearance. Anyone objection? Regards, Hiroshi Saito -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Import: I need some help to design UI
Hi, all I design wxWizard UI with xrc. But It can't be resized. One week ago, I had posted a topic in wxForum. Get no answer: http://wxforum.shadonet.com/viewtopic.php?t=22485 In the examples with wxWidgets source, the wizard dialog is created by new wxWizard(wxFrame frame). All of them can be resized. Suggest me, please. --- Quan Zongliang quanzongli...@gmail.com CIT Japan: http://www.cit.co.jp CIT China: http://www.citbj.com.cn -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
