date:20170331

[pgadmin-hackers] pgAdmin 4 commit: Properly handle truncated table names (> NAMEDATALEN)

2017-03-31 Thread Dave Page

Properly handle truncated table names (> NAMEDATALEN). Fixes #2277

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb0bd8acc5d6899ed514159e344928e6453faa63
Author: Aravindraja Thinakaran 

Modified Files
--
.../server_groups/servers/databases/schemas/tables/__init__.py  | 6 ++
1 file changed, 6 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add the config option ALLOW_SAVE_PASSWORD to allow ad

2017-03-31 Thread Dave Page

Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of 
passwords. Fixes #2232

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a861f7a914ab5c33cf9e04aae6fa4aa5bf96a53
Author: Akshay Joshi 

Modified Files
--
web/config.py  | 5 +
web/pgadmin/browser/server_groups/servers/__init__.py  | 7 ---
.../browser/server_groups/servers/templates/servers/password.html  | 4 +++-
.../browser/server_groups/servers/templates/servers/servers.js | 3 +++
4 files changed, 15 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-03-31 Thread Dave Page

Hi

On Friday, March 31, 2017, Khushboo Vashi 
wrote:

> Hi,
>
> On Mon, Mar 27, 2017 at 9:57 PM, Dave Page  > wrote:
>
>> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
>> > > wrote:
>> > Hi Dave,
>> >
>> > I have fixed the issue and the patch for the same is attached, but the
>> > Binary path options are not translated properly.
>>
>> Thanks - committed.
>>
>> > We register the preferences before the first request of the app. In this
>> > case we don't have any language loaded, so it will take only English.
>> > To fix this issue, I had explicitly added gettext for the labels and
>> help
>> > messages while opening the Preference dialogue.
>> > All the labels and help messages render properly except Binary paths;
>> as at
>> > run time we don't get the translation of 'EDB Advanced Server Binary
>> Path'.
>> > We have translations like below:
>> >
>> > #: pgadmin/browser/server_groups/servers/types.py:59
>> > msgid "{0} Binary Path"
>> > msgstr "Ścieżka Binarna {0}"
>> >
>> > So, in this case my suggestion is to have the entire label/help messages
>> > translations.
>> > So, that the Preference dialogue can translate run time.
>>
>> I'm fine with that; however, the strings should come from the
>> underlying drivers of course, as only they should have specific
>> knowledge of details such as the name of the database server they
>> provide access to.
>>
>> The string always comes from drivers as they are being registered from
> there.
> I have attached the patch to translate the entire string.
> I took the reference of the string from the messages.po file and
> translated, so someone has to validate that this is the correct translation.
>

All I see in the patch is updates to the message catalog. It seems to me
there should be chunks in there to push the entire string back into the
relevant driver, otherwise the changes to the messages.po files will be
overwritten the next time I do an extract/merge.

Essentially, I think we need to add properties to the drivers, such as:

BIN_PATH_LABEL = _("PostgreSQL Binary Path")
BIN_PATH_HELP = _("Path to the directory containing the PostgreSQL utility
programs (pg_dump, pg_restore etc).")

Then in types.py, we'd have something like:

st.utility_path = paths.register(
'bin_paths', st.stype + '_bin_dir',
st.BIN_PATH_LABEL,
'text', default_path, category_label=_('Binary paths'),
help_str=st.BIN_PATH_HELP
)
)

Thanks.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Generic function qtLiteral was not adapting values pr

2017-03-31 Thread Dave Page

Generic function qtLiteral was not adapting values properly when they contain 
non ascii characters. Fixes #2305

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9acf3404005333daaa9658c4e2c22ad58ad1f99b
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Remove debug code.

2017-03-31 Thread Dave Page

Remove debug code.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ba9269a88a055bd151cbf5929b0d660d2843ef2

Modified Files
--
web/pgadmin/browser/templates/browser/js/browser.js | 3 ---
1 file changed, 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix error highlighting in the query tool. Fixes #2291

2017-03-31 Thread Dave Page

Fix error highlighting in the query tool. Fixes #2291

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efb077b7f77f6313bb4b67aa3ffb27a65e296330
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/tools/sqleditor/__init__.py | 6 --
web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-03-31 Thread Dave Page

Thanks, applied.

On Friday, March 31, 2017, Harshal Dhumal 
wrote:

> Hi,
>
> PFA patch for RM2305.
>
>
> Issue: Generic function qtLiteral was not adapting values properly which
> contains non ascii characters.
>
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

2017-03-31 Thread Dave Page

Thanks, applied.

On Friday, March 31, 2017, Akshay Joshi 
wrote:

> Hi
>
> Please find the attached patch to fix RM #2232 Add the ability to
> gray-out/disable the "Save Password" option when creating a connection to a
> server.
>
> Please review it.
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

2017-03-31 Thread Dave Page

Thanks, applied.

On Friday, March 31, 2017, Khushboo Vashi 
wrote:

> Hi,
>
> Please find the attached patch to fix RM #2291: Error highlighting broken.
>
> Murtuza / Akshay,
>
> Can you please review the patch?
>
> Thanks,
> Khushboo
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Devrim Gündüz

Hi,

Ok,.got it.

Thanks!

Regards, Devrim

On April 1, 2017 12:34:35 AM GMT+03:00, Dave Page  wrote:
>On Friday, March 31, 2017, Devrim Gündüz  wrote:
>
>>
>> Hi Dave,
>>
>> On Fri, 2017-03-31 at 21:03 +, Dave Page wrote:
>> > Update Babel version.
>>
>> Uh, this is the version on Fedora 25.
>>
>> RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI.
>>
>
>Doesn't really matter - the bug in question will only affect developers
>who
>recompile the message catalogs using Python 3.
>
>Thanks.
>
>
>-- 
>Dave Page
>Blog: http://pgsnake.blogspot.com
>Twitter: @pgsnake
>
>EnterpriseDB UK: http://www.enterprisedb.com
>The Enterprise PostgreSQL Company

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page

On Friday, March 31, 2017, Devrim Gündüz  wrote:

>
> Hi Dave,
>
> On Fri, 2017-03-31 at 21:03 +, Dave Page wrote:
> > Update Babel version.
>
> Uh, this is the version on Fedora 25.
>
> RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI.
>

Doesn't really matter - the bug in question will only affect developers who
recompile the message catalogs using Python 3.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Devrim Gündüz


Hi Dave,

On Fri, 2017-03-31 at 21:03 +, Dave Page wrote:
> Update Babel version.

Uh, this is the version on Fedora 25.

RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI.

Regards,
-- 
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

[pgadmin-hackers] pgAdmin 4 commit: Add missing semi-colon.

2017-03-31 Thread Dave Page

Add missing semi-colon.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4fd3133717d04dfd5df3cee4162e43be628617a

Modified Files
--
ci/update_messages.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page

Update Babel version.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7fc21e3bb28ef782ccb1d251108b2d079e719fe

Modified Files
--
requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add missing bracket

2017-03-31 Thread Dave Page

Add missing bracket

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3e6fe5b642886bf55fe28b4ae5865f2f283bf7f

Modified Files
--
ci/update_messages.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update CI script output for parsing with the Log Pars

2017-03-31 Thread Dave Page

Update CI script output for parsing with the Log Parser plugin in Jenkins

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e50c186df14d57d8d9d4f49138e5557d1e8e3dc

Modified Files
--
ci/build_docs.sh|  4 +---
ci/build_pip_wheel.sh   |  4 +---
ci/build_runtime_qt4.sh |  4 +---
ci/build_runtime_qt5.sh |  4 +---
ci/build_tarballs.sh|  4 +---
ci/ci_runner.sh | 18 +-
ci/create_config.sh |  4 +---
ci/run_jasmine_tests.sh |  4 +---
ci/run_python_tests.sh  | 13 -
ci/update_messages.sh   | 10 --
10 files changed, 24 insertions(+), 45 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Include translation message catalogs in CI build/test

2017-03-31 Thread Dave Page

Include translation message catalogs in CI build/test runs.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a1bb8863a8759263636b0b8aa77ad462f3ce4d4

Modified Files
--
ci/ci_runner.sh | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Make sure each build/test starts in the correct direc

2017-03-31 Thread Dave Page

Make sure each build/test starts in the correct directory.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac1637f281d320ef727c23eef135d332ee6eb8cd

Modified Files
--
ci/build_docs.sh|  3 ++-
ci/build_pip_wheel.sh   |  3 ++-
ci/build_runtime_qt4.sh |  1 +
ci/build_runtime_qt5.sh |  1 +
ci/build_tarballs.sh|  2 ++
ci/ci_runner.sh | 17 -
ci/create_config.sh |  2 ++
ci/run_jasmine_tests.sh |  1 +
ci/run_python_tests.sh  |  2 ++
ci/update_messages.sh   |  3 ++-
10 files changed, 15 insertions(+), 20 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add message catalog builds to CI, and run all tests f

2017-03-31 Thread Dave Page

Add message catalog builds to CI, and run all tests from a runner script to 
enable test/build addition purely from the source tree.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6fa5f5b3356cb07e84e5b1c263bbff8a59d4daf

Modified Files
--
ci/ci_runner.sh   | 27 +++
ci/update_messages.sh | 15 +++
2 files changed, 42 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread George Gelashvili

Hi,

We've updated Murtuza's README change to be more consistent with other
instructions - adding a colon and newline.

-Matt and George

On Fri, Mar 31, 2017 at 10:47 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor add-on patch for README.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> Patch looks good to me.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Joao & Sarah,
>>>
>>> I have asked Murtuza to review the patch today.
>>> He will update me by EOD.
>>>
>>> If all goes well, I will commit the patch.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>
>>> On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hello Dave and Ashesh,

 Do you still need us to provide more information about this patch or is
 it ready to be merged?

 Thanks
 Joao

 On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
>
> We found out a issue using Python 3 related to importing modules that
> we corrected in the patch that is now attached.
>
> Also we would like to know the status of this.
>
> Thanks
> Joao & Sarah
>
> On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear 
> wrote:
>
>> Hi!
>>
>> We realized that this change was causing the tests to fail because
>> the folder for the sqlite databases was not being created. We also 
>> updated
>> the files to contain the missing headers.
>>
>> Thanks!
>> Joao & Sarah
>>
>>
>>
>> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page  wrote:
>>
>>> Ashesh, can you review/commit this please? One thing I notice on a
>>> quick look through is that the file headers are missing everywhere.
>>> They should be present in all source files, except where they would
>>> bloat the data transfer from client to server.
>>>
>>> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear 
>>> wrote:
>>> > Hi Hackers!
>>> >
>>> > It looks like our previous patch messed up some logging. Please
>>> use this one
>>> > instead.
>>> >
>>> > Thanks,
>>> > Joao & Sarah
>>> >
>>> >
>>> >
>>> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <
>>> smcal...@pivotal.io> wrote:
>>> >>
>>> >> Hi Hackers!
>>> >>
>>> >> Here's a patch to move to current db migration system to use
>>> Alembic.
>>> >> Instructions to create new migrations are in the README.
>>> >>
>>> >> Thanks!
>>> >> Joao & Sarah
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (
>>> pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
diff --git a/README b/README
index 973fdec1..f6d05df0 100644
--- a/README
+++ b/README
@@ -196,6 +196,10 @@ Add any changes to the 'upgrade' function.
 
 There is no need to increment the SETTINGS_SCHEMA_VERSION.
 
+For other positional arguments refer to help:
+
+(pgadmin4) $ FLASK_APP=pgAdmin4.py flask db --help
+
 Configuring the Runtime
 ---
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Murtuza Zabuawala

Hi,

PFA minor add-on patch for README.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> Patch looks good to me.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Joao & Sarah,
>>
>> I have asked Murtuza to review the patch today.
>> He will update me by EOD.
>>
>> If all goes well, I will commit the patch.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Dave and Ashesh,
>>>
>>> Do you still need us to provide more information about this patch or is
>>> it ready to be merged?
>>>
>>> Thanks
>>> Joao
>>>
>>> On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hello Hackers,

 We found out a issue using Python 3 related to importing modules that
 we corrected in the patch that is now attached.

 Also we would like to know the status of this.

 Thanks
 Joao & Sarah

 On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear 
 wrote:

> Hi!
>
> We realized that this change was causing the tests to fail because the
> folder for the sqlite databases was not being created. We also updated the
> files to contain the missing headers.
>
> Thanks!
> Joao & Sarah
>
>
>
> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page  wrote:
>
>> Ashesh, can you review/commit this please? One thing I notice on a
>> quick look through is that the file headers are missing everywhere.
>> They should be present in all source files, except where they would
>> bloat the data transfer from client to server.
>>
>> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear 
>> wrote:
>> > Hi Hackers!
>> >
>> > It looks like our previous patch messed up some logging. Please use
>> this one
>> > instead.
>> >
>> > Thanks,
>> > Joao & Sarah
>> >
>> >
>> >
>> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear 
>> wrote:
>> >>
>> >> Hi Hackers!
>> >>
>> >> Here's a patch to move to current db migration system to use
>> Alembic.
>> >> Instructions to create new migrations are in the README.
>> >>
>> >> Thanks!
>> >> Joao & Sarah
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (
>> pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

>>>
>>
>
diff --git a/README b/README
index 973fdec..f39cb37 100644
--- a/README
+++ b/README
@@ -196,6 +196,9 @@ Add any changes to the 'upgrade' function.
 
 There is no need to increment the SETTINGS_SCHEMA_VERSION.
 
+For other positional arguments refer help,
+(pgadmin4) $ FLASK_APP=pgAdmin4.py flask db --help
+
 Configuring the Runtime
 ---
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Murtuza Zabuawala

Hi Ashesh,

Patch looks good to me.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi  wrote:

> Hi Joao & Sarah,
>
> I have asked Murtuza to review the patch today.
> He will update me by EOD.
>
> If all goes well, I will commit the patch.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
> On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Dave and Ashesh,
>>
>> Do you still need us to provide more information about this patch or is
>> it ready to be merged?
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Hackers,
>>>
>>> We found out a issue using Python 3 related to importing modules that we
>>> corrected in the patch that is now attached.
>>>
>>> Also we would like to know the status of this.
>>>
>>> Thanks
>>> Joao & Sarah
>>>
>>> On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear 
>>> wrote:
>>>
 Hi!

 We realized that this change was causing the tests to fail because the
 folder for the sqlite databases was not being created. We also updated the
 files to contain the missing headers.

 Thanks!
 Joao & Sarah



 On Thu, Mar 16, 2017 at 9:31 AM, Dave Page  wrote:

> Ashesh, can you review/commit this please? One thing I notice on a
> quick look through is that the file headers are missing everywhere.
> They should be present in all source files, except where they would
> bloat the data transfer from client to server.
>
> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear 
> wrote:
> > Hi Hackers!
> >
> > It looks like our previous patch messed up some logging. Please use
> this one
> > instead.
> >
> > Thanks,
> > Joao & Sarah
> >
> >
> >
> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear 
> wrote:
> >>
> >> Hi Hackers!
> >>
> >> Here's a patch to move to current db migration system to use
> Alembic.
> >> Instructions to create new migrations are in the README.
> >>
> >> Thanks!
> >> Joao & Sarah
> >>
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hack...@postgresql.or
> g)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-31 Thread Akshay Joshi

Hi Navnath

I have run the updated patch. It is working fine with Python 2.7 but I am
facing following error with Python 3.5, can you please look into it:

==

ERROR: runTest
(pgadmin.feature_tests.connect_to_server_feature_test.ConnectsToServerFeatureTest)

Test database connection which can be created from the UI

--

Traceback (most recent call last):

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/base_feature_test.py",
line 33, in setUp

self.page.reset_layout()

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 33, in reset_layout

self.click_modal_ok()

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 38, in click_modal_ok

self.click_element(self.find_by_xpath("//button[contains(.,'OK')]"))

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 71, in find_by_xpath

return self.wait_for_element(lambda driver:
driver.find_element_by_xpath(xpath))

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 128, in wait_for_element

return self._wait_for("element to exist", element_if_it_exists)

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 162, in _wait_for

"Timed out waiting for " + waiting_for_message)

  File
"/Users/akshay/Development/Workspace/lib/python3.5/site-packages/selenium/webdriver/support/wait.py",
line 80, in until

raise TimeoutException(message, screen, stacktrace)

selenium.common.exceptions.TimeoutException: Message: Timed out waiting for
element to exist



==

ERROR: runTest
(pgadmin.feature_tests.table_ddl_feature_test.TableDdlFeatureTest)

Test scenarios for acceptance tests

--

Traceback (most recent call last):

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/base_feature_test.py",
line 33, in setUp

self.page.reset_layout()

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 31, in reset_layout

self.click_element(self.find_by_partial_link_text("File"))

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 90, in click_element

return self._wait_for("clicking the element not to throw an exception",
click_succeeded)

  File
"/Users/akshay/Development/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 162, in _wait_for

"Timed out waiting for " + waiting_for_message)

  File
"/Users/akshay/Development/Workspace/lib/python3.5/site-packages/selenium/webdriver/support/wait.py",
line 80, in until

raise TimeoutException(message, screen, stacktrace)

selenium.common.exceptions.TimeoutException: Message: Timed out waiting for
clicking the element not to throw an exception



--

Ran 153 tests in 45.493s


FAILED (errors=2, skipped=16)


==

Test Result Summary

==


Traceback (most recent call last):

  File "runtests.py", line 354, in 

skipped_cases)

  File
"/Users/akshay/Development/pgadmin4/web/regression/python_test_utils/test_utils.py",
line 442, in get_scenario_name

key, value = case_name_dict.items()[0]

TypeError: 'dict_items' object does not support indexing

On Thu, Mar 30, 2017 at 8:04 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi Dave,
>
>  Please find the revised patch for test result enhancement.
>
> *What's in the patch:*
> 1. The test result summary will store in JSON file.
> 2. Removed some redundant code from *regression/test_utils.py*
> *3. A*dded the scenario names for feature tests.
> 4. To print test scenario names in failed and skipped test cases, I o
> verride *apply_scenario()* function in *regression/test_utils.py*
>
> I have also attached the sample JSON file with the test result as per your
> suggestions.
>
> Thanks!
>
>
>
> On Wed, Mar 29, 2017 at 6:03 PM, Dave Page  wrote:
>
>> On Wed, Mar 29, 2017 at 4:12 AM, Navnath Gadakh
>>  wrote:
>> > Hi,
>> >
>> > On Mon, Mar 27, 2017 at 5:37 PM, Dave Page  wrote:
>> >>
>> >> Hi
>> >>
>> >> On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh
>> >>  wrote:
>> >> > Hello Dave,
>> >> >
>> >> > On Fri, Mar 24, 2017 at 9:10 PM, Dave Page 
>> wrote:
>> >> >>
>> >> >> Hi
>> >> >>
>> >> >> On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh
>> >> >>  wrote:
>> >> >> >
>> >> >> >> When running with the patch:
>> >> >> >>
>> >> >> >> 1) The browser isn't closed, and the script never exits - it just
>> >> >> >> sits
>> >> >

[pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-03-31 Thread Harshal Dhumal

Hi,

PFA patch for RM2305.


Issue: Generic function qtLiteral was not adapting values properly which
contains non ascii characters.


-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py
index bdbbee4..5c4f9ac 100644
--- a/web/pgadmin/utils/driver/psycopg2/__init__.py
+++ b/web/pgadmin/utils/driver/psycopg2/__init__.py
@@ -1828,21 +1828,20 @@ class Driver(BaseDriver):
 
 @staticmethod
 def qtLiteral(value):
-try:
-res = adapt(value).getquoted()
-except UnicodeEncodeError:
-# We will handle special characters with utf8 encoding
-adapted = adapt(value)
+adapted = adapt(value)
+
+# Not all adapted objects have encoding
+# e.g.
+# psycopg2.extensions.BOOLEAN
+# psycopg2.extensions.FLOAT
+# psycopg2.extensions.INTEGER
+# etc...
+if hasattr(adapted, 'encoding'):
 adapted.encoding = 'utf8'
-res = adapted.getquoted()
+res = adapted.getquoted()
 
-# Returns in bytes, we need to convert it in string
 if isinstance(res, bytes):
-try:
-res = res.decode()
-except UnicodeDecodeError:
-res = res.decode('utf-8')
-
+return res.decode('utf-8')
 return res
 
 @staticmethod

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix dialog help in browser tab/window

2017-03-31 Thread Akshay Joshi

Thanks patch applied.

On Thu, Mar 30, 2017 at 7:54 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue where "Dialog Help" was broken in case where
> query tool/Debugger opens in new browser tab.
> RM#2310
>
> *Note:*
> Object help might not work as well when used in new browser tab but for
> that we might need to find a way to pass node & server information in new
> browser tab so that we can able to create proper url for given/selected
> object which requires some time and fortunately we not using Object help
> button in query tool or debugger at present, meanwhile this patch will fix
> the issue for dialog help button only.
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Dialog Help was broken in case where query tool/Debug

2017-03-31 Thread Akshay Joshi

Dialog Help was broken in case where query tool/Debugger opens in new browser 
tab. Fixes #2310

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08ff9d7422aef7e1bdd46c5d71f5965ee5e36ab4
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/templates/browser/js/browser.js| 29 ++
1 file changed, 18 insertions(+), 11 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-03-31 Thread Khushboo Vashi

Hi,

On Mon, Mar 27, 2017 at 9:57 PM, Dave Page  wrote:

> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
>  wrote:
> > Hi Dave,
> >
> > I have fixed the issue and the patch for the same is attached, but the
> > Binary path options are not translated properly.
>
> Thanks - committed.
>
> > We register the preferences before the first request of the app. In this
> > case we don't have any language loaded, so it will take only English.
> > To fix this issue, I had explicitly added gettext for the labels and help
> > messages while opening the Preference dialogue.
> > All the labels and help messages render properly except Binary paths; as
> at
> > run time we don't get the translation of 'EDB Advanced Server Binary
> Path'.
> > We have translations like below:
> >
> > #: pgadmin/browser/server_groups/servers/types.py:59
> > msgid "{0} Binary Path"
> > msgstr "Ścieżka Binarna {0}"
> >
> > So, in this case my suggestion is to have the entire label/help messages
> > translations.
> > So, that the Preference dialogue can translate run time.
>
> I'm fine with that; however, the strings should come from the
> underlying drivers of course, as only they should have specific
> knowledge of details such as the name of the database server they
> provide access to.
>
> The string always comes from drivers as they are being registered from
there.
I have attached the patch to translate the entire string.
I took the reference of the string from the messages.po file and
translated, so someone has to validate that this is the correct translation.


> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/translations/pl/LC_MESSAGES/messages.po b/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
index ac20c13..f53c5fc 100644
--- a/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
@@ -357,6 +357,14 @@ msgstr "Ścieżki"
 msgid "{0} Binary Path"
 msgstr "Ścieżka Binarna {0}"
 
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "PostgreSQL Binary Path"
+msgstr "Ścieżka Binarna PostgreSQL"
+
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "EDB Advanced Server Binary Path"
+msgstr "Ścieżka Binarna EDB Advanced Server"
+
 #: pgadmin/browser/server_groups/servers/types.py:57
 msgid "Binary paths"
 msgstr "Ścieżki binarne"
@@ -367,6 +375,18 @@ msgid ""
 "pg_restore etc)."
 msgstr "Ścieżka zawierająca programy narzędziowe {0} (pg_dump, pg_restore itd)."
 
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the EDB Advanced Server utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "Ścieżka zawierająca programy narzędziowe EDB Advanced Server (pg_dump, pg_restore itd)."
+
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the PostgreSQL utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "Ścieżka zawierająca programy narzędziowe PostgreSQL (pg_dump, pg_restore itd)."
+
 #: pgadmin/browser/server_groups/servers/types.py:111
 #, python-format
 msgid "Could not find the utility for the operation '%s'"
diff --git a/web/pgadmin/translations/zh/LC_MESSAGES/messages.po b/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
index f07037e..7faed78 100644
--- a/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
@@ -357,6 +357,14 @@ msgstr "路径"
 msgid "{0} Binary Path"
 msgstr "{0} 二进制文件路径"
 
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "PostgreSQL Binary Path"
+msgstr "PostgreSQL 二进制文件路径"
+
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "EDB Advanced Server Binary Path"
+msgstr "EDB Advanced Server 二进制文件路径"
+
 #: pgadmin/browser/server_groups/servers/types.py:57
 msgid "Binary paths"
 msgstr "二进制路径"
@@ -367,6 +375,18 @@ msgid ""
 "pg_restore etc)."
 msgstr "包含{0} 实用程序（pg_dump，pg_restore等）的目录的路径。"
 
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the PostgreSQL utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "包含PostgreSQL 实用程序（pg_dump，pg_restore等）的目录的路径。"
+
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the EDB Advanced Server utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "包含EDB Advanced Server 实用程序（pg_dump，pg_restore等）的目录的路径。"
+
 #: pgadmin/browser/server_groups/servers/types.py:111
 #, python-format
 msgid "Could not find the utility for the operation '%s'"

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

2017-03-31 Thread Akshay Joshi

Hi

Please find the attached patch to fix RM #2232 Add the ability to
gray-out/disable the "Save Password" option when creating a connection to a
server.

Please review it.


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_2232.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

2017-03-31 Thread Khushboo Vashi

Hi,

Please find the attached patch to fix RM #2291: Error highlighting broken.

Murtuza / Akshay,

Can you please review the patch?

Thanks,
Khushboo
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index f08b02e..0444377 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -481,8 +481,10 @@ def poll(trans_id):
 # Check the transaction and connection status
 status, error_msg, conn, trans_obj, session_obj = check_transaction_status(trans_id)
 if status and conn is not None and session_obj is not None:
-status, result = conn.poll()
-if status == ASYNC_OK:
+status, result = conn.poll(formatted_exception_msg=True)
+if not status:
+return internal_server_error(result)
+elif status == ASYNC_OK:
 status = 'Success'
 rows_affected = conn.rows_affected()
 
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index eed0e09..1bda067 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1843,6 +1843,8 @@ define(
 msg = e.responseJSON.errormsg;
 
   self.update_msg_history(false, msg);
+  // Highlight the error in the sql panel
+  self._highlight_error(msg);
 }
   });
   }, self.POLL_FALLBACK_TIME());

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2304, #2145 - Resolve the issue for restoring

2017-03-31 Thread Ashesh Vashi

Fixes #2304, #2145 - Resolve the issue for restoring the table from the backup.

Earlier - implementation was generating the backup code like as below:
XXX/pg_restore.exe --host "x.x.x.x" --port "" --username "osboxes" 
--no-password --dbname "test" --data-only --verbose --table "tt.test2" 
"XXX-FILE.bak"

It should have been:
XXX/pg_restore.exe --host "x.x.x.x" --port "" --username "osboxes" 
--no-password --dbname "test" --data-only --verbose --schema "tt" --table 
"test2" "XXX-FILE.bak"

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8005b0529227ca8fbbb1252475c5a4ec9fcc5330
Author: Maxim Zakharov 

Modified Files
--
web/pgadmin/tools/restore/__init__.py   | 10 +-
.../tools/restore/templates/restore/js/restore.js   | 17 +++--
2 files changed, 16 insertions(+), 11 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Ashesh Vashi

Hi Joao & Sarah,

I have asked Murtuza to review the patch today.
He will update me by EOD.

If all goes well, I will commit the patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Dave and Ashesh,
>
> Do you still need us to provide more information about this patch or is it
> ready to be merged?
>
> Thanks
> Joao
>
> On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Hackers,
>>
>> We found out a issue using Python 3 related to importing modules that we
>> corrected in the patch that is now attached.
>>
>> Also we would like to know the status of this.
>>
>> Thanks
>> Joao & Sarah
>>
>> On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear 
>> wrote:
>>
>>> Hi!
>>>
>>> We realized that this change was causing the tests to fail because the
>>> folder for the sqlite databases was not being created. We also updated the
>>> files to contain the missing headers.
>>>
>>> Thanks!
>>> Joao & Sarah
>>>
>>>
>>>
>>> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page  wrote:
>>>
 Ashesh, can you review/commit this please? One thing I notice on a
 quick look through is that the file headers are missing everywhere.
 They should be present in all source files, except where they would
 bloat the data transfer from client to server.

 On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear 
 wrote:
 > Hi Hackers!
 >
 > It looks like our previous patch messed up some logging. Please use
 this one
 > instead.
 >
 > Thanks,
 > Joao & Sarah
 >
 >
 >
 > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear 
 wrote:
 >>
 >> Hi Hackers!
 >>
 >> Here's a patch to move to current db migration system to use Alembic.
 >> Instructions to create new migrations are in the README.
 >>
 >> Thanks!
 >> Joao & Sarah
 >>
 >
 >
 >
 > --
 > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
 )
 > To make changes to your subscription:
 > http://www.postgresql.org/mailpref/pgadmin-hackers
 >



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>

[pgadmin-hackers] pgAdmin 4 commit: Properly handle truncated table names (> NAMEDATALEN)

[pgadmin-hackers] pgAdmin 4 commit: Add the config option ALLOW_SAVE_PASSWORD to allow ad

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

[pgadmin-hackers] pgAdmin 4 commit: Generic function qtLiteral was not adapting values pr

[pgadmin-hackers] pgAdmin 4 commit: Remove debug code.

[pgadmin-hackers] pgAdmin 4 commit: Fix error highlighting in the query tool. Fixes #2291

Re: [pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

Re: [pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

[pgadmin-hackers] pgAdmin 4 commit: Add missing semi-colon.

[pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

[pgadmin-hackers] pgAdmin 4 commit: Add missing bracket

[pgadmin-hackers] pgAdmin 4 commit: Update CI script output for parsing with the Log Pars

[pgadmin-hackers] pgAdmin 4 commit: Include translation message catalogs in CI build/test

[pgadmin-hackers] pgAdmin 4 commit: Make sure each build/test starts in the correct direc

[pgadmin-hackers] pgAdmin 4 commit: Add message catalog builds to CI, and run all tests f

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Re: [pgadmin-hackers][patch] Move to Alembic migration system

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

[pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix dialog help in browser tab/window

[pgadmin-hackers] pgAdmin 4 commit: Dialog Help was broken in case where query tool/Debug

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

[pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2304, #2145 - Resolve the issue for restoring

Re: [pgadmin-hackers][patch] Move to Alembic migration system

31 matches

Site Navigation

Mail list logo

Footer information