Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree

2017-04-06 Thread Ashesh Vashi 
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hello,
>
> PFA patch to fix the issue in browser tree when adding new node if parent
> collection node is not loaded.
> *Fixes:* RM#2321
>
> Steps:
> 1) Open pgAdmin4.
> 2) Do not expand server-group node.
> 3) Right click on server-group collection node and add server, now click
> on save button
> (This issue is reproducible on any collection node which is not loaded)
> 4) You will see that only newly added node is displayed in browser tree
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2321 - [Browser Tree] Shows only the newly cre

2017-04-06 Thread Ashesh Vashi 
Fixes #2321 - [Browser Tree] Shows only the newly created node (not, all
other child node) of a parent node, when it has not been already loaded.

In order to resolve the issue - we will open the parent, and select the
created node, instead of adding it to parent node.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dba7d8303f709bc42007bc798a8673a120b10e3
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/templates/browser/js/browser.js | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Shirley Wang 
Ok! Right justified it is

On Thu, Apr 6, 2017 at 11:22 AM Anthony DeBarros 
wrote:

> Agreed on all the responses thus far. The ability to distinguish values
> ranging from thousands to tens of thousands to millions, etc., is
> substantially harder if numbers are left-justified.
>
> On Thu, Apr 6, 2017 at 10:41 AM, Robert Eckhardt 
> wrote:
>
> > 3. right-justified numbers come from precedents like excel or other
> > spreadsheet type tools and muddles the distinction between editable and
> > un-editable tables (at least data output in from query results is
> > un-editable, I know right clicking on a table in the browser to "view ...
> > data/rows" outputs an editable table)
>
> When we first released pgAdmin 4 we forgot to right-justify numbers.
> Users complained. Lots. They need to stay right justified.
>
>
> Right justifying makes it substantially easier to understand magnitude and
> makes it easier to get decimal alignment.
>
> -- Rob
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
>

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Anthony DeBarros 
Agreed on all the responses thus far. The ability to distinguish values
ranging from thousands to tens of thousands to millions, etc., is
substantially harder if numbers are left-justified.

On Thu, Apr 6, 2017 at 10:41 AM, Robert Eckhardt 
wrote:

> > 3. right-justified numbers come from precedents like excel or other
>> > spreadsheet type tools and muddles the distinction between editable and
>> > un-editable tables (at least data output in from query results is
>> > un-editable, I know right clicking on a table in the browser to "view
>> ...
>> > data/rows" outputs an editable table)
>>
>> When we first released pgAdmin 4 we forgot to right-justify numbers.
>> Users complained. Lots. They need to stay right justified.
>>
>
> Right justifying makes it substantially easier to understand magnitude and
> makes it easier to get decimal alignment.
>
> -- Rob
>
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

[pgadmin-hackers] pgAdmin 4 commit: Oops, syntax error.

2017-04-06 Thread Dave Page 
Oops, syntax error.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d55b8394cfd6c33d67f00395b16b0b3490bc873a

Modified Files
--
web/karma.conf.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Robert Eckhardt 
>
> > 3. right-justified numbers come from precedents like excel or other
> > spreadsheet type tools and muddles the distinction between editable and
> > un-editable tables (at least data output in from query results is
> > un-editable, I know right clicking on a table in the browser to "view ...
> > data/rows" outputs an editable table)
>
> When we first released pgAdmin 4 we forgot to right-justify numbers.
> Users complained. Lots. They need to stay right justified.
>

Right justifying makes it substantially easier to understand magnitude and
makes it easier to get decimal alignment.

-- Rob


>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

[pgadmin-hackers] pgAdmin 4 commit: Swap entries in karma.conf so test-main.js is matched

2017-04-06 Thread Dave Page 
Swap entries in karma.conf so test-main.js is matched first, per suggestion 
from Atira to fix the failing Jasmine tests.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcc122f29015983cca0f29ae074ec4951be8006b

Modified Files
--
web/karma.conf.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table

2017-04-06 Thread Dave Page 
On Thu, Apr 6, 2017 at 3:27 PM, Shirley Wang  wrote:
> Thanks, all!
>
>>
>> On Wed, Apr 5, 2017 at 4:55 PM, Anthony DeBarros 
>> wrote:
>>>
>>> I like the changes overall. Feels polished.
>>>
>>> For mockup purposes, remember that pgAdmin 4 behavior right-justifies
>>> integers, numerics, etc., for readability.
>>>
>
> Anthony, I left-justified integers in the table for three reasons:
> 1. it aligns better with the table headers
> 2. it provides more consistent spacing between results making it easier to
> read
> 3. right-justified numbers come from precedents like excel or other
> spreadsheet type tools and muddles the distinction between editable and
> un-editable tables (at least data output in from query results is
> un-editable, I know right clicking on a table in the browser to "view ...
> data/rows" outputs an editable table)

When we first released pgAdmin 4 we forgot to right-justify numbers.
Users complained. Lots. They need to stay right justified.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-06 Thread Dave Page 
On Thu, Apr 6, 2017 at 3:05 PM, Murtuza Zabuawala
 wrote:
>
>
> On Thu, Apr 6, 2017 at 1:40 PM, Dave Page  wrote:
>>
>> On Thu, Apr 6, 2017 at 2:27 AM, Jonas Thelemann
>>  wrote:
>> > Thanks for committing! :)
>> >
>> >>> i18n-trim.diff
>> >>>
>> >>> Removed two linebreaks to improve translation experience.
>> >>
>> >> Hmm, I've applied that, but expect an ongoing battle between gettext
>> >> and
>> >> PEP8...
>> >>
>> > Ok, I had to look up what PEP8 is :D
>> > So the only problem was that, with those newlines I removed, the
>> > translatable strings contained many extremely useless whitespaces
>> > inserted
>> > by the code indentation. I guess a workaround could be to just remove
>> > the
>> > spaces like I've seen somewhere else already:
>> >
>> > --
>> > --"""abc \n
>> > def"""
>> > --
>> >
>> > instead of:
>> >
>> > --
>> > --"""abc def"""
>> > --
>> >
>> > and:
>> >
>> > --
>> > --"""abc \n
>> > --def"""
>> > --
>> >
>> > ... where dashes represent whitespaces.
>> > But that is just an idea and something somebody with better Python
>> > knowledge
>> > should decide :)
>>
>> Hmm, yeah. So we really need the messages to be a single string, as
>> the splits may not make sense in other languages, so this won't work:
>>
> This will return single string only, python won't add any extra whitespace
> or new line with this format.

Which one?

>>
>> >>> print("Hello " \
>> ...   "How are you")
>>
>> This will result in extra whitespace:
>>
>> >>> print("Hello \
>> ...How are you")
>>
>> Whilst this will result in an extra line break:
>>
>> >>> print("""Hello
>> ... How are you""")
>>
>> I'm beginning to think we have no choice but to ignore PEP8 and not
>> allow strings to wrap except where we want them to. I can't find
>> anything on Google about other alternatives - EDB guys, any
>> suggestions?
>>
>> >> Can you provide patches for the changes above?
>> >
>> > Yes, I can do that, but not right away. I currently have some other
>> > things
>> > to complete in the next few weeks, but I'll try to fit that in.
>>
>> Cool, thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-06 Thread Murtuza Zabuawala 
On Thu, Apr 6, 2017 at 1:40 PM, Dave Page  wrote:

> On Thu, Apr 6, 2017 at 2:27 AM, Jonas Thelemann
>  wrote:
> > Thanks for committing! :)
> >
> >>> i18n-trim.diff
> >>>
> >>> Removed two linebreaks to improve translation experience.
> >>
> >> Hmm, I've applied that, but expect an ongoing battle between gettext and
> >> PEP8...
> >>
> > Ok, I had to look up what PEP8 is :D
> > So the only problem was that, with those newlines I removed, the
> > translatable strings contained many extremely useless whitespaces
> inserted
> > by the code indentation. I guess a workaround could be to just remove the
> > spaces like I've seen somewhere else already:
> >
> > --
> > --"""abc \n
> > def"""
> > --
> >
> > instead of:
> >
> > --
> > --"""abc def"""
> > --
> >
> > and:
> >
> > --
> > --"""abc \n
> > --def"""
> > --
> >
> > ... where dashes represent whitespaces.
> > But that is just an idea and something somebody with better Python
> knowledge
> > should decide :)
>
> Hmm, yeah. So we really need the messages to be a single string, as
> the splits may not make sense in other languages, so this won't work:
>
> This will return single string only, python won't add any extra whitespace
or new line with this format.

> >>> print("Hello " \
> ...   "How are you")
>
> This will result in extra whitespace:
>
> >>> print("Hello \
> ...How are you")
>
> Whilst this will result in an extra line break:
>
> >>> print("""Hello
> ... How are you""")
>
> I'm beginning to think we have no choice but to ignore PEP8 and not
> allow strings to wrap except where we want them to. I can't find
> anything on Google about other alternatives - EDB guys, any
> suggestions?
>
> >> Can you provide patches for the changes above?
> >
> > Yes, I can do that, but not right away. I currently have some other
> things
> > to complete in the next few weeks, but I'll try to fit that in.
>
> Cool, thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] Jasmine tests failing on CI

2017-04-06 Thread Dave Page 
Hi Tira,

The Jasmine tests have started failing on jenkins.pgadmin.org. They
still pass on my laptop, and were working fine prior to today. I've
not changed anything in the code that I would expect to break
anything:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0
(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for
fsevents@1.1.1: wanted {"os":"darwin","arch":"any"} (current:
{"os":"linux","arch":"x64"})
npm WARN web No description
npm WARN web No repository field.
npm WARN web No license field.
 [33m06 04 2017 09:08:54.653:WARN [watcher]:  [39mAll files matched by
"/var/lib/jenkins/workspace/pgadmin4-master-python34/web/regression/javascript/test-main.js"
were excluded or matched by prior matchers.
 [32m06 04 2017 09:08:54.754:INFO [karma]:  [39mKarma v1.6.0 server
started at http://0.0.0.0:9876/
 [32m06 04 2017 09:08:54.755:INFO [launcher]:  [39mLaunching browser
PhantomJS with unlimited concurrency
 [32m06 04 2017 09:08:54.762:INFO [launcher]:  [39mStarting browser PhantomJS
 [32m06 04 2017 09:08:55.017:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]:
 [39mConnected on socket EoHSMp65Ic2FQa5Z with id 23708146
 [33m06 04 2017 09:09:05.017:WARN [PhantomJS 2.1.1 (Linux 0.0.0)]:
 [39mDisconnected (1 times), because no message in 1 ms.
PhantomJS 2.1.1 (Linux 0.0.0) ERROR
  Disconnected, because no message in 1 ms.

[https://jenkins.pgadmin.org/job/pgadmin4-master-python33/lastFailedBuild/console]

Googling is showing numerous other people with the same problem
(including that it only fails on some machines such as CI servers), in
some cases able to fix it with random tweaks to timeout and retry
settings.

Do you have any idea what's really going on? I'm loathe to start
randomly tweaking settings without understanding the real issue.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix validation on the table dialogue so the Save butt

2017-04-06 Thread Dave Page 
Fix validation on the table dialogue so the Save button isn't enabled if the 
name is removed and autovac custom settings are enabled. Fixes #2105

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3880bc7eb829e786d50d115e95acb2b2d77d20e8
Author: RAJASEKAR G 

Modified Files
--
.../servers/databases/schemas/tables/templates/table/js/table.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Properly handle EXPLAIN queries entered directly by t

2017-04-06 Thread Dave Page 
Properly handle EXPLAIN queries entered directly by the user in the query tool. 
Fixes #2287

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c758920890309e50f47a9427039cf735ddf04d37
Author: RAJASEKAR G 

Modified Files
--
web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update the Polish translation

2017-04-06 Thread Dave Page 
Update the Polish translation

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ac5bf4f1204db9a14b96af41400b61e2c500158
Author: Begina Felicysym 

Modified Files
--
.../translations/pl/LC_MESSAGES/messages.mo| Bin 101293 -> 112948 bytes
.../translations/pl/LC_MESSAGES/messages.po| 249 +++--
2 files changed, 85 insertions(+), 164 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Update translations - polish translation

2017-04-06 Thread Dave Page 
Thanks, committed.

On Wed, Apr 5, 2017 at 6:17 PM, Begina Felicysym  wrote:
> Hi,
>
> I just fixed the polish translation
>
>
>
> Cheers
>
> Begina
>
>
>
> Dnia Środa, 5 Kwietnia 2017 15:03 Dave Page  napisał(a)
>
> Update translations
>
>
>
> Branch
>
> --
>
> master
>
>
>
> Details
>
> ---
>
> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d9cfa667986070d5694b5ce0f089b527b0e04a2
>
>
>
> Modified Files
>
> --
>
> web/pgadmin/messages.pot   | 440 
>
> .../translations/pl/LC_MESSAGES/messages.mo| Bin 112251 -> 101293
> bytes
>
> .../translations/pl/LC_MESSAGES/messages.po| 569
> -
>
> .../translations/zh/LC_MESSAGES/messages.mo| Bin 96165 -> 86541
> bytes
>
> .../translations/zh/LC_MESSAGES/messages.po| 563
> +++-
>
> 5 files changed, 844 insertions(+), 728 deletions(-)
>
>
>
>
>
> --
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>
> To make changes to your subscription:
>
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
>
>
>
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Use a more appropriate output file name.

2017-04-06 Thread Dave Page 
Use a more appropriate output file name.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a412e3226ff7c51760c16fab3ccf55780d17696b

Modified Files
--
web/regression/runtests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Write a JSON file when regression tests run, listing

2017-04-06 Thread Dave Page 
Write a JSON file when regression tests run, listing results.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd23f714780878f19726ead2c03b98115a08
Author: Navnath Gadakh 

Modified Files
--
.../connect_to_server_feature_test.py  |  5 ++
.../feature_tests/table_ddl_feature_test.py|  6 ++
web/regression/.gitignore  |  1 +
web/regression/python_test_utils/test_utils.py | 73 +++-
web/regression/runtests.py | 97 --
5 files changed, 138 insertions(+), 44 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] i18n GER, suggestions, questions

2017-04-06 Thread Dave Page 
On Thu, Apr 6, 2017 at 2:27 AM, Jonas Thelemann
 wrote:
> Thanks for committing! :)
>
>>> i18n-trim.diff
>>>
>>> Removed two linebreaks to improve translation experience.
>>
>> Hmm, I've applied that, but expect an ongoing battle between gettext and
>> PEP8...
>>
> Ok, I had to look up what PEP8 is :D
> So the only problem was that, with those newlines I removed, the
> translatable strings contained many extremely useless whitespaces inserted
> by the code indentation. I guess a workaround could be to just remove the
> spaces like I've seen somewhere else already:
>
> --
> --"""abc \n
> def"""
> --
>
> instead of:
>
> --
> --"""abc def"""
> --
>
> and:
>
> --
> --"""abc \n
> --def"""
> --
>
> ... where dashes represent whitespaces.
> But that is just an idea and something somebody with better Python knowledge
> should decide :)

Hmm, yeah. So we really need the messages to be a single string, as
the splits may not make sense in other languages, so this won't work:

>>> print("Hello " \
...   "How are you")

This will result in extra whitespace:

>>> print("Hello \
...How are you")

Whilst this will result in an extra line break:

>>> print("""Hello
... How are you""")

I'm beginning to think we have no choice but to ignore PEP8 and not
allow strings to wrap except where we want them to. I can't find
anything on Google about other alternatives - EDB guys, any
suggestions?

>> Can you provide patches for the changes above?
>
> Yes, I can do that, but not right away. I currently have some other things
> to complete in the next few weeks, but I'll try to fit that in.

Cool, thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers