Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

[Akshay Joshi]

Thanks patch applied.

On Mon, Apr 24, 2017 at 4:40 PM, Dave Page  wrote:

> Akshay, can you review/commit this please?
>
> On Fri, Apr 21, 2017 at 6:35 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please test the patch with query provided by user,
>>
>> SELECT ARRAY[48994717597666517,48968053424532376,76561198004879311,
>> 76561198078757065,76561198086825618]::text as good,
>> ARRAY[48994717597666520,48968053424532376,76561198004879311,
>> 76561198078757065,76561198086825618] as bad
>>
>> I was doing regression with some large arbitrary numbers due to which it
>> was converting it to numeric[] and numeric[] is already handled in our
>> code.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Apr 20, 2017 at 7:18 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> That is strange.
>>>
>>> I tested on PG9.6 and it was working properly, What is the your PG
>>> version?
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Thu, Apr 20, 2017 at 7:06 PM, Dave Page  wrote:
>>>


 On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>>
>> PFA minor patch to fix the the issue with bigint[] array values as JS
>> truncates long numbers from array object.
>> RM#2272
>>
>
 Hi

 As far as I can see, this doesn't work as expected. The "bad" column is
 interpreted as numeric[] on my machine, which I assume needs to be added to
 the list as well?

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fix handling of bigint[] type. Fixes #2272

[Akshay Joshi]

Fix handling of bigint[] type. Fixes #2272

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38c8a4fb607373358b49bfe656d2c0290c05020c
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

[Akshay Joshi]

Thanks patch applied.

On Mon, Apr 24, 2017 at 4:40 PM, Dave Page  wrote:

> Akshay, can you review/commit this please?
>
> On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the patch to fix the issue while using ANALYZE option in IE.
>>
>> *Issue:*
>> We were using .startsWith() function to check the sql if it is already
>> starts with explain clause or not, which was added in commit:
>> c758920890309e50f47a9427039cf735ddf04d37
>>
>> But IE do not support .startsWith() function.
>>
>>
>>
>>- Desktop
>>- Mobile
>>
>> FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
>> Basic support 41 17
>>  (17) (Yes)
>> No support 28 9
>>
>>
>> But IE do not support .startsWith() function.
>>
>> I have also changed the code for File Manager module as well for the same
>> issue.
>>
>> So affected modules are,
>> - Query tool
>> - File Manager
>>
>> Please review.
>> RM#2347
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: startsWith() function of java script is not supported

[Akshay Joshi]

startsWith() function of java script is not supported in IE, instead use 
startsWith() function of underscore string. Fixes #2347

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=928c0d3de8eac88d0ef8f6272951d12dbfe636f7
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js | 7 ---
web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js| 4 +++-
2 files changed, 7 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue where we were not correctly providing default
parameters to respective argument(s).
RM#2350

Affected node,
1) Functions
2) Trigger Function
3) Procedures (EPAS)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
index 2d2b6fb..970f51c 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
@@ -479,6 +479,22 @@ class FunctionView(PGChildNodeView, DataTypeReader):
 'i': 'IN', 'o': 'OUT', 'b': 'INOUT', 'v': 'VARIADIC', 't': 'TABLE'
 }
 
+# We need to put default parameter at proper location in list
+# Total number of default parameters
+default_values_size = len(proargdefaultvals)
+
+# Total number of parameters
+total_parameters_size = len(proargtypes)
+
+# Parameters which do not have default parameters
+par_without_default = total_parameters_size - default_values_size
+
+# only if we have at least one parameter with default value
+if default_values_size > 0 and par_without_default > 0:
+for idx in range(par_without_default):
+# Set null value for parameter non-default parameter
+proargdefaultvals.insert(idx, '')
+
 # The proargtypes doesn't give OUT params, so we need to fetch
 # those from database explicitly, below code is written for this
 # purpose.

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [patch] Query Output Header Width

[Dave Page]

Thanks - patch applied!

On Mon, Apr 24, 2017 at 2:43 PM, Sarah McAlear  wrote:

> Oh, good catch! Here's a new patch with all the lines in place.
>
> Thanks,
> Joao & Sarah
>
> On Thu, Apr 20, 2017 at 12:05 PM, Dave Page  wrote:
>
>>
>>
>> On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili <
>> ggelashv...@pivotal.io> wrote:
>>
>>> Hello Hackers,
>>>
>>> We found that having the column header extend all the way across the
>>> query output frame made it seem like there were more columns. This was
>>> confusing to some users.
>>>
>>> We made a change to the column header styling so it ends with the
>>> rightmost column.
>>>
>>> Happy Friday!
>>> Matt & Shirley & George
>>>
>>
>> Hi Matt & Shirley & George!
>>
>> I agree with the basic premise of this patch, however it has the
>> side-effect of removing the bottom border from the entire header row, which
>> makes the transition from the header ro to the first data row look very odd
>> (especially in the first row header, which essentially merges into the
>> top-left "select all" cell). Screenshot attached.
>>
>> Can you get the line back in place, but so it only shows up under the
>> actual header cells?
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Only display the header row in SlickGrid where column

[Dave Page]

Only display the header row in SlickGrid where columns actually exist.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f718e1f49c95460b828c397ce36c1e2ea37a0031
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
web/pgadmin/tools/sqleditor/static/css/sqleditor.css | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [patch] Query Output Header Width

[Sarah McAlear]

Oh, good catch! Here's a new patch with all the lines in place.

Thanks,
Joao & Sarah

On Thu, Apr 20, 2017 at 12:05 PM, Dave Page  wrote:

>
>
> On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili <
> ggelashv...@pivotal.io> wrote:
>
>> Hello Hackers,
>>
>> We found that having the column header extend all the way across the
>> query output frame made it seem like there were more columns. This was
>> confusing to some users.
>>
>> We made a change to the column header styling so it ends with the
>> rightmost column.
>>
>> Happy Friday!
>> Matt & Shirley & George
>>
>
> Hi Matt & Shirley & George!
>
> I agree with the basic premise of this patch, however it has the
> side-effect of removing the bottom border from the entire header row, which
> makes the transition from the header ro to the first data row look very odd
> (especially in the first row header, which essentially merges into the
> top-left "select all" cell). Screenshot attached.
>
> Can you get the line back in place, but so it only shows up under the
> actual header cells?
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


0001-Make-output-header-align-right.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

[Sarah McAlear]

Awesome, thank you for adding that back in!

On Sun, Apr 23, 2017 at 11:17 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Hackers,
>>
>> We review the patch, just noticed a spelling issue so we regenerated the
>> patch.
>>
> Thanks.
> Your patch was missing README changes. :-)
>
> Committed after adding the necessary changes.
>
> -- Thanks,
> Ashesh Vashi
>
>
>>
>> Thanks
>> Joao & Oliver
>>
>> On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Joao & Oliver,
>>>
>>> On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hello Hackers,

 @Ashesh thanks for the feedback

 Here is the reviewed patch with the suggestions of Ashesh.

 Disclaimer: We added a new patch file with the changes

>>>
>>> I have made some more changes to the patch.
>>> - 'with app.app_context(..)' statement was not required in the
>>> 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade
>>> function.
>>> - We also need to create other directories (i.e. sessions, storage,
>>> directory containing the log-file) during the setup/running the application
>>> (if not exists).
>>> - Added proper check in the pgAdmin4.wsgi file (if configuration file
>>> exists, or not)
>>>
>>> Please review it.
>>>
>>> -- Thanks, Ashesh
>>>
>>>
>>
>

Re: [GENERAL] [pgadmin-hackers] file permission on ssl key

[Adrian Klaver]

On 04/23/2017 07:42 PM, Ashesh Vashi wrote:

Hi Jeroen,

This is pgAdmin hackers list.
Please send mail to pgsql-gene...@postgresql.org
 mailing list for your postgresql
related queries.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



/http://www.linkedin.com/in/asheshvashi/


On Sun, Apr 23, 2017 at 11:25 PM, Jeroen Jacobs
mailto:jeroen.jac...@headincloud.be>> wrote:

Hi,

I'm getting this error when I try to configure ssl with postgres:


What version of Postgres?

https://www.postgresql.org/docs/9.6/static/release-9-6.html

"Allow the server's SSL key file to have group read access if it is 
owned by root (Christoph Berg)


Formerly, we insisted the key file be owned by the user running the 
PostgreSQL server, but that is inconvenient on some systems (such as 
Debian) that are configured to manage certificates centrally. Therefore, 
allow the case where the key file is owned by root and has group read 
access. It is up to the operating system administrator to ensure that 
the group does not include any untrusted users.

"



pr 23 13:12:47 pgmaster01 pg_ctl: FATAL:  private key file
"/etc/ssl/pgmaster01-key.pem" has group or world access
Apr 23 13:12:47 pgmaster01 pg_ctl: DETAIL:  Permissions should be
u=rw (0600) or less.

The actual permission is:

centos@pgmaster01 ~]$ ls -l /etc/ssl/pgmaster01-key.pem
-r--r- 1 root ssl-read 3243 Apr 23 00:00 /etc/ssl/pgmaster01-key.pem

postgres user is part of the ssl-read group. Thi ssl key is shared
with other software as well, so giving exclusive access to the
postgres user is NOT an option.

I understand why postgres complains, but I'm pretty sure about what
I'm doing here. How can I tell postgres to start anyway, even when
it doesn't like those permissions? There should be a way to override
this, I'm the admin here, it's up to me to decide to implement my
security setup, not the software itself.

So basically I have three options:

- don't use ssl at all (not an option at all, actually)
- create a separate copy of my ssl key file with the correct
permissions that postgres likes (ugly workaround)
- use another database server which allows me to configure it how I
want it.

I'm actually considering settling for the last solution, due to this
crazy restriction you put in place...


Regards,

Jeroen.





--
Adrian Klaver
adrian.kla...@aklaver.com


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility

[Dave Page]

Thanks - looks good, so committed.

On Fri, Apr 21, 2017 at 1:02 PM, Akshay Joshi  wrote:

> Hi All
>
> Please find the patch to support PostgreSQL 10 compatibility, though it
> was not completed as SCRAM authentication support is still remaining to
> change the password.
>
> Patch contains following:
>
>- Changed the function name as it was change in v10.
>- Changed the SQL to get the sequence information.
>- Change the logic of Check Recovery test case as it was running for
>each version instead of specified database version.
>- Remove some unused __init__.py file.
>- Handle background error for dashboard when the selected server is
>deleted.
>
> Please review it.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214 (missed some f

[Dave Page]

Initial support for PG 10.0, per #2214 (missed some files)

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a449be784e8fa6ee719aa97bcb8b5e514fc7150e
Author: Akshay Joshi 

Modified Files
--
.../templates/sequence/sql/10.0_plus/get_def.sql   | 11 ++
.../connect/sql/10.0_plus/check_recovery.sql   |  9 +
.../servers/tests/test_check_recovery.py   | 46 ++
3 files changed, 66 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Initial support for PG 10.0, per #2214

[Dave Page]

Initial support for PG 10.0, per #2214

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59834fba310722b0c45bdcb3bfc9eb0a8ac4d9aa
Author: Akshay Joshi 

Modified Files
--
.../templates/sequence/sql/default/update.sql  | 10 +++---
.../server_groups/servers/templates/__init__.py|  0
.../servers/templates/connect/__init__.py  |  0
.../servers/templates/connect/sql/__init__.py  |  0
.../templates/connect/sql/tests/__init__.py|  0
.../connect/sql/tests/test_check_recovery.py   | 37 --
web/pgadmin/dashboard/__init__.py  | 16 ++
web/pgadmin/utils/versioned_template_loader.py |  1 +
8 files changed, 22 insertions(+), 42 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

[Dave Page]

Thanks - applied. I'll keep an eye on Jenkins :-)

On Fri, Apr 21, 2017 at 7:58 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> We recreated the patch and should work now.
>
> The problem looks like an issue with pip. I just opened an issue in their
> github .
>
> Thanks
> Joao & Oliver
>
> On Fri, Apr 21, 2017 at 5:20 AM, Dave Page  wrote:
>
>> Hi,
>>
>> Unfortunately I've had to revert this as the Jenkins CI builds started
>> failing on all branches. It appears that the --install-option for
>> chromerdriver_installer is also passed to pyperclip, which then barfs on it:
>>
>> /var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/lib/python2.7/site-packages/pip/req/req_file.py:150:
>>  UserWarning: Disabling all use of wheels due to the use of --build-options 
>> / --global-options / --install-options.
>>   cmdoptions.check_install_build_global(options, opts)
>> Collecting chromedriver_installer==0.0.6 (from -r 
>> web/regression/requirements.txt (line 1))
>>   Using cached chromedriver_installer-0.0.6.tar.gz
>> Collecting pyperclip~=1.5.27 (from -r web/regression/requirements.txt (line 
>> 2))
>>   Using cached pyperclip-1.5.27.zip
>> Collecting selenium==3.3.1 (from -r web/regression/requirements.txt (line 3))
>>   Using cached selenium-3.3.1.tar.gz
>> Collecting testscenarios==0.5.0 (from -r web/regression/requirements.txt 
>> (line 4))
>>   Using cached testscenarios-0.5.0.tar.gz
>> Collecting testtools==2.0.0 (from -r web/regression/requirements.txt (line 
>> 5))
>>   Using cached testtools-2.0.0.tar.gz
>> Requirement already satisfied: traceback2==1.4.0 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from -r 
>> web/regression/requirements.txt (line 6))
>> Requirement already satisfied: unittest2==1.1.0 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from -r 
>> web/regression/requirements.txt (line 7))
>> Requirement already satisfied: pbr>=0.11 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from testscenarios==0.5.0->-r 
>> web/regression/requirements.txt (line 4))
>> Requirement already satisfied: extras in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r 
>> web/regression/requirements.txt (line 5))
>> Requirement already satisfied: fixtures>=1.3.0 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r 
>> web/regression/requirements.txt (line 5))
>> Requirement already satisfied: pyrsistent in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r 
>> web/regression/requirements.txt (line 5))
>> Requirement already satisfied: python-mimeparse in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from testtools==2.0.0->-r 
>> web/regression/requirements.txt (line 5))
>> Requirement already satisfied: linecache2 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from traceback2==1.4.0->-r 
>> web/regression/requirements.txt (line 6))
>> Requirement already satisfied: argparse in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from unittest2==1.1.0->-r 
>> web/regression/requirements.txt (line 7))
>> Requirement already satisfied: six>=1.4 in 
>> ./pgadmin-venv/lib/python2.7/site-packages (from unittest2==1.1.0->-r 
>> web/regression/requirements.txt (line 7))
>> Skipping bdist_wheel for chromedriver-installer, due to binaries being 
>> disabled for it.
>> Skipping bdist_wheel for pyperclip, due to binaries being disabled for it.
>> Skipping bdist_wheel for selenium, due to binaries being disabled for it.
>> Skipping bdist_wheel for testscenarios, due to binaries being disabled for 
>> it.
>> Skipping bdist_wheel for testtools, due to binaries being disabled for it.
>> Installing collected packages: chromedriver-installer, pyperclip, selenium, 
>> testtools, testscenarios
>>   Running setup.py install for chromedriver-installer: started
>> Running setup.py install for chromedriver-installer: finished with 
>> status 'done'
>>   Running setup.py install for pyperclip: started
>> Running setup.py install for pyperclip: finished with status 'error'
>> Complete output from command 
>> /var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/bin/python 
>> -u -c "import setuptools, 
>> tokenize;__file__='/tmp/pip-build-YzPhsw/pyperclip/setup.py';f=getattr(tokenize,
>>  'open', open)(__file__);code=f.read().replace('\r\n', 
>> '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record 
>> /tmp/pip-Sy2sJJ-record/install-record.txt 
>> --single-version-externally-managed --compile --install-headers 
>> /var/lib/jenkins/workspace/pgadmin4-master-python27/pgadmin-venv/include/site/python2.7/pyperclip
>>  --chromedriver-version=2.29:
>> usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
>>or: -c --help [cmd1 cmd2 ...]
>>or: -c --help-commands
>>or: -c cmd --help
>>
>> error: option --chromedriver-version not recognized
>>
>>
>>
>> On Fri, Apr 21, 2017 at 9:54 AM, Dav

[pgadmin-hackers] pgAdmin 4 commit: Update test requirements for the latest rev of Chrome

[Dave Page]

Update test requirements for the latest rev of Chrome.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3eb92f7ea3abf3c6cb21d6f1dc391a300095026c
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
web/regression/requirements.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

[Dave Page]

Ashesh, can you review/commit this please? Thanks.

On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where node rename is not working properly
> after 7dd9efd8
> 
>  commit
> .
> RM#2355
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

[Dave Page]

Ashesh, can you review/commit this please?

On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> We found out that when you are connected to a GreenPlum database and try
> to get Dependents and Dependencies of an object the application was
> returning a SQL error.
>
> This patch splits the SQL query used to retrieve the Dependents,
> Dependencies, and Roles SQL file into multiple versioned files.
> Add Unit Tests for each file.
> Also added __init__.py files to other test directories to run the tests in
> them.
> Add ORDER BY into Copy Selection Feature test to ensure the results are
> retrieved always in the same order
> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it
> for versions less than 9.1
>
> Thanks
>
> Joao & Sarah
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

[Dave Page]

Akshay, can you review/commit this please?

On Fri, Apr 21, 2017 at 6:35 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please test the patch with query provided by user,
>
> SELECT ARRAY[48994717597666517,48968053424532376,76561198004879311,
> 76561198078757065,76561198086825618]::text as good,
> ARRAY[48994717597666520,48968053424532376,76561198004879311,
> 76561198078757065,76561198086825618] as bad
>
> I was doing regression with some large arbitrary numbers due to which it
> was converting it to numeric[] and numeric[] is already handled in our
> code.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Apr 20, 2017 at 7:18 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> That is strange.
>>
>> I tested on PG9.6 and it was working properly, What is the your PG
>> version?
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Apr 20, 2017 at 7:06 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,
>
> PFA minor patch to fix the the issue with bigint[] array values as JS
> truncates long numbers from array object.
> RM#2272
>

>>> Hi
>>>
>>> As far as I can see, this doesn't work as expected. The "bad" column is
>>> interpreted as numeric[] on my machine, which I assume needs to be added to
>>> the list as well?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

[Dave Page]

Akshay, can you review/commit this please?

On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Please find the patch to fix the issue while using ANALYZE option in IE.
>
> *Issue:*
> We were using .startsWith() function to check the sql if it is already
> starts with explain clause or not, which was added in commit:
> c758920890309e50f47a9427039cf735ddf04d37
>
> But IE do not support .startsWith() function.
>
>
>
>- Desktop
>- Mobile
>
> FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
> Basic support 41 17
>  (17) (Yes)
> No support 28 9
>
>
> But IE do not support .startsWith() function.
>
> I have also changed the code for File Manager module as well for the same
> issue.
>
> So affected modules are,
> - Query tool
> - File Manager
>
> Please review.
> RM#2347
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Table column edit breaks when using column level permissions

[Dave Page]

Akshay, can you review/commit this please?

On Fri, Apr 14, 2017 at 12:09 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue in table node where it breaks column edit when
> user provides column level permissions.
> RM#2335
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Added dependency on Flask-Migrate added by previous c

[Ashesh Vashi]

Added dependency on Flask-Migrate added by previous commit:
6283ef7f5e4379d5e2202ca2919b9ea76caf57c7

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=139a10e8f9b483ede6e6578f451119bd698e1bca

Modified Files
--
requirements.txt | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] QT dependances of the web version?

[Dave Page]

On Fri, Apr 21, 2017 at 11:41 PM, Josh Berkus  wrote:

> Dave, all:
>
> Does the web version of pgadmin4 rely on QT somehow?
>
> The reason I ask is that, when you install pgadmin4 on a server,
> installing the required QT modules drags in all of Xorg/Wayland, which
> is around 250MB of packages which aren't needed or wanted on a server.
>
> If not, I'll look for a way to build pgadmin without having the QT modules.
>

The web package shouldn't have any dependencies on anything related to
Qt/Xorg. iirc, it should only depend on Python stuff, and libpq.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Install of pgadmin4 from package fails ...

[Dave Page]

On Fri, Apr 21, 2017 at 10:40 PM, Josh Berkus  wrote:

> On 04/21/2017 02:14 PM, Josh Berkus wrote:
> > On 04/21/2017 01:57 AM, Devrim Gündüz wrote:
> >> On RHEL 7 / Fedora 25:
> >>
> >> * systemctl enable pgadmin4-v1.service; systemctl start
> pgadmin4-v1.service
> >> * cp /etc/httpd/conf.d/pgadmin4-v1.conf.sample
> /etc/httpd/conf.d/pgadmin4-
> >> v1.conf
> >> * systemctl start httpd.service
> >>
> >> should be enough, at least this is what I just tested on my Fedora 25
> box.
> >
> > So I just tried this, and it doesn't do any of the setup.
> >
> > There's no config_local, and as far as I can tell the database isn't
> > created.  It's hard to know for sure, though, because without a
> > config_local I'm not sure where it would be located.
> >
> > Error: [Fri Apr 21 21:02:32.080337 2017] [wsgi:error] [pid 26] [remote
> > 76.115.138.49:35628] FileNotFoundError: [Errno 2] No such file or
> > directory: '/usr/share/httpd/.pgadmin/pgadmin4.log'
> >
> > ... certainly there is no /usr/share/httpd/.pgadmin directory
> >
>
> Aha, here's the problem.  Setup is getting run as root, not as the user
> httpd.  This means it's dropping .pgadmin into /root/, which the web
> server can't access; it's "home" directory is /usr/share/httpd.
> However, that directory isn't writable by the apache user, either.
>
> There isn't an easy fix for this; on a default Fedora or CentOS system,
> the only directory the apache user has read/write to is /tmp, as far as
> I know.
>
> Ideas?


This is covered in the docs:
https://www.pgadmin.org/docs4/1.x/server_deployment.html

Create a directory, setup the config to use it as required, then chown the
database after running setup (which is probably easier than trying to run
it as the apache user directly).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

[Dave Page]

On Fri, Apr 21, 2017 at 6:45 PM, Josh Berkus  wrote:

> Devrim,
>
> > * cp /etc/httpd/conf.d/pgadmin4-v1.conf.sample
> /etc/httpd/conf.d/pgadmin4-
> > v1.conf
>
> One more question: the sample .conf doesn't have the
> threads-and-1-process configuration recommended in the pgadmin docs.  Is
> there a reason it doesn't need it?


That's definitely required, otherwise you will end up with multiple DB
connection managers and have no way for client sessions to maintain
affinity with the right one.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company