date:20170509

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-05-09 Thread Harshal Dhumal

Hi,

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear  wrote:

> Hi Harshal!
>
> We applied your patch and ran the Javascript tests and realized there are
> 6 tests failing. After that we replicate the failures by hand and found the
> following issues:
>
> - Clicking in the checkboxes of the rows does not select the row anymore.
> - When copying and pasting (any) data, we realized that it copied an empty
> dataset.
>
> Thanks for pointing out these issues. I have fixed them at my end and also
remaining tests are failing because in earlier implementation of sql editor
we have used pain 2Darray to provide data to slick grid and In this patch I
have used Slick grid DataView
 to provide data to
slick gird. I'll need to update test cases to support this DataView change.
I'll send updated patch with all of the above changes along with suggestion
given by Dave.



> We didn't review the patch further because there aren't any tests for the
> newly implemented functionality.
>
> Is there a place to find a dataset with 96k rows that you guys were
> testing with?
>

Execute below SQL queries to create table dummy_data  with dataset of 100k
records. (you can change number of records to generate by replacing 10
in below SQL query)



*CREATE TABLE public.dummy_data*
*(*
*   id serial NOT NULL, *
*   name text*
*) *
*WITH (*
*  OIDS = FALSE*
*)*
*;*
*ALTER TABLE public.dummy_data*
*  OWNER TO postgres;*


*INSERT INTO public.dummy_data(*
*id, name)*
* SELECT generate_series(1,10), 'dummy name';*







>
> Note: To run the Javascript test you can use the following commands
> ```
> $ cd web
> $ yarn install
> $ yarn run karma start --single-run
> ```
>
> Thanks
> Joao & Sarah
>
> On Mon, May 8, 2017 at 9:16 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, May 8, 2017 at 4:49 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> This is fantastic! The speedup in the query tool is phenomenal with
>>> large result sets. For 96K rows, I'm now seeing 1 second until I can browse
>>> the data, vs. 13 in v1.4 (and 22 secs in pgAdmin 3)!! Awesome work Harshal
>>> :-)
>>>
>>> Questions/comments:
>>>
>>> - Can we put the row number in the left-hand column, to the right of the
>>> checkbox? This patch highlights just how much value that had in pgAdmin 3
>>> (I hadn't realised we had missed it until now)
>>>
>>> - If the user clicks the checkbox to select all rows, we need to
>>> retrieve them all at that time, otherwise they may be inadvertently working
>>> with a truncated result set.
>>>
>>> Sure I'll do above both the changes.
>>
>>
>>> - Are any changes needed to ensure the Download button works? I'm seeing
>>> missing rows in my test here, but that could be because of the known issues
>>> there with Unicode.
>>>
>>> This is fixed and checked in.
>>
>>
>>
>>> Thanks!
>>>
>>>
>>> On Sun, May 7, 2017 at 6:10 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 Here is patch for initial implementation of on demand loading of result
 set for query tool and datagrid.

 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Tue, Apr 25, 2017 at 5:21 PM, Dave Page  wrote:

> Hi
>
> On Tue, Apr 25, 2017 at 8:41 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> To implement feature #2137
>>  we'll need to use
>> server cursor. However server cursor has some
>> limitation.
>> For eg.
>> 1. It cannot execute BEGIN; query (basically user cannot start new
>> database transaction)
>> 2. In case if Auto commit is true then we try to execute user queries
>> inside BEGIN and END when ever it's possible even though user has not put
>> BEGIN and END in his query.
>>
>> Also not all queries executed using Query tool produces records as
>> result. So can we assume only
>> queries started with SELECT should be executed using server cursor to
>> support on demand loading.
>> Or should we give user an option to use on demand loading like we
>> have options for Auto commit? and Auto rollback?
>> In case of on demand loading option user will be responsible to
>> execute correct queries (queries which can be executed using server 
>> cursor)
>>
>> Let me know your opinion on this.
>>
>
> Hmm, those are good points.
>
> So, as a first step, there's no absolute

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-09 Thread Sarah McAlear

Hi Akshay!


> Some test file names ended with "*_sql_template.py*" do we need to add
> that string ?

we added this suffix after moving the tests up a level to tables/tests to
clarify what subject they applied to. we changed the suffix to "_sql.py"

- Files "test_column_acl_sql_template.py" and "test_column_properties_sql_
> template.py" should be moved from tables->tests to tables->column->tests.
> As it's related to column.
> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_sql
> _template.py" should be moved from tables->tests to
> tables->triggers->tests. As its related to triggers.

these tests are related to the sql files in tables/templates/column, not
tables/column, so moving them into tables/column would be more confusing.

Following test cases are failing

Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql
doesn't fail in your environment?

Thanks,
George & Sarah


0001-Fix-error-while-checking-Dependents-and-Dependencies.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node

2017-05-09 Thread Murtuza Zabuawala

Hi,

Please find updated patch.

Updated logic to convert name only if name is of type int/long/float
(Python2) or of type int/float (Python3) instead of blindly convert it to
string.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 9, 2017 at 7:06 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue in table node where it fails to create
> table when user provides numeric table name eg: 123.
> RM#2284
>
> Issue is when use json.loads() it converts string "123" into integer 123.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
index e118cab..b6bf7ed 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
@@ -1376,6 +1376,28 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 
 return data
 
+def check_and_convert_name_to_string(self, data):
+"""
+This function will check and covert table to string incase
+it is numeric
+
+Args:
+data: data dict
+
+Returns:
+Updated data dict
+"""
+# For Python2, it can be int, long, float
+if hasattr(str, 'decode'):
+if isinstance(data['name'], (int, long, float)):
+data['name'] = str(data['name'])
+else:
+# For Python3, it can be int, float
+if isinstance(data['name'], (int, float)):
+data['name'] = str(data['name'])
+return data
+
+
 @check_precondition
 def create(self, gid, sid, did, scid):
 """
@@ -1417,6 +1439,7 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 
 # Parse & format columns
 data = self._parse_format_columns(data)
+data = self.check_and_convert_name_to_string(data)
 
 # 'coll_inherits' is Array but it comes as string from browser
 # We will convert it again to list
@@ -1447,8 +1470,10 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 return internal_server_error(errormsg=res)
 
 # PostgreSQL truncates the table name to 63 characters.
-# Have to truncate the name like PostgreSQL to get the proper 
schema id
+# Have to truncate the name like PostgreSQL to get the
+# proper OID
 CONST_MAX_CHAR_COUNT = 63
+
 if len(data['name']) > CONST_MAX_CHAR_COUNT:
 data['name'] = data['name'][0:CONST_MAX_CHAR_COUNT]
 
@@ -2129,9 +2154,12 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 data['relacl'][mode], self.acl
 )
 
-# If name if not present
+# If name is not present in request data
 if 'name' not in data:
 data['name'] = old_data['name']
+
+data = self.check_and_convert_name_to_string(data)
+
 # If name if not present
 if 'schema' not in data:
 data['schema'] = old_data['schema']
@@ -2310,6 +2338,7 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 
 # Parse & format columns
 data = self._parse_format_columns(data)
+data = self.check_and_convert_name_to_string(data)
 
 if 'foreign_key' in data:
 for c in data['foreign_key']:

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #216

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Relax version dependency on psycopg2

--
[...truncated 291.21 KB...]
copying images... [ 34%] images/query_output_messages.png
copying images... [ 35%] images/synonym_sql.png
copying images... [ 35%] images/collation_definition.png
copying images... [ 35%] images/fts_parser_definition.png
copying images... [ 36%] images/pgagent_steps.png
copying images... [ 36%] images/trigger_function_definition.png
copying images... [ 36%] images/main_properties_table.png
copying images... [ 37%] images/import_export_pw.png
copying images... [ 37%] images/role_sql.png
copying images... [ 37%] images/backup_process_watcher.png
copying images... [ 38%] images/foreign_table_constraints.png
copying images... [ 38%] images/type_security.png
copying images... [ 39%] images/fts_dictionary_sql.png
copying images... [ 39%] images/table_unique.png
copying images... [ 39%] images/column_general.png
copying images... [ 40%] images/fts_parser_general.png
copying images... [ 40%] images/procedure_arguments.png
copying images... [ 40%] images/query_toolbar.png
copying images... [ 41%] images/main_query_tool.png
copying images... [ 41%] images/exclusion_constraint_columns.png
copying images... [ 41%] images/procedure_general.png
copying images... [ 42%] images/event_trigger_security.png
copying images... [ 42%] images/preferences_paths_binary.png
copying images... [ 42%] images/primary_key_sql.png
copying images... [ 43%] images/foreign_server_definition.png
copying images... [ 43%] images/domain_constraint_sql.png
copying images... [ 43%] images/backup_globals_messages.png
copying images... [ 44%] images/domain_sql.png
copying images... [ 44%] images/backup_objects.png
copying images... [ 45%] images/pgagent_properties.png
copying images... [ 45%] images/query_execute_section.png
copying images... [ 45%] images/foreign_server_sql.png
copying images... [ 46%] images/debug_toolbar.png
copying images... [ 46%] images/preferences_browser_display.png
copying images... [ 46%] images/backup_messages.png
copying images... [ 47%] images/debug_main.png
copying images... [ 47%] images/main_statistics.png
copying images... [ 47%] images/procedure_sql.png
copying images... [ 48%] images/role_security.png
copying images... [ 48%] images/pgagent_schedules.png
copying images... [ 48%] images/user_mapping_options.png
copying images... [ 49%] images/table_advanced.png
copying images... [ 49%] images/backup_sections.png
copying images... [ 50%] images/preferences_tree.png
copying images... [ 50%] images/package_code.png
copying images... [ 50%] images/extension_general.png
copying images... [ 51%] images/maintenance.png
copying images... [ 51%] images/tablespace_definition.png
copying images... [ 51%] images/foreign_data_wrapper_general.png
copying images... [ 52%] images/column_definition.png
copying images... [ 52%] images/foreign_server_options.png
copying images... [ 52%] images/schema_security.png
copying images... [ 53%] images/type_external.png
copying images... [ 53%] images/materialized_view_sql.png
copying images... [ 53%] images/import_export_miscellaneous.png
copying images... [ 54%] images/ce_not_running.png
copying images... [ 54%] images/language_sql.png
copying images... [ 54%] images/import_export_options.png
copying images... [ 55%] images/primary_key_definition.png
copying images... [ 55%] images/function_parameters.png
copying images... [ 56%] images/rule_sql.png
copying images... [ 56%] images/ce_timeout.png
copying images... [ 56%] images/ce_error_hba.png
copying images... [ 57%] images/pgadmin_login.png
copying images... [ 57%] images/main_dashboard.png
copying images... [ 57%] images/backup_miscellaneous.png
copying images... [ 58%] images/import_export_columns.png
copying images... [ 58%] images/grant_wizard_step1.png
copying images... [ 58%] images/preferences_dashboard_graphs.png
copying images... [ 59%] images/preferences_sql_options.png
copying images... [ 59%] images/foreign_key_sql.png
copying images... [ 59%] images/tablespace_general.png
copying images... [ 60%] images/column_variables.png
copying images... [ 60%] images/resource_group_sql.png
copying images... [ 60%] images/ce_password_failed.png
copying images... [ 61%] images/foreign_table_general.png
copying images... [ 61%] images/restore_sections.png
copying images... [ 62%] images/rule_definition.png
copying images... [ 62%] images/column_security.png
copying images... [ 62%] images/move_objects_sql.png
copying images... [ 63%] images/restore_objects.png
copying images... [ 63%] images/trigger_function_options.png
copying images... [ 63%] images/type_composite.png
copying images... [ 64%] images/type_shell.png
copying images... [ 64%] images/fts_configuration_sql.png
copying images... [ 64%] images/procedure_definition.png
copying images... [ 65%] images/preferences_sql_explain_options.png
copying

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #98

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Relax version dependency on psycopg2

--
[...truncated 287.33 KB...]
copying images... [ 28%] images/database_parameters.png
copying images... [ 28%] images/view_general.png
copying images... [ 29%] images/backup_do_not_save.png
copying images... [ 29%] images/column_security.png
copying images... [ 29%] images/function_definition.png
copying images... [ 30%] images/language_general.png
copying images... [ 30%] images/fts_template_general.png
copying images... [ 30%] images/view_definition.png
copying images... [ 31%] images/backup_globals_general.png
copying images... [ 31%] images/unique_constraint_general.png
copying images... [ 31%] images/query_autocomplete.png
copying images... [ 32%] images/restore_objects.png
copying images... [ 32%] images/procedure_sql.png
copying images... [ 32%] images/query_tool.png
copying images... [ 33%] images/tablespace_sql.png
copying images... [ 33%] images/type_range.png
copying images... [ 34%] images/type_external.png
copying images... [ 34%] images/file_menu.png
copying images... [ 34%] images/preferences_browser_display.png
copying images... [ 35%] images/query_output_messages.png
copying images... [ 35%] images/query_output_data.png
copying images... [ 35%] images/language_security.png
copying images... [ 36%] images/pgagent_schedule_definition.png
copying images... [ 36%] images/resource_group_sql.png
copying images... [ 36%] images/ce_timeout.png
copying images... [ 37%] images/backup_queries.png
copying images... [ 37%] images/restore_messages.png
copying images... [ 37%] images/import_export_options.png
copying images... [ 38%] images/query_output_explain.png
copying images... [ 38%] images/schema_general.png
copying images... [ 39%] images/sequence_general.png
copying images... [ 39%] images/logo-right-128.png
copying images... [ 39%] images/database_security.png
copying images... [ 40%] images/fts_template_sql.png
copying images... [ 40%] images/pgagent_schedule_exceptions.png
copying images... [ 40%] images/role_definition.png
copying images... [ 41%] images/move_objects_sql.png
copying images... [ 41%] images/trigger_sql.png
copying images... [ 41%] images/foreign_server_sql.png
copying images... [ 42%] images/grant_wizard_step3.png
copying images... [ 42%] images/check_definition.png
copying images... [ 42%] images/event_trigger_definition.png
copying images... [ 43%] images/package_sql.png
copying images... [ 43%] images/backup_globals_messages.png
copying images... [ 43%] images/pgagent_properties.png
copying images... [ 44%] images/preferences_storage_options.png
copying images... [ 44%] images/restore_queries.png
copying images... [ 45%] images/domain_constraint_definition.png
copying images... [ 45%] images/domain_general.png
copying images... [ 45%] images/fts_parser_sql.png
copying images... [ 46%] images/table_constraints.png
copying images... [ 46%] images/primary_key_definition.png
copying images... [ 46%] images/procedure_options.png
copying images... [ 47%] images/package_general.png
copying images... [ 47%] images/backup_disable.png
copying images... [ 47%] images/trigger_function_sql.png
copying images... [ 48%] images/fts_configuration_general.png
copying images... [ 48%] images/restore_general.png
copying images... [ 48%] images/debug_main.png
copying images... [ 49%] images/tablespace_general.png
copying images... [ 49%] images/type_sql.png
copying images... [ 50%] images/language_definition.png
copying images... [ 50%] images/unique_constraint_sql.png
copying images... [ 50%] images/preferences_dashboard_graphs.png
copying images... [ 51%] images/preferences_paths_binary.png
copying images... [ 51%] images/debug_stack.png
copying images... [ 51%] images/foreign_server_definition.png
copying images... [ 52%] images/column_variables.png
copying images... [ 52%] images/materialized_view_definition.png
copying images... [ 52%] images/collation_definition.png
copying images... [ 53%] images/domain_definition.png
copying images... [ 53%] images/extension_definition.png
copying images... [ 53%] images/foreign_server_options.png
copying images... [ 54%] images/main_statistics.png
copying images... [ 54%] images/view_security.png
copying images... [ 54%] images/import_export_miscellaneous.png
copying images... [ 55%] images/debug_error_message.png
copying images... [ 55%] images/pgadmin_welcome.png
copying images... [ 56%] images/trigger_function_parameters.png
copying images... [ 56%] images/preferences_browser_nodes.png
copying images... [ 56%] images/materialized_view_sql.png
copying images... [ 57%] images/primary_key_sql.png
copying images... [ 57%] images/server_group.png
copying images... [ 57%] images/backup_messages.png
copying images... [ 58%] images/trigger_code.png
copying images... [ 58%] images/function_sql.png
copying images... [ 58%] images/pgagent_sql.png
copying

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #107

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Relax version dependency on psycopg2

--
[...truncated 287.20 KB...]
copying images... [ 28%] images/package_sql.png
copying images... [ 28%] images/trigger_general.png
copying images... [ 29%] images/backup_disable.png
copying images... [ 29%] images/fts_template_general.png
copying images... [ 29%] images/database_sql.png
copying images... [ 30%] images/restore_process_watcher.png
copying images... [ 30%] images/materialized_view_security.png
copying images... [ 30%] images/synonym_general.png
copying images... [ 31%] images/foreign_server_security.png
copying images... [ 31%] images/trigger_function_sql.png
copying images... [ 31%] images/materialized_view_parameter.png
copying images... [ 32%] images/event_trigger_definition.png
copying images... [ 32%] images/check_sql.png
copying images... [ 32%] images/main_properties_edit.png
copying images... [ 33%] images/foreign_key_definition.png
copying images... [ 33%] images/event_trigger_general.png
copying images... [ 34%] images/view_general.png
copying images... [ 34%] images/cast_sql.png
copying images... [ 34%] images/query_output_messages.png
copying images... [ 35%] images/synonym_sql.png
copying images... [ 35%] images/collation_definition.png
copying images... [ 35%] images/fts_parser_definition.png
copying images... [ 36%] images/pgagent_steps.png
copying images... [ 36%] images/trigger_function_definition.png
copying images... [ 36%] images/main_properties_table.png
copying images... [ 37%] images/import_export_pw.png
copying images... [ 37%] images/role_sql.png
copying images... [ 37%] images/backup_process_watcher.png
copying images... [ 38%] images/foreign_table_constraints.png
copying images... [ 38%] images/type_security.png
copying images... [ 39%] images/fts_dictionary_sql.png
copying images... [ 39%] images/table_unique.png
copying images... [ 39%] images/column_general.png
copying images... [ 40%] images/fts_parser_general.png
copying images... [ 40%] images/procedure_arguments.png
copying images... [ 40%] images/query_toolbar.png
copying images... [ 41%] images/main_query_tool.png
copying images... [ 41%] images/exclusion_constraint_columns.png
copying images... [ 41%] images/procedure_general.png
copying images... [ 42%] images/event_trigger_security.png
copying images... [ 42%] images/preferences_paths_binary.png
copying images... [ 42%] images/primary_key_sql.png
copying images... [ 43%] images/foreign_server_definition.png
copying images... [ 43%] images/domain_constraint_sql.png
copying images... [ 43%] images/backup_globals_messages.png
copying images... [ 44%] images/domain_sql.png
copying images... [ 44%] images/backup_objects.png
copying images... [ 45%] images/pgagent_properties.png
copying images... [ 45%] images/query_execute_section.png
copying images... [ 45%] images/foreign_server_sql.png
copying images... [ 46%] images/debug_toolbar.png
copying images... [ 46%] images/preferences_browser_display.png
copying images... [ 46%] images/backup_messages.png
copying images... [ 47%] images/debug_main.png
copying images... [ 47%] images/main_statistics.png
copying images... [ 47%] images/procedure_sql.png
copying images... [ 48%] images/role_security.png
copying images... [ 48%] images/pgagent_schedules.png
copying images... [ 48%] images/user_mapping_options.png
copying images... [ 49%] images/table_advanced.png
copying images... [ 49%] images/backup_sections.png
copying images... [ 50%] images/preferences_tree.png
copying images... [ 50%] images/package_code.png
copying images... [ 50%] images/extension_general.png
copying images... [ 51%] images/maintenance.png
copying images... [ 51%] images/tablespace_definition.png
copying images... [ 51%] images/foreign_data_wrapper_general.png
copying images... [ 52%] images/column_definition.png
copying images... [ 52%] images/foreign_server_options.png
copying images... [ 52%] images/schema_security.png
copying images... [ 53%] images/type_external.png
copying images... [ 53%] images/materialized_view_sql.png
copying images... [ 53%] images/import_export_miscellaneous.png
copying images... [ 54%] images/ce_not_running.png
copying images... [ 54%] images/language_sql.png
copying images... [ 54%] images/import_export_options.png
copying images... [ 55%] images/primary_key_definition.png
copying images... [ 55%] images/function_parameters.png
copying images... [ 56%] images/rule_sql.png
copying images... [ 56%] images/ce_timeout.png
copying images... [ 56%] images/ce_error_hba.png
copying images... [ 57%] images/pgadmin_login.png
copying images... [ 57%] images/main_dashboard.png
copying images... [ 57%] images/backup_miscellaneous.png
copying images... [ 58%] images/import_export_columns.png
copying images... [ 58%] images/grant_wizard_step1.png
copying images... [ 58%] images/preferences_dashboard_graphs.png
copying images... [

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #100

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Relax version dependency on psycopg2

--
[...truncated 287.25 KB...]
copying images... [ 28%] images/foreign_key_sql.png
copying images... [ 28%] images/foreign_server_general.png
copying images... [ 29%] images/foreign_server_definition.png
copying images... [ 29%] images/foreign_server_options.png
copying images... [ 29%] images/foreign_server_security.png
copying images... [ 30%] images/foreign_server_sql.png
copying images... [ 30%] images/foreign_table_general.png
copying images... [ 30%] images/foreign_table_definition.png
copying images... [ 31%] images/foreign_table_columns.png
copying images... [ 31%] images/foreign_table_constraints.png
copying images... [ 31%] images/foreign_table_options.png
copying images... [ 32%] images/foreign_table_security.png
copying images... [ 32%] images/foreign_table_sql.png
copying images... [ 32%] images/fts_configuration_general.png
copying images... [ 33%] images/fts_configuration_definition.png
copying images... [ 33%] images/fts_configuration_tokens.png
copying images... [ 34%] images/fts_configuration_sql.png
copying images... [ 34%] images/fts_dictionary_general.png
copying images... [ 34%] images/fts_dictionary_definition.png
copying images... [ 35%] images/fts_dictionary_options.png
copying images... [ 35%] images/fts_dictionary_sql.png
copying images... [ 35%] images/fts_parser_general.png
copying images... [ 36%] images/fts_parser_definition.png
copying images... [ 36%] images/fts_parser_sql.png
copying images... [ 36%] images/fts_template_general.png
copying images... [ 37%] images/fts_template_definition.png
copying images... [ 37%] images/fts_template_sql.png
copying images... [ 37%] images/function_general.png
copying images... [ 38%] images/function_definition.png
copying images... [ 38%] images/function_options.png
copying images... [ 39%] images/function_arguments.png
copying images... [ 39%] images/function_parameters.png
copying images... [ 39%] images/function_security.png
copying images... [ 40%] images/function_sql.png
copying images... [ 40%] images/grant_wizard_step1.png
copying images... [ 40%] images/grant_wizard_step2.png
copying images... [ 41%] images/grant_wizard_step3.png
copying images... [ 41%] images/import_export_options.png
copying images... [ 41%] images/import_export_miscellaneous.png
copying images... [ 42%] images/import_export_columns.png
copying images... [ 42%] images/import_export_complete.png
copying images... [ 42%] images/import_export_pw.png
copying images... [ 43%] images/logo-right-128.png
copying images... [ 43%] images/index_general.png
copying images... [ 43%] images/index_definition.png
copying images... [ 44%] images/index_sql.png
copying images... [ 44%] images/language_general.png
copying images... [ 45%] images/language_definition.png
copying images... [ 45%] images/language_security.png
copying images... [ 45%] images/language_sql.png
copying images... [ 46%] images/maintenance.png
copying images... [ 46%] images/maintenance_complete.png
copying images... [ 46%] images/maintenance_pw.png
copying images... [ 47%] images/materialized_view_general.png
copying images... [ 47%] images/materialized_view_definition.png
copying images... [ 47%] images/materialized_view_storage.png
copying images... [ 48%] images/materialized_view_parameter.png
copying images... [ 48%] images/materialized_view_security.png
copying images... [ 48%] images/materialized_view_sql.png
copying images... [ 49%] images/move_objects_general.png
copying images... [ 49%] images/move_objects_sql.png
copying images... [ 50%] images/package_general.png
copying images... [ 50%] images/package_code.png
copying images... [ 50%] images/package_security.png
copying images... [ 51%] images/package_sql.png
copying images... [ 51%] images/pgadmin_login.png
copying images... [ 51%] images/pgadmin_login_recover.png
copying images... [ 52%] images/file_menu.png
copying images... [ 52%] images/object_menu.png
copying images... [ 52%] images/tool_menu.png
copying images... [ 53%] images/help_menu.png
copying images... [ 53%] images/main_dashboard.png
copying images... [ 53%] images/main_properties_table.png
copying images... [ 54%] images/main_properties_edit.png
copying images... [ 54%] images/main_properties_icons.png
copying images... [ 54%] images/main_sql.png
copying images... [ 55%] images/main_statistics.png
copying images... [ 55%] images/main_dependencies.png
copying images... [ 56%] images/main_dependents.png
copying images... [ 56%] images/main_query_tool.png
copying images... [ 56%] images/main_left_pane.png
copying images... [ 57%] images/pgadmin_user.png
copying images... [ 57%] images/add_pgadmin_user.png
copying images... [ 57%] images/pgagent_general.png
copying images... [ 58%] images/pgagent_steps.png
copying images... [ 58%] images/pgagent_step_definition.png
copying images... [

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #98

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Relax version dependency on psycopg2

--
[...truncated 287.20 KB...]
copying images... [ 28%] images/domain_constraints.png
copying images... [ 28%] images/grant_wizard_step1.png
copying images... [ 29%] images/query_tool_message.png
copying images... [ 29%] images/type_enumeration.png
copying images... [ 29%] images/backup_globals_messages.png
copying images... [ 30%] images/debug_main.png
copying images... [ 30%] images/main_dashboard.png
copying images... [ 30%] images/table_advanced.png
copying images... [ 31%] images/domain_security.png
copying images... [ 31%] images/query_sql_editor.png
copying images... [ 31%] images/table_constraints.png
copying images... [ 32%] images/preferences_storage_options.png
copying images... [ 32%] images/cast_general.png
copying images... [ 32%] images/primary_key_definition.png
copying images... [ 33%] images/query_output_explain_details.png
copying images... [ 33%] images/backup_server_messages.png
copying images... [ 34%] images/column_definition.png
copying images... [ 34%] images/pgagent_schedule_definition.png
copying images... [ 34%] images/preferences_dashboard_graphs.png
copying images... [ 35%] images/ce_password_failed.png
copying images... [ 35%] images/debug_step_in.png
copying images... [ 35%] images/type_external.png
copying images... [ 36%] images/debug_error_message.png
copying images... [ 36%] images/preferences_browser_display.png
copying images... [ 36%] images/column_sql.png
copying images... [ 37%] images/fts_parser_general.png
copying images... [ 37%] images/import_export_miscellaneous.png
copying images... [ 37%] images/type_range.png
copying images... [ 38%] images/restore_do_not_save.png
copying images... [ 38%] images/rule_sql.png
copying images... [ 39%] images/unique_constraint_general.png
copying images... [ 39%] images/foreign_table_general.png
copying images... [ 39%] images/object_menu.png
copying images... [ 40%] images/backup_queries.png
copying images... [ 40%] images/procedure_parameters.png
copying images... [ 40%] images/synonym_general.png
copying images... [ 41%] images/query_autocomplete.png
copying images... [ 41%] images/main_properties_edit.png
copying images... [ 41%] images/view_general.png
copying images... [ 42%] images/fts_configuration_sql.png
copying images... [ 42%] images/connect_to_server.png
copying images... [ 42%] images/extension_sql.png
copying images... [ 43%] images/foreign_data_wrapper_general.png
copying images... [ 43%] images/extension_general.png
copying images... [ 43%] images/fts_dictionary_sql.png
copying images... [ 44%] images/restore_miscellaneous.png
copying images... [ 44%] images/tool_menu.png
copying images... [ 45%] images/restore_queries.png
copying images... [ 45%] images/role_definition.png
copying images... [ 45%] images/import_export_complete.png
copying images... [ 46%] images/table_check.png
copying images... [ 46%] images/trigger_sql.png
copying images... [ 46%] images/sequence_general.png
copying images... [ 47%] images/main_left_pane.png
copying images... [ 47%] images/maintenance_complete.png
copying images... [ 47%] images/table_security.png
copying images... [ 48%] images/pgagent_schedule_exceptions.png
copying images... [ 48%] images/foreign_server_sql.png
copying images... [ 48%] images/type_security.png
copying images... [ 49%] images/role_security.png
copying images... [ 49%] images/server_general.png
copying images... [ 50%] images/restore_process_watcher.png
copying images... [ 50%] images/pgagent_schedule_repeat.png
copying images... [ 50%] images/fts_configuration_tokens.png
copying images... [ 51%] images/database_definition.png
copying images... [ 51%] images/primary_key_sql.png
copying images... [ 51%] images/table_general.png
copying images... [ 52%] images/pgadmin_login.png
copying images... [ 52%] images/preferences_sql_options.png
copying images... [ 52%] images/backup_sections.png
copying images... [ 53%] images/foreign_table_definition.png
copying images... [ 53%] images/fts_parser_definition.png
copying images... [ 53%] images/grant_wizard_step2.png
copying images... [ 54%] images/exclusion_constraint_general.png
copying images... [ 54%] images/server_group.png
copying images... [ 54%] images/domain_general.png
copying images... [ 55%] images/foreign_server_security.png
copying images... [ 55%] images/trigger_general.png
copying images... [ 56%] images/ce_not_running.png
copying images... [ 56%] images/rule_definition.png
copying images... [ 56%] images/fts_template_definition.png
copying images... [ 57%] images/domain_constraint_sql.png
copying images... [ 57%] images/procedure_general.png
copying images... [ 57%] images/ce_error_hba.png
copying images... [ 58%] images/import_export_columns.png
copying images... [ 58%] images/restore_objects.png
copying images... [ 58%] images/check_sql.png
copying

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #97

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Support loading files with Unicode BOMs. Fixes #2369

--
[...truncated 287.21 KB...]
copying images... [ 28%] images/restore_miscellaneous.png
copying images... [ 28%] images/exclusion_constraint_columns.png
copying images... [ 29%] images/column_variables.png
copying images... [ 29%] images/language_general.png
copying images... [ 29%] images/sequence_general.png
copying images... [ 30%] images/event_trigger_security.png
copying images... [ 30%] images/query_output_data.png
copying images... [ 30%] images/fts_template_general.png
copying images... [ 31%] images/foreign_server_general.png
copying images... [ 31%] images/rule_definition.png
copying images... [ 31%] images/check_general.png
copying images... [ 32%] images/restore_messages.png
copying images... [ 32%] images/connect_to_server.png
copying images... [ 32%] images/table_exclude.png
copying images... [ 33%] images/restore_queries.png
copying images... [ 33%] images/collation_general.png
copying images... [ 34%] images/backup_server_process_watcher.png
copying images... [ 34%] images/table_general.png
copying images... [ 34%] images/domain_constraints.png
copying images... [ 35%] images/pgadmin_login.png
copying images... [ 35%] images/grant_wizard_step2.png
copying images... [ 35%] images/trigger_function_general.png
copying images... [ 36%] images/fts_dictionary_options.png
copying images... [ 36%] images/main_sql.png
copying images... [ 36%] images/debug_set_breakpoint.png
copying images... [ 37%] images/trigger_general.png
copying images... [ 37%] images/fts_configuration_tokens.png
copying images... [ 37%] images/resource_group_general.png
copying images... [ 38%] images/foreign_key_definition.png
copying images... [ 38%] images/backup_server_general.png
copying images... [ 39%] images/query_autocomplete.png
copying images... [ 39%] images/user_mapping_options.png
copying images... [ 39%] images/procedure_sql.png
copying images... [ 40%] images/fts_template_sql.png
copying images... [ 40%] images/type_sql.png
copying images... [ 40%] images/main_properties_edit.png
copying images... [ 41%] images/type_security.png
copying images... [ 41%] images/maintenance_complete.png
copying images... [ 41%] images/server_general.png
copying images... [ 42%] images/package_general.png
copying images... [ 42%] images/foreign_data_wrapper_sql.png
copying images... [ 42%] images/import_export_options.png
copying images... [ 43%] images/import_export_pw.png
copying images... [ 43%] images/main_dependencies.png
copying images... [ 43%] images/foreign_table_definition.png
copying images... [ 44%] images/foreign_table_general.png
copying images... [ 44%] images/collation_definition.png
copying images... [ 45%] images/table_columns.png
copying images... [ 45%] images/unique_constraint_definition.png
copying images... [ 45%] images/main_properties_icons.png
copying images... [ 46%] images/pgagent_properties.png
copying images... [ 46%] images/pgadmin_user.png
copying images... [ 46%] images/procedure_security.png
copying images... [ 47%] images/ce_not_running.png
copying images... [ 47%] images/foreign_key_general.png
copying images... [ 47%] images/index_general.png
copying images... [ 48%] images/query_tool_message.png
copying images... [ 48%] images/view_sql.png
copying images... [ 48%] images/table_check.png
copying images... [ 49%] images/preferences_browser_display.png
copying images... [ 49%] images/tablespace_security.png
copying images... [ 50%] images/function_security.png
copying images... [ 50%] images/add_pgadmin_user.png
copying images... [ 50%] images/password.png
copying images... [ 51%] images/query_sql_editor.png
copying images... [ 51%] images/trigger_code.png
copying images... [ 51%] images/debug_ic_step_in.png
copying images... [ 52%] images/import_export_complete.png
copying images... [ 52%] images/trigger_function_definition.png
copying images... [ 52%] images/backup_process_watcher.png
copying images... [ 53%] images/foreign_server_security.png
copying images... [ 53%] images/materialized_view_definition.png
copying images... [ 53%] images/domain_constraint_definition.png
copying images... [ 54%] images/import_export_miscellaneous.png
copying images... [ 54%] images/foreign_data_wrapper_definition.png
copying images... [ 54%] images/schema_security.png
copying images... [ 55%] images/rule_sql.png
copying images... [ 55%] images/foreign_table_sql.png
copying images... [ 56%] images/table_unique.png
copying images... [ 56%] images/debug_variables.png
copying images... [ 56%] images/import_export_columns.png
copying images... [ 57%] images/preferences_sql_options.png
copying images... [ 57%] images/domain_general.png
copying images... [ 57%] images/preferences_browser_nodes.png
copying images... [ 58%] images/backup_server_messages.png
copying images... [ 58%] images/main_dashboard.png

[pgadmin-hackers] pgAdmin 4 commit: Relax version dependency on psycopg2

2017-05-09 Thread Dave Page

Relax version dependency on psycopg2

Right now psycopg2 is required to be exactly version 2.6.2, which makes it 
mostly impossible to install pgadmin4 without having the postgresql C 
development packages installed (since you need to rebuild psycopg2 from source 
to make that work, given that few platforms ship *exactly* that version).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29217946c398c3ec1938c6381cd5c0eb68a48cc8
Author: Magnus Hagander 

Modified Files
--
requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Relax version dependency on psycopg2

2017-05-09 Thread Dave Page

Thanks, patch applied.

On Tue, May 9, 2017 at 12:28 PM, Magnus Hagander 
wrote:

> Right now psycopg2 is required to be exactly version 2.6.2, which makes it
> mostly impossible to install pgadmin4 without having the postgresql C
> development packages installed (since you need to rebuild psycopg2 from
> source to make that work, given that few platforms ship *exactly* that
> version).
>
> I suggest just saying "2.6 or greater", which should make it work on many
> more platforms.
>
> AFAIK there aren't any other packages with similar compile requirements,
> so the rest seem OK.
>
> --
>  Magnus Hagander
>  Me: https://www.hagander.net/ 
>  Work: https://www.redpill-linpro.com/ 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #106

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Support loading files with Unicode BOMs. Fixes #2369

--
[...truncated 287.16 KB...]
copying images... [ 28%] images/package_sql.png
copying images... [ 28%] images/trigger_general.png
copying images... [ 29%] images/backup_disable.png
copying images... [ 29%] images/fts_template_general.png
copying images... [ 29%] images/database_sql.png
copying images... [ 30%] images/restore_process_watcher.png
copying images... [ 30%] images/materialized_view_security.png
copying images... [ 30%] images/synonym_general.png
copying images... [ 31%] images/foreign_server_security.png
copying images... [ 31%] images/trigger_function_sql.png
copying images... [ 31%] images/materialized_view_parameter.png
copying images... [ 32%] images/event_trigger_definition.png
copying images... [ 32%] images/check_sql.png
copying images... [ 32%] images/main_properties_edit.png
copying images... [ 33%] images/foreign_key_definition.png
copying images... [ 33%] images/event_trigger_general.png
copying images... [ 34%] images/view_general.png
copying images... [ 34%] images/cast_sql.png
copying images... [ 34%] images/query_output_messages.png
copying images... [ 35%] images/synonym_sql.png
copying images... [ 35%] images/collation_definition.png
copying images... [ 35%] images/fts_parser_definition.png
copying images... [ 36%] images/pgagent_steps.png
copying images... [ 36%] images/trigger_function_definition.png
copying images... [ 36%] images/main_properties_table.png
copying images... [ 37%] images/import_export_pw.png
copying images... [ 37%] images/role_sql.png
copying images... [ 37%] images/backup_process_watcher.png
copying images... [ 38%] images/foreign_table_constraints.png
copying images... [ 38%] images/type_security.png
copying images... [ 39%] images/fts_dictionary_sql.png
copying images... [ 39%] images/table_unique.png
copying images... [ 39%] images/column_general.png
copying images... [ 40%] images/fts_parser_general.png
copying images... [ 40%] images/procedure_arguments.png
copying images... [ 40%] images/query_toolbar.png
copying images... [ 41%] images/main_query_tool.png
copying images... [ 41%] images/exclusion_constraint_columns.png
copying images... [ 41%] images/procedure_general.png
copying images... [ 42%] images/event_trigger_security.png
copying images... [ 42%] images/preferences_paths_binary.png
copying images... [ 42%] images/primary_key_sql.png
copying images... [ 43%] images/foreign_server_definition.png
copying images... [ 43%] images/domain_constraint_sql.png
copying images... [ 43%] images/backup_globals_messages.png
copying images... [ 44%] images/domain_sql.png
copying images... [ 44%] images/backup_objects.png
copying images... [ 45%] images/pgagent_properties.png
copying images... [ 45%] images/query_execute_section.png
copying images... [ 45%] images/foreign_server_sql.png
copying images... [ 46%] images/debug_toolbar.png
copying images... [ 46%] images/preferences_browser_display.png
copying images... [ 46%] images/backup_messages.png
copying images... [ 47%] images/debug_main.png
copying images... [ 47%] images/main_statistics.png
copying images... [ 47%] images/procedure_sql.png
copying images... [ 48%] images/role_security.png
copying images... [ 48%] images/pgagent_schedules.png
copying images... [ 48%] images/user_mapping_options.png
copying images... [ 49%] images/table_advanced.png
copying images... [ 49%] images/backup_sections.png
copying images... [ 50%] images/preferences_tree.png
copying images... [ 50%] images/package_code.png
copying images... [ 50%] images/extension_general.png
copying images... [ 51%] images/maintenance.png
copying images... [ 51%] images/tablespace_definition.png
copying images... [ 51%] images/foreign_data_wrapper_general.png
copying images... [ 52%] images/column_definition.png
copying images... [ 52%] images/foreign_server_options.png
copying images... [ 52%] images/schema_security.png
copying images... [ 53%] images/type_external.png
copying images... [ 53%] images/materialized_view_sql.png
copying images... [ 53%] images/import_export_miscellaneous.png
copying images... [ 54%] images/ce_not_running.png
copying images... [ 54%] images/language_sql.png
copying images... [ 54%] images/import_export_options.png
copying images... [ 55%] images/primary_key_definition.png
copying images... [ 55%] images/function_parameters.png
copying images... [ 56%] images/rule_sql.png
copying images... [ 56%] images/ce_timeout.png
copying images... [ 56%] images/ce_error_hba.png
copying images... [ 57%] images/pgadmin_login.png
copying images... [ 57%] images/main_dashboard.png
copying images... [ 57%] images/backup_miscellaneous.png
copying images... [ 58%] images/import_export_columns.png
copying images... [ 58%] images/grant_wizard_step1.png
copying images... [ 58%] images/preferences_dashboard_graphs.png

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #99

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Support loading files with Unicode BOMs. Fixes #2369

--
[...truncated 287.16 KB...]
copying images... [ 28%] images/database_general.png
copying images... [ 28%] images/pgagent_properties.png
copying images... [ 29%] images/debug_step_in.png
copying images... [ 29%] images/query_output_explain_details.png
copying images... [ 29%] images/main_left_pane.png
copying images... [ 30%] images/table_foreign_key.png
copying images... [ 30%] images/table_check.png
copying images... [ 30%] images/domain_constraint_general.png
copying images... [ 31%] images/fts_template_definition.png
copying images... [ 31%] images/collation_general.png
copying images... [ 31%] images/backup_server_messages.png
copying images... [ 32%] images/query_sql_editor.png
copying images... [ 32%] images/domain_security.png
copying images... [ 32%] images/event_trigger_security.png
copying images... [ 33%] images/foreign_data_wrapper_security.png
copying images... [ 33%] images/foreign_server_security.png
copying images... [ 34%] images/user_mapping_general.png
copying images... [ 34%] images/trigger_sql.png
copying images... [ 34%] images/table_parameter.png
copying images... [ 35%] images/foreign_table_columns.png
copying images... [ 35%] images/backup_messages.png
copying images... [ 35%] images/query_output_history.png
copying images... [ 36%] images/check_general.png
copying images... [ 36%] images/main_properties_table.png
copying images... [ 36%] images/pgagent_sql.png
copying images... [ 37%] images/query_execute_section.png
copying images... [ 37%] images/schema_sql.png
copying images... [ 37%] images/pgagent_schedule_repeat.png
copying images... [ 38%] images/table_exclude.png
copying images... [ 38%] images/function_sql.png
copying images... [ 39%] images/exclusion_constraint_columns.png
copying images... [ 39%] images/event_trigger_definition.png
copying images... [ 39%] images/query_output_data.png
copying images... [ 40%] images/query_output_error.png
copying images... [ 40%] images/debug_params.png
copying images... [ 40%] images/tool_menu.png
copying images... [ 41%] images/preferences_paths_binary.png
copying images... [ 41%] images/object_menu.png
copying images... [ 41%] images/materialized_view_sql.png
copying images... [ 42%] images/fts_configuration_definition.png
copying images... [ 42%] images/backup_objects.png
copying images... [ 42%] images/language_sql.png
copying images... [ 43%] images/trigger_function_general.png
copying images... [ 43%] images/fts_parser_sql.png
copying images... [ 43%] images/add_pgadmin_user.png
copying images... [ 44%] images/file_menu.png
copying images... [ 44%] images/column_definition.png
copying images... [ 45%] images/schema_default_privileges.png
copying images... [ 45%] images/database_security.png
copying images... [ 45%] images/debug_variables.png
copying images... [ 46%] images/server_general.png
copying images... [ 46%] images/function_general.png
copying images... [ 46%] images/pgadmin_user.png
copying images... [ 47%] images/main_query_tool.png
copying images... [ 47%] images/type_external.png
copying images... [ 47%] images/column_sql.png
copying images... [ 48%] images/exclusion_constraint_definition.png
copying images... [ 48%] images/pgadmin_login.png
copying images... [ 48%] images/foreign_table_sql.png
copying images... [ 49%] images/import_export_columns.png
copying images... [ 49%] images/foreign_data_wrapper_general.png
copying images... [ 50%] images/pgagent_schedule_definition.png
copying images... [ 50%] images/backup_sections.png
copying images... [ 50%] images/role_definition.png
copying images... [ 51%] images/help_menu.png
copying images... [ 51%] images/domain_definition.png
copying images... [ 51%] images/table_general.png
copying images... [ 52%] images/domain_general.png
copying images... [ 52%] images/fts_template_general.png
copying images... [ 52%] images/rule_definition.png
copying images... [ 53%] images/event_trigger_general.png
copying images... [ 53%] images/pgagent_general.png
copying images... [ 53%] images/import_export_miscellaneous.png
copying images... [ 54%] images/restore_messages.png
copying images... [ 54%] images/tablespace_security.png
copying images... [ 54%] images/server_group.png
copying images... [ 55%] images/exclusion_constraint_sql.png
copying images... [ 55%] images/procedure_general.png
copying images... [ 56%] images/trigger_code.png
copying images... [ 56%] images/backup_server_process_watcher.png
copying images... [ 56%] images/maintenance_pw.png
copying images... [ 57%] images/tablespace_definition.png
copying images... [ 57%] images/trigger_events.png
copying images... [ 57%] images/query_toolbar.png
copying images... [ 58%] images/ce_not_running.png
copying images... [ 58%] images/preferences_dashboard_graphs.png
copying images... [ 58%]

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #99

2017-05-09 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Support loading files with Unicode BOMs. Fixes #2369

--
[...truncated 287.14 KB...]
copying images... [ 28%] images/foreign_key_sql.png
copying images... [ 28%] images/foreign_server_general.png
copying images... [ 29%] images/foreign_server_definition.png
copying images... [ 29%] images/foreign_server_options.png
copying images... [ 29%] images/foreign_server_security.png
copying images... [ 30%] images/foreign_server_sql.png
copying images... [ 30%] images/foreign_table_general.png
copying images... [ 30%] images/foreign_table_definition.png
copying images... [ 31%] images/foreign_table_columns.png
copying images... [ 31%] images/foreign_table_constraints.png
copying images... [ 31%] images/foreign_table_options.png
copying images... [ 32%] images/foreign_table_security.png
copying images... [ 32%] images/foreign_table_sql.png
copying images... [ 32%] images/fts_configuration_general.png
copying images... [ 33%] images/fts_configuration_definition.png
copying images... [ 33%] images/fts_configuration_tokens.png
copying images... [ 34%] images/fts_configuration_sql.png
copying images... [ 34%] images/fts_dictionary_general.png
copying images... [ 34%] images/fts_dictionary_definition.png
copying images... [ 35%] images/fts_dictionary_options.png
copying images... [ 35%] images/fts_dictionary_sql.png
copying images... [ 35%] images/fts_parser_general.png
copying images... [ 36%] images/fts_parser_definition.png
copying images... [ 36%] images/fts_parser_sql.png
copying images... [ 36%] images/fts_template_general.png
copying images... [ 37%] images/fts_template_definition.png
copying images... [ 37%] images/fts_template_sql.png
copying images... [ 37%] images/function_general.png
copying images... [ 38%] images/function_definition.png
copying images... [ 38%] images/function_options.png
copying images... [ 39%] images/function_arguments.png
copying images... [ 39%] images/function_parameters.png
copying images... [ 39%] images/function_security.png
copying images... [ 40%] images/function_sql.png
copying images... [ 40%] images/grant_wizard_step1.png
copying images... [ 40%] images/grant_wizard_step2.png
copying images... [ 41%] images/grant_wizard_step3.png
copying images... [ 41%] images/import_export_options.png
copying images... [ 41%] images/import_export_miscellaneous.png
copying images... [ 42%] images/import_export_columns.png
copying images... [ 42%] images/import_export_complete.png
copying images... [ 42%] images/import_export_pw.png
copying images... [ 43%] images/logo-right-128.png
copying images... [ 43%] images/index_general.png
copying images... [ 43%] images/index_definition.png
copying images... [ 44%] images/index_sql.png
copying images... [ 44%] images/language_general.png
copying images... [ 45%] images/language_definition.png
copying images... [ 45%] images/language_security.png
copying images... [ 45%] images/language_sql.png
copying images... [ 46%] images/maintenance.png
copying images... [ 46%] images/maintenance_complete.png
copying images... [ 46%] images/maintenance_pw.png
copying images... [ 47%] images/materialized_view_general.png
copying images... [ 47%] images/materialized_view_definition.png
copying images... [ 47%] images/materialized_view_storage.png
copying images... [ 48%] images/materialized_view_parameter.png
copying images... [ 48%] images/materialized_view_security.png
copying images... [ 48%] images/materialized_view_sql.png
copying images... [ 49%] images/move_objects_general.png
copying images... [ 49%] images/move_objects_sql.png
copying images... [ 50%] images/package_general.png
copying images... [ 50%] images/package_code.png
copying images... [ 50%] images/package_security.png
copying images... [ 51%] images/package_sql.png
copying images... [ 51%] images/pgadmin_login.png
copying images... [ 51%] images/pgadmin_login_recover.png
copying images... [ 52%] images/file_menu.png
copying images... [ 52%] images/object_menu.png
copying images... [ 52%] images/tool_menu.png
copying images... [ 53%] images/help_menu.png
copying images... [ 53%] images/main_dashboard.png
copying images... [ 53%] images/main_properties_table.png
copying images... [ 54%] images/main_properties_edit.png
copying images... [ 54%] images/main_properties_icons.png
copying images... [ 54%] images/main_sql.png
copying images... [ 55%] images/main_statistics.png
copying images... [ 55%] images/main_dependencies.png
copying images... [ 56%] images/main_dependents.png
copying images... [ 56%] images/main_query_tool.png
copying images... [ 56%] images/main_left_pane.png
copying images... [ 57%] images/pgadmin_user.png
copying images... [ 57%] images/add_pgadmin_user.png
copying images... [ 57%] images/pgagent_general.png
copying images... [ 58%] images/pgagent_steps.png
copying images... [ 58%] images/pgagent_step_definition.png

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

2017-05-09 Thread Dave Page

Thanks, patch applied.

On Tue, May 9, 2017 at 10:33 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Please find patch to fix the issue handling BOM characters in user files
> when they load their sql files in query tool.
> RM#2369
>
> FYI,
> I have attached sample BOM file in redmine for testing.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-09 Thread Dave Page

On Tue, May 9, 2017 at 11:03 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Mon, May 8, 2017 at 4:37 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> On Mon, May 8, 2017 at 3:51 PM, Dave Page  wrote:
>>>
 Hi

 On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Mon, May 8, 2017 at 3:28 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> The support to handle [null] and [default] values is added for
>>> following formatters:
>>>  - JsonFormatter
>>>  - NumbersFormatter
>>>  - CheckmarkFormatter
>>>  - TextFormatter
>>>
>>> Previously when a new row is added, it was not validating each and
>>> every cell for columns with attribute not_null = true.
>>> Introduced a new function validateRow(...) which is called on
>>> adding a new row, it validates each cell with column having
>>> attribute(not_null=true). the corresponding cell will highlighted and 
>>> save
>>> button will be disabled if value is [null].
>>>
>>
>> I'm not sure that behaviour is right. What I now see (given the table
>> below) is that:
>>
>> - If I click in the id field of a new row, it forces me to enter a
>> value or hit escape. Why is it trying to force me? It's a serial field, 
>> so
>> will get a value on save anyway.
>>
> Yes, It is because I am validating all cell values after it renders.
> It will reverted back.
>
>>
>> - If I do enter a value in the ID field, focus jumps over all the
>> other fields with either a default or no 'not null' option to the
>> data_no_nulls column. Focus should always go to the next field.
>>
>> I think this addition can just be removed - I'm pretty sure the
>> previous behaviour would have been what we want, with the additional
>> formatters fixed.
>>
> But If i remove this addition, the value for column like
> 'data_no_nulls' will be set to '' (blank string), then on save its value
> will be validated on the server side and whatever the error message is 
> will
> be returned back (the same behaviour as in pgAdmin3)
>

 Which is fine I think. If you want to leave the validation there,
 that's also fine - but, it a) shouldn't require me to press Esc if I decide
 not to fill in that value yet, and b) shouldn't change the tab order of the
 fields. It's also broken of course, in that it was trying to force me to
 enter a value for a not-null field with a default.

>>> Yes, I will check if we just highlight the field and don't force the
>>> user to enter value.
>>> This will enable user to edit any field using TAB key even if required
>>> field is highlighted red.
>>> Should the save button remains disable untill user enters any valid
>>> value in 'data_no_nulls' column ?
>>>
>>
>> I think that's fine, yes - as long as we get the validation right :-)
>>
> For highlighting the error field and enable user to navigate to other
> cells using TAB key,
> I spend some time looking and debugging into the code and found that it
> requires lot of changes in slick.grid.js core functions as there are no
> event listeners provided to listen and changes in core file is not
> preferred. It may also break other functionalities as code is quite complex.
> So, I think we should validate data on server side and display any error
> messages on UI.
>

OK.


>

>>>
>>
>>>
>>> Now I will add more feature test cases for remaining formatters.
>>> Will send separate patch for feature test cases once completed.
>>>
>>
>> Thanks.
>>
>>
>>>
>>> Please review updated patch.
>>>
>>>
>>> On Tue, May 2, 2017 at 5:57 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Tue, May 2, 2017 at 5:21 PM, Dave Page 
 wrote:

> Hi,
>
> This is looking much better now :-). Couple of thoughts and a bug:
>
> - Only the TextFormatter seems to handle both [null] and [default]
> values. Shouldn't all formatters do so (including Json and Checkmark)?
>
 Yes, I will apply the same changes for other formatters too.

> For example, "serial" columns currently get displayed as [null]
> when left blank, but I would expect to see [default].
>
> - I would suggest we put [null] and [default] in a lighter colour
> - #99.
>
> - With the feature test patch added, I seem to be

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-05-09 Thread Surinder Kumar

Hi Dave,

On Mon, May 8, 2017 at 4:37 PM, Dave Page  wrote:

>
>
> On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Mon, May 8, 2017 at 3:51 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Mon, May 8, 2017 at 3:28 PM, Dave Page  wrote:

> Hi
>
> On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> The support to handle [null] and [default] values is added for
>> following formatters:
>>  - JsonFormatter
>>  - NumbersFormatter
>>  - CheckmarkFormatter
>>  - TextFormatter
>>
>> Previously when a new row is added, it was not validating each and
>> every cell for columns with attribute not_null = true.
>> Introduced a new function validateRow(...) which is called on adding
>> a new row, it validates each cell with column having
>> attribute(not_null=true). the corresponding cell will highlighted and 
>> save
>> button will be disabled if value is [null].
>>
>
> I'm not sure that behaviour is right. What I now see (given the table
> below) is that:
>
> - If I click in the id field of a new row, it forces me to enter a
> value or hit escape. Why is it trying to force me? It's a serial field, so
> will get a value on save anyway.
>
 Yes, It is because I am validating all cell values after it renders.
 It will reverted back.

>
> - If I do enter a value in the ID field, focus jumps over all the
> other fields with either a default or no 'not null' option to the
> data_no_nulls column. Focus should always go to the next field.
>
> I think this addition can just be removed - I'm pretty sure the
> previous behaviour would have been what we want, with the additional
> formatters fixed.
>
 But If i remove this addition, the value for column like
 'data_no_nulls' will be set to '' (blank string), then on save its value
 will be validated on the server side and whatever the error message is will
 be returned back (the same behaviour as in pgAdmin3)

>>>
>>> Which is fine I think. If you want to leave the validation there, that's
>>> also fine - but, it a) shouldn't require me to press Esc if I decide not to
>>> fill in that value yet, and b) shouldn't change the tab order of the
>>> fields. It's also broken of course, in that it was trying to force me to
>>> enter a value for a not-null field with a default.
>>>
>> Yes, I will check if we just highlight the field and don't force the
>> user to enter value.
>> This will enable user to edit any field using TAB key even if required
>> field is highlighted red.
>> Should the save button remains disable untill user enters any valid value
>> in 'data_no_nulls' column ?
>>
>
> I think that's fine, yes - as long as we get the validation right :-)
>
For highlighting the error field and enable user to navigate to other
cells using TAB key,
I spend some time looking and debugging into the code and found that it
requires lot of changes in slick.grid.js core functions as there are no
event listeners provided to listen and changes in core file is not
preferred. It may also break other functionalities as code is quite complex.
So, I think we should validate data on server side and display any error
messages on UI.

>
>>>
>>
>
>>
>> Now I will add more feature test cases for remaining formatters. Will
>> send separate patch for feature test cases once completed.
>>
>
> Thanks.
>
>
>>
>> Please review updated patch.
>>
>>
>> On Tue, May 2, 2017 at 5:57 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Tue, May 2, 2017 at 5:21 PM, Dave Page  wrote:
>>>
 Hi,

 This is looking much better now :-). Couple of thoughts and a bug:

 - Only the TextFormatter seems to handle both [null] and [default]
 values. Shouldn't all formatters do so (including Json and Checkmark)?

>>> Yes, I will apply the same changes for other formatters too.
>>>
 For example, "serial" columns currently get displayed as [null]
 when left blank, but I would expect to see [default].

 - I would suggest we put [null] and [default] in a lighter colour -
 #99.

 - With the feature test patch added, I seem to be consistently
 getting the following failure (immediately after your new tests run):

 
 ==
 ERROR: runTest (pgadmin.feature_tests.xss_che

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-09 Thread Akshay Joshi

Hi Sarah

Below are my review comments on the latest patch:

   - Some test file names ended with "*_sql_template.py*" do we need to add
   that string ?
   - Files "test_column_acl_sql_template.py" and "test_column_properties_sql
   _template.py" should be moved from tables->tests to
   tables->column->tests. As it's related to column.
   - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_
   sql_template.py" should be moved from tables->tests to
   tables->triggers->tests. As its related to triggers.
   - Following test cases are failing for PG 9.6 and PG 10.0 with error "*name
   'long' is not defined". *I am using python 3.5
  - TestRoleDependenciesSqlTemplate
  - TestTablesPropertiesSqlTemplate
  - TestTablesNodeSqlTemplate


On Mon, May 8, 2017 at 9:44 PM, Sarah McAlear  wrote:

> Hi!
>
> This patch has the tests moved to the test directories of the parent.
>
> Thanks,
> Joao & Sarah
>
> On Mon, May 8, 2017 at 7:28 AM, Dave Page  wrote:
>
>> Hi
>>
>> On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All
>>>
>>> I have reviewed the code and have following questions:
>>>
>>>- Why do we have empty __init__.py file in sql and
>>>templates/ folder. In this patch we have couple of occurrences 
>>> one
>>>of them is web/pgadmin/browser/server_groups/servers/databases/
>>>schemas/table/templates/trigger and  web/pgadmin/browser/serve
>>>r_groups/servers/databases/schemas/table/templates/trigger/sql
>>>
>>> That was already answered up-thread: We added the __init__.py files
>> into templates to convert them into packages so that the tests inside of
>> them can be found by the test runner.
>>
>>>
>>>- Why do we have tests folder inside sql folder as we already have
>>>tests folder in respective module. For example we have tests folder in
>>>
>>> *web/pgadmin/browser/server_groups/servers/databases/schemas/table/column 
>>> *then
>>>why do we need it in
>>>
>>> *web/pgadmin/browser/server_groups/servers/databases/schemas/table/templates/column/sql/tests*
>>>
>>> That does seem like a valid concern to me.
>>
>>
>>> Apart from above code looks good to me.
>>>
>>> On Mon, May 8, 2017 at 2:20 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>


 On Mon, May 8, 2017 at 1:46 PM, Dave Page  wrote:

> Akshay, as Ashesh is unavailable today, can you please review/commit
> this ASAP?
>

 Sure.

>
> Thanks.
>
> On Fri, May 5, 2017 at 1:18 PM, Dave Page  wrote:
>
>> Can you get this polished off on Monday please Ashesh?
>>
>> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt <
>> reckha...@pivotal.io> wrote:
>>
>>> All,
>>>
>>> This change in the xss testing is preventing our CI from going green
>>> and is also preventing the Dependents and Dependencies tabs in Greenplum
>>> from being useful.
>>>
>>> Can we either merge this or provide feedback as to what needs to
>>> change so that it can be merged.
>>>
>>> Thank you
>>> Rob
>>>
>>> On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear 
>>> wrote:
>>>
 Hi Hackers & Ashesh!

 Is there anything else we can do for this?

 Thanks!
 Matt & Sarah

 On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Thanks for reviewing, Ashesh.
>
> We have updated the patch. The headers are all consistent and we
> removed the __init__.py files in directories containing only .sql.
>
> Thanks!
> Joao & Matt
>
> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Ashesh,
>>
>> Thanks for reviewing the patch.
>>
>> We added the __init__.py files into templates to convert them
>> into packages so that the tests inside of them can be found by the 
>> test
>> runner.
>>
>> Thanks!
>> Joao & Sarah
>>
>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page 
>>> wrote:
>>>
 Ashesh, can you review/commit this please?

 On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira
  wrote:

> Hi Hackers,
>
> We found out that when you are connected to a GreenPlum
> database and try to get Dependents and Dependencies of an object 
> the
> application was

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel

Hi Dave,

On Tue, May 9, 2017 at 3:08 PM, Dave Page 
wrote:

> Hi
>
> On Tue, May 9, 2017 at 10:28 AM, Neel Patel 
> wrote:
>
>> Hi Dave,
>>
>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar'
>> related compilation error in Qt4. BUT
>>
>> Below compilation error is coming because we have not applied the latest
>> patch of webkit which was fixed in annulen/webkit repo which was raised at
>> below path.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of
>> ‘QWebPage’
>>  webviewPtr->page()->triggerAc
>> tion(QWebPage::RequestClose);
>>
>> To fix the above compilation error currently we have two solution.
>>
>>- Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
>>- Comment the below line temporary for compilation until we get the
>>releases from annulen/webkit.
>>
>>webviewPtr->page()->triggerAction(QWebPage::RequestClose);
>>
>> Other compilation issues, (Me and Akshay) will fix and commit it but need
>> your input on above issue.
>>
>
> For various reasons we need to retain compatibility with the previous
> versions of qtwebkit. Can we detect at build time what version we have, and
> enable/disable that code as appropriate?
>

Make sense.  We will check if we are getting any webkit version in
application or not and update you.


>
>>
>> Thanks,
>> Neel Patel
>>
>> On Tue, May 9, 2017 at 2:02 PM, Dave Page 
>> wrote:
>>
>>> It's running CentOS 7.3, with packages from EPEL:
>>>
>>> [dpage@jenkins ~]$ rpm -qa |grep qt
>>> qt5-qtbase-common-5.6.1-10.el7.noarch
>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64
>>> qt-4.8.5-13.el7.x86_64
>>> qt5-qtbase-5.6.1-10.el7.x86_64
>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64
>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
>>> qt-devel-4.8.5-13.el7.x86_64
>>> qt-settings-19-23.5.el7.centos.noarch
>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64
>>> qt5-qtlocation-5.6.1-10.el7.x86_64
>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64
>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
>>> qtwebkit-2.3.4-6.el7.x86_64
>>> qt3-3.3.8b-51.el7.x86_64
>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64
>>> qt5-rpm-macros-5.6.1-10.el7.noarch
>>> qtwebkit-devel-2.3.4-6.el7.x86_64
>>> qt-x11-4.8.5-13.el7.x86_64
>>> qt5-qtsensors-5.6.1-10.el7.x86_64
>>>
>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel 
>>> wrote:
>>>
 Hi Dave,

 Yes, It looks like compilation fails on Qt4. We will fix this issue but
 which version of Qt4 we are using in Jenkins ?

 Thanks,
 Neel Patel

 On Tue, May 9, 2017 at 1:56 PM, Dave Page 
 wrote:

>
>
> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Tue, May 9, 2017 at 1:42 PM, Dave Page > > wrote:
>>
>>> This appears to have made Jenkins get all angry and red :-(
>>>
>>> https://jenkins.pgadmin.org/
>>>
>>
>>We(Neel and I) have tested it and working fine.
>>
>
> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>
>
>>
>>>
>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks patch applied.

 On Mon, May 8, 2017 at 3:21 PM, Dave Page 
 wrote:

> Akshay, could you review this please?
>
> Thanks.
>
> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
> neel.pa...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch file with the fix of RM #2328 -
>> [Runtime]: Unable to launch query tool and debugger in new browser 
>> tab.
>>
>> I have used Qt 5.8 with webkit mentioned in below URL.
>>
>> https://github.com/annulen/webkit/releases
>>
>>
>> As there was a bug in QWebKit regarding "unload" event. We have
>> raised and also they have provided patch file to fix this issue. I 
>> have
>> applied the patch in linux and compile the webkit and tested the 
>> attached
>> patch with compiled webkit which is now working fine.
>>
>> Below is the link for reference regarding unload issue. They have
>> provided test webkit release for Mac in below URL but for other 
>> platform we
>> need to apply the patch and compile the webkit until they provide
>> webkit-releases for all platforms.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> Do review it and let me know in case of any issue.

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Dave Page

Hi

On Tue, May 9, 2017 at 10:28 AM, Neel Patel 
wrote:

> Hi Dave,
>
> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar'
> related compilation error in Qt4. BUT
>
> Below compilation error is coming because we have not applied the latest
> patch of webkit which was fixed in annulen/webkit repo which was raised at
> below path.
>
> https://github.com/annulen/webkit/issues/519
>
> BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of
> ‘QWebPage’
>  webviewPtr->page()->triggerAction(QWebPage::
> RequestClose);
>
> To fix the above compilation error currently we have two solution.
>
>- Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
>- Comment the below line temporary for compilation until we get the
>releases from annulen/webkit.
>
>webviewPtr->page()->triggerAction(QWebPage::RequestClose);
>
> Other compilation issues, (Me and Akshay) will fix and commit it but need
> your input on above issue.
>

For various reasons we need to retain compatibility with the previous
versions of qtwebkit. Can we detect at build time what version we have, and
enable/disable that code as appropriate?


>
> Thanks,
> Neel Patel
>
> On Tue, May 9, 2017 at 2:02 PM, Dave Page 
> wrote:
>
>> It's running CentOS 7.3, with packages from EPEL:
>>
>> [dpage@jenkins ~]$ rpm -qa |grep qt
>> qt5-qtbase-common-5.6.1-10.el7.noarch
>> qt5-qtbase-devel-5.6.1-10.el7.x86_64
>> qt-4.8.5-13.el7.x86_64
>> qt5-qtbase-5.6.1-10.el7.x86_64
>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
>> qt5-qtwebchannel-5.6.1-10.el7.x86_64
>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
>> qt-devel-4.8.5-13.el7.x86_64
>> qt-settings-19-23.5.el7.centos.noarch
>> qt5-qtbase-gui-5.6.1-10.el7.x86_64
>> qt5-qtlocation-5.6.1-10.el7.x86_64
>> qt5-qtwebsockets-5.6.1-10.el7.x86_64
>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
>> qtwebkit-2.3.4-6.el7.x86_64
>> qt3-3.3.8b-51.el7.x86_64
>> qt5-qtdeclarative-5.6.1-10.el7.x86_64
>> qt5-rpm-macros-5.6.1-10.el7.noarch
>> qtwebkit-devel-2.3.4-6.el7.x86_64
>> qt-x11-4.8.5-13.el7.x86_64
>> qt5-qtsensors-5.6.1-10.el7.x86_64
>>
>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel 
>> wrote:
>>
>>> Hi Dave,
>>>
>>> Yes, It looks like compilation fails on Qt4. We will fix this issue but
>>> which version of Qt4 we are using in Jenkins ?
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page 
>>> wrote:
>>>


 On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi
>
> On Tue, May 9, 2017 at 1:42 PM, Dave Page 
> wrote:
>
>> This appears to have made Jenkins get all angry and red :-(
>>
>> https://jenkins.pgadmin.org/
>>
>
>We(Neel and I) have tested it and working fine.
>

 It clearly doesn't compile on QT4. Please review the Jenkins logs.


>
>>
>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>>>
 Akshay, could you review this please?

 Thanks.

 On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch file with the fix of RM #2328 -
> [Runtime]: Unable to launch query tool and debugger in new browser 
> tab.
>
> I have used Qt 5.8 with webkit mentioned in below URL.
>
> https://github.com/annulen/webkit/releases
>
>
> As there was a bug in QWebKit regarding "unload" event. We have
> raised and also they have provided patch file to fix this issue. I 
> have
> applied the patch in linux and compile the webkit and tested the 
> attached
> patch with compiled webkit which is now working fine.
>
> Below is the link for reference regarding unload issue. They have
> provided test webkit release for Mac in below URL but for other 
> platform we
> need to apply the patch and compile the webkit until they provide
> webkit-releases for all platforms.
>
> https://github.com/annulen/webkit/issues/519
>
> Do review it and let me know in case of any issue.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (
> pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page

[pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

2017-05-09 Thread Murtuza Zabuawala

Hi,

Please find patch to fix the issue handling BOM characters in user files
when they load their sql files in query tool.
RM#2369

FYI,
I have attached sample BOM file in redmine for testing.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/misc/file_manager/__init__.py 
b/web/pgadmin/misc/file_manager/__init__.py
index 6e081b1..85d7fb4 100644
--- a/web/pgadmin/misc/file_manager/__init__.py
+++ b/web/pgadmin/misc/file_manager/__init__.py
@@ -17,6 +17,7 @@ import sys
 import time
 from sys import platform as _platform
 import config
+import codecs
 
 import simplejson as json
 from flask import render_template, Response, session, request as req, url_for
@@ -932,6 +933,68 @@ class Filemanager(object):
 else:
 return newPath, newName
 
+@staticmethod
+def check_file_for_bom_and_binary(filename, enc="utf-8"):
+"""
+This utility function will check if file is Binary file
+and/or if it startswith BOM character
+
+Args:
+filename: File
+enc: Encoding for the file
+
+Returns:
+Status(Error?), Error message, Binary file flag,
+BOM character flag and Encoding to open file
+"""
+status = True
+err_msg = None
+is_startswith_bom = False
+
+# check if file type is text or binary
+text_chars = bytearray([7, 8, 9, 10, 12, 13, 27]) \
++ bytearray(range(0x20, 0x7f)) \
++ bytearray(range(0x80, 0x100))
+
+def is_binary_string(bytes_data):
+"""Checks if string data is binary"""
+return bool(
+bytes_data.translate(None, text_chars)
+)
+
+# read the file
+try:
+
+with open(filename, 'rb') as f:
+file_data = f.read(1024)
+
+# Check for BOM in file data
+for encoding, boms in \
+('utf-8-sig', (codecs.BOM_UTF8,)), \
+('utf-16', (codecs.BOM_UTF16_LE, codecs.BOM_UTF16_BE)), \
+('utf-32', (codecs.BOM_UTF32_LE, codecs.BOM_UTF32_BE)):
+if any(file_data.startswith(bom) for bom in boms):
+is_startswith_bom = True
+enc = encoding
+
+# Check if string is binary
+is_binary = is_binary_string(file_data)
+
+except IOError as ex:
+status = False
+# we don't want to expose real path of file
+# so only show error message.
+if ex.strerror == 'Permission denied':
+err_msg = u"Error: {0}".format(ex.strerror)
+else:
+err_msg = u"Error: {0}".format(str(ex))
+
+except Exception as ex:
+status = False
+err_msg = u"Error: {0}".format(str(ex))
+
+return status, err_msg, is_binary, is_startswith_bom, enc
+
 def addfolder(self, path, name):
 """
 Functionality to create new folder
diff --git a/web/pgadmin/tools/sqleditor/__init__.py 
b/web/pgadmin/tools/sqleditor/__init__.py
index 2d1d4e5..6431b3a 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -12,6 +12,7 @@ import simplejson as json
 import os
 import pickle
 import random
+import codecs
 
 from flask import Response, url_for, render_template, session, request
 from flask_babel import gettext
@@ -1220,7 +1221,10 @@ def load_file():
 
 file_path = unquote(file_data['file_name'])
 if hasattr(str, 'decode'):
-file_path = 
unquote(file_data['file_name']).encode('utf-8').decode('utf-8')
+file_path = unquote(
+file_data['file_name']
+).encode('utf-8').decode('utf-8')
+
 # retrieve storage directory path
 storage_manager_path = get_storage_directory()
 if storage_manager_path:
@@ -1230,45 +1234,27 @@ def load_file():
 file_path.lstrip('/').lstrip('\\')
 )
 
-file_data = None
+status, err_msg, is_binary, \
+is_startswith_bom, enc = Filemanager.check_file_for_bom_and_binary(
+file_path
+)
 
-# check if file type is text or binary
-textchars = bytearray(
-[7, 8, 9, 10, 12, 13, 27]) + bytearray(
-range(0x20, 0x7f)) + bytearray(range(0x80, 0x100))
+if not status:
+return internal_server_error(
+errormsg=gettext(err_msg)
+)
 
-is_binary_string = lambda bytes: bool(
-bytes.translate(None, textchars)
-)
+if is_binary:
+return internal_server_error(
+errormsg=gettext("File type not supported")
+)
+
+with codecs.open(file_path, 'r', encoding=enc) as fileObj:
+data = fileObj.read()
 
-# read file
-try:
-with open(file_path, 'rb') as fileObj:
-is_binary = is_binary_string(fileObj.read(1024))
-

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel

Hi Dave,

Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar'
related compilation error in Qt4. BUT

Below compilation error is coming because we have not applied the latest
patch of webkit which was fixed in annulen/webkit repo which was raised at
below path.

https://github.com/annulen/webkit/issues/519

BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of
‘QWebPage’

 webviewPtr->page()->triggerAction(QWebPage::RequestClose);

To fix the above compilation error currently we have two solution.

   - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
   - Comment the below line temporary for compilation until we get the
   releases from annulen/webkit.

   webviewPtr->page()->triggerAction(QWebPage::RequestClose);

Other compilation issues, (Me and Akshay) will fix and commit it but need
your input on above issue.

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:02 PM, Dave Page 
wrote:

> It's running CentOS 7.3, with packages from EPEL:
>
> [dpage@jenkins ~]$ rpm -qa |grep qt
> qt5-qtbase-common-5.6.1-10.el7.noarch
> qt5-qtbase-devel-5.6.1-10.el7.x86_64
> qt-4.8.5-13.el7.x86_64
> qt5-qtbase-5.6.1-10.el7.x86_64
> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
> qt5-qtwebchannel-5.6.1-10.el7.x86_64
> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
> qt-devel-4.8.5-13.el7.x86_64
> qt-settings-19-23.5.el7.centos.noarch
> qt5-qtbase-gui-5.6.1-10.el7.x86_64
> qt5-qtlocation-5.6.1-10.el7.x86_64
> qt5-qtwebsockets-5.6.1-10.el7.x86_64
> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
> qtwebkit-2.3.4-6.el7.x86_64
> qt3-3.3.8b-51.el7.x86_64
> qt5-qtdeclarative-5.6.1-10.el7.x86_64
> qt5-rpm-macros-5.6.1-10.el7.noarch
> qtwebkit-devel-2.3.4-6.el7.x86_64
> qt-x11-4.8.5-13.el7.x86_64
> qt5-qtsensors-5.6.1-10.el7.x86_64
>
> On Tue, May 9, 2017 at 9:28 AM, Neel Patel 
> wrote:
>
>> Hi Dave,
>>
>> Yes, It looks like compilation fails on Qt4. We will fix this issue but
>> which version of Qt4 we are using in Jenkins ?
>>
>> Thanks,
>> Neel Patel
>>
>> On Tue, May 9, 2017 at 1:56 PM, Dave Page 
>> wrote:
>>
>>>
>>>
>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi

 On Tue, May 9, 2017 at 1:42 PM, Dave Page 
 wrote:

> This appears to have made Jenkins get all angry and red :-(
>
> https://jenkins.pgadmin.org/
>

We(Neel and I) have tested it and working fine.

>>>
>>> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>>>
>>>

>
> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks patch applied.
>>
>> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>>
>>> Akshay, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>>> neel.pa...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached patch file with the fix of RM #2328 -
 [Runtime]: Unable to launch query tool and debugger in new browser tab.

 I have used Qt 5.8 with webkit mentioned in below URL.

 https://github.com/annulen/webkit/releases


 As there was a bug in QWebKit regarding "unload" event. We have
 raised and also they have provided patch file to fix this issue. I have
 applied the patch in linux and compile the webkit and tested the 
 attached
 patch with compiled webkit which is now working fine.

 Below is the link for reference regarding unload issue. They have
 provided test webkit release for Mac in below URL but for other 
 platform we
 need to apply the patch and compile the webkit until they provide
 webkit-releases for all platforms.

 https://github.com/annulen/webkit/issues/519

 Do review it and let me know in case of any issue.

 Thanks,
 Neel Patel


 --
 Sent via pgadmin-hackers mailing list (
 pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>> 976-788-8246 <+91%2097678%2088246>*
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
>

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Dave Page

It's running CentOS 7.3, with packages from EPEL:

[dpage@jenkins ~]$ rpm -qa |grep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
qt5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
qt5-qtwebchannel-5.6.1-10.el7.x86_64
qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
qt-devel-4.8.5-13.el7.x86_64
qt-settings-19-23.5.el7.centos.noarch
qt5-qtbase-gui-5.6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86_64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.1-10.el7.x86_64
qt5-rpm-macros-5.6.1-10.el7.noarch
qtwebkit-devel-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017 at 9:28 AM, Neel Patel 
wrote:

> Hi Dave,
>
> Yes, It looks like compilation fails on Qt4. We will fix this issue but
> which version of Qt4 we are using in Jenkins ?
>
> Thanks,
> Neel Patel
>
> On Tue, May 9, 2017 at 1:56 PM, Dave Page 
> wrote:
>
>>
>>
>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page 
>>> wrote:
>>>
 This appears to have made Jenkins get all angry and red :-(

 https://jenkins.pgadmin.org/

>>>
>>>We(Neel and I) have tested it and working fine.
>>>
>>
>> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>>
>>
>>>

 On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks patch applied.
>
> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>
>> Akshay, could you review this please?
>>
>> Thanks.
>>
>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>> neel.pa...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch file with the fix of RM #2328 -
>>> [Runtime]: Unable to launch query tool and debugger in new browser tab.
>>>
>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>
>>> https://github.com/annulen/webkit/releases
>>>
>>>
>>> As there was a bug in QWebKit regarding "unload" event. We have
>>> raised and also they have provided patch file to fix this issue. I have
>>> applied the patch in linux and compile the webkit and tested the 
>>> attached
>>> patch with compiled webkit which is now working fine.
>>>
>>> Below is the link for reference regarding unload issue. They have
>>> provided test webkit release for Mac in below URL but for other 
>>> platform we
>>> need to apply the patch and compile the webkit until they provide
>>> webkit-releases for all platforms.
>>>
>>> https://github.com/annulen/webkit/issues/519
>>>
>>> Do review it and let me know in case of any issue.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hack...@postgresql.or
>>> g)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
> 976-788-8246 <+91%2097678%2088246>*
>



 --
 Dave Page
 VP, Chief Architect, Tools & Installers
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel

Hi Dave,

Yes, It looks like compilation fails on Qt4. We will fix this issue but
which version of Qt4 we are using in Jenkins ?

Thanks,
Neel Patel

On Tue, May 9, 2017 at 1:56 PM, Dave Page 
wrote:

>
>
> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Tue, May 9, 2017 at 1:42 PM, Dave Page 
>> wrote:
>>
>>> This appears to have made Jenkins get all angry and red :-(
>>>
>>> https://jenkins.pgadmin.org/
>>>
>>
>>We(Neel and I) have tested it and working fine.
>>
>
> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>
>
>>
>>>
>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks patch applied.

 On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:

> Akshay, could you review this please?
>
> Thanks.
>
> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
> neel.pa...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>> Unable to launch query tool and debugger in new browser tab.
>>
>> I have used Qt 5.8 with webkit mentioned in below URL.
>>
>> https://github.com/annulen/webkit/releases
>>
>>
>> As there was a bug in QWebKit regarding "unload" event. We have
>> raised and also they have provided patch file to fix this issue. I have
>> applied the patch in linux and compile the webkit and tested the attached
>> patch with compiled webkit which is now working fine.
>>
>> Below is the link for reference regarding unload issue. They have
>> provided test webkit release for Mac in below URL but for other platform 
>> we
>> need to apply the patch and compile the webkit until they provide
>> webkit-releases for all platforms.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> Do review it and let me know in case of any issue.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
>> )
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



 --
 *Akshay Joshi*
 *Principal Software Engineer *



 *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
 976-788-8246 <+91%2097678%2088246>*

>>>
>>>
>>>
>>> --
>>> Dave Page
>>> VP, Chief Architect, Tools & Installers
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Dave Page

On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi 
wrote:

> Hi
>
> On Tue, May 9, 2017 at 1:42 PM, Dave Page 
> wrote:
>
>> This appears to have made Jenkins get all angry and red :-(
>>
>> https://jenkins.pgadmin.org/
>>
>
>We(Neel and I) have tested it and working fine.
>

It clearly doesn't compile on QT4. Please review the Jenkins logs.


>
>>
>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>>>
 Akshay, could you review this please?

 Thanks.

 On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch file with the fix of RM #2328 - [Runtime]:
> Unable to launch query tool and debugger in new browser tab.
>
> I have used Qt 5.8 with webkit mentioned in below URL.
>
> https://github.com/annulen/webkit/releases
>
>
> As there was a bug in QWebKit regarding "unload" event. We have raised
> and also they have provided patch file to fix this issue. I have applied
> the patch in linux and compile the webkit and tested the attached patch
> with compiled webkit which is now working fine.
>
> Below is the link for reference regarding unload issue. They have
> provided test webkit release for Mac in below URL but for other platform 
> we
> need to apply the patch and compile the webkit until they provide
> webkit-releases for all platforms.
>
> https://github.com/annulen/webkit/issues/519
>
> Do review it and let me know in case of any issue.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] Autoformatting

2017-05-09 Thread Dave Page

On Mon, May 8, 2017 at 3:50 PM, Robert Eckhardt 
wrote:

> Over the weekend I created some options for formatting. certainly this
> isn't complete but I hope it is a good starting point for the conversation.
> Copy and paste lost syntax highlighting but please assume that will be
> included.
>
> /* Unformatted  */
>
> select distinct dep.deptype,dep.classid,coalesce(coc.relname,
> clrw.relname) as
> ownertable from pg_depend dep left join pg_class cl on dep.objid = cl.oid
> left join pg_attribute att on dep.objid = att.attrelid and dep.objsubid =
> att.attnum
> where dep.objid = 16385 :: oid and classid in (select oid from pg_class
> where relname in ( 'pg_class', 'pg_constraint' )) order by
> classid,cl.relkin;
>
>
> /* Keywords Upper, Stacked, commas after */
>
> SELECT DISTINCT dep.deptype,
> dep.classid,
> Coalesce(coc.relname, clrw.relname) AS ownertable
> FROM   pg_depend dep
>left join pg_class cl
>   ON dep.objid = cl.oid
>left join pg_attribute att
>   ON dep.objid = att.attrelid
>  AND dep.objsubid = att.attnum
> WHERE  dep.objid = 16385 :: oid
>AND classid IN (SELECT oid
>FROM   pg_class
>WHERE  relname IN ( 'pg_class', 'pg_constraint' ))
> ORDER  BY classid,
>   cl.relkin;
>

Snipping the rest, as I think 'commas before' are the work of Chthulu.
Aside from the fact that they look ugly, the whole point of a comma is to
denote a pause/separation after a word.

Anyhoo, The standard we try to use in pgAdmin at the moment is slightly
different from the example you've given. To add it into the mix...

/* Keywords Upper, 4 space indent, commas after, AND/OR after,
 * no spaces after ( or before ), or around ::
 */
SELECT DISTINCT
dep.deptype,
dep.classid,
coalesce(coc.relname, clrw.relname) AS ownertable
FROM
pg_depend dep
LEFT JOIN pg_class cl ON dep.objid = cl.oid
LEFT JOIN pg_attribute att ON dep.objid = att.attrelid AND dep.objsubid
= att.attnum
WHERE
dep.objid = 16385::oid AND
classid IN (
SELECT
oid
FROM
pg_class
WHERE
relname IN ('pg_class', 'pg_constraint')
)
ORDER BY
classid,
cl.relkind;

There are some subtleties that are open to personal taste there;

- Formatting of the sub-select - e.g. should the SELECT directly follow the
(, and should the rest be indented accordingly?

- Formatting of multiple quals in the joins; e.g. should the qual following
the AND be on the next line, and if so, should it be indented one level, or
to align with the qual above? Should the first qual be on the next line?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Akshay Joshi

Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page 
wrote:

> This appears to have made Jenkins get all angry and red :-(
>
> https://jenkins.pgadmin.org/
>

   We(Neel and I) have tested it and working fine.

>
>
> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks patch applied.
>>
>> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>>
>>> Akshay, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel >> > wrote:
>>>
 Hi,

 Please find attached patch file with the fix of RM #2328 - [Runtime]:
 Unable to launch query tool and debugger in new browser tab.

 I have used Qt 5.8 with webkit mentioned in below URL.

 https://github.com/annulen/webkit/releases

 As there was a bug in QWebKit regarding "unload" event. We have raised
 and also they have provided patch file to fix this issue. I have applied
 the patch in linux and compile the webkit and tested the attached patch
 with compiled webkit which is now working fine.

 Below is the link for reference regarding unload issue. They have
 provided test webkit release for Mac in below URL but for other platform we
 need to apply the patch and compile the webkit until they provide
 webkit-releases for all platforms.

 https://github.com/annulen/webkit/issues/519

 Do review it and let me know in case of any issue.

 Thanks,
 Neel Patel

 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

-- 
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Dave Page

This appears to have made Jenkins get all angry and red :-(

https://jenkins.pgadmin.org/

On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi 
wrote:

> Thanks patch applied.
>
> On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:
>
>> Akshay, could you review this please?
>>
>> Thanks.
>>
>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel 
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>>> Unable to launch query tool and debugger in new browser tab.
>>>
>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>
>>> https://github.com/annulen/webkit/releases
>>>
>>>
>>> As there was a bug in QWebKit regarding "unload" event. We have raised
>>> and also they have provided patch file to fix this issue. I have applied
>>> the patch in linux and compile the webkit and tested the attached patch
>>> with compiled webkit which is now working fine.
>>>
>>> Below is the link for reference regarding unload issue. They have
>>> provided test webkit release for Mac in below URL but for other platform we
>>> need to apply the patch and compile the webkit until they provide
>>> webkit-releases for all platforms.
>>>
>>> https://github.com/annulen/webkit/issues/519
>>>
>>> Do review it and let me know in case of any issue.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Akshay Joshi

Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page  wrote:

> Akshay, could you review this please?
>
> Thanks.
>
> On Fri, May 5, 2017 at 11:53 AM, Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>> Unable to launch query tool and debugger in new browser tab.
>>
>> I have used Qt 5.8 with webkit mentioned in below URL.
>>
>> https://github.com/annulen/webkit/releases
>>
>>
>> As there was a bug in QWebKit regarding "unload" event. We have raised
>> and also they have provided patch file to fix this issue. I have applied
>> the patch in linux and compile the webkit and tested the attached patch
>> with compiled webkit which is now working fine.
>>
>> Below is the link for reference regarding unload issue. They have
>> provided test webkit release for Mac in below URL but for other platform we
>> need to apply the patch and compile the webkit until they provide
>> webkit-releases for all platforms.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> Do review it and let me know in case of any issue.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2328

2017-05-09 Thread Akshay Joshi

Fixes #2328
 1) Fixed issue of opening Query Tool and Debugger in new Tab with QT 5.8 and 
annulen webkit
 2) Moved unload event of window from javascript files to html.
 3) Change alertify messages for debugger.
 4) Closed all connections created by debugger. Previously only one connection 
has been closed.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d0e9c82feaaa5d6b8face6b04f1fc8fddefc3507
Author: Neel Patel 

Modified Files
--
runtime/BrowserWindow.cpp  | 108 -
runtime/BrowserWindow.h|  35 ---
runtime/WebViewWindow.cpp  |  44 +
runtime/WebViewWindow.h|  19 
.../tools/datagrid/templates/datagrid/index.html   |   7 ++
.../datagrid/templates/datagrid/js/datagrid.js |  22 +
web/pgadmin/tools/debugger/__init__.py |  30 ++
.../tools/debugger/templates/debugger/direct.html  |  28 +++---
.../debugger/templates/debugger/js/debugger.js |  22 +
.../debugger/templates/debugger/js/debugger_ui.js  |  11 +--
.../tools/debugger/templates/debugger/js/direct.js |  99 ---
11 files changed, 292 insertions(+), 133 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #216

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #98

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #107

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #100

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #98

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #97

[pgadmin-hackers] pgAdmin 4 commit: Relax version dependency on psycopg2

Re: [pgadmin-hackers] Relax version dependency on psycopg2

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #106

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #99

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #99

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

[pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] Autoformatting

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2328

30 matches

Site Navigation

Mail list logo

Footer information