Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

2017-05-15 Thread Murtuza Zabuawala 
++ Attaching patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 16, 2017 at 12:20 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue in FTS dictionary as below,
> 1) Strip the quotes from the options.
> 2) Template is not shown in properties views if it is not in a system
> schema.
> RM#1126
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_1126.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

2017-05-15 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue in FTS dictionary as below,
1) Strip the quotes from the options.
2) Template is not shown in properties views if it is not in a system
schema.
RM#1126

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-15 Thread Matthew Kleiman 
Hey Merlin

Yes, we are using the 6pac fork. We've found Ben (6pac) to be very
responsive. He accepted two PRs we wrote to the SlickGrid in a very timely
manner.

Thanks,
Matt

On Mon, May 15, 2017 at 4:46 PM Merlin Moncure  wrote:

> On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira
>  wrote:
> > Hello Hackers
> >
> > We upgraded SlickGrid to the latest version + 53ee34. We upgraded since
> we
> > are working on some changes to the query results functionality, including
> > improvements to column selection and shortcuts.
> >
> > This SlickGrid upgrade includes a PR we wrote that simplifies some of
> these
> > changes.
> >
> > Please note that we are not requesting this be included in the 1.5
> release.
> >
> > Thanks!
> > Joao and George
>
> hm, curious if you've moved off the mostly abandoned main fork
> (https://github.com/mleibman/SlickGrid) to the currently active one
> (https://github.com/6pac/SlickGrid)...
>
> merlin
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-15 Thread Merlin Moncure 
On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hello Hackers
>
> We upgraded SlickGrid to the latest version + 53ee34. We upgraded since we
> are working on some changes to the query results functionality, including
> improvements to column selection and shortcuts.
>
> This SlickGrid upgrade includes a PR we wrote that simplifies some of these
> changes.
>
> Please note that we are not requesting this be included in the 1.5 release.
>
> Thanks!
> Joao and George

hm, curious if you've moved off the mostly abandoned main fork
(https://github.com/mleibman/SlickGrid) to the currently active one
(https://github.com/6pac/SlickGrid)...

merlin


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-05-15 Thread Harshal Dhumal 
Hi,

On Sat, May 13, 2017 at 12:35 AM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> We were only able to apply the patch on 1f903ba2 (were seeing patch does
> not apply due to sqleditor.js conflicts)
> The javascript tests passed, but we were unable to copy rows or columns or
> cells when running the application. Could you run feature tests?
>
There are three modes sqleditor can be launched
1. Query tool  (Tools menus -> Query Tool)
2. Datagrid.  (Right click on any table/view  -> View Data -> View
All/First 100/Last 100/Filtered rows)
3. Scripts (Right click on any table/view ->
INSERT/CREATE/UPDATE/DELETE/SELECT)

Paste functionality is only enabled in Datagrid and table has Primary key
otherwise it's disabled. In your case row might have been copied but you
were unable paste because you might be trying to paste the rows in Query
tool. Please try again in Datagrid with table having Primary key.


>
> Now that more functionality is being added to sqleditor.js, this may be a
> good time to extract the functionality to separate files. This will
> increase readability, and encourage separation of concerns. It will also
> make changes easier to test in isolation.
>
Ok. Let me check if I can separate out ant functionalities.


> It's probably a good idea to test the changes made to the python as well
> as javascript code. In this case, the new behavior of poll() in sqleditor
> __init__ should be tested.
>

At this point we don't have any python unit tests that can test sqleditor
backend (python code).
@Dave should I include python unit test cases in this patch?


>
> --Joao and George
>
>
> On Fri, May 12, 2017 at 8:32 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Here is rebased patch.
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, May 12, 2017 at 1:28 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Pls find updated patch for on demand loading feature.
>>>
>>> Changes:
>>> 1. Added row number.
>>> 2. load renaming result set if user performs select all operation either
>>> on grid or column.
>>> 3. Fixed Row selection issue and row past issue.
>>> 4. Updated existing jasmine test cases.
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, May 9, 2017 at 10:02 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear 
 wrote:

> Hi Harshal!
>
> We applied your patch and ran the Javascript tests and realized there
> are 6 tests failing. After that we replicate the failures by hand and 
> found
> the following issues:
>
> - Clicking in the checkboxes of the rows does not select the row
> anymore.
> - When copying and pasting (any) data, we realized that it copied an
> empty dataset.
>
> Thanks for pointing out these issues. I have fixed them at my end and
 also remaining tests are failing because in earlier implementation of sql
 editor we have used pain 2Darray to provide data to slick grid and In this
 patch I have used Slick grid DataView
  to provide data
 to slick gird. I'll need to update test cases to support this DataView
 change. I'll send updated patch with all of the above changes along with
 suggestion given by Dave.



> We didn't review the patch further because there aren't any tests for
> the newly implemented functionality.
>
> Is there a place to find a dataset with 96k rows that you guys were
> testing with?
>

 Execute below SQL queries to create table dummy_data  with dataset of
 100k records. (you can change number of records to generate by replacing
 10 in below SQL query)



 *CREATE TABLE public.dummy_data*
 *(*
 *   id serial NOT NULL, *
 *   name text*
 *) *
 *WITH (*
 *  OIDS = FALSE*
 *)*
 *;*
 *ALTER TABLE public.dummy_data*
 *  OWNER TO postgres;*


 *INSERT INTO public.dummy_data(*
 *id, name)*
 * SELECT generate_series(1,10), 'dummy name';*







>
> Note: To run the Javascript test you can use the following commands
> ```
> $ cd web
> $ yarn install
> $ yarn run karma start --single-run
> ```
>
> Thanks
> Joao & Sarah
>
> On Mon, May 8, 2017 at 9:16 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> --
>>

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Joao Pedro De Almeida Pereira 
We were commenting on the disabled state of the copy button, so nevermind/
we are currently working on an update to the copy functionality of the grid.
Thanks for the fixes!

On Mon, May 15, 2017 at 1:31 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> The array temp_new_rows is used to keep track to new added rows in View
> data. It is used to add 'disabled_row'class for new rows to highlight
> when grid renders after delete/copy/add row operation.
>
> Please find attached patch.
>
> On Mon, May 15, 2017 at 10:14 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> The single cell selection works for me using Cmd+C. Not reproducible for
>> me.
>>
>> Please provide steps to reproduce.
>>
>>
>>
>>
>> On Mon, May 15, 2017 at 9:58 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Issue caused because variable temp_new_rows was access before it was
>>> initialised. Attached patch fixes this issue.
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, May 15, 2017 at 9:28 PM, Dave Page  wrote:
>>>
 Aww, nuts. I thought we had tests for that? Did we miss that particular
 case?

 Anyway, copying of a single value still works (with Cmd+C), so I'm not
 inclined to re-wrap everything for this unless someone can get a patch to
 me by ~9AM UK time tomorrow. Surinder?

 On Mon, May 15, 2017 at 4:50 PM, Joao Pedro De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi hackers,
>
> We were checking out the selection functionality after this
> commit--looks like selection no longer works for single cells.
>
> If you press a cell in the grid the following message is console
> logged:
>
> sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of 
> undefined
> at SlickGrid. (sqleditor.js:869)
> at Event.notify (slick.core.js:143)
> at trigger (slick.grid.js:1067)
> at setActiveCellInternal (slick.grid.js:2693)
> at HTMLDivElement.handleClick (slick.grid.js:2469)
> at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
> at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
> at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)
>
> ​
>
> Thanks
> George & Joao
>
> On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:
>
>> I've committed a modified version of this patch following some
>> discussion on IM with Surinder.
>>
>> Thanks Surinder!
>>
>> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> The regression test cases for 'copy row' was failing.
>>> This patch was assuming that each selected row will have primary key
>>> due to selection was not working. Fixed.
>>>
>>> Please find revised patch.
>>>
>>> Thanks
>>> Surinder Kumar
>>>
>>> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi,

 This patch contains following changes:

 1) When a new row is added, allow to delete if changes are not
 saved.

 2) Disable new row selection if primary key is not given but
 changes are saved on server.

 3) Copy and paste one or more rows, then add new row doesn't
 work(entered value doesn't appear).

 4) After deleting a row, add new row doesn't work.

 5) New row added with explicitly given primary key should not
 disabled.


 Please review.

 Thanks,
 Surinder Kumar

>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hack...@postgresql.or
>>> g)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Surinder Kumar 
Hi,

The array temp_new_rows is used to keep track to new added rows in View
data. It is used to add 'disabled_row'class for new rows to highlight when
grid renders after delete/copy/add row operation.

Please find attached patch.

On Mon, May 15, 2017 at 10:14 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Joao,
>
> The single cell selection works for me using Cmd+C. Not reproducible for
> me.
>
> Please provide steps to reproduce.
>
>
>
>
> On Mon, May 15, 2017 at 9:58 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Issue caused because variable temp_new_rows was access before it was
>> initialised. Attached patch fixes this issue.
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, May 15, 2017 at 9:28 PM, Dave Page  wrote:
>>
>>> Aww, nuts. I thought we had tests for that? Did we miss that particular
>>> case?
>>>
>>> Anyway, copying of a single value still works (with Cmd+C), so I'm not
>>> inclined to re-wrap everything for this unless someone can get a patch to
>>> me by ~9AM UK time tomorrow. Surinder?
>>>
>>> On Mon, May 15, 2017 at 4:50 PM, Joao Pedro De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hi hackers,

 We were checking out the selection functionality after this
 commit--looks like selection no longer works for single cells.

 If you press a cell in the grid the following message is console logged:

 sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of 
 undefined
 at SlickGrid. (sqleditor.js:869)
 at Event.notify (slick.core.js:143)
 at trigger (slick.grid.js:1067)
 at setActiveCellInternal (slick.grid.js:2693)
 at HTMLDivElement.handleClick (slick.grid.js:2469)
 at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
 at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
 at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)

 ​

 Thanks
 George & Joao

 On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:

> I've committed a modified version of this patch following some
> discussion on IM with Surinder.
>
> Thanks Surinder!
>
> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> The regression test cases for 'copy row' was failing.
>> This patch was assuming that each selected row will have primary key
>> due to selection was not working. Fixed.
>>
>> Please find revised patch.
>>
>> Thanks
>> Surinder Kumar
>>
>> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> This patch contains following changes:
>>>
>>> 1) When a new row is added, allow to delete if changes are not saved.
>>>
>>> 2) Disable new row selection if primary key is not given but changes
>>> are saved on server.
>>>
>>> 3) Copy and paste one or more rows, then add new row doesn't
>>> work(entered value doesn't appear).
>>>
>>> 4) After deleting a row, add new row doesn't work.
>>>
>>> 5) New row added with explicitly given primary key should not
>>> disabled.
>>>
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
>> )
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


track_new_rows_minor_fix.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Surinder Kumar 
Hi Joao,

The single cell selection works for me using Cmd+C. Not reproducible for me.

Please provide steps to reproduce.




On Mon, May 15, 2017 at 9:58 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Issue caused because variable temp_new_rows was access before it was
> initialised. Attached patch fixes this issue.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 9:28 PM, Dave Page  wrote:
>
>> Aww, nuts. I thought we had tests for that? Did we miss that particular
>> case?
>>
>> Anyway, copying of a single value still works (with Cmd+C), so I'm not
>> inclined to re-wrap everything for this unless someone can get a patch to
>> me by ~9AM UK time tomorrow. Surinder?
>>
>> On Mon, May 15, 2017 at 4:50 PM, Joao Pedro De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi hackers,
>>>
>>> We were checking out the selection functionality after this
>>> commit--looks like selection no longer works for single cells.
>>>
>>> If you press a cell in the grid the following message is console logged:
>>>
>>> sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of 
>>> undefined
>>> at SlickGrid. (sqleditor.js:869)
>>> at Event.notify (slick.core.js:143)
>>> at trigger (slick.grid.js:1067)
>>> at setActiveCellInternal (slick.grid.js:2693)
>>> at HTMLDivElement.handleClick (slick.grid.js:2469)
>>> at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
>>> at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
>>> at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)
>>>
>>> ​
>>>
>>> Thanks
>>> George & Joao
>>>
>>> On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:
>>>
 I've committed a modified version of this patch following some
 discussion on IM with Surinder.

 Thanks Surinder!

 On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> The regression test cases for 'copy row' was failing.
> This patch was assuming that each selected row will have primary key
> due to selection was not working. Fixed.
>
> Please find revised patch.
>
> Thanks
> Surinder Kumar
>
> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> This patch contains following changes:
>>
>> 1) When a new row is added, allow to delete if changes are not saved.
>>
>> 2) Disable new row selection if primary key is not given but changes
>> are saved on server.
>>
>> 3) Copy and paste one or more rows, then add new row doesn't
>> work(entered value doesn't appear).
>>
>> 4) After deleting a row, add new row doesn't work.
>>
>> 5) New row added with explicitly given primary key should not
>> disabled.
>>
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Harshal Dhumal 
Hi,

Issue caused because variable temp_new_rows was access before it was
initialised. Attached patch fixes this issue.

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 9:28 PM, Dave Page  wrote:

> Aww, nuts. I thought we had tests for that? Did we miss that particular
> case?
>
> Anyway, copying of a single value still works (with Cmd+C), so I'm not
> inclined to re-wrap everything for this unless someone can get a patch to
> me by ~9AM UK time tomorrow. Surinder?
>
> On Mon, May 15, 2017 at 4:50 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi hackers,
>>
>> We were checking out the selection functionality after this commit--looks
>> like selection no longer works for single cells.
>>
>> If you press a cell in the grid the following message is console logged:
>>
>> sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of 
>> undefined
>> at SlickGrid. (sqleditor.js:869)
>> at Event.notify (slick.core.js:143)
>> at trigger (slick.grid.js:1067)
>> at setActiveCellInternal (slick.grid.js:2693)
>> at HTMLDivElement.handleClick (slick.grid.js:2469)
>> at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
>> at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
>> at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)
>>
>> ​
>>
>> Thanks
>> George & Joao
>>
>> On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:
>>
>>> I've committed a modified version of this patch following some
>>> discussion on IM with Surinder.
>>>
>>> Thanks Surinder!
>>>
>>> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi

 The regression test cases for 'copy row' was failing.
 This patch was assuming that each selected row will have primary key
 due to selection was not working. Fixed.

 Please find revised patch.

 Thanks
 Surinder Kumar

 On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> This patch contains following changes:
>
> 1) When a new row is added, allow to delete if changes are not saved.
>
> 2) Disable new row selection if primary key is not given but changes
> are saved on server.
>
> 3) Copy and paste one or more rows, then add new row doesn't
> work(entered value doesn't appear).
>
> 4) After deleting a row, add new row doesn't work.
>
> 5) New row added with explicitly given primary key should not disabled.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>



 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index f3ca7b0..82b966f 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1597,7 +1597,8 @@ define(
   self.explain_costs = false;
   self.explain_buffers = false;
   self.explain_timing = false;
-  self.is_new_browser_tab = is_new_browser_tab;
+  self.is_new_browser_tab = is_new_browser_tab
+  self.temp_new_rows = [];
 
   // We do not allow to call the start multiple times.
   if (self.gridView)

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Dave Page 
Aww, nuts. I thought we had tests for that? Did we miss that particular
case?

Anyway, copying of a single value still works (with Cmd+C), so I'm not
inclined to re-wrap everything for this unless someone can get a patch to
me by ~9AM UK time tomorrow. Surinder?

On Mon, May 15, 2017 at 4:50 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi hackers,
>
> We were checking out the selection functionality after this commit--looks
> like selection no longer works for single cells.
>
> If you press a cell in the grid the following message is console logged:
>
> sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of 
> undefined
> at SlickGrid. (sqleditor.js:869)
> at Event.notify (slick.core.js:143)
> at trigger (slick.grid.js:1067)
> at setActiveCellInternal (slick.grid.js:2693)
> at HTMLDivElement.handleClick (slick.grid.js:2469)
> at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
> at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
> at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)
>
> ​
>
> Thanks
> George & Joao
>
> On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:
>
>> I've committed a modified version of this patch following some discussion
>> on IM with Surinder.
>>
>> Thanks Surinder!
>>
>> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> The regression test cases for 'copy row' was failing.
>>> This patch was assuming that each selected row will have primary key due
>>> to selection was not working. Fixed.
>>>
>>> Please find revised patch.
>>>
>>> Thanks
>>> Surinder Kumar
>>>
>>> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi,

 This patch contains following changes:

 1) When a new row is added, allow to delete if changes are not saved.

 2) Disable new row selection if primary key is not given but changes
 are saved on server.

 3) Copy and paste one or more rows, then add new row doesn't
 work(entered value doesn't appear).

 4) After deleting a row, add new row doesn't work.

 5) New row added with explicitly given primary key should not disabled.


 Please review.

 Thanks,
 Surinder Kumar

>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Joao Pedro De Almeida Pereira 
Hi hackers,

We were checking out the selection functionality after this commit--looks
like selection no longer works for single cells.

If you press a cell in the grid the following message is console logged:

sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of undefined
at SlickGrid. (sqleditor.js:869)
at Event.notify (slick.core.js:143)
at trigger (slick.grid.js:1067)
at setActiveCellInternal (slick.grid.js:2693)
at HTMLDivElement.handleClick (slick.grid.js:2469)
at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)

​

Thanks
George & Joao

On Mon, May 15, 2017 at 10:05 AM, Dave Page  wrote:

> I've committed a modified version of this patch following some discussion
> on IM with Surinder.
>
> Thanks Surinder!
>
> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> The regression test cases for 'copy row' was failing.
>> This patch was assuming that each selected row will have primary key due
>> to selection was not working. Fixed.
>>
>> Please find revised patch.
>>
>> Thanks
>> Surinder Kumar
>>
>> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> This patch contains following changes:
>>>
>>> 1) When a new row is added, allow to delete if changes are not saved.
>>>
>>> 2) Disable new row selection if primary key is not given but changes are
>>> saved on server.
>>>
>>> 3) Copy and paste one or more rows, then add new row doesn't
>>> work(entered value doesn't appear).
>>>
>>> 4) After deleting a row, add new row doesn't work.
>>>
>>> 5) New row added with explicitly given primary key should not disabled.
>>>
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] pgAdmin 4 commit: Include backports.csv as a python dependency in the w

2017-05-15 Thread Dave Page 
Include backports.csv as a python dependency in the wheel.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4817b3774270dfa360dddec9f6d36e6b608984a1

Modified Files
--
pkg/pip/setup_pip.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #122

2017-05-15 Thread pgAdmin 4 Jenkins 
See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure all required directories are created before we

2017-05-15 Thread Dave Page 
Ensure all required directories are created before we start logging.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be42b67f790de7f5cc84b978c5a664ad1d515bd5

Modified Files
--
web/pgadmin/__init__.py | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #232

2017-05-15 Thread pgAdmin 4 Jenkins 
See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #121

2017-05-15 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Ensure that there's an __init__.py file present in the backports 
module

[Dave Page] Various improvements to the NULL/DEFAULT handling in the data 
editor.

--
[...truncated 254.43 KB...]
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_put.SchemaPutTestCase)
Check Schema Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_add.TypesAddTestCase)
Add type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_delete.TypesDeleteTestCase)
Delete type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_get.TypesGetTestCase)
Get type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_put.TypesUpdateTestCase)
Update type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTes

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Dave Page 
I've committed a modified version of this patch following some discussion
on IM with Surinder.

Thanks Surinder!

On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> The regression test cases for 'copy row' was failing.
> This patch was assuming that each selected row will have primary key due
> to selection was not working. Fixed.
>
> Please find revised patch.
>
> Thanks
> Surinder Kumar
>
> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> This patch contains following changes:
>>
>> 1) When a new row is added, allow to delete if changes are not saved.
>>
>> 2) Disable new row selection if primary key is not given but changes are
>> saved on server.
>>
>> 3) Copy and paste one or more rows, then add new row doesn't work(entered
>> value doesn't appear).
>>
>> 4) After deleting a row, add new row doesn't work.
>>
>> 5) New row added with explicitly given primary key should not disabled.
>>
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Various improvements to the NULL/DEFAULT handling in

2017-05-15 Thread Dave Page 
Various improvements to the NULL/DEFAULT handling in the data editor. Fixes 
#2399

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7d4bf475bc5b131d9a76376ebfc87e004d92333
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/tools/sqleditor/command.py |   7 +-
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 110 +
2 files changed, 95 insertions(+), 22 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure that there's an __init__.py file present in th

2017-05-15 Thread Dave Page 
Ensure that there's an __init__.py file present in the backports module 
directory on Windows

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa554eb767547a82d894025dfe1c141c157c6451

Modified Files
--
Make-MinGW.bat | 3 +++
1 file changed, 3 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #231

2017-05-15 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Mac build fixes:

--
[...truncated 257.36 KB...]
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.SchemaGetTestCase)
Check Schema Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_put.SchemaPutTestCase)
Check Schema Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_add.TypesAddTestCase)
Add type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_delete.TypesDeleteTestCase)
Delete type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_get.TypesGetTestCase)
Get type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_put.TypesUpdateTestCase)
Update type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
r

[pgadmin-hackers] pgAdmin 4 commit: Mac build fixes:

2017-05-15 Thread Dave Page 
Mac build fixes:

- Rebuild Python packages from scratch so we know what libraries they use
- Ensure the backports Python module has an __init__.py file.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=001e0ce1cf7e9cd5beb754a964810791b8089020

Modified Files
--
pkg/mac/build.sh | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure object names are properly escaped for external

2017-05-15 Thread Dave Page 
Ensure object names are properly escaped for external process management. Fixes 
#2405

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1cb2a62fa8cc130fcc6a64b5aa4f16e85cb397b6
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js |  2 +-
web/pgadmin/tools/backup/__init__.py  | 48 +--
web/pgadmin/tools/import_export/__init__.py   | 23 +++
web/pgadmin/utils/html.py | 14 ++-
4 files changed, 64 insertions(+), 23 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Bump version in preparation for release.

2017-05-15 Thread Dave Page 
Bump version in preparation for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0e78309cb413f76d5e7650e1f57e48de0ba

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
web/config.py| 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c

2017-05-15 Thread Dave Page 
While building runtime with QtWebEngine, we found 2 compilation errors which 
were introduced in a previous commit in runtime:

We set "setNetworkAccessManager" in WebEnginePage which was only required for 
Webkit so removed that statement.
"triggerAction" on WebPage is only required for Qt > 5 with WebKit only. Not 
required for WebEngine so added that condition.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07b06348ab487a54077e6fa3aaa16d25c51f6f82
Author: Neel Patel 

Modified Files
--
runtime/BrowserWindow.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine

2017-05-15 Thread Dave Page 
Thanks, applied.

On Mon, May 15, 2017 at 10:48 AM, Neel Patel 
wrote:

> Hi Dave,
>
> While building runtime with QtWebEngine, we found 2 compilation errors
> which was introduced due to previous commit in runtime.
>
>- We set "setNetworkAccessManager" in WebEnginePage which was only
>required for Webkit so removed that statement.
>- "triggerAction" on WebPage is only required for Qt > 5 with WebKit
>only. Not required for WebEngine so added that condition.
>
> Please find attached fix for the same. Do review it and let me know for
> any queries.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Surinder Kumar 
Hi

The regression test cases for 'copy row' was failing.
This patch was assuming that each selected row will have primary key due to
selection was not working. Fixed.

Please find revised patch.

Thanks
Surinder Kumar

On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> This patch contains following changes:
>
> 1) When a new row is added, allow to delete if changes are not saved.
>
> 2) Disable new row selection if primary key is not given but changes are
> saved on server.
>
> 3) Copy and paste one or more rows, then add new row doesn't work(entered
> value doesn't appear).
>
> 4) After deleting a row, add new row doesn't work.
>
> 5) New row added with explicitly given primary key should not disabled.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>


RM_2399_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine

2017-05-15 Thread Neel Patel 
Hi Dave,

While building runtime with QtWebEngine, we found 2 compilation errors
which was introduced due to previous commit in runtime.

   - We set "setNetworkAccessManager" in WebEnginePage which was only
   required for Webkit so removed that statement.
   - "triggerAction" on WebPage is only required for Qt > 5 with WebKit
   only. Not required for WebEngine so added that condition.

Please find attached fix for the same. Do review it and let me know for any
queries.

Thanks,
Neel Patel


QtWebEngine_Compilation_Fix.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Dave Page 
OK, that needs fixing then...

On Mon, May 15, 2017 at 9:59 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi Dave,
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 1:43 PM, Dave Page  wrote:
>
>> So is the last patch considered good?
>>
> Except one thing, when user renames server group (note that server group
> should never be expanded before renaming) and then expands it by clicking +
> icon then it's old name gets restored.
>
> Step:
> 1. Load application in browser.
> 2. Do not expand any of the server group.
> 3. Rename Server group (new name gets updated in tree).
> 4. Now expand Server group (old name gets restored in tree).
>
> Note that this happens only when Server groups was never expanded before.
>
>
>
>>
>> On Mon, May 15, 2017 at 9:11 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Yes, It is existing one only, We did not touch on any part of sorting
>>> algorithm in this patch.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, May 15, 2017 at 1:24 PM, Dave Page  wrote:
>>>
 Ashesh is out this week. As long as new nodes are sorted with the same
 algorithm as existing ones, that's fine.

 On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Harshal,
>
> We are using https://github.com/javve/natural-sort for sorting nodes
> which is implemented by Ashesh.
>
> @Ashesh,
> Any suggestion on this?
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> Currently nodes are sorted in case sensitive manner it should be case
>> insensitive.
>>
>>
>>
>> See current Server group order is A, Servers, a1, a​2. It should be A,
>> a1, a2, Servers.
>> Similarly check sorting order for server and database nodes
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> Please find updated patch as discussed.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 As discussed please find updated patch removing hardcoded check for
 server & server-group node.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> PFA updated patch for the issue.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page 
>> wrote:
>>
>>> Ashesh, can you review/commit this please? Thanks.
>>>
>>> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA minor patch to fix the issue where node rename is not
 working properly after 7dd9efd8
 
  commit
 .
 RM#2355

>>> We should remove the existing node, and then insert at right
>> place instead of refreshing the parent.
>> Because - that will select the parent node, and not that node,
>> and also - it adds overhead of refreshing the whole parent node.
>>
>> Please send the patch as per our discussion.
>>
>> -- Thanks, Ashesh
>>
>>>
 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page 
And... done.

On Mon, May 15, 2017 at 10:10 AM, Dave Page  wrote:

> Hi
>
> Hmm, OK - well I still can't reproduce it (using a table), but the change
> is clearly an appropriate check so I'll get it committed.
>
> Thanks.
>
> On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> As there were no proper steps given in RM to re-produce the issue, I
>> assumed that user tried to delete schema and then click on the table, hence
>> he got that error.
>> So I checked the code notice that validation was missing at a location of
>> error trace mentioned in RM, it assumed that we always get one row from
>> database.
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, May 15, 2017 at 1:57 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA minor patch to add object validation in table node for SQL and
 Properties tab .
 RM#2395

>>>
>>> I don't see how this relates to the issue reported which is related to
>>> dropping a schema containing a view (from what I can tell), whereas the
>>> patch is changing the table module.
>>>
>>> FWIW, I can't reproduce the reported issue either.
>>>
>>> Can you clarify please?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Validate table presence in SQL and Properties route h

2017-05-15 Thread Dave Page 
Validate table presence in SQL and Properties route handles. Fixes #2395

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ad14b379e0458fda10e3f710cb4d88c40425da3
Author: Murtuza Zabuawala 

Modified Files
--
.../server_groups/servers/databases/schemas/tables/__init__.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page 
Hi

Hmm, OK - well I still can't reproduce it (using a table), but the change
is clearly an appropriate check so I'll get it committed.

Thanks.

On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> As there were no proper steps given in RM to re-produce the issue, I
> assumed that user tried to delete schema and then click on the table, hence
> he got that error.
> So I checked the code notice that validation was missing at a location of
> error trace mentioned in RM, it assumed that we always get one row from
> database.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 1:57 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to add object validation in table node for SQL and
>>> Properties tab .
>>> RM#2395
>>>
>>
>> I don't see how this relates to the issue reported which is related to
>> dropping a schema containing a view (from what I can tell), whereas the
>> patch is changing the table module.
>>
>> FWIW, I can't reproduce the reported issue either.
>>
>> Can you clarify please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Harshal Dhumal 
Hi Dave,


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 1:43 PM, Dave Page  wrote:

> So is the last patch considered good?
>
Except one thing, when user renames server group (note that server group
should never be expanded before renaming) and then expands it by clicking +
icon then it's old name gets restored.

Step:
1. Load application in browser.
2. Do not expand any of the server group.
3. Rename Server group (new name gets updated in tree).
4. Now expand Server group (old name gets restored in tree).

Note that this happens only when Server groups was never expanded before.



>
> On Mon, May 15, 2017 at 9:11 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Yes, It is existing one only, We did not touch on any part of sorting
>> algorithm in this patch.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, May 15, 2017 at 1:24 PM, Dave Page  wrote:
>>
>>> Ashesh is out this week. As long as new nodes are sorted with the same
>>> algorithm as existing ones, that's fine.
>>>
>>> On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Harshal,

 We are using https://github.com/javve/natural-sort for sorting nodes
 which is implemented by Ashesh.

 @Ashesh,
 Any suggestion on this?

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Currently nodes are sorted in case sensitive manner it should be case
> insensitive.
>
>
>
> See current Server group order is A, Servers, a1, a​2. It should be A,
> a1, a2, Servers.
> Similarly check sorting order for server and database nodes
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> Please find updated patch as discussed.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> As discussed please find updated patch removing hardcoded check for
>>> server & server-group node.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 PFA updated patch for the issue.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

>
> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page 
> wrote:
>
>> Ashesh, can you review/commit this please? Thanks.
>>
>> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the issue where node rename is not
>>> working properly after 7dd9efd8
>>> 
>>>  commit
>>> .
>>> RM#2355
>>>
>> We should remove the existing node, and then insert at right
> place instead of refreshing the parent.
> Because - that will select the parent node, and not that node, and
> also - it adds overhead of refreshing the whole parent node.
>
> Please send the patch as per our discussion.
>
> -- Thanks, Ashesh
>
>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (
>>> pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgs

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Murtuza Zabuawala 
Hi Dave,

As there were no proper steps given in RM to re-produce the issue, I
assumed that user tried to delete schema and then click on the table, hence
he got that error.
So I checked the code notice that validation was missing at a location of
error trace mentioned in RM, it assumed that we always get one row from
database.



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 1:57 PM, Dave Page  wrote:

> Hi
>
> On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to add object validation in table node for SQL and
>> Properties tab .
>> RM#2395
>>
>
> I don't see how this relates to the issue reported which is related to
> dropping a schema containing a view (from what I can tell), whereas the
> patch is changing the table module.
>
> FWIW, I can't reproduce the reported issue either.
>
> Can you clarify please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page 
Hi

On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to add object validation in table node for SQL and
> Properties tab .
> RM#2395
>

I don't see how this relates to the issue reported which is related to
dropping a schema containing a view (from what I can tell), whereas the
patch is changing the table module.

FWIW, I can't reproduce the reported issue either.

Can you clarify please?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Dave Page 
So is the last patch considered good?

On Mon, May 15, 2017 at 9:11 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Yes, It is existing one only, We did not touch on any part of sorting
> algorithm in this patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 1:24 PM, Dave Page  wrote:
>
>> Ashesh is out this week. As long as new nodes are sorted with the same
>> algorithm as existing ones, that's fine.
>>
>> On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Harshal,
>>>
>>> We are using https://github.com/javve/natural-sort for sorting nodes
>>> which is implemented by Ashesh.
>>>
>>> @Ashesh,
>>> Any suggestion on this?
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi Murtuza,

 Currently nodes are sorted in case sensitive manner it should be case
 insensitive.



 See current Server group order is A, Servers, a1, a​2. It should be A,
 a1, a2, Servers.
 Similarly check sorting order for server and database nodes


 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> Please find updated patch as discussed.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> As discussed please find updated patch removing hardcoded check for
>> server & server-group node.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> PFA updated patch for the issue.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>

 On Mon, Apr 24, 2017 at 4:43 PM, Dave Page 
 wrote:

> Ashesh, can you review/commit this please? Thanks.
>
> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the issue where node rename is not working
>> properly after 7dd9efd8
>> 
>>  commit
>> .
>> RM#2355
>>
> We should remove the existing node, and then insert at right place
 instead of refreshing the parent.
 Because - that will select the parent node, and not that node, and
 also - it adds overhead of refreshing the whole parent node.

 Please send the patch as per our discussion.

 -- Thanks, Ashesh

>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (
>> pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Murtuza Zabuawala 
Hi Dave,

Yes, It is existing one only, We did not touch on any part of sorting
algorithm in this patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 1:24 PM, Dave Page  wrote:

> Ashesh is out this week. As long as new nodes are sorted with the same
> algorithm as existing ones, that's fine.
>
> On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Harshal,
>>
>> We are using https://github.com/javve/natural-sort for sorting nodes
>> which is implemented by Ashesh.
>>
>> @Ashesh,
>> Any suggestion on this?
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> Currently nodes are sorted in case sensitive manner it should be case
>>> insensitive.
>>>
>>>
>>>
>>> See current Server group order is A, Servers, a1, a​2. It should be A,
>>> a1, a2, Servers.
>>> Similarly check sorting order for server and database nodes
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 Please find updated patch as discussed.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> As discussed please find updated patch removing hardcoded check for
> server & server-group node.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> PFA updated patch for the issue.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>>
>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page 
>>> wrote:
>>>
 Ashesh, can you review/commit this please? Thanks.

 On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where node rename is not working
> properly after 7dd9efd8
> 
>  commit
> .
> RM#2355
>
 We should remove the existing node, and then insert at right place
>>> instead of refreshing the parent.
>>> Because - that will select the parent node, and not that node, and
>>> also - it adds overhead of refreshing the whole parent node.
>>>
>>> Please send the patch as per our discussion.
>>>
>>> -- Thanks, Ashesh
>>>

> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (
> pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Dave Page 
Ashesh is out this week. As long as new nodes are sorted with the same
algorithm as existing ones, that's fine.

On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Harshal,
>
> We are using https://github.com/javve/natural-sort for sorting nodes
> which is implemented by Ashesh.
>
> @Ashesh,
> Any suggestion on this?
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> Currently nodes are sorted in case sensitive manner it should be case
>> insensitive.
>>
>>
>>
>> See current Server group order is A, Servers, a1, a​2. It should be A,
>> a1, a2, Servers.
>> Similarly check sorting order for server and database nodes
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> Please find updated patch as discussed.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 As discussed please find updated patch removing hardcoded check for
 server & server-group node.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> PFA updated patch for the issue.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page  wrote:
>>
>>> Ashesh, can you review/commit this please? Thanks.
>>>
>>> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA minor patch to fix the issue where node rename is not working
 properly after 7dd9efd8
 
  commit
 .
 RM#2355

>>> We should remove the existing node, and then insert at right place
>> instead of refreshing the parent.
>> Because - that will select the parent node, and not that node, and
>> also - it adds overhead of refreshing the whole parent node.
>>
>> Please send the patch as per our discussion.
>>
>> -- Thanks, Ashesh
>>
>>>
 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 --
 Sent via pgadmin-hackers mailing list (
 pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Murtuza Zabuawala 
Hi Harshal,

We are using https://github.com/javve/natural-sort for sorting nodes which
is implemented by Ashesh.

@Ashesh,
Any suggestion on this?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Currently nodes are sorted in case sensitive manner it should be case
> insensitive.
>
>
>
> See current Server group order is A, Servers, a1, a​2. It should be A,
> a1, a2, Servers.
> Similarly check sorting order for server and database nodes
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> Please find updated patch as discussed.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> As discussed please find updated patch removing hardcoded check for
>>> server & server-group node.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 PFA updated patch for the issue.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

>
> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page  wrote:
>
>> Ashesh, can you review/commit this please? Thanks.
>>
>> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the issue where node rename is not working
>>> properly after 7dd9efd8
>>> 
>>>  commit
>>> .
>>> RM#2355
>>>
>> We should remove the existing node, and then insert at right place
> instead of refreshing the parent.
> Because - that will select the parent node, and not that node, and
> also - it adds overhead of refreshing the whole parent node.
>
> Please send the patch as per our discussion.
>
> -- Thanks, Ashesh
>
>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hack...@postgresql.or
>>> g)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

>>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

[pgadmin-hackers] [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Surinder Kumar 
Hi,

This patch contains following changes:

1) When a new row is added, allow to delete if changes are not saved.

2) Disable new row selection if primary key is not given but changes are
saved on server.

3) Copy and paste one or more rows, then add new row doesn't work(entered
value doesn't appear).

4) After deleting a row, add new row doesn't work.

5) New row added with explicitly given primary key should not disabled.


Please review.

Thanks,
Surinder Kumar


RM_2399.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Harshal Dhumal 
Hi Murtuza,

Currently nodes are sorted in case sensitive manner it should be case
insensitive.



See current Server group order is A, Servers, a1, a​2. It should be A, a1,
a2, Servers.
Similarly check sorting order for server and database nodes


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> Please find updated patch as discussed.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> As discussed please find updated patch removing hardcoded check for
>> server & server-group node.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> PFA updated patch for the issue.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>

 On Mon, Apr 24, 2017 at 4:43 PM, Dave Page  wrote:

> Ashesh, can you review/commit this please? Thanks.
>
> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the issue where node rename is not working
>> properly after 7dd9efd8
>> 
>>  commit
>> .
>> RM#2355
>>
> We should remove the existing node, and then insert at right place
 instead of refreshing the parent.
 Because - that will select the parent node, and not that node, and also
 - it adds overhead of refreshing the whole parent node.

 Please send the patch as per our discussion.

 -- Thanks, Ashesh

>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
>> )
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>