Re: [pgadmin-hackers] New problem with the latest Kubuntu
On Thu, May 1, 2008 at 9:54 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I don't find any. Perhaps we can wait a bit. If nobody asks for it, there's > no urgent need. It'll give us time to test the dev release with my latest > commit. Does -Wno-write-strings do it? http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7252 - in trunk/pgadmin3: . pgadmin/frm
Author: dpage Date: 2008-05-02 09:59:36 +0100 (Fri, 02 May 2008) New Revision: 7252 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7252&view=rev Log: Update node text when refreshing treeview nodes in case part of the identifier has changed. Per Erwin. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/frm/frmMain.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by guillaume: r7255 - in branches/REL-1_8_0_PATCHES/pgadmin3: pgadmin xtra/pgagent
Author: guillaume Date: 2008-05-02 10:17:28 +0100 (Fri, 02 May 2008) New Revision: 7255 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7255&view=rev Log: Silence compiler warning with a CPPFLAG (-Wno-write-strings). Modified: branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/Makefile.am branches/REL-1_8_0_PATCHES/pgadmin3/xtra/pgagent/Makefile.am -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by guillaume: r7256 - in branches/REL-1_8_0_EDB/pgadmin3: pgadmin xtra/pgagent
Author: guillaume Date: 2008-05-02 10:17:56 +0100 (Fri, 02 May 2008) New Revision: 7256 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7256&view=rev Log: Silence compiler warning with a CPPFLAG (-Wno-write-strings). Modified: branches/REL-1_8_0_EDB/pgadmin3/pgadmin/Makefile.am branches/REL-1_8_0_EDB/pgadmin3/xtra/pgagent/Makefile.am -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] New problem with the latest Kubuntu
Dave Page a écrit : On Thu, May 1, 2008 at 9:54 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: I don't find any. Perhaps we can wait a bit. If nobody asks for it, there's no urgent need. It'll give us time to test the dev release with my latest commit. Does -Wno-write-strings do it? http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html You're right, it works now. I commited it (1.8 "standard" and EDB branches). Thanks. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7257 - trunk/pgadmin3/pgadmin/frm
Author: dpage Date: 2008-05-02 10:24:44 +0100 (Fri, 02 May 2008) New Revision: 7257 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7257&view=rev Log: Fix message formatting Modified: trunk/pgadmin3/pgadmin/frm/frmQuery.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7258 - branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/frm
Author: dpage Date: 2008-05-02 10:25:23 +0100 (Fri, 02 May 2008) New Revision: 7258 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7258&view=rev Log: Fix message formatting Modified: branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/frm/frmQuery.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7259 - branches/REL-1_8_0_EDB/pgadmin3/pgadmin/frm
Author: dpage Date: 2008-05-02 10:25:46 +0100 (Fri, 02 May 2008) New Revision: 7259 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7259&view=rev Log: Fix message formatting Modified: branches/REL-1_8_0_EDB/pgadmin3/pgadmin/frm/frmQuery.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] New problem with the latest Kubuntu
On Fri, May 2, 2008 at 10:19 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > You're right, it works now. I commited it (1.8 "standard" and EDB branches). Cool - thanks. And I should repeat, for the record, feel free to ignore the EDB branch if you like - I don't expect you to patch there as well, though I won't complain if you do :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7253 - in branches/REL-1_8_0_PATCHES/pgadmin3: . pgadmin/frm
Author: dpage Date: 2008-05-02 10:00:25 +0100 (Fri, 02 May 2008) New Revision: 7253 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7253&view=rev Log: Update node text when refreshing treeview nodes in case part of the identifier has changed. Per Erwin. Modified: branches/REL-1_8_0_PATCHES/pgadmin3/CHANGELOG branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/frm/frmMain.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7254 - in branches/REL-1_8_0_EDB/pgadmin3: . pgadmin/frm
Author: dpage Date: 2008-05-02 10:00:48 +0100 (Fri, 02 May 2008) New Revision: 7254 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7254&view=rev Log: Update node text when refreshing treeview nodes in case part of the identifier has changed. Per Erwin. Modified: branches/REL-1_8_0_EDB/pgadmin3/CHANGELOG branches/REL-1_8_0_EDB/pgadmin3/pgadmin/frm/frmMain.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Refresh issue in object tree
On Mon, Apr 28, 2008 at 7:44 PM, Erwin Brandstetter <[EMAIL PROTECTED]> wrote: > Hi developers! Hi Dave! > > Testing pgAdmin v.1.8.2 (Feb 5 2008), rev: 7050, on WinXP; host: pg 8.2.7 > and 8.3.1 on Debian Etch > > A refresh on a collection in the object tree updates all object names under > it, but a refresh on a single object fails to update its name (while the > definition in the SQL pane is updated like expected) > That feels counter-intuitive, one would expect the name to be included. It > also leads to a state where the object browser contradicts the SQL pane. > > I have tested this with trigger functions, functions, tables and views. So I > assume it is a general issue in the object tree. Yup, indeed - we never refresh the node text, we just recreate the nodes under the current one, or reassign the object data to the current node. I've committed a fix that will also update the text if the object isn't a collection. Thanks, Dave. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] New problem with the latest Kubuntu
On Fri, May 2, 2008 at 10:41 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I have no problem patching the EDB branch (when I'm allowed :) ). > You're always allowed - it's no different from any other stable branch in that sense. It's only really there to make my life easier as I needed to push out some new features for the build used in Postgres Plus earlier than they would have made the next community release. Thanks anyway :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] New problem with the latest Kubuntu
Dave Page a écrit : On Fri, May 2, 2008 at 10:19 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: You're right, it works now. I commited it (1.8 "standard" and EDB branches). Cool - thanks. And I should repeat, for the record, feel free to ignore the EDB branch if you like - I don't expect you to patch there as well, though I won't complain if you do :-) I have no problem patching the EDB branch (when I'm allowed :) ). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7260 - in trunk/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:14:58 +0100 (Fri, 02 May 2008) New Revision: 7260 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7260&view=rev Log: Prevent unsaved changes in the edit grid being lost if the filter or sorting dialogue is opened. Per Erwin. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/frm/frmEditGrid.cpp trunk/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7263 - in trunk/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:30:01 +0100 (Fri, 02 May 2008) New Revision: 7263 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7263&view=rev Log: Always refresh the data when the user clicks OK on the edit grid options dialogue to ensure the filter/sort is applied to current data. Per Erwin. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/frm/frmEditGrid.cpp trunk/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7264 - in branches/REL-1_8_0_PATCHES/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:30:45 +0100 (Fri, 02 May 2008) New Revision: 7264 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7264&view=rev Log: Always refresh the data when the user clicks OK on the edit grid options dialogue to ensure the filter/sort is applied to current data. Per Erwin. Modified: branches/REL-1_8_0_PATCHES/pgadmin3/CHANGELOG branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/frm/frmEditGrid.cpp branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7265 - in branches/REL-1_8_0_EDB/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:31:20 +0100 (Fri, 02 May 2008) New Revision: 7265 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7265&view=rev Log: Always refresh the data when the user clicks OK on the edit grid options dialogue to ensure the filter/sort is applied to current data. Per Erwin. Modified: branches/REL-1_8_0_EDB/pgadmin3/CHANGELOG branches/REL-1_8_0_EDB/pgadmin3/pgadmin/frm/frmEditGrid.cpp branches/REL-1_8_0_EDB/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7262 - in branches/REL-1_8_0_EDB/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:16:19 +0100 (Fri, 02 May 2008) New Revision: 7262 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7262&view=rev Log: Prevent unsaved changes in the edit grid being lost if the filter or sorting dialogue is opened. Per Erwin. Modified: branches/REL-1_8_0_EDB/pgadmin3/CHANGELOG branches/REL-1_8_0_EDB/pgadmin3/pgadmin/frm/frmEditGrid.cpp branches/REL-1_8_0_EDB/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7261 - in branches/REL-1_8_0_PATCHES/pgadmin3: . pgadmin/frm pgadmin/include/frm
Author: dpage Date: 2008-05-02 11:15:35 +0100 (Fri, 02 May 2008) New Revision: 7261 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7261&view=rev Log: Prevent unsaved changes in the edit grid being lost if the filter or sorting dialogue is opened. Per Erwin. Modified: branches/REL-1_8_0_PATCHES/pgadmin3/CHANGELOG branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/frm/frmEditGrid.cpp branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/include/frm/frmEditGrid.h -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Behavioral issues in data grid: unsaved data, sort/filter
Hi Erwin, On Fri, Apr 25, 2008 at 8:51 PM, Erwin Brandstetter <[EMAIL PROTECTED]> wrote: > - Do not warn, if data has not changed OK, that's the hard one. I don't know how we can do that without some fairly extensive work. I'll add it to the todo list. On the plus side, that's an annoyance, not a data loss bug. > - Do warn, if data has changed. Not only at attempts to close the window, > but also on any attempt to requery, including sort/filter. I've committed a patch that should fix this. > While being at it, requery _every_ time [OK] is clicked - as opposed to > [Cancel] - in the sort/filter dialog. > It is futile to check for changes in filter/sort, as the underlying data > may have changed, and it is confusing if a meaningless whitespace makes all > the difference. > The user can always click [Cancel] if he does not want to requery. That's more of a debatable change but I think you're correct and have committed the change. Thanks, Dave. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7266 - in trunk/pgadmin3: . pgadmin/dlg
Author: dpage Date: 2008-05-02 12:49:42 +0100 (Fri, 02 May 2008) New Revision: 7266 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7266&view=rev Log: Allow EnterpriseDB packages to be created without bodies. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/dlg/dlgPackage.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7267 - in branches/REL-1_8_0_PATCHES/pgadmin3: . pgadmin/dlg
Author: dpage Date: 2008-05-02 12:50:08 +0100 (Fri, 02 May 2008) New Revision: 7267 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7267&view=rev Log: Allow EnterpriseDB packages to be created without bodies. Modified: branches/REL-1_8_0_PATCHES/pgadmin3/CHANGELOG branches/REL-1_8_0_PATCHES/pgadmin3/pgadmin/dlg/dlgPackage.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by dpage: r7268 - in branches/REL-1_8_0_EDB/pgadmin3: . pgadmin/dlg
Author: dpage Date: 2008-05-02 12:50:34 +0100 (Fri, 02 May 2008) New Revision: 7268 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7268&view=rev Log: Allow EnterpriseDB packages to be created without bodies. Modified: branches/REL-1_8_0_EDB/pgadmin3/CHANGELOG branches/REL-1_8_0_EDB/pgadmin3/pgadmin/dlg/dlgPackage.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Png files
Hi, Does anyone know where we got the objects' icons ? I thought it was a pgfoundry project but I can't find it. And Google is unhelpful here. Thanks. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Png files
On Fri, May 2, 2008 at 3:39 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Hi, > > Does anyone know where we got the objects' icons ? I thought it was a > pgfoundry project but I can't find it. And Google is unhelpful here. http://pgfoundry.org/docman/?group_id=189 -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Behavioral issues in data grid: unsaved data, sort/filter
Hi Dave! Great! I am looking forward to the new point release. :) [EMAIL PROTECTED] wrote: Hi Erwin, On Fri, Apr 25, 2008 at 8:51 PM, Erwin Brandstetter <[EMAIL PROTECTED]> wrote: (...) - Do warn, if data has changed. Not only at attempts to close the window, but also on any attempt to requery, including sort/filter. I've committed a patch that should fix this. Does that include the peculiar case, where the key makes the data grid forget about changes? (When pressed after the first edit and as opposed to moving on by mouse.) Regards Erwin -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Behavioral issues in data grid: unsaved data, sort/filter
On Fri, May 2, 2008 at 4:33 PM, Erwin Brandstetter <[EMAIL PROTECTED]> wrote: > Does that include the peculiar case, where the key makes the data grid > forget about changes? (When pressed after the first edit and as opposed to > moving on by mouse.) I need to play with that some more. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Behavioral issues in data grid: unsaved data, sort/filter
On Fri, May 2, 2008 at 5:03 PM, Dave Page <[EMAIL PROTECTED]> wrote: > On Fri, May 2, 2008 at 4:33 PM, Erwin Brandstetter > <[EMAIL PROTECTED]> wrote: > > > Does that include the peculiar case, where the key makes the data grid > > forget about changes? (When pressed after the first edit and as opposed to > > moving on by mouse.) > > I need to play with that some more. OK, I've done some playing and uploaded a windows build to http://developer.pgadmin.org/~dpage/pgAdmin3.zip (iirc, you usually test on Windows). Please give it a whirl - I believe I've fixed the case, but I want to be sure there are no regressions I've missed as this seems reasonable to include in 1.8.3. Thanks, Dave -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Behavioral issues in data grid: unsaved data, sort/filter
Hi Dave! [EMAIL PROTECTED] wrote: OK, I've done some playing and uploaded a windows build to http://developer.pgadmin.org/~dpage/pgAdmin3.zip (iirc, you usually test on Windows). Please give it a whirl - I believe I've fixed the case, but I want to be sure there are no regressions I've missed as this seems reasonable to include in 1.8.3. Right, thanks, I mainly use WinXP as desktop, the transition to Ubuntu 8.04/ Debian Lenny is imminent, though. Testing pgAdmin v.1.9.0-Dev (May 2 2008), rev: 7245:7266M, on WinXP; host: pg 8.2.7 and 8.3.1 on Debian Etch. I have played around a bit and run the same tests as before. AFAICS, you've nailed all mentioned cases of potential data loss, which is the most important part. - key now seems to have the same effect as moving to the next field with the mouse pointer. This is a twofold improvement: no data loss, behavior unified. The false warnings have consequently become more frequent. It is the lesser evil, if we have to chose. - Save warning now fires, if I engage sort/filter, which prevents data loss. It might be even smarter to wait until sort/filter is actually applied. If one just wants to look up the filter or decides to [CANCEL] for any other reason, then we may not need the warning. But that's a minor point. - [Cancel] or [OK] now abort or apply sort/filter just the way it should be IMO. I've also checked for the other stuff I have reported recently and replied on the thread where I've come up with something. The rest seems to work like a charm now. Also no crashes or anything bad and new. - Rule privilege for VIEWs: partly fixed, see reply on thread. - Refresh object name: seems FIXED. - "FORCE" option for REINDEX: seems Robins FIXED it. - Redundant double-quotes in types: seems FIXED. - Errors & notices in pgAdmin log-files: seems FIXED. Regards Erwin -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers