Re: [pgadmin-hackers] Dialogs review
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See > http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure > about what we should do with this... debug the stuff on wxMac source files? > or simply put it in the BUGS file and continue the work ? I was trying to come up with a test case for this using the xrc sample app in wxWidgets - however it seems to work fine. I used the changes below - can you see what's different?: *** controls.xrc.orig 2008-07-21 10:04:12.0 +0100 --- controls.xrc2008-07-21 10:16:49.0 +0100 *** *** 591,606 1 ! 0 0 0 0 0 ! wxALIGN_CENTER|wxALL 5 - 220,160 wxLC_REPORT|wxSUNKEN_BORDER --- 591,605 1 ! 1 0 0 0 0 ! wxGROW|wxEXPAND|wxTOP|wxLEFT|wxRIGHT 5 wxLC_REPORT|wxSUNKEN_BORDER -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Dialogs review
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Anyways, I attach the new dlgCast.xrc patch file. That looks pretty sweet, and works well :-). The only thing I note, is that even with a bigger gap between controls, the bottom highlight on the active control (the blue border on OS X) still isn't shown. If that's the case for you as well, then it seems pointless leaving such a large gap. Reducing the borders from 8 to 4 looks better here. Thoughts? Aside from that, I think that one is ready to go - and should set the standard for the following dialogues :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Dialogs review
Dave Page a écrit : On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Anyways, I attach the new dlgCast.xrc patch file. That looks pretty sweet, and works well :-). The only thing I note, is that even with a bigger gap between controls, the bottom highlight on the active control (the blue border on OS X) still isn't shown. If that's the case for you as well, then it seems pointless leaving such a large gap. Reducing the borders from 8 to 4 looks better here. Reducing the border works here too. To have the blue border on each side of the control, we need to make the control bigger. For example, cbSourceType and cbTargetType have 12 for width. With 14, they show the bottom highlight. Thoughts? Aside from that, I think that one is ready to go - and should set the standard for the following dialogues :-) There's still one thing that bothers me. The "Use replication" label seems closer to the left side of the window's border. And I need to check the border and width changes on Linux and Windows. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME 1 Properties 2 8 5 5 6 1 Name 5,7d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,5d 135,-1d wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 OID 5,22d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,20d 135,-1d wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Source type 5,37d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,35d 130,14d wxCB_DROPDOWN wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Target type 5,52d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,50d 130,14d wxCB_DROPDOWN wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Function 5,67d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,65d 135,12d wxCB_READONLY|wxCB_DROPDOWN wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Implicit 5,82d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,80d 13,12d wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Comment 5,97d wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 70,95d 135,83d wxTE_MULTILINE wxEXPAND|wxALL 4 Use replication 5,183d wxALIGN_CENTRE_VERTICAL 70,181d 135,12d wxCB_READONLY|wxCB_DROPDOWN wxEXPAND|wxALIGN_TOP|wxALL 4 1
[pgadmin-hackers] dlgCheck review
A small property dialog. Works on Linux and Mac OS X. Comments? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME 1 0 0 Properties 2 4 5 5 1 1 Name 5,7d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,5d 135,-1d wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Check 5,22d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,20d 135,109d wxTE_MULTILINE wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Comment 5,134d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,132d 135,49d wxTE_MULTILINE wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 Use replication 5,186d wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT 4 70,184d 135,12d wxCB_READONLY|wxCB_DROPDOWN wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT 4 wxTOP|wxLEFT|wxRIGHT|wxGROW 1 2,2d 214,215d wxALL|wxGROW|wxALIGN_CENTRE 3 2,2d 7 3,3d Help 135,220d 3,3d &OK 1 135,220d 3,3d &Cancel 176,220d 3,3d 2 wxTOP|wxLEFT|wxRIGHT|wxGROW 3,3d -1,15d wxGROW|wxALIGN_CENTRE 3 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Dialogs review
Dave Page a écrit : On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure about what we should do with this... debug the stuff on wxMac source files? or simply put it in the BUGS file and continue the work ? I was trying to come up with a test case for this using the xrc sample app in wxWidgets - however it seems to work fine. I used the changes below - can you see what's different?: I worked all the evening on this. The xrc sample app works for me. It even works with our Definition notebook page. So, we should be able to make it work on pgAdmin. I tried to simplify our xrc file in pgAdmin, but I couldn't find a way to make it work. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
