Re: [pgadmin-hackers] One question on the Restore window

2009-12-22 Thread Dave Page 
On Sun, Dec 20, 2009 at 10:22 PM, Guillaume Lelarge
 wrote:
> Hi,
>
> I worked today on the restore window. I added all the missing options
> (with a release check for some of them), and I added sizers to have a
> good UI. You can see the result in the screenshots attached (from
> frmRestore_1.png to frmRestore_3.png).
>
> I have some problems with the UI of the backup TOC. I want to allow
> users to restore only some selected objects of the backup. Right now,
> the restore window allows only to restore one object, even if you
> selected more than one. So I try to find a good UI for this. I see two
> ways for doing it:
>
>  * Keep the list, adding checkbox (see frmRestore_5.png).
>  * Replace the list with a tree (see frmRestore_4.png).
>
> The tree is more appealing, really simple to understand. Anyone who used
> the backup window can use the restore window... Well, not really. If a
> user wants to restore some tables but not the schema, he needs to
> unselect the schema, and then to select the tables. It feels a bit
> awkward to see the schema not selected when some of its own tables are.
> Moreover, the list is really simpler to remember the order of the
> objects (the tree kind of destroys the order). But this is not really
> important. I'm much more bothered with the fact that we can have some
> tables selected and that the schema they belong to is not.

Following the design of the backup window is preferrable certainly.
I'm not sure I'm too worried about the selection issue - most people
will never use it I imagine, and if they do, they probably only want
to restore a small number of tables, so deselecting the schema gives
them a blank list to do that.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Dave Page 
On Mon, Dec 21, 2009 at 2:41 PM, Thom Brown  wrote:
> Hi,
>
> Not so much a feature request but a tweak to a default settings.  The guys
> at work agree that copying the creation script for a database object into a
> new query window is a bit annoying and unnecessary as we always end up
> having to clear the window each time before typing anything.  I imagine it's
> not something people will want a vast majority of the time, so maybe not
> disabling it by default would be a good idea.  We've now disabled it in our
> own clients, but find it odd it's enabled as default behaviour in the first
> place.

It's a historic thing. Happy if anyone wants to change the default now though.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Dave Page 
On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
 wrote:
> Le 21/12/2009 15:41, Thom Brown a écrit :
>> [...]
>> Not so much a feature request but a tweak to a default settings.  The guys
>> at work agree that copying the creation script for a database object into a
>> new query window is a bit annoying and unnecessary as we always end up
>> having to clear the window each time before typing anything.  I imagine it's
>> not something people will want a vast majority of the time, so maybe not
>> disabling it by default would be a good idea.  We've now disabled it in our
>> own clients, but find it odd it's enabled as default behaviour in the first
>> place.
>>
>
> I have the exact same behavior: open the query tool, delete the SQL
> script, start the real work. Kind of annoying. So I won't oppose to fix
> it this way :)

We're talking about the default value for the option that does that
already. It just defaults to on at the moment, but Thom thinks off
seems more sensible.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Magnus Hagander 
2009/12/22 Dave Page :
> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
>  wrote:
>> Le 21/12/2009 15:41, Thom Brown a écrit :
>>> [...]
>>> Not so much a feature request but a tweak to a default settings.  The guys
>>> at work agree that copying the creation script for a database object into a
>>> new query window is a bit annoying and unnecessary as we always end up
>>> having to clear the window each time before typing anything.  I imagine it's
>>> not something people will want a vast majority of the time, so maybe not
>>> disabling it by default would be a good idea.  We've now disabled it in our
>>> own clients, but find it odd it's enabled as default behaviour in the first
>>> place.
>>>
>>
>> I have the exact same behavior: open the query tool, delete the SQL
>> script, start the real work. Kind of annoying. So I won't oppose to fix
>> it this way :)
>
> We're talking about the default value for the option that does that
> already. It just defaults to on at the moment, but Thom thinks off
> seems more sensible.

+1 for the idea of changing it to off by default.

We still have an explicit option in the right-click menu to do it, right?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Dave Page 
On Tue, Dec 22, 2009 at 9:59 AM, Magnus Hagander  wrote:

> We still have an explicit option in the right-click menu to do it, right?

What right-click menu?



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Guillaume Lelarge 
Le 22/12/2009 10:57, Dave Page a écrit :
> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
>  wrote:
>> Le 21/12/2009 15:41, Thom Brown a écrit :
>>> [...]
>>> Not so much a feature request but a tweak to a default settings.  The guys
>>> at work agree that copying the creation script for a database object into a
>>> new query window is a bit annoying and unnecessary as we always end up
>>> having to clear the window each time before typing anything.  I imagine it's
>>> not something people will want a vast majority of the time, so maybe not
>>> disabling it by default would be a good idea.  We've now disabled it in our
>>> own clients, but find it odd it's enabled as default behaviour in the first
>>> place.
>>>
>>
>> I have the exact same behavior: open the query tool, delete the SQL
>> script, start the real work. Kind of annoying. So I won't oppose to fix
>> it this way :)
> 
> We're talking about the default value for the option that does that
> already. It just defaults to on at the moment, but Thom thinks off
> seems more sensible.
> 

OK, so, IOW, I think he's right. We should turn it off by default.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown 
2009/12/22 Dave Page 

> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
>  wrote:
> > Le 21/12/2009 15:41, Thom Brown a écrit :
> >> [...]
> >> Not so much a feature request but a tweak to a default settings.  The
> guys
> >> at work agree that copying the creation script for a database object
> into a
> >> new query window is a bit annoying and unnecessary as we always end up
> >> having to clear the window each time before typing anything.  I imagine
> it's
> >> not something people will want a vast majority of the time, so maybe not
> >> disabling it by default would be a good idea.  We've now disabled it in
> our
> >> own clients, but find it odd it's enabled as default behaviour in the
> first
> >> place.
> >>
> >
> > I have the exact same behavior: open the query tool, delete the SQL
> > script, start the real work. Kind of annoying. So I won't oppose to fix
> > it this way :)
>
> We're talking about the default value for the option that does that
> already. It just defaults to on at the moment, but Thom thinks off
> seems more sensible.
>
>
>
Yes, I'm not against it being available, just it being the default
behaviour. :)  The specific option I'm referring to is in File > Options,
and in the Query tab there's an option named "Copy SQL from main window to
query tool" which is checked by default.

Thom

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Magnus Hagander 
2009/12/22 Dave Page :
> On Tue, Dec 22, 2009 at 9:59 AM, Magnus Hagander  wrote:
>
>> We still have an explicit option in the right-click menu to do it, right?
>
> What right-click menu?

Right click on an object in the tree.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Dave Page 
On Tue, Dec 22, 2009 at 10:03 AM, Magnus Hagander  wrote:
> 2009/12/22 Dave Page :
>> On Tue, Dec 22, 2009 at 9:59 AM, Magnus Hagander  wrote:
>>
>>> We still have an explicit option in the right-click menu to do it, right?
>>
>> What right-click menu?
>
> Right click on an object in the tree.

Oh right. We'll, yeah there's the CREATE SCRIPT option.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Guillaume Lelarge 
Le 22/12/2009 11:02, Thom Brown a écrit :
> 2009/12/22 Dave Page 
> 
>> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
>>  wrote:
>>> Le 21/12/2009 15:41, Thom Brown a écrit :
 [...]
 Not so much a feature request but a tweak to a default settings.  The
>> guys
 at work agree that copying the creation script for a database object
>> into a
 new query window is a bit annoying and unnecessary as we always end up
 having to clear the window each time before typing anything.  I imagine
>> it's
 not something people will want a vast majority of the time, so maybe not
 disabling it by default would be a good idea.  We've now disabled it in
>> our
 own clients, but find it odd it's enabled as default behaviour in the
>> first
 place.

>>>
>>> I have the exact same behavior: open the query tool, delete the SQL
>>> script, start the real work. Kind of annoying. So I won't oppose to fix
>>> it this way :)
>>
>> We're talking about the default value for the option that does that
>> already. It just defaults to on at the moment, but Thom thinks off
>> seems more sensible.
>>
>>
>>
> Yes, I'm not against it being available, just it being the default
> behaviour. :)  The specific option I'm referring to is in File > Options,
> and in the Query tab there's an option named "Copy SQL from main window to
> query tool" which is checked by default.
> 

To tell the truth, I didn't remember there was an option for this. I'll
turn it off.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown 
2009/12/22 Guillaume Lelarge 

> Le 22/12/2009 11:02, Thom Brown a écrit :
> > 2009/12/22 Dave Page 
> >
> >> On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
> >>  wrote:
> >>> Le 21/12/2009 15:41, Thom Brown a écrit :
>  [...]
>  Not so much a feature request but a tweak to a default settings.  The
> >> guys
>  at work agree that copying the creation script for a database object
> >> into a
>  new query window is a bit annoying and unnecessary as we always end up
>  having to clear the window each time before typing anything.  I
> imagine
> >> it's
>  not something people will want a vast majority of the time, so maybe
> not
>  disabling it by default would be a good idea.  We've now disabled it
> in
> >> our
>  own clients, but find it odd it's enabled as default behaviour in the
> >> first
>  place.
> 
> >>>
> >>> I have the exact same behavior: open the query tool, delete the SQL
> >>> script, start the real work. Kind of annoying. So I won't oppose to fix
> >>> it this way :)
> >>
> >> We're talking about the default value for the option that does that
> >> already. It just defaults to on at the moment, but Thom thinks off
> >> seems more sensible.
> >>
> >>
> >>
> > Yes, I'm not against it being available, just it being the default
> > behaviour. :)  The specific option I'm referring to is in File > Options,
> > and in the Query tab there's an option named "Copy SQL from main window
> to
> > query tool" which is checked by default.
> >
>
> To tell the truth, I didn't remember there was an option for this. I'll
> turn it off.
>
>
>
Thanks guys! :)

Thom

[pgadmin-hackers] SVN Commit by guillaume: r8140 - in trunk/pgadmin3: . pgadmin/include/utils

2009-12-22 Thread svn 
Author: guillaume

Date: 2009-12-22 13:14:18 + (Tue, 22 Dec 2009)

New Revision: 8140

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8140&view=rev

Log:
StickySql is false by default, per request from Tom Brown.



Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/include/utils/sysSettings.h

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Guillaume Lelarge 
Le 22/12/2009 11:07, Thom Brown a écrit :
> 2009/12/22 Guillaume Lelarge 
> 
>> Le 22/12/2009 11:02, Thom Brown a écrit :
>>> 2009/12/22 Dave Page 
>>>
 On Mon, Dec 21, 2009 at 5:37 PM, Guillaume Lelarge
  wrote:
> Le 21/12/2009 15:41, Thom Brown a écrit :
>> [...]
>> Not so much a feature request but a tweak to a default settings.  The
 guys
>> at work agree that copying the creation script for a database object
 into a
>> new query window is a bit annoying and unnecessary as we always end up
>> having to clear the window each time before typing anything.  I
>> imagine
 it's
>> not something people will want a vast majority of the time, so maybe
>> not
>> disabling it by default would be a good idea.  We've now disabled it
>> in
 our
>> own clients, but find it odd it's enabled as default behaviour in the
 first
>> place.
>>
>
> I have the exact same behavior: open the query tool, delete the SQL
> script, start the real work. Kind of annoying. So I won't oppose to fix
> it this way :)

 We're talking about the default value for the option that does that
 already. It just defaults to on at the moment, but Thom thinks off
 seems more sensible.



>>> Yes, I'm not against it being available, just it being the default
>>> behaviour. :)  The specific option I'm referring to is in File > Options,
>>> and in the Query tab there's an option named "Copy SQL from main window
>> to
>>> query tool" which is checked by default.
>>>
>>
>> To tell the truth, I didn't remember there was an option for this. I'll
>> turn it off.
>>
>>
>>
> Thanks guys! :)
> 

Done. I didn't backpatch it on the 1.10 branch. I don't think we should
do this but I don't really have a hard feeling on this, so tell me if it
needs to be done.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Dave Page 
On Tue, Dec 22, 2009 at 1:16 PM, Guillaume Lelarge
 wrote:
> Done. I didn't backpatch it on the 1.10 branch. I don't think we should
> do this but I don't really have a hard feeling on this, so tell me if it
> needs to be done.

It's not a bug fix so it doesn't get back patched.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #120: Disable copying SQL from main window to query tool by default

2009-12-22 Thread pgAdmin Trac 
#120: Disable copying SQL from main window to query tool by default
---+
 Reporter:  Tom Brown  |   Owner:  dpage
 Type:  feature|  Status:  new  
 Priority:  minor  |   Milestone:  1.12 
Component:  pgadmin| Version:  1.10 
 Keywords:  querytool  |Platform:  all  
---+
 Not so much a feature request but a tweak to a default settings.  The guys
 at work agree that copying the creation script for a database object into
 a new query window is a bit annoying and unnecessary as we always end up
 having to clear the window each time before typing anything.  I imagine
 it's not something people will want a vast majority of the time, so maybe
 not disabling it by default would be a good idea.  We've now disabled it
 in our own clients, but find it odd it's enabled as default behaviour in
 the first place.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #120: Disable copying SQL from main window to query tool by default

2009-12-22 Thread pgAdmin Trac 
#120: Disable copying SQL from main window to query tool by default
---+
 Reporter:  Tom Brown  |   Owner:  gleu
 Type:  feature|  Status:  assigned
 Priority:  minor  |   Milestone:  1.12
Component:  pgadmin| Version:  1.10
 Keywords:  querytool  |Platform:  all 
---+
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #120: Disable copying SQL from main window to query tool by default

2009-12-22 Thread pgAdmin Trac 
#120: Disable copying SQL from main window to query tool by default
+---
  Reporter:  Tom Brown  |   Owner:  gleu 
  Type:  feature|  Status:  closed   
  Priority:  minor  |   Milestone:  1.12 
 Component:  pgadmin| Version:  1.10 
Resolution:  fixed  |Keywords:  querytool
  Platform:  all|  
+---
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Fixed in r8140.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Thom Brown 
2009/12/22 Dave Page 

> On Tue, Dec 22, 2009 at 1:16 PM, Guillaume Lelarge
>  wrote:
> > Done. I didn't backpatch it on the 1.10 branch. I don't think we should
> > do this but I don't really have a hard feeling on this, so tell me if it
> > needs to be done.
>
> It's not a bug fix so it doesn't get back patched.
>
>
Out of curiosity, will this only affect those who are installing pgAdmin
without an existing version installed?  Meaning, will upgrades have no
effect on this option's default due to a pre-existing configuration file
somewhere?

Thom

Re: [pgadmin-hackers] Feature request: disable copying SQL from main window to query tool by default

2009-12-22 Thread Guillaume Lelarge 
Le 22/12/2009 14:23, Thom Brown a écrit :
> 2009/12/22 Dave Page 
> 
>> On Tue, Dec 22, 2009 at 1:16 PM, Guillaume Lelarge
>>  wrote:
>>> Done. I didn't backpatch it on the 1.10 branch. I don't think we should
>>> do this but I don't really have a hard feeling on this, so tell me if it
>>> needs to be done.
>>
>> It's not a bug fix so it doesn't get back patched.
>>
>>
> Out of curiosity, will this only affect those who are installing pgAdmin
> without an existing version installed?

Yes.

> Meaning, will upgrades have no
> effect on this option's default due to a pre-existing configuration file
> somewhere?

Yes.

It'll affect first time users.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] One question on the Restore window

2009-12-22 Thread Guillaume Lelarge 
Le 22/12/2009 10:39, Dave Page a écrit :
> On Sun, Dec 20, 2009 at 10:22 PM, Guillaume Lelarge
>  wrote:
>> Hi,
>>
>> I worked today on the restore window. I added all the missing options
>> (with a release check for some of them), and I added sizers to have a
>> good UI. You can see the result in the screenshots attached (from
>> frmRestore_1.png to frmRestore_3.png).
>>
>> I have some problems with the UI of the backup TOC. I want to allow
>> users to restore only some selected objects of the backup. Right now,
>> the restore window allows only to restore one object, even if you
>> selected more than one. So I try to find a good UI for this. I see two
>> ways for doing it:
>>
>>  * Keep the list, adding checkbox (see frmRestore_5.png).
>>  * Replace the list with a tree (see frmRestore_4.png).
>>
>> The tree is more appealing, really simple to understand. Anyone who used
>> the backup window can use the restore window... Well, not really. If a
>> user wants to restore some tables but not the schema, he needs to
>> unselect the schema, and then to select the tables. It feels a bit
>> awkward to see the schema not selected when some of its own tables are.
>> Moreover, the list is really simpler to remember the order of the
>> objects (the tree kind of destroys the order). But this is not really
>> important. I'm much more bothered with the fact that we can have some
>> tables selected and that the schema they belong to is not.
> 
> Following the design of the backup window is preferrable certainly.
> I'm not sure I'm too worried about the selection issue - most people
> will never use it I imagine, and if they do, they probably only want
> to restore a small number of tables, so deselecting the schema gives
> them a blank list to do that.
> 

OK, I dropped the list, and I'll now work on the use of the tree widget.

Thanks for your answer.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] import: source code is pushed to git repository

2009-12-22 Thread Dave Page 
On Sun, Dec 20, 2009 at 9:10 AM, Quan Zongliang  wrote:
> hi all
>
> I pushed import 's source code to:
> git://git.postgresql.org/git/users/quan74/pgadmin-import.git
>
> web:
> http://git.postgresql.org/gitweb?p=users/quan74/pgadmin-import.git;a=summary
>
> To suport ODBC, please define preprocessor __WITHODBC3__.
> Under *nix, __WITHIODBC__ or __WITHUNIXODBC is needed.
>
> Archive file: Only zip and tar file is supported.
>
> All of them only tested under WindowsXP.

Not so good on Mac yet :-(

g++ -DHAVE_CONFIG_H -I. -I..   -I/usr/local/pgsql/include -DSSL
-I/usr/local/lib/wx/include/mac-unicode-release-static-2.8
-I/usr/local/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-D__WXMAC__ -O2 -DEMBED_XRC -no-cpp-precomp -arch ppc -arch i386
-I/usr/local//include/libxml2 -I/usr/local/include
-I/usr/local//include/libxml2 -Wall -Wno-non-virtual-dtor
-fno-strict-aliasing -I../pgadmin/include   -c -o frmMain.o `test -f
'./frm/frmMain.cpp' || echo './'`./frm/frmMain.cpp
In file included from ./frm/frmMain.cpp:61:
../pgadmin/include/frm/frmImport.h:118: error: ‘wxSpinEvent’ has not
been declared
In file included from ./frm/frmMain.cpp:61:
../pgadmin/include/frm/frmImport.h:118: error: ‘wxSpinEvent’ has not
been declared
lipo: can't figure out the architecture type of:
/var/folders/wn/wnM76L9ZF6agsFkWcNv6pk+++TI/-Tmp-//ccBdhNrR.out
make[2]: *** [frmMain.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Seems like oyu need to add  to frmImport.h.



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] import: source code is pushed to git repository

2009-12-22 Thread Dave Page 
On Tue, Dec 22, 2009 at 9:08 PM, Dave Page  wrote:
>> All of them only tested under WindowsXP.
>
> Not so good on Mac yet :-(
>
...
> Seems like oyu need to add  to frmImport.h.
>
> 

OK, got it to the link phase with the attached patch, but then it died
horribly. I think you need to build your code under gcc every now and
again, to keep it in a nice cross-platform friendly state. It's also a
good idea to catch any problems - gcc tends to be a much less
forgiving compiler than VC++, which will often allow code which will
crash elsewhere (for example, passing wxStrings through variadic
functions such as on line 4304 of frmImport.cpp).

If you don't have a Linux box, I'd suggest grabbing a copy of
VirtualBox for Windows, and installing Ubuntu or Fedora in it.

g++ -DHAVE_CONFIG_H -I. -I..   -I/usr/local/pgsql/include -DSSL
-I/usr/local/lib/wx/include/mac-unicode-release-static-2.8
-I/usr/local/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-D__WXMAC__ -O2 -DEMBED_XRC -no-cpp-precomp -arch ppc -arch i386
-I/usr/local//include/libxml2 -I/usr/local/include
-I/usr/local//include/libxml2 -Wall -Wno-non-virtual-dtor
-fno-strict-aliasing -I../pgadmin/include   -c -o frmImport.o `test -f
'./frm/frmImport.cpp' || echo './'`./frm/frmImport.cpp
In file included from ./frm/frmImport.cpp:7:
../pgadmin/include/frm/frmImport.h:67: error: ‘pgTable’ has not been declared
../pgadmin/include/frm/frmImport.h:210: error: ISO C++ forbids
declaration of ‘pgTable’ with no type
../pgadmin/include/frm/frmImport.h:210: error: expected ‘;’ before ‘*’ token
./frm/frmImport.cpp:309: error: ‘pgTable’ has not been declared
./frm/frmImport.cpp: In constructor ‘frmImport::frmImport(frmMain*, int*)’:
./frm/frmImport.cpp:312: error: ‘m_table’ was not declared in this scope
./frm/frmImport.cpp: In member function ‘void frmImport::Init()’:
./frm/frmImport.cpp:381: error: ‘m_table’ was not declared in this scope
./frm/frmImport.cpp:390: error: no matching function for call to
‘wxXmlResource::LoadObject(frmImport* const, frmMain*&, const wchar_t
[10], const wchar_t [9])’
/usr/local/include/wx-2.8/wx/xrc/xmlres.h:201: note: candidates are:
wxObject* wxXmlResource::LoadObject(wxWindow*, const wxString&, const
wxString&)
/usr/local/include/wx-2.8/wx/xrc/xmlres.h:207: note:
bool wxXmlResource::LoadObject(wxObject*, wxWindow*, const wxString&,
const wxString&)
./frm/frmImport.cpp: In member function ‘void
frmImport::OnTextFilePreviewMore(wxCommandEvent&)’:
./frm/frmImport.cpp:823: warning: comparison between signed and
unsigned integer expressions
./frm/frmImport.cpp: In member function ‘void
frmImport::OnArchFilePathKillFocus(wxFocusEvent&)’:
./frm/frmImport.cpp:854: warning: taking address of temporary
./frm/frmImport.cpp: In member function ‘void
frmImport::OnArchFilePreviewMore(wxCommandEvent&)’:
./frm/frmImport.cpp:911: warning: comparison between signed and
unsigned integer expressions
./frm/frmImport.cpp: In member function ‘void
frmImport::OnColSettingCellChange(wxGridEvent&)’:
./frm/frmImport.cpp:1268: warning: unused variable ‘evcolnr’
./frm/frmImport.cpp: In member function ‘void frmImport::ImportData()’:
./frm/frmImport.cpp:2228: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2354: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2592: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:2814: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:1470: warning: unused variable ‘logwarn’
./frm/frmImport.cpp: In member function ‘void frmImport::GenColsPreview()’:
./frm/frmImport.cpp:3857: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3882: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3781: warning: unused variable ‘skipemptyline’
./frm/frmImport.cpp:4056: error: ‘_itow’ was not declared in this scope
./frm/frmImport.cpp:3426: warning: unused variable ‘errcount’
./frm/frmImport.cpp: In member function ‘bool
frmImport::GenCSVSQLData(wxString&, wxString&, wxString**, size_t,
wxDateTime&, int, int)’:
./frm/frmImport.cpp:4304: warning: cannot pass objects of non-POD type
‘class wxString’ through ‘...’; call will abort at runtime
./frm/frmImport.cpp:4196: warning: unused variable ‘pvgridrowidx’
./frm/frmImport.cpp: In member function ‘void
frmImport::InitWizardPage(frmImport::WizardPageNumber)’:
./frm/frmImport.cpp:4869: warning: enumeration value ‘INVALIDPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘ALLIMPPAGES’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘TARGETPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘SRCTYPEPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘SRCODBCPAGE’ not
handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘COLSETTINGPAGE’
not handled in switch
./frm/frmImport.cpp:4869: warning: enumeration value ‘DESTLOGPAGE’ not
handled in switch
./frm/frmImport.cpp: In member fun