Re: [pgadmin-hackers] [HACKERS] 8.5 vs. 9.0

[Guillaume Lelarge]

Le 21/01/2010 11:57, Dave Page a écrit :
> On Thu, Jan 21, 2010 at 10:54 AM, Thom Brown  wrote:
> 
>> I feel sorry for 8.5 now.  It had such high hopes of becoming a proper
>> version.
> 
> Yeah, well - it'll be remembered. I still find occasional references
> to PostgreSQL 7.5 in the pgAdmin code.
> 

Just saw this. Should we change every 8.5 with 9.0 in pgAdmin's code?
That's not a hard work, but it would probably be better to do that right
now.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [HACKERS] 8.5 vs. 9.0

[Dave Page]

On 1/21/10, Guillaume Lelarge  wrote:
> Le 21/01/2010 11:57, Dave Page a écrit :
>> On Thu, Jan 21, 2010 at 10:54 AM, Thom Brown  wrote:
>>
>>> I feel sorry for 8.5 now.  It had such high hopes of becoming a proper
>>> version.
>>
>> Yeah, well - it'll be remembered. I still find occasional references
>> to PostgreSQL 7.5 in the pgAdmin code.
>>
>
> Just saw this. Should we change every 8.5 with 9.0 in pgAdmin's code?
> That's not a hard work, but it would probably be better to do that right
> now.
>

I quite enjoy finding those old references - it's a weird reminder of
history (and of course, it makes no difference to the operation of the
code) :-)

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [HACKERS] 8.5 vs. 9.0

[Guillaume Lelarge]

Le 21/01/2010 20:31, Dave Page a écrit :
> On 1/21/10, Guillaume Lelarge  wrote:
>> Le 21/01/2010 11:57, Dave Page a écrit :
>>> On Thu, Jan 21, 2010 at 10:54 AM, Thom Brown  wrote:
>>>
 I feel sorry for 8.5 now.  It had such high hopes of becoming a proper
 version.
>>>
>>> Yeah, well - it'll be remembered. I still find occasional references
>>> to PostgreSQL 7.5 in the pgAdmin code.
>>>
>>
>> Just saw this. Should we change every 8.5 with 9.0 in pgAdmin's code?
>> That's not a hard work, but it would probably be better to do that right
>> now.
>>
> 
> I quite enjoy finding those old references - it's a weird reminder of
> history (and of course, it makes no difference to the operation of the
> code) :-)
> 

Sure.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8164 - in branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin: dlg schema

[svn]

Author: guillaume

Date: 2010-01-21 20:20:12 + (Thu, 21 Jan 2010)

New Revision: 8164

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8164&view=rev

Log:
Previous commit forgot to fix the SQL in the main browser window.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgRole.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgDatabase.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgFunction.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgRole.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgUser.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8165 - in trunk/pgadmin3/pgadmin: dlg schema

[svn]

Author: guillaume

Date: 2010-01-21 20:40:44 + (Thu, 21 Jan 2010)

New Revision: 8165

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8165&view=rev

Log:
Previous commit forgot to fix the SQL in the main browser window.



Modified:
   trunk/pgadmin3/pgadmin/dlg/dlgRole.cpp
   trunk/pgadmin3/pgadmin/schema/pgDatabase.cpp
   trunk/pgadmin3/pgadmin/schema/pgFunction.cpp
   trunk/pgadmin3/pgadmin/schema/pgRole.cpp
   trunk/pgadmin3/pgadmin/schema/pgUser.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #129: SQL syntax error when changing a parameter for a database, role/user and a function

[pgAdmin Trac]

#129: SQL syntax error when changing a parameter for a database, role/user and a
function
--+-
  Reporter:  gleu |   Owner:  dpage 
  Type:  bug  |  Status:  reopened  
  Priority:  minor|   Milestone:  1.10.2
 Component:  pgadmin  | Version:  1.10  
Resolution:   |Keywords:  role database function
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Other fixes in r8164 and r8165.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #129: SQL syntax error when changing a parameter for a database, role/user and a function

[pgAdmin Trac]

#129: SQL syntax error when changing a parameter for a database, role/user and a
function
--+-
  Reporter:  gleu |   Owner:  gleu  
  Type:  bug  |  Status:  assigned  
  Priority:  minor|   Milestone:  1.10.2
 Component:  pgadmin  | Version:  1.10  
Resolution:   |Keywords:  role database function
  Platform:  all  |  
--+-
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  reopened => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #129: SQL syntax error when changing a parameter for a database, role/user and a function

[pgAdmin Trac]

#129: SQL syntax error when changing a parameter for a database, role/user and a
function
--+-
  Reporter:  gleu |   Owner:  gleu  
  Type:  bug  |  Status:  closed
  Priority:  minor|   Milestone:  1.10.2
 Component:  pgadmin  | Version:  1.10  
Resolution:  fixed|Keywords:  role database function
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #95: Support "ALTER TABLE ... ALTER COLUMN ... SET DISTINCT"

[pgAdmin Trac]

#95: Support "ALTER TABLE ... ALTER COLUMN ... SET DISTINCT"
--+-
  Reporter:  gleu |   Owner:  gleu  
  Type:  feature  |  Status:  closed
  Priority:  minor|   Milestone:  1.12  
 Component:  pgadmin  | Version:  trunk 
Resolution:  fixed|Keywords:  column 9.0
  Platform:  all  |  
--+-
Changes (by gleu):

  * keywords:  column 8.5 => column 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #96: Deferrable unique constraints

[pgAdmin Trac]

#96: Deferrable unique constraints
+---
  Reporter:  gleu   |   Owner:  dpage 
  Type:  feature|  Status:  closed
  Priority:  minor  |   Milestone:
 Component:  pgadmin| Version:  trunk 
Resolution:  won't fix  |Keywords:  constraint 9.0
  Platform:  all|  
+---
Changes (by gleu):

  * keywords:  constraint 8.5 => constraint 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #97: Triggers on columns

[pgAdmin Trac]

#97: Triggers on columns
--+-
  Reporter:  gleu |   Owner:  gleu   
  Type:  feature  |  Status:  closed 
  Priority:  minor|   Milestone:  1.12   
 Component:  pgadmin  | Version:  trunk  
Resolution:  fixed|Keywords:  trigger 9.0
  Platform:  all  |  
--+-
Changes (by gleu):

  * keywords:  trigger 8.5 => trigger 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #98: TRIGGER with WHEN clause

[pgAdmin Trac]

#98: TRIGGER with WHEN clause
--+-
  Reporter:  gleu |   Owner:  gleu   
  Type:  feature  |  Status:  closed 
  Priority:  minor|   Milestone:  1.12   
 Component:  pgadmin  | Version: 
Resolution:  fixed|Keywords:  trigger 9.0
  Platform:  all  |  
--+-
Changes (by gleu):

  * keywords:  trigger 8.5 => trigger 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #99: Default ACLs

[pgAdmin Trac]

#99: Default ACLs
--+-
 Reporter:  gleu  |   Owner:  dpage
 Type:  feature   |  Status:  new  
 Priority:  minor |   Milestone:   
Component:  pgadmin   | Version:  trunk
 Keywords:  role 9.0  |Platform:  all  
--+-
Changes (by gleu):

  * keywords:  role 8.5 => role 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #100: GRANT ON ALL IN schema

[pgAdmin Trac]

#100: GRANT ON ALL IN schema
+---
 Reporter:  gleu|   Owner:  dpage
 Type:  feature |  Status:  new  
 Priority:  minor   |   Milestone:   
Component:  pgadmin | Version:  trunk
 Keywords:  schema 9.0  |Platform:  all  
+---
Changes (by gleu):

  * keywords:  schema 8.5 => schema 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #101: New VACUUM options syntax

[pgAdmin Trac]

#101: New VACUUM options syntax
+---
  Reporter:  gleu   |   Owner:  dpage  
  Type:  feature|  Status:  closed 
  Priority:  minor  |   Milestone: 
 Component:  pgadmin| Version:  trunk  
Resolution:  won't fix  |Keywords:  maintenance 9.0
  Platform:  all|  
+---
Changes (by gleu):

  * keywords:  maintenance 8.5 => maintenance 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #116: Application Name

[pgAdmin Trac]

#116: Application Name
--+-
  Reporter:  gleu |   Owner:  gleu 
  Type:  feature  |  Status:  closed   
  Priority:  minor|   Milestone:  1.12 
 Component:  pgadmin  | Version:  trunk
Resolution:  fixed|Keywords:  core serverstatus 9.0
  Platform:  all  |  
--+-
Changes (by gleu):

  * keywords:  core serverstatus 8.5 => core serverstatus 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #117: Explain Buffers

[pgAdmin Trac]

#117: Explain Buffers
---+
 Reporter:  gleu   |   Owner:  dpage
 Type:  feature|  Status:  new  
 Priority:  minor  |   Milestone:   
Component:  pgadmin| Version:  trunk
 Keywords:  querytool 9.0  |Platform:  all  
---+
Changes (by gleu):

  * keywords:  querytool 8.5 => querytool 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #118: Operator Exclusion Constraints

[pgAdmin Trac]

#118: Operator Exclusion Constraints
---+
 Reporter:  gleu   |   Owner:  dpage
 Type:  feature|  Status:  new  
 Priority:  minor  |   Milestone:   
Component:  pgadmin| Version:  trunk
 Keywords:  table 9.0  |Platform:  all  
---+
Changes (by gleu):

  * keywords:  table 8.5 => table 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #124: Support for the new "ALTER TABLESPACE name SET/RESET" statement

[pgAdmin Trac]

#124: Support for the new "ALTER TABLESPACE name SET/RESET" statement
+---
 Reporter:  gleu|   Owner:  gleu
 Type:  feature |  Status:  assigned
 Priority:  minor   |   Milestone:  1.12
Component:  pgadmin | Version:  trunk   
 Keywords:  tablespace 9.0  |Platform:  all 
+---
Changes (by gleu):

  * keywords:  tablespace 8.5 => tablespace 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #126: New INPLACE option for VACUUM FULL

[pgAdmin Trac]

#126: New INPLACE option for VACUUM FULL
-+--
 Reporter:  gleu |   Owner:  gleu
 Type:  feature  |  Status:  assigned
 Priority:  minor|   Milestone:  1.12
Component:  pgadmin  | Version:  trunk   
 Keywords:  maintenance 9.0  |Platform:  all 
-+--
Changes (by gleu):

  * keywords:  maintenance 8.5 => maintenance 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #127: Tablespaces can take configuration parameters

[pgAdmin Trac]

#127: Tablespaces can take configuration parameters
+---
  Reporter:  gleu   |   Owner:  dpage 
  Type:  feature|  Status:  closed
  Priority:  minor  |   Milestone:
 Component:  pgadmin| Version:  trunk 
Resolution:  duplicate  |Keywords:  tablespace 9.0
  Platform:  all|  
+---
Changes (by gleu):

  * keywords:  tablespace 8.5 => tablespace 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #128: Hotstandby and Streaming Replication

[pgAdmin Trac]

#128: Hotstandby and Streaming Replication
+---
 Reporter:  gleu|   Owner:  dpage
 Type:  feature |  Status:  new  
 Priority:  minor   |   Milestone:   
Component:  pgadmin | Version:  trunk
 Keywords:  server 9.0  |Platform:  all  
+---
Changes (by gleu):

  * keywords:  server 8.5 => server 9.0


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #99: Default ACLs

[pgAdmin Trac]

#99: Default ACLs
--+-
 Reporter:  gleu  |   Owner:  gleu
 Type:  feature   |  Status:  assigned
 Priority:  minor |   Milestone:  
Component:  pgadmin   | Version:  trunk   
 Keywords:  role 9.0  |Platform:  all 
--+-
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Ticket 102: Allow more complex user/database default GUC settings

[Guillaume Lelarge]

Hi,

It took me one more day than I previously thought. Anyways, here it is.
I checked every I could (apart from checking on Windows and Mac OS X
because I don't have those in my hotel room...).

There is not much to say on this patch. It changes the Role and Database
dialogsbut not that much. Should work on 9.0 (obviously), and previous
releases.

Comments?

(for sure, my last patch with BackendMinimumVersion(8, 5)... forgot to
fix those :) )


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
diff --git a/pgadmin/ctl/ctlListView.cpp b/pgadmin/ctl/ctlListView.cpp
index 84e17e6..ac46f06 100644
--- a/pgadmin/ctl/ctlListView.cpp
+++ b/pgadmin/ctl/ctlListView.cpp
@@ -105,3 +105,41 @@ void ctlListView::CreateColumns(wxImageList *images, const wxString &left, const
 if (images)
 SetImageList(images, wxIMAGE_LIST_SMALL);
 }
+
+
+void ctlListView::CreateColumns(wxImageList *images, const wxString &str1, const wxString &str2, const wxString &str3, int leftSize)
+{
+int rightSize;
+if (leftSize < 0)
+{
+#ifdef __WXMAC__
+leftSize = rightSize = (GetParent()->GetSize().GetWidth() - 20)/2;
+#else
+leftSize = rightSize = GetSize().GetWidth()/2;
+#endif
+}
+else
+{
+if (leftSize)
+leftSize = ConvertDialogToPixels(wxPoint(leftSize, 0)).x;
+
+#ifdef __WXMAC__
+rightSize = (GetParent()->GetSize().GetWidth() - 20) - leftSize;
+#else
+rightSize = GetClientSize().GetWidth()-leftSize;
+#endif
+}
+if (!leftSize)
+{
+InsertColumn(0, str1, wxLIST_FORMAT_LEFT, GetClientSize().GetWidth());
+}
+else
+{
+InsertColumn(0, str1, wxLIST_FORMAT_LEFT, leftSize);
+InsertColumn(1, str2, wxLIST_FORMAT_LEFT, rightSize/2);
+InsertColumn(2, str3, wxLIST_FORMAT_LEFT, rightSize/2);
+}
+
+if (images)
+SetImageList(images, wxIMAGE_LIST_SMALL);
+}
diff --git a/pgadmin/dlg/dlgDatabase.cpp b/pgadmin/dlg/dlgDatabase.cpp
index b5a6041..39fa1d5 100644
--- a/pgadmin/dlg/dlgDatabase.cpp
+++ b/pgadmin/dlg/dlgDatabase.cpp
@@ -32,6 +32,7 @@
 
 #define lstVariablesCTRL_LISTVIEW("lstVariables")
 #define cbVarname   CTRL_COMBOBOX2("cbVarname")
+#define cbVarUsername   CTRL_COMBOBOX2("cbVarUsername")
 #define txtValueCTRL_TEXT("txtValue")
 #define chkValueCTRL_CHECKBOX("chkValue")
 #define btnAdd  CTRL_BUTTON("wxID_ADD")
@@ -63,6 +64,7 @@ BEGIN_EVENT_TABLE(dlgDatabase, dlgSecurityProperty)
 EVT_BUTTON(wxID_ADD,dlgDatabase::OnVarAdd)
 EVT_BUTTON(wxID_REMOVE, dlgDatabase::OnVarRemove)
 EVT_TEXT(XRCID("cbVarname"),dlgDatabase::OnVarnameSelChange)
+EVT_TEXT(XRCID("cbVarUsername"),dlgDatabase::OnVarnameSelChange)
 EVT_COMBOBOX(XRCID("cbVarname"),dlgDatabase::OnVarnameSelChange)
 EVT_BUTTON(wxID_OK, dlgDatabase::OnOK)
 EVT_TEXT(XRCID("cbCollate"),dlgDatabase::OnCollateSelChange)
@@ -79,7 +81,7 @@ dlgDatabase::dlgDatabase(pgaFactory *f, frmMain *frame, pgDatabase *node)
 {
 database=node;
 schemaRestrictionOk=true;
-lstVariables->CreateColumns(0, _("Variable"), _("Value"));
+lstVariables->CreateColumns(0, _("Username"), _("Variable"), _("Value"));
 
 chkValue->Hide();
 
@@ -108,6 +110,14 @@ int dlgDatabase::Go(bool modal)
 AddGroups();
 AddUsers(cbOwner);
 
+if (connection->BackendMinimumVersion(8,5))
+{
+cbVarUsername->Append(wxT(""));
+AddUsers(cbVarUsername);
+}
+else
+cbVarUsername->Enable(false);
+
 if (connection->BackendMinimumVersion(8, 0))
 {
 stPath->Hide();
@@ -151,6 +161,11 @@ int dlgDatabase::Go(bool modal)
 delete set;
 
 cbVarname->SetSelection(0);
+
+if (connection->BackendMinimumVersion(8,5))
+{
+cbVarUsername->SetSelection(0);
+}
 }
 
 if (database)
@@ -168,16 +183,27 @@ int dlgDatabase::Go(bool modal)
 if (readOnly)
 {
 cbVarname->Disable();
+cbVarUsername->Disable();
 txtValue->Disable();
 btnAdd->Disable();
 btnRemove->Disable();
 }
 
 size_t i;
+wxString username;
+wxString varname;
+wxString varvalue;
 for (i=0 ; i < database->GetVariables().GetCount() ; i++)
 {
-wxString item=database->GetVariables().Item(i);
-lstVariables->AppendItem(0, item.BeforeFirst('='), item.AfterFirst('='));
+wxStringTokenizer tkz(database->GetVariables().Item(i), wxT("="));
+while (tkz.HasMoreTokens())
+{
+username = tkz.GetNextToken();
+varname = tkz.GetNextToken();
+varvalue = tkz.GetNextToken();
+}
+
+lstVariables->AppendItem(0, username, varname, varvalue);
 }
 
 PrepareTabl

[pgadmin-hackers] Patches

[Guillaume Lelarge]

Hi,

I intend to work next on ticket 99 (Default ACLs). I'll need to change
the role dialog that my previous patch already changed. Actually, I have
quite some patches in the pipe. git makes it so easy to work on multiple
patches, it is just marvellous. So I'll have to apply some of my patches
to the SVN if I want to continue to work without too much fuss. At
least, I'll need to commit the last one (ticket 102) ASAP.

Thanks.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #117: Explain Buffers

[pgAdmin Trac]

#117: Explain Buffers
---+
 Reporter:  gleu   |   Owner:  gleu
 Type:  feature|  Status:  assigned
 Priority:  minor  |   Milestone:  
Component:  pgadmin| Version:  trunk   
 Keywords:  querytool 9.0  |Platform:  all 
---+
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


Comment:

 The COST information would be interesting too.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers