date:20100310

[pgadmin-hackers] PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

2010-03-10 Thread Ashesh Vashi

Hi,

Please find the patch for the same.
We found this issue from long time, but did not have time to resolve it.

--
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company 


FB12446_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New minor release?

2010-03-10 Thread Dave Page

On Tue, Mar 9, 2010 at 11:18 PM, Guillaume Lelarge
 wrote:
> Le 08/03/2010 22:33, Guillaume Lelarge a écrit :
>> Le 08/03/2010 19:24, Dave Page a écrit :
>>> If u can finalise, stamp and tag today, that would be extremely
>>> helpful. I'll build tomorrow then.
>>>
>>
>> Stamped and tagged. I still need to work on the website though.
>>
>
> Done. See patch attached (not commited).
>
> Waiting for comments and/or approval.

Looks OK to my eyes.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8218 - trunk/pgadmin3/pgadmin/debugger

2010-03-10 Thread svn

Author: dpage

Date: 2010-03-10 09:07:06 + (Wed, 10 Mar 2010)

New Revision: 8218

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8218&view=rev

Log:
Don't crash if debugging a null procedure. [Ashesh Vashi]


Modified:
   trunk/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

2010-03-10 Thread Ashesh Vashi

Sorry previous patch has one 'fprintf'.
Please find the updated patch.

On Wed, Mar 10, 2010 at 1:11 PM, Ashesh Vashi  wrote:

> Hi,
>
> Please find the patch for the same.
> We found this issue from long time, but did not have time to resolve it.
>
> --
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company
>
>


FB12446_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8219 - trunk/pgadmin3

2010-03-10 Thread svn

Author: dpage

Date: 2010-03-10 09:10:12 + (Wed, 10 Mar 2010)

New Revision: 8219

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8219&view=rev

Log:
Update the changelog.


Modified:
   trunk/pgadmin3/CHANGELOG

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8220 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/debugger

2010-03-10 Thread svn

Author: dpage

Date: 2010-03-10 09:12:14 + (Wed, 10 Mar 2010)

New Revision: 8220

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8220&view=rev

Log:
Don't crash if debugging a null procedure. [Ashesh Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

2010-03-10 Thread Dave Page

For the benefit of the list, I've asked Ashesh to do some additional
testing on this before we commit, as the debugger code can be quite
finicky, with the threading behaving subtly differently on each of
Win32, GTK and Mac.

On Wed, Mar 10, 2010 at 8:42 AM, Ashesh Vashi
 wrote:
> Sorry previous patch has one 'fprintf'.
> Please find the updated patch.
>
> On Wed, Mar 10, 2010 at 1:11 PM, Ashesh Vashi
>  wrote:
>>
>> Hi,
>> Please find the patch for the same.
>> We found this issue from long time, but did not have time to resolve it.
>> --
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise Postgres Company
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New minor release?

2010-03-10 Thread Guillaume Lelarge

Le 10/03/2010 09:29, Dave Page a écrit :
> On Tue, Mar 9, 2010 at 11:18 PM, Guillaume Lelarge
>  wrote:
>> Le 08/03/2010 22:33, Guillaume Lelarge a écrit :
>>> Le 08/03/2010 19:24, Dave Page a écrit :
 If u can finalise, stamp and tag today, that would be extremely
 helpful. I'll build tomorrow then.

>>>
>>> Stamped and tagged. I still need to work on the website though.
>>>
>>
>> Done. See patch attached (not commited).
>>
>> Waiting for comments and/or approval.
> 
> Looks OK to my eyes.
> 

When should I commit it? or do you want to take care of it?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New minor release?

2010-03-10 Thread Dave Page

Whenever u like :-)

On 3/10/10, Guillaume Lelarge  wrote:
> Le 10/03/2010 09:29, Dave Page a écrit :
>> On Tue, Mar 9, 2010 at 11:18 PM, Guillaume Lelarge
>>  wrote:
>>> Le 08/03/2010 22:33, Guillaume Lelarge a écrit :
 Le 08/03/2010 19:24, Dave Page a écrit :
> If u can finalise, stamp and tag today, that would be extremely
> helpful. I'll build tomorrow then.
>

 Stamped and tagged. I still need to work on the website though.

>>>
>>> Done. See patch attached (not commited).
>>>
>>> Waiting for comments and/or approval.
>>
>> Looks OK to my eyes.
>>
>
> When should I commit it? or do you want to take care of it?
>
>
> --
> Guillaume.
>  http://www.postgresqlfr.org
>  http://dalibo.com
>


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Ticket 135: Support for the new CREATE TABLE OF syntax

2010-03-10 Thread Guillaume Lelarge

Hi,

You'll find attached a patch that allows a user to specify a composite
type in the table dialog to create a new table. It uses the "CREATE
TABLE tablename OF typename" syntax.

One restriction: the user can't change some column's properties (default
value for example). The user has to create the table, then change
properties for some columns.

Comments?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
diff --git a/pgadmin/dlg/dlgColumn.cpp b/pgadmin/dlg/dlgColumn.cpp
index e6178e4..f62bf87 100644
--- a/pgadmin/dlg/dlgColumn.cpp
+++ b/pgadmin/dlg/dlgColumn.cpp
@@ -299,6 +299,15 @@ int dlgColumn::Go(bool modal)
 txtAttstattarget->Disable();
 txtDefault->Disable();
 }
+else if (table->GetOfTypeOid() > 0)
+{
+txtName->Disable();
+chkNotNull->Enable();
+txtLength->Disable();
+cbDatatype->Disable();
+txtAttstattarget->Enable();
+txtDefault->Enable();
+}
 
 size_t i;
 for (i=0 ; i < column->GetVariables().GetCount() ; i++)
diff --git a/pgadmin/dlg/dlgTable.cpp b/pgadmin/dlg/dlgTable.cpp
index b993777..e1207b8 100644
--- a/pgadmin/dlg/dlgTable.cpp
+++ b/pgadmin/dlg/dlgTable.cpp
@@ -41,6 +41,7 @@
 #define btnRemoveTable  CTRL_BUTTON("btnRemoveTable")
 #define cbTablesCTRL_COMBOBOX2("cbTables")
 #define cbTablespaceCTRL_COMBOBOX("cbTablespace")
+#define cbOfTypeCTRL_COMBOBOX("cbOfType")
 #define txtFillFactor   CTRL_TEXT("txtFillFactor")
 
 #define btnAddCol   CTRL_BUTTON("btnAddCol")
@@ -102,6 +103,7 @@ BEGIN_EVENT_TABLE(dlgTable, dlgSecurityProperty)
 EVT_CHECKBOX(XRCID("chkHasOids"),   dlgProperty::OnChange)
 EVT_TEXT(XRCID("cbTablespace"), dlgProperty::OnChange)
 EVT_COMBOBOX(XRCID("cbTablespace"), dlgProperty::OnChange)
+EVT_COMBOBOX(XRCID("cbOfType"), dlgTable::OnChangeOfType)
 EVT_CHECKBOX(XRCID("chkHasOids"),   dlgProperty::OnChange)
 EVT_TEXT(XRCID("cbTables"), dlgTable::OnChangeTable)
 EVT_BUTTON(XRCID("btnAddTable"),dlgTable::OnAddTable)
@@ -208,6 +210,16 @@ int dlgTable::Go(bool modal)
 PrepareTablespace(cbTablespace);
 PopulateDatatypeCache();
 
+// new of type combobox
+wxString typeQuery = wxT("SELECT t.oid, t.typname ")
+wxT("FROM pg_type t, pg_namespace n ")
+wxT("WHERE t.typtype='c' AND t.typnamespace=n.oid ")
+wxT("AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema') ")
+wxT("ORDER BY typname");
+cbOfType->Insert(wxEmptyString, 0, (void *)0);
+cbOfType->FillOidKey(connection, typeQuery);
+cbOfType->SetSelection(0);
+
 hasPK=false;
 
 if (table)
@@ -218,6 +230,9 @@ int dlgTable::Go(bool modal)
 if (table->GetTablespaceOid() != 0)
 cbTablespace->SetKey(table->GetTablespaceOid());
 
+if (table->GetOfTypeOid() != 0)
+cbOfType->SetKey(table->GetOfTypeOid());
+
 inheritedTableOids=table->GetInheritedTablesOidList();
 
 wxArrayString qitl=table->GetQuotedInheritedTablesList();
@@ -230,7 +245,6 @@ int dlgTable::Go(bool modal)
 
 btnAddTable->Enable(connection->BackendMinimumVersion(8, 2) && cbTables->GetGuessedSelection() >= 0);
 lbTables->Enable(connection->BackendMinimumVersion(8, 2));
-cbTables->Enable(connection->BackendMinimumVersion(8, 2));
 chkHasOids->Enable(table->GetHasOids() && connection->BackendMinimumVersion(8, 0));
 cbTablespace->Enable(connection->BackendMinimumVersion(7, 5));
 
@@ -354,6 +368,9 @@ int dlgTable::Go(bool modal)
 cbTablespace->SetSelection(0);
 }
 
+cbOfType->Enable(connection->BackendMinimumVersion(9, 0) && !table);
+cbTables->Enable(connection->BackendMinimumVersion(8, 2) && cbOfType->GetCurrentSelection() == 0);
+
 if (connection->BackendMinimumVersion(8,2) || !table)
 {
 wxString systemRestriction;
@@ -1187,26 +1204,34 @@ wxString dlgTable::GetSql()
 }
 else
 {
-sql = wxT("CREATE TABLE ") + tabname
-+ wxT("\n(");
+bool typedTable = cbOfType->GetCurrentSelection() > 0 && cbOfType->GetOIDKey() > 0;
+sql = wxT("CREATE TABLE ") + tabname;
+if (typedTable)
+sql += wxT("\nOF ") + qtIdent(cbOfType->GetValue());
+
+if (!typedTable || (typedTable && lstConstraints->GetItemCount() > 0))
+sql += wxT("\n(");
 
 int pos;
 bool needComma=false;
-for (pos=0 ; pos < lstColumns->GetItemCount() ; pos++)
+if (!typedTable)
 {
-if (lstColumns->GetText(pos, 2).IsEmpty())
+for (pos=0 ; pos < lstColumns->GetItemCount() ; pos++)
 {
-// standard definition, not inherited
-if (needComma)
-sql += wxT(", ");
-else
-needComma=tru

[pgadmin-hackers] SVN Commit by guillaume: r8221 - in trunk/www: . download

2010-03-10 Thread svn

Author: guillaume

Date: 2010-03-10 18:57:47 + (Wed, 10 Mar 2010)

New Revision: 8221

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8221&view=rev

Log:
Website update for 1.10.2 release.



Modified:
   trunk/www/download/macosx.php
   trunk/www/download/source.php
   trunk/www/download/windows.php
   trunk/www/index.php
   trunk/www/news.php

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New minor release?

2010-03-10 Thread Guillaume Lelarge

Le 10/03/2010 19:28, Dave Page a écrit :
> Whenever u like :-)
> 

Done, thanks :)


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8222 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

2010-03-10 Thread svn

Author: guillaume

Date: 2010-03-10 18:58:49 + (Wed, 10 Mar 2010)

New Revision: 8222

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8222&view=rev

Log:
Automatic stringmerge using merge script.


Modified:
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8223 - trunk/www/advocacy

2010-03-10 Thread svn

Author: guillaume

Date: 2010-03-10 19:05:06 + (Wed, 10 Mar 2010)

New Revision: 8223

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8223&view=rev

Log:
Fix a sentence.



Modified:
   trunk/www/advocacy/index.php

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8224 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

2010-03-10 Thread svn

Author: guillaume

Date: 2010-03-10 19:05:47 + (Wed, 10 Mar 2010)

New Revision: 8224

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8224&view=rev

Log:
Automatic stringmerge using merge script.


Modified:
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8225 - trunk/www/locale/fr_FR/LC_MESSAGES

2010-03-10 Thread svn

Author: guillaume

Date: 2010-03-10 19:08:02 + (Wed, 10 Mar 2010)

New Revision: 8225

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8225&view=rev

Log:
Update website french translation.



Modified:
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] New minor release?

2010-03-10 Thread Dave Page

Thanks :-)

On 3/10/10, Guillaume Lelarge  wrote:
> Le 10/03/2010 19:28, Dave Page a écrit :
>> Whenever u like :-)
>>
>
> Done, thanks :)
>
>
> --
> Guillaume.
>  http://www.postgresqlfr.org
>  http://dalibo.com
>


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

Re: [pgadmin-hackers] New minor release?

[pgadmin-hackers] SVN Commit by dpage: r8218 - trunk/pgadmin3/pgadmin/debugger

[pgadmin-hackers] Re: PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

[pgadmin-hackers] SVN Commit by dpage: r8219 - trunk/pgadmin3

[pgadmin-hackers] SVN Commit by dpage: r8220 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/debugger

Re: [pgadmin-hackers] Re: PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

Re: [pgadmin-hackers] New minor release?

Re: [pgadmin-hackers] New minor release?

[pgadmin-hackers] Ticket 135: Support for the new CREATE TABLE OF syntax

[pgadmin-hackers] SVN Commit by guillaume: r8221 - in trunk/www: . download

Re: [pgadmin-hackers] New minor release?

[pgadmin-hackers] SVN Commit by guillaume: r8222 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

[pgadmin-hackers] SVN Commit by guillaume: r8223 - trunk/www/advocacy

[pgadmin-hackers] SVN Commit by guillaume: r8224 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

[pgadmin-hackers] SVN Commit by guillaume: r8225 - trunk/www/locale/fr_FR/LC_MESSAGES

Re: [pgadmin-hackers] New minor release?

17 matches

Site Navigation

Mail list logo

Footer information