[pgadmin-hackers] SVN Commit by dpage: r8232 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/include/utils pgadmin/utils

[svn]

Author: dpage

Date: 2010-03-19 09:39:47 + (Fri, 19 Mar 2010)

New Revision: 8232

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8232&view=rev

Log:
Warn the user if a file couldn't be opened because it contains invalid 
characters [Ashesh Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/include/utils/utffile.h
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/utils/utffile.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8233 - in trunk/pgadmin3: . pgadmin/include/utils pgadmin/utils

[svn]

Author: dpage

Date: 2010-03-19 09:39:55 + (Fri, 19 Mar 2010)

New Revision: 8233

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8233&view=rev

Log:
Warn the user if a file couldn't be opened because it contains invalid 
characters [Ashesh Vashi]


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/include/utils/utffile.h
   trunk/pgadmin3/pgadmin/utils/utffile.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: pgAdmin III: Query Window does not give any error, if it does not able to open the given file.

[Dave Page]

On Wed, Mar 17, 2010 at 10:36 AM, Ashesh Vashi
 wrote:
> Hi Dave/Team,
> We found that - Query window does not give any error, if it does not able to
> open the selected file.
> The problem was: it is not able to convert the contents of the file in
> Unicode characters. :-(.
> The patch for the trunk throws a warning from wxUtfFile::Read function and
> returns with -1.
> The patch for the REL-1_10_0_PATCHES branch throws a warning only from
> frmQuery::OpenLastFile function.

Thanks. I applied the patch for trunk to both branches, as I couldn't
see any reason they should be different. I also simplified the message
from the one I originally suggested to you, because turning off the
UTF-8 option doesn't always help.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: PATCH: Fail to restore table/function, if it has special characters.

[Dave Page]

On Fri, Mar 19, 2010 at 6:10 AM, Ashesh Vashi
 wrote:
>
> Please find the attached patch for REL_1_10_PATCHES branches and updated
> patch for the trunk (with few tab characters to 4 spaces.)

I'd be surprised if this works - past experience of fixing this stuff
in similar areas tells me that using the same quoting rules on Windows
and *nix are quite different.

What platforms did you test on?

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: PATCH: Fail to restore table/function, if it has special characters.

[Ashesh Vashi]

I tested on Windows XP SP2, Ubuntu 9.10 32 bit & Mac OSX 10.5 Intel.

On Fri, Mar 19, 2010 at 3:21 PM, Dave Page  wrote:

> On Fri, Mar 19, 2010 at 6:10 AM, Ashesh Vashi
>  wrote:
> >
> > Please find the attached patch for REL_1_10_PATCHES branches and updated
> > patch for the trunk (with few tab characters to 4 spaces.)
>
> I'd be surprised if this works - past experience of fixing this stuff
> in similar areas tells me that using the same quoting rules on Windows
> and *nix are quite different.
>
> What platforms did you test on?
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> PG East Conference:
> http://www.enterprisedb.com/community/nav-pg-east-2010.do
>

[pgadmin-hackers] SVN Commit by dpage: r8234 - trunk/pgadmin3/pgadmin

[svn]

Author: dpage

Date: 2010-03-19 10:20:57 + (Fri, 19 Mar 2010)

New Revision: 8234

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8234&view=rev

Log:
Fix the VC++ project file.


Modified:
   trunk/pgadmin3/pgadmin/pgAdmin3.vcproj

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8235 - in branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin: frm include/utils utils

[svn]

Author: dpage

Date: 2010-03-19 10:30:41 + (Fri, 19 Mar 2010)

New Revision: 8235

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8235&view=rev

Log:
Refactor recent changes to quoting rules [Ashesh Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/frm/frmBackup.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/frm/frmBackupGlobals.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/frm/frmBackupServer.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/frm/frmRestore.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/include/utils/misc.h
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/utils/misc.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8236 - in trunk/pgadmin3/pgadmin: frm include/utils utils

[svn]

Author: dpage

Date: 2010-03-19 10:30:47 + (Fri, 19 Mar 2010)

New Revision: 8236

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8236&view=rev

Log:
Refactor recent changes to quoting rules [Ashesh Vashi]


Modified:
   trunk/pgadmin3/pgadmin/frm/frmBackup.cpp
   trunk/pgadmin3/pgadmin/frm/frmBackupGlobals.cpp
   trunk/pgadmin3/pgadmin/frm/frmBackupServer.cpp
   trunk/pgadmin3/pgadmin/frm/frmRestore.cpp
   trunk/pgadmin3/pgadmin/include/utils/misc.h
   trunk/pgadmin3/pgadmin/utils/misc.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: PATCH: Fail to restore table/function, if it has special characters.

[Dave Page]

On Fri, Mar 19, 2010 at 9:56 AM, Ashesh Vashi
 wrote:
> I tested on Windows XP SP2, Ubuntu 9.10 32 bit & Mac OSX 10.5 Intel.

Hmm, well it works for me too, so I'll eat my words and congratulate
you on finding a nice clean solution :-)

Thanks - applied.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #153: pgAdmin Graphical Query Tool Crashes on Mac

[pgAdmin Trac]

#153: pgAdmin Graphical Query Tool Crashes on Mac
-+--
 Reporter:  Gary Carter  |   Owner:  dpage   
 Type:  bug  |  Status:  new 
 Priority:  minor|   Milestone:  
Component:  pgadmin  | Version:  1.10
 Keywords:  gqb  |Platform:  mac os x
-+--
 Mac OS X v10.5.8

 pgAdmin v1.10.2

 1. Open Query Tool
 2. select Graphical Query Builder
 3. drag one table onto canvas, select a column or 2
 4. drag another table onto canvas, select a column or 2
 5. drag a join link between the tables
 6. Click the Join tab at the bottom portion of the dialog
 7. Alternate mouse click the join line on the canvas and select Delete
 Join
 8. wait..., keep waiting... poof!

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #154: Fail to restore table/function, if it has special characters

[pgAdmin Trac]

#154: Fail to restore table/function, if it has special characters
--+-
 Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
 Type:  bug   |  Status:  new 
 Priority:  minor |   Milestone:  
Component:  pgadmin   | Version:  1.10
 Keywords:  restore   |Platform:  all 
--+-
 The restore option of a table/function will fail, if the function name
 contains special characters (i.e. test"xyz)

 Please find the patch to resolve the issue for both the trunk and
 1_10_0_PATCHES branch.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #154: Fail to restore table/function, if it has special characters

[pgAdmin Trac]

#154: Fail to restore table/function, if it has special characters
---+
  Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
  Type:  bug   |  Status:  closed  
  Priority:  minor |   Milestone:  1.10.3  
 Component:  pgadmin   | Version:  1.10
Resolution:  fixed |Keywords:  restore 
  Platform:  all   |  
---+
Changes (by gleu):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.10.3


Comment:

 Fixed in r8227 and r8228.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #155: Query Window does not give any error, if it does not able to open the given file.

[pgAdmin Trac]

#155: Query Window does not give any error, if it does notable to open the
given file.
--+-
 Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
 Type:  bug   |  Status:  new 
 Priority:  minor |   Milestone:  
Component:  pgadmin   | Version:  1.10
 Keywords:  querytool |Platform:  all 
--+-
 We found that - Query window does not give any error, if it does not able
 to open the selected file.
 The problem was: it is not able to convert the contents of the file in
 Unicode characters. :-(.

 The patch for the trunk throws a warning from wxUtfFile::Read function and
 returns with -1.
 The patch for the REL-1_10_0_PATCHES branch throws a warning only from
 frmQuery::OpenLastFile function.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgadmin 1.10.2 crashes on start

[Guillaume Lelarge]

Le 17/03/2010 18:20, Erwin Brandstetter a écrit :
> [...]
> A couple of months ago I was planning to get involved with the
> development of pgadmin again, but, alas, I am swamped at work. Still
> hoping that the situation will clear up.
> Meanwhile, after the release of v.1.10.2 I have logged my first ticket
> in trac.
> The ticket says it all. It is remarkable that the crash happens on Win
> XP Home, while another copy on Win XP Pro (installed yesterday) seems to
> work fine.
> 
> Would you say it is good practice to also send a message to the list, or
> will a ticket do?
> 

I prefer a ticket + a mail, as you did.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #156: Warn the user if a file couldn't be opened because it contains invalid characters

[pgAdmin Trac]

#156: Warn the user if a file couldn't be opened because it contains invalid
characters
--+-
 Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
 Type:  bug   |  Status:  new 
 Priority:  minor |   Milestone:  
Component:  pgadmin   | Version:  1.10
 Keywords:  querytool |Platform:  all 
--+-


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #156: Warn the user if a file couldn't be opened because it contains invalid characters

[pgAdmin Trac]

#156: Warn the user if a file couldn't be opened because it contains invalid
characters
---+
  Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
  Type:  bug   |  Status:  closed  
  Priority:  minor |   Milestone:  1.10.3  
 Component:  pgadmin   | Version:  1.10
Resolution:  fixed |Keywords:  querytool   
  Platform:  all   |  
---+
Changes (by gleu):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.10.3


Comment:

 Fixed in r8232 and r8233.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #154: Fail to restore table/function, if it has special characters

[pgAdmin Trac]

#154: Fail to restore table/function, if it has special characters
---+
  Reporter:  Ashesh Vashi  |   Owner:  Ashesh Vashi
  Type:  bug   |  Status:  closed  
  Priority:  minor |   Milestone:  1.10.3  
 Component:  pgadmin   | Version:  1.10
Resolution:  fixed |Keywords:  restore 
  Platform:  all   |  
---+

Comment(by gleu):

 Fixed in r8235 and r8236.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] SVN Commit by dpage: r8234 - trunk/pgadmin3/pgadmin

[Guillaume Lelarge]

Le 19/03/2010 11:20, s...@pgadmin.org a écrit :
> Author: dpage
> 
> Date: 2010-03-19 10:20:57 + (Fri, 19 Mar 2010)
> 
> New Revision: 8234
> 
> Revision summary: 
> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8234&view=rev
> 
> Log:
> Fix the VC++ project file.
> 
> 
> Modified:
>trunk/pgadmin3/pgadmin/pgAdmin3.vcproj
> 

Thanks for doing it. I didn't find time to do it this week.

I'll work on the remaining 9.0 items this week-end.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #148: Miscellaneous requests for the query tool

[Dickson S. Guedes]

2010/3/15 pgAdmin Trac :
> #148: Miscellaneous requests for the query tool
>  allow the user defines the max size of the query that could be added in 
> history,

Done, default to 100.

> the total number of queries stored

Done, default to 10.

> avoid store  itentical queries.

Done, but at now it avoids only identical queries. If we run the same
query only changing some spaces or tabs it'll allow the inclusion of
the query in the history. I don't know if this "duplication" may be
accepted as a "expected behaviour" or a bug.

> ask for query deletion

Done, using 'NO' as default.

This patch fixes the 'SetMacrosFile' in sysSettings.h, too.

Patch attached. Comments?

Thanks.

Dickson S. Guedes
mail/xmpp: gue...@guedesoft.net - skype: guediz
http://guedesoft.net - http://www.postgresql.org.br


pgadmin-ticket-148.patch.gz
Description: GNU Zip compressed data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers