[pgadmin-hackers] SVN Commit by guillaume: r8278 - branches/REL-1_10_0_PATCHES/pgadmin3/i18n/pt_PT

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 17:31:28 +0100 (Tue, 20 Apr 2010)

New Revision: 8278

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8278&view=rev

Log:
Fix the pt_PT translation.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/i18n/pt_PT/pgadmin3.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8279 - trunk/pgadmin3/i18n/pt_PT

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 17:33:08 +0100 (Tue, 20 Apr 2010)

New Revision: 8279

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8279&view=rev

Log:
Fix the pt_PT translation, per request from Jorge Gustavo Rocha.



Modified:
   trunk/pgadmin3/i18n/pt_PT/pgadmin3.mo
   trunk/pgadmin3/i18n/pt_PT/pgadmin3.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8280 - branches/REL-1_10_0_PATCHES/pgadmin3/i18n/pt_PT

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 17:33:37 +0100 (Tue, 20 Apr 2010)

New Revision: 8280

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8280&view=rev

Log:
Sorry, forgot the .mo file.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/i18n/pt_PT/pgadmin3.mo

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin III] #170: Quoted rule identifiers (schema name)

2010-04-20 Thread pgAdmin Trac
#170: Quoted rule identifiers (schema name)
-+--
 Reporter:  sbre...@…|   Owner:  gleu 
 Type:  bug  |  Status:  new  
 Priority:  minor|   Milestone:   
Component:  pgadmin  | Version:  trunk
 Keywords:  browser sqlpane  |Platform:  all  
-+--
 This is the copy of the script produced in the SQL editor window upon
 clicking on "CREATE script" for my rule with quoted identifiers:

 -- Rule: ""EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR_INSERT_RULE" ON
 ACCOUNTING."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR""
 -- DROP RULE "EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR_INSERT_RULE" ON
 ACCOUNTING."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR";
 CREATE OR REPLACE RULE
 "EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR_INSERT_RULE" AS
 ON INSERT TO "ACCOUNTING"."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR" DO
 INSTEAD  INSERT INTO ...

 What I miss:

 - the quotation mark around the schema qualifier in the "Rule: ..." and
 "DROP ..." lines
 - the schema qualifier in the "CREATE OR REPLACE ..." line

 The same for the view itself looks fine:

 -- View: "ACCOUNTING"."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR"
 -- DROP VIEW "ACCOUNTING"."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR";
 CREATE OR REPLACE VIEW
 "ACCOUNTING"."EMPLOYMENT_CONTRACT_ACCOUNTINGS_EDITOR" AS ...

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8281 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/schema

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 18:07:03 +0100 (Tue, 20 Apr 2010)

New Revision: 8281

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8281&view=rev

Log:
Fix the reverse engineering of a rule, per a report from sbremal.
Fixes #170.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgRule.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8282 - in trunk/pgadmin3: . pgadmin/schema

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 18:07:58 +0100 (Tue, 20 Apr 2010)

New Revision: 8282

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8282&view=rev

Log:
Fix the reverse engineering of a rule, per a report from sbremal.



Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/schema/pgRule.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8283 - branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 18:09:11 +0100 (Tue, 20 Apr 2010)

New Revision: 8283

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8283&view=rev

Log:
Get some consistency on the naming of objects in the reverse engineered SQL.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgGroup.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgOperatorClass.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgOperatorFamily.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgRole.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgSchema.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgTablespace.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgUser.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8284 - trunk/pgadmin3/pgadmin/schema

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 18:09:53 +0100 (Tue, 20 Apr 2010)

New Revision: 8284

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8284&view=rev

Log:
Get some consistency on the naming of objects in the reverse engineered SQL.



Modified:
   trunk/pgadmin3/pgadmin/schema/pgGroup.cpp
   trunk/pgadmin3/pgadmin/schema/pgOperatorClass.cpp
   trunk/pgadmin3/pgadmin/schema/pgOperatorFamily.cpp
   trunk/pgadmin3/pgadmin/schema/pgRole.cpp
   trunk/pgadmin3/pgadmin/schema/pgSchema.cpp
   trunk/pgadmin3/pgadmin/schema/pgTablespace.cpp
   trunk/pgadmin3/pgadmin/schema/pgUser.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin III] #170: Quoted rule identifiers (schema name)

2010-04-20 Thread pgAdmin Trac
#170: Quoted rule identifiers (schema name)
--+-
  Reporter:  sbre...@…|   Owner:  gleu   
  Type:  bug  |  Status:  closed 
  Priority:  minor|   Milestone:  1.10.3 
 Component:  pgadmin  | Version:  1.10   
Resolution:  fixed|Keywords:  browser sqlpane
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  new => closed
  * version:  trunk => 1.10
  * resolution:  => fixed
  * milestone:  => 1.10.3


Comment:

 Fixed in r8281 and 8282.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin III] #171: Problem with restore

2010-04-20 Thread pgAdmin Trac
#171: Problem with restore
-+--
 Reporter:  Kieran McCusker  |   Owner:  gleu
 Type:  bug  |  Status:  new 
 Priority:  minor|   Milestone:  
Component:  pgadmin  | Version:  1.10
 Keywords:  restore  |Platform:  all 
-+--
 Sorry if this has been raised before but I have just tried to restore a
 table from one of my schemas.

 The problem was that this table name is very common - It is used in many
 schemas as each schema is the data for an individual client.

 Restore has the three disabled checkboxes
 Only data(checked)
 Only schema(unchecked)
 Single object(checked)

 and then below
 Table (my table name)

 I assumed was it was going to restore only the selected table - What it
 actually did was restore all tables with that name!

 This seems confusing at best (and how would you do what I wanted using the
 UI?)

 Shouldn't the schema be checked as well?

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8285 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/frm

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 20:54:35 +0100 (Tue, 20 Apr 2010)

New Revision: 8285

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8285&view=rev

Log:
Specify the schema of the table/function to restore if pg_restore's release is 
8.2 or later, per a report from Kieran McCusker.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/frm/frmRestore.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8286 - in trunk/pgadmin3: . pgadmin/frm

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 21:20:55 +0100 (Tue, 20 Apr 2010)

New Revision: 8286

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8286&view=rev

Log:
Specify the schema of the table/function to restore if pg_restore's release is 
8.2 or later, per a report from Kieran McCusker.



Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/frm/frmRestore.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin III] #171: Problem with restore

2010-04-20 Thread pgAdmin Trac
#171: Problem with restore
--+-
  Reporter:  Kieran McCusker  |   Owner:  gleu   
  Type:  bug  |  Status:  closed 
  Priority:  minor|   Milestone:  1.10.3 
 Component:  pgadmin  | Version:  1.10   
Resolution:  fixed|Keywords:  restore
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.10.3


Comment:

 Fixed in r8285 and r8286.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] SVN Commit by guillaume: r8287 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/dlg pgadmin/schema

2010-04-20 Thread svn
Author: guillaume

Date: 2010-04-20 23:13:46 +0100 (Tue, 20 Apr 2010)

New Revision: 8287

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8287&view=rev

Log:
Fix the saving and reverse engineering of parameters for database, table, and 
function, according to a report from Erwin Brandstetter.
Fixes #169.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgDatabase.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgFunction.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgRole.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgUser.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgDatabase.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgFunction.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgRole.cpp
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgUser.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] SET search_path = value

2010-04-20 Thread Guillaume Lelarge
Le 20/04/2010 08:54, Guillaume Lelarge a écrit :
> Le 20/04/2010 05:28, Euler Taveira de Oliveira a écrit :
>> Guillaume Lelarge escreveu:
>>> pgAdmin shouldn't use quotes on some parameters: search_path,
>>> temp_tablespaces. Perhaps others. I don't find a way to pick them
>>> automatically. For example, their vartype are "string". Which is quite
>>> ambiguous with others "string" parameters like archive_command. Of
>>> course, we can use a specific code for them. It would be really easy,
>>> but I would prefer to find another way.
>>>
>> I don't see an easy way. :( Perhaps the plan could be map all of these
>> parameters (because in the future legacy versions will use this code path) 
>> and
>> then implement a way to identify those strings without quotes in PostgreSQL.
> 
> Yeah, I don't find a better way to fix this right now.
> 

Fix commited for 1.10. Still needs to work on the trunk patch. Will do
tomorrow.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers