Re: [pgadmin-hackers] Redundant statements

[Erwin Brandstetter]

On 28.04.2010 19:16, brandstet...@falter.at wrote:

Aloha!

I am testing Guillaume's version of pgadmin3.exe from Apr. 17.

The fix below is included and it seems to fix the problem just fine. 
However, as a side effect (?) there is now a redundant statement for 
each and every column:

ALTER TABLE foo ALTER COLUMN bar SET STORAGE PLAIN;
or
ALTER TABLE foo ALTER COLUMN baz SET STORAGE EXTENDED;

I think those statements should only be included, if the storage type 
differs from the default setting - like "SET STATISTICS" is handled now.

It is pretty noisy as it is now.

On a side note: I would handle "WITH (OIDS=FALSE)" for table 
definitions likewise: only print it, if it differs from the default 
setting.


Maybe an option "Show complete SQL"? To switch between "complete" 
(noisy) and default display (only what is necessary to create an 
identical object with the current settings).
Personally I am only interested in the "compact" version, but other 
people's preferences may vary?


This would be a major wishlist item. Not complicated, but possibly many 
lines of code.

What do you think of it? Should I create a ticket?

Regards
Erwin

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Guillaume Lelarge]

Sorry for not answering sooner.

Le 29/04/2010 14:15, Erwin Brandstetter a écrit :
> On 28.04.2010 19:16, brandstet...@falter.at wrote:
>> Aloha!
>>
>> I am testing Guillaume's version of pgadmin3.exe from Apr. 17.
>>
>> The fix below is included and it seems to fix the problem just fine.
>> However, as a side effect (?) there is now a redundant statement for
>> each and every column:
>> ALTER TABLE foo ALTER COLUMN bar SET STORAGE PLAIN;
>> or
>> ALTER TABLE foo ALTER COLUMN baz SET STORAGE EXTENDED;
>>
>> I think those statements should only be included, if the storage type
>> differs from the default setting - like "SET STATISTICS" is handled now.
>> It is pretty noisy as it is now.

"SET STATISTICS" is not really handled this way. We had "SET STATISTICS"
statement if the value is bigger than zero. (Because if it is zero,
PostgreSQL will use the default_statistics_target setting.

Anyway, I agree that "SET STORAGE" is really noisy. Suppose a table with
20 columns. You will have 20 statements about storage. I agree that
something like this is needed. My problem is: what should we use as a
default value? PLAIN would be the default on non-toastable columns, and
EXTENDED the one to use with toastable columns? is there a way to be
sure of this?

>> On a side note: I would handle "WITH (OIDS=FALSE)" for table
>> definitions likewise: only print it, if it differs from the default
>> setting.

If we do this, a user won't be able to copy the SQL and paste/execute it
on another server if this one has another value for default_with_oids.
So, I'm against its removal (unless someone could prove I'm wrong :) ).

> Maybe an option "Show complete SQL"? To switch between "complete"
> (noisy) and default display (only what is necessary to create an
> identical object with the current settings).
> Personally I am only interested in the "compact" version, but other
> people's preferences may vary?

I'm not sure about this either. How could a user know about the
differences between a complete and a partial SQL?

> This would be a major wishlist item. Not complicated, but possibly many
> lines of code.

Well, actually, the only thing I think is needed here is to display (or
not) some column's properties. Not complicated, not a lot of code.

> What do you think of it? Should I create a ticket?

Well, I would like to have a better handling of the "SET STORAGE"
statement. So, yes, you can create a ticket on that, without being too
specific on the solution, which still needs some talk.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH(WIP): Printing Support And Save GQB/Explain as an image

[Ashesh Vashi]

Hi Dave,

As discussed, I am not confident about the Printing support on Mac OSX.
It is working well on other platforms. In fact, Print Preview is also
working good on OSX. But, It gives arbitrary results for the printing.. (The
main feature of this patch.) :-(

I will need some more time investigating the exact issue.

As discussed, I m taking of the save as an image functionality from the
patch and sending you the patch for the same with this.

I am feeling very disappointed, but I do not want to rush into the things
and do not want to do things in hurry.

--
Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company


On Mon, Apr 26, 2010 at 6:18 PM, Dave Page  wrote:

> Hi Ashesh,
>
> On Fri, Apr 23, 2010 at 10:44 PM, Ashesh Vashi
>  wrote:
> > PFA
>
> OK, this patch now compiles on the Mac. I think here are a few things
> that need work
>
> - The Save/Print options are not enabled when they should be. For
> example, if I open the query tool, and run an Explain, I have to click
> to the 'Data Output' tab and then back to the Explain tab before the
> Save/Print options get enabled.
>
> - Why are there separate options for Saving/Printing the EXPLAIN
> output and GQB? As only one can be displayed at a time, we should have
> just one set of options which apply to the visible image.
>
> - The borders on saved images seem somewhat arbitrary. It would be
> good to crop the image to a consistent border around the visible items
> (say 25 or 50 pixels for example).
>
> - If you click on a node in a plan and then save the image, the popup
> info box isn't included.
>
> FYI, I don't think the last two items are essential to fix before beta
> 1. The first two are though.
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise Postgres Company
>
Index: ctl/explainCanvas.cpp
===
--- ctl/explainCanvas.cpp	(revision 8307)
+++ ctl/explainCanvas.cpp	(working copy)
@@ -26,7 +26,6 @@
 SetDiagram(new wxDiagram);
 GetDiagram()->SetCanvas(this);
 SetBackgroundColour(*wxWHITE);
-lastShape=0;
 popup = new ExplainPopup(this);
 }
 
@@ -39,7 +38,6 @@
 void ExplainCanvas::Clear()
 {
 GetDiagram()->DeleteAllShapes();
-lastShape=0;
 }
 
 
@@ -183,6 +181,37 @@
 }
 
 
+void ExplainCanvas::SaveAsImage(const wxString& fileName, wxBitmapType imageType)
+{
+if (GetDiagram()->GetCount() == 0)
+{
+wxMessageBox(_("Nothing to be saved!"), _("Save As an image"), wxOK | wxICON_INFORMATION);
+return;
+}
+
+int width = 0, height = 0;
+GetVirtualSize(&width, &height);
+
+/*
+* Create the bitmap from the Explain window
+*/
+wxMemoryDC memDC;
+wxBitmap tempBitmap(width, height);
+
+memDC.SelectObject(tempBitmap);
+memDC.Clear();
+
+// Draw the diagram on the bitmap (Memory Device Context)
+GetDiagram()->Redraw(memDC);
+
+memDC.SelectObject(wxNullBitmap);
+
+if (!tempBitmap.SaveFile(fileName, imageType))
+{
+wxLogError(_("Could not write the file %s: Errcode=%d."), fileName.c_str(), wxSysErrorCode());
+}
+}
+
 class ExplainText : public wxWindow
 {
 public:
Index: include/ctl/explainCanvas.h
===
--- include/ctl/explainCanvas.h	(revision 8307)
+++ include/ctl/explainCanvas.h	(working copy)
@@ -33,10 +33,11 @@
 void ShowPopup(ExplainShape *s);
 void SetExplainString(const wxString &str);
 void Clear();
+void SaveAsImage(const wxString& fileName, wxBitmapType imageType);
 
 private:
 
-ExplainShape *rootShape, *lastShape;
+ExplainShape *rootShape;
 ExplainPopup *popup;
 };
 
@@ -105,3 +106,4 @@
 };
 
 #endif
+
Index: include/ctl/ctlSQLBox.h
===
--- include/ctl/ctlSQLBox.h	(revision 8307)
+++ include/ctl/ctlSQLBox.h	(working copy)
@@ -58,7 +58,6 @@
 void SetAutoIndent(bool on) { m_autoIndent = on; }
 void EnableAutoComp(bool on) { m_autocompDisabled = on; }
 bool BlockComment(bool uncomment=false);
-
 void UpdateLineNumber();
 
 CharacterRange RegexFindText(int minPos, int maxPos, const wxString& text);
@@ -73,7 +72,9 @@
 dlgFindReplace* m_dlgFindReplace;
 	pgConn *m_database;
 bool m_autoIndent, m_autocompDisabled;
+
+friend class QueryPrintout;
 };
 
+#endif
 
-#endif
Index: include/frm/menu.h
===
--- include/frm/menu.h	(revision 8307)
+++ include/frm/menu.h	(working copy)
@@ -19,6 +19,8 @@
 MNU_ADDSERVER = 101,
 MNU_SAVEDEFINITION,
 MNU_EXIT,
+MNU_SAVEAS_IMAGE_GQB,
+MNU_SAVEAS_IMAGE_EXPLAIN,
 MNU_CONTEXTMENU,
 MNU_SQLPANE,
 MNU_OBJECTBROWSER,
Index: include/frm/frmQuery.h
===
--- include/frm/frmQuery.h	(revision 8307)
+++ include/frm/frmQuery.

[pgadmin-hackers] PATCH: Debugger crashing on OSX

[Ashesh Vashi]

Hi Dave,

As you found the segment fault on OSX  related to debugger.
In dlgDirectDbg::OnTargetComplete(), It waits for the function
this->Show(true) for completion, and "this" pointer will not be available on
cancellation,  and hence It is crashing on next line.
ie. this->SetFocus();

On removing this line, the problem is getting solved.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company
Index: debugger/dlgDirectDbg.cpp
===
--- debugger/dlgDirectDbg.cpp	(revision 8307)
+++ debugger/dlgDirectDbg.cpp	(working copy)
@@ -775,7 +775,6 @@
 return;
 
 this->Show( true );
-this->SetFocus();
 }
 
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Erwin Brandstetter]

On 29.04.2010 15:21, guilla...@lelarge.info wrote:

Sorry for not answering sooner.
   


No problem, the thread is old, but I just posted that yesterday. :)



Le 29/04/2010 14:15, Erwin Brandstetter a écrit :
   

On 28.04.2010 19:16, brandstet...@falter.at wrote:
 

Aloha!

I am testing Guillaume's version of pgadmin3.exe from Apr. 17.

The fix below is included and it seems to fix the problem just fine.
However, as a side effect (?) there is now a redundant statement for
each and every column:
 ALTER TABLE foo ALTER COLUMN bar SET STORAGE PLAIN;
or
 ALTER TABLE foo ALTER COLUMN baz SET STORAGE EXTENDED;

I think those statements should only be included, if the storage type
differs from the default setting - like "SET STATISTICS" is handled now.
It is pretty noisy as it is now.
   

"SET STATISTICS" is not really handled this way. We had "SET STATISTICS"
statement if the value is bigger than zero. (Because if it is zero,
PostgreSQL will use the default_statistics_target setting.
   


Actually, 0 (zero) disables statistics gathering. -1 is for reverting to 
the system default.

http://www.postgresql.org/docs/8.4/interactive/sql-altertable.html



Anyway, I agree that "SET STORAGE" is really noisy. Suppose a table with
20 columns. You will have 20 statements about storage. I agree that
something like this is needed. My problem is: what should we use as a
default value? PLAIN would be the default on non-toastable columns, and
EXTENDED the one to use with toastable columns? is there a way to be
sure of this?

   

On a side note: I would handle "WITH (OIDS=FALSE)" for table
definitions likewise: only print it, if it differs from the default
setting.
   

If we do this, a user won't be able to copy the SQL and paste/execute it
on another server if this one has another value for default_with_oids.
So, I'm against its removal (unless someone could prove I'm wrong :) ).
   


As it is now, the policy is somewhat unclear. Some elements are added 
even though they are redundant under the local settings, others are not.
If we could switch between complete and compact display, this would help 
to clear the situation.
In my daily work I reuse code in the same db cluster 99% of the time - 
95% of the time in the same db. Redundant SQL is only cluttering the 
display and slows me down on a regular basis.
One or the other redundant key word should not hurt, but we could strip 
most of the noise. (Reduces traffic a bit, too.)
For cases where we want to copy objects to a different environment, the 
option "complete SQL" should be an improvement, too.


I would define "local settings" as what "SHOW ALL" returns for the 
current connection (database / user defaults are in effect).




Maybe an option "Show complete SQL"? To switch between "complete"
(noisy) and default display (only what is necessary to create an
identical object with the current settings).
Personally I am only interested in the "compact" version, but other
people's preferences may vary?
 

I'm not sure about this either. How could a user know about the
differences between a complete and a partial SQL?
   


We could have a note at the very top (possibly optional., too):
-- SQL complete
-- SQL for current connection
Current settings are defined by the connection parameters displayed in 
the toolbar: host, user, database.




This would be a major wishlist item. Not complicated, but possibly many
lines of code.
 

Well, actually, the only thing I think is needed here is to display (or
not) some column's properties. Not complicated, not a lot of code.
   


Even better. :) But there are probably a number of cases, where we might 
want to add SQL to the "complete" version or trim in the "compact" version.




What do you think of it? Should I create a ticket?
 

Well, I would like to have a better handling of the "SET STORAGE"
statement. So, yes, you can create a ticket on that, without being too
specific on the solution, which still needs some talk.
   


So we agree on "SET STORAGE". I'll create a ticket on that.

The option to switch between "complete" and "compact" is a different 
(more fundamental) feature. I would like it a lot, but I am not coding, 
so I can only suggest.



Regards
Erwin


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8308 - trunk/www/download

[svn]

Author: guillaume

Date: 2010-04-29 16:33:34 +0100 (Thu, 29 Apr 2010)

New Revision: 8308

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8308&view=rev

Log:
Update Debian's notes for download.



Modified:
   trunk/www/download/debian.php

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8309 - in trunk/www/locale: cs_CZ/LC_MESSAGES fr_FR/LC_MESSAGES zh_CN/LC_MESSAGES

[svn]

Author: guillaume

Date: 2010-04-29 16:34:22 +0100 (Thu, 29 Apr 2010)

New Revision: 8309

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8309&view=rev

Log:
Automatic stringmerge using merge script.


Modified:
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/cs_CZ/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.po
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/zh_CN/LC_MESSAGES/pgadmin3_website.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8310 - trunk/www/locale

[svn]

Author: guillaume

Date: 2010-04-29 16:34:45 +0100 (Thu, 29 Apr 2010)

New Revision: 8310

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8310&view=rev

Log:
Update pot file.



Modified:
   trunk/www/locale/pgadmin3_website.pot

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8311 - trunk/www/locale/fr_FR/LC_MESSAGES

[svn]

Author: guillaume

Date: 2010-04-29 16:37:06 +0100 (Thu, 29 Apr 2010)

New Revision: 8311

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8311&view=rev

Log:
Update website's french translation.



Modified:
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.mo
   trunk/www/locale/fr_FR/LC_MESSAGES/pgadmin3_website.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

[pgAdmin Trac]

#176: Reduce "SET STORAGE" noise in SQL pannel
---+
 Reporter:  brsa   |   Owner:  dpage
 Type:  bug|  Status:  new  
 Priority:  minor  |   Milestone:   
Component:  pgadmin| Version:  trunk
 Keywords:  browser, SQL pane  |Platform:  all  
---+
 As per discussion at
 http://archives.postgresql.org/pgadmin-hackers/2010-04/msg00286.php

 We need an elegant way to figure out the default and only display "SET
 STORAGE" for non-default settings.

 Guillaume:
 PLAIN would be the default on non-toastable columns, and EXTENDED the one
 to use with toastable columns? is there a way to be sure of this?

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Guillaume Lelarge]

Le 29/04/2010 17:28, Erwin Brandstetter a écrit :
> On 29.04.2010 15:21, guilla...@lelarge.info wrote:
>> Sorry for not answering sooner.
>>
> 
> No problem, the thread is old, but I just posted that yesterday. :)
> 
> 
>> Le 29/04/2010 14:15, Erwin Brandstetter a écrit :
>>   
>>> On 28.04.2010 19:16, brandstet...@falter.at wrote:
>>> 
 Aloha!

 I am testing Guillaume's version of pgadmin3.exe from Apr. 17.

 The fix below is included and it seems to fix the problem just fine.
 However, as a side effect (?) there is now a redundant statement for
 each and every column:
  ALTER TABLE foo ALTER COLUMN bar SET STORAGE PLAIN;
 or
  ALTER TABLE foo ALTER COLUMN baz SET STORAGE EXTENDED;

 I think those statements should only be included, if the storage type
 differs from the default setting - like "SET STATISTICS" is handled
 now.
 It is pretty noisy as it is now.

>> "SET STATISTICS" is not really handled this way. We had "SET STATISTICS"
>> statement if the value is bigger than zero. (Because if it is zero,
>> PostgreSQL will use the default_statistics_target setting.
>>
> 
> Actually, 0 (zero) disables statistics gathering. -1 is for reverting to
> the system default.
> http://www.postgresql.org/docs/8.4/interactive/sql-altertable.html
> 

Sorry, was wrong on this one :)

>> Anyway, I agree that "SET STORAGE" is really noisy. Suppose a table with
>> 20 columns. You will have 20 statements about storage. I agree that
>> something like this is needed. My problem is: what should we use as a
>> default value? PLAIN would be the default on non-toastable columns, and
>> EXTENDED the one to use with toastable columns? is there a way to be
>> sure of this?
>>
>>   
 On a side note: I would handle "WITH (OIDS=FALSE)" for table
 definitions likewise: only print it, if it differs from the default
 setting.

>> If we do this, a user won't be able to copy the SQL and paste/execute it
>> on another server if this one has another value for default_with_oids.
>> So, I'm against its removal (unless someone could prove I'm wrong :) ).
>>
> 
> As it is now, the policy is somewhat unclear. Some elements are added
> even though they are redundant under the local settings, others are not.
> If we could switch between complete and compact display, this would help
> to clear the situation.

+1

> In my daily work I reuse code in the same db cluster 99% of the time -
> 95% of the time in the same db. Redundant SQL is only cluttering the
> display and slows me down on a regular basis.
> One or the other redundant key word should not hurt, but we could strip
> most of the noise. (Reduces traffic a bit, too.)
> For cases where we want to copy objects to a different environment, the
> option "complete SQL" should be an improvement, too.
> 
> I would define "local settings" as what "SHOW ALL" returns for the
> current connection (database / user defaults are in effect).
> 

OK.

>>> Maybe an option "Show complete SQL"? To switch between "complete"
>>> (noisy) and default display (only what is necessary to create an
>>> identical object with the current settings).
>>> Personally I am only interested in the "compact" version, but other
>>> people's preferences may vary?
>>>  
>> I'm not sure about this either. How could a user know about the
>> differences between a complete and a partial SQL?
>>
> 
> We could have a note at the very top (possibly optional., too):
> -- SQL complete
> -- SQL for current connection
> Current settings are defined by the connection parameters displayed in
> the toolbar: host, user, database.
> 

Seems better to me.

>>> This would be a major wishlist item. Not complicated, but possibly many
>>> lines of code.
>>>  
>> Well, actually, the only thing I think is needed here is to display (or
>> not) some column's properties. Not complicated, not a lot of code.
>>
> 
> Even better. :) But there are probably a number of cases, where we might
> want to add SQL to the "complete" version or trim in the "compact" version.
> 

Sure. We'll need complete details on these cases :)

>>> What do you think of it? Should I create a ticket?
>>>  
>> Well, I would like to have a better handling of the "SET STORAGE"
>> statement. So, yes, you can create a ticket on that, without being too
>> specific on the solution, which still needs some talk.
>>
> 
> So we agree on "SET STORAGE". I'll create a ticket on that.
> 

Yeah. I also found how to detect the "initial" value of the storage
(column typstorage in pg_catalog.pg_type). So I'll work on this right now.

> The option to switch between "complete" and "compact" is a different
> (more fundamental) feature. I would like it a lot, but I am not coding,
> so I can only suggest.
> 

You can also create a ticket on this. But I'll refrain working on this,
waiting for Dave's opinion on this issue. And it probably won't be for
1.12, as beta will 

Re: [pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

[pgAdmin Trac]

#176: Reduce "SET STORAGE" noise in SQL pannel
---+
 Reporter:  brsa   |   Owner:  gleu
 Type:  bug|  Status:  assigned
 Priority:  minor  |   Milestone:  
Component:  pgadmin| Version:  trunk   
 Keywords:  browser, SQL pane  |Platform:  all 
---+
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8312 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/include/schema pgadmin/schema

[svn]

Author: guillaume

Date: 2010-04-29 17:45:30 +0100 (Thu, 29 Apr 2010)

New Revision: 8312

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8312&view=rev

Log:
Fix to only show Storage value if the value is different from the type's 
default value, per a suggestion from Erwin Brandstetter.
Fixes #176.



Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/include/schema/pgColumn.h
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/schema/pgColumn.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8313 - in trunk/pgadmin3: . pgadmin/include/schema pgadmin/schema

[svn]

Author: guillaume

Date: 2010-04-29 17:46:48 +0100 (Thu, 29 Apr 2010)

New Revision: 8313

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8313&view=rev

Log:
Fix to only show Storage value if the value is different from the type's 
default value, per a suggestion from Erwin Brandstetter.
Fixes #176.



Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/include/schema/pgColumn.h
   trunk/pgadmin3/pgadmin/schema/pgColumn.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #176: Reduce "SET STORAGE" noise in SQL pannel

[pgAdmin Trac]

#176: Reduce "SET STORAGE" noise in SQL pannel
--+-
  Reporter:  brsa |   Owner:  gleu 
  Type:  bug  |  Status:  closed   
  Priority:  minor|   Milestone:  1.10.3   
 Component:  pgadmin  | Version:  1.10 
Resolution:  fixed|Keywords:  browser, SQL pane
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  assigned => closed
  * version:  trunk => 1.10
  * resolution:  => fixed
  * milestone:  => 1.10.3


Comment:

 Fixed in r8312 and 8313.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Guillaume Lelarge]

Le 29/04/2010 17:50, Guillaume Lelarge a écrit :
> Le 29/04/2010 17:28, Erwin Brandstetter a écrit :
>> On 29.04.2010 15:21, guilla...@lelarge.info wrote:
> [...]
 What do you think of it? Should I create a ticket?
  
>>> Well, I would like to have a better handling of the "SET STORAGE"
>>> statement. So, yes, you can create a ticket on that, without being too
>>> specific on the solution, which still needs some talk.
>>>
>>
>> So we agree on "SET STORAGE". I'll create a ticket on that.
>>
> 
> Yeah. I also found how to detect the "initial" value of the storage
> (column typstorage in pg_catalog.pg_type). So I'll work on this right now.
> 

Fixed. I can provide you a new pgAdmin3.exe quite easily if you want.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8314 - in trunk/pgadmin3: . pgadmin/debugger

[svn]

Author: dpage

Date: 2010-04-29 20:02:24 +0100 (Thu, 29 Apr 2010)

New Revision: 8314

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8314&view=rev

Log:
Fix a crash bug seen when closing the debugger parameter dialog on OSX.


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8315 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/debugger

[svn]

Author: dpage

Date: 2010-04-29 20:07:28 +0100 (Thu, 29 Apr 2010)

New Revision: 8315

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8315&view=rev

Log:
Fix a crash bug seen when closing the debugger parameter dialog on OSX.


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Debugger crashing on OSX

[Dave Page]

On Thu, Apr 29, 2010 at 3:19 PM, Ashesh Vashi
 wrote:
> Hi Dave,
> As you found the segment fault on OSX  related to debugger.
> In dlgDirectDbg::OnTargetComplete(), It waits for the function
> this->Show(true) for completion, and "this" pointer will not be available on
> cancellation,  and hence It is crashing on next line.
> ie. this->SetFocus();
> On removing this line, the problem is getting solved.

Thanks, patch applied.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8316 - in trunk/pgadmin3: . pgadmin pgadmin/ctl pgadmin/frm pgadmin/gqb pgadmin/include/ctl pgadmin/include/frm pgadmin/include/gqb

[svn]

Author: dpage

Date: 2010-04-29 20:32:20 +0100 (Thu, 29 Apr 2010)

New Revision: 8316

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8316&view=rev

Log:
Add support for saving the graphical explain and query builder canvases as 
images. [Ashesh Vashi]


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/ctl/explainCanvas.cpp
   trunk/pgadmin3/pgadmin/frm/frmQuery.cpp
   trunk/pgadmin3/pgadmin/gqb/gqbGraphSimple.cpp
   trunk/pgadmin3/pgadmin/gqb/gqbView.cpp
   trunk/pgadmin3/pgadmin/include/ctl/ctlSQLBox.h
   trunk/pgadmin3/pgadmin/include/ctl/explainCanvas.h
   trunk/pgadmin3/pgadmin/include/frm/frmQuery.h
   trunk/pgadmin3/pgadmin/include/frm/menu.h
   trunk/pgadmin3/pgadmin/include/gqb/gqbGraphBehavior.h
   trunk/pgadmin3/pgadmin/include/gqb/gqbGraphSimple.h
   trunk/pgadmin3/pgadmin/include/gqb/gqbViewController.h
   trunk/pgadmin3/pgadmin/pgAdmin3.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8317 - trunk/pgadmin3/pgadmin

[svn]

Author: dpage

Date: 2010-04-29 20:34:40 +0100 (Thu, 29 Apr 2010)

New Revision: 8317

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8317&view=rev

Log:
Remove dead code.


Modified:
   trunk/pgadmin3/pgadmin/pgAdmin3.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH(WIP): Printing Support And Save GQB/Explain as an image

[Dave Page]

On Thu, Apr 29, 2010 at 2:25 PM, Ashesh Vashi
 wrote:
> Hi Dave,
> As discussed, I am not confident about the Printing support on Mac OSX.
> It is working well on other platforms. In fact, Print Preview is also
> working good on OSX. But, It gives arbitrary results for the printing.. (The
> main feature of this patch.) :-(
> I will need some more time investigating the exact issue.
> As discussed, I m taking of the save as an image functionality from the
> patch and sending you the patch for the same with this.
> I am feeling very disappointed, but I do not want to rush into the things
> and do not want to do things in hurry.

Yeah, it's annoying but the right thing to do.

I've committed the patch as it is now, but please work on the
following fixes for the next beta:

- Only enable the Save Image menu options if there is something to
save. Accidently clicking the wrong one currently gives an annoying
'Nothing to save' message.

- Remember the file format selected by the user and use that as the
default the next time.

- Remember the last filename independently for the GQB and EXPLAIN output files.

Thanks!

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8318 - in trunk/pgadmin3/i18n: af_ZA ar_SA bg_BG ca_ES cs_CZ da_DK de_CH de_DE el_GR es_ES fa_IR fi_FI fr_FR gl_ES gu_IN hi_IN hr_HR hu_HU id_ID is_IS it_IT

[svn]

Author: guillaume

Date: 2010-04-29 21:05:50 +0100 (Thu, 29 Apr 2010)

New Revision: 8318

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8318&view=rev

Log:
Automatic merge using stringmerge script.


Modified:
   trunk/pgadmin3/i18n/af_ZA/pgadmin3.po
   trunk/pgadmin3/i18n/ar_SA/pgadmin3.po
   trunk/pgadmin3/i18n/bg_BG/pgadmin3.po
   trunk/pgadmin3/i18n/ca_ES/pgadmin3.po
   trunk/pgadmin3/i18n/cs_CZ/pgadmin3.po
   trunk/pgadmin3/i18n/da_DK/pgadmin3.po
   trunk/pgadmin3/i18n/de_CH/pgadmin3.po
   trunk/pgadmin3/i18n/de_DE/pgadmin3.po
   trunk/pgadmin3/i18n/el_GR/pgadmin3.po
   trunk/pgadmin3/i18n/es_ES/pgadmin3.po
   trunk/pgadmin3/i18n/fa_IR/pgadmin3.po
   trunk/pgadmin3/i18n/fi_FI/pgadmin3.po
   trunk/pgadmin3/i18n/fr_FR/pgadmin3.po
   trunk/pgadmin3/i18n/gl_ES/pgadmin3.po
   trunk/pgadmin3/i18n/gu_IN/pgadmin3.po
   trunk/pgadmin3/i18n/hi_IN/pgadmin3.po
   trunk/pgadmin3/i18n/hr_HR/pgadmin3.po
   trunk/pgadmin3/i18n/hu_HU/pgadmin3.po
   trunk/pgadmin3/i18n/id_ID/pgadmin3.po
   trunk/pgadmin3/i18n/is_IS/pgadmin3.po
   trunk/pgadmin3/i18n/it_IT/pgadmin3.po
   trunk/pgadmin3/i18n/ja_JP/pgadmin3.po
   trunk/pgadmin3/i18n/ko_KR/pgadmin3.po
   trunk/pgadmin3/i18n/lt_LT/pgadmin3.po
   trunk/pgadmin3/i18n/lv_LV/pgadmin3.po
   trunk/pgadmin3/i18n/mk_MK/pgadmin3.po
   trunk/pgadmin3/i18n/nb_NO/pgadmin3.po
   trunk/pgadmin3/i18n/nl_NL/pgadmin3.po
   trunk/pgadmin3/i18n/pl_PL/pgadmin3.po
   trunk/pgadmin3/i18n/pt_BR/pgadmin3.po
   trunk/pgadmin3/i18n/pt_PT/pgadmin3.po
   trunk/pgadmin3/i18n/ro_RO/pgadmin3.po
   trunk/pgadmin3/i18n/ru_RU/pgadmin3.po
   trunk/pgadmin3/i18n/sk_SK/pgadmin3.po
   trunk/pgadmin3/i18n/sl_SI/pgadmin3.po
   trunk/pgadmin3/i18n/sr_RS/pgadmin3.po
   trunk/pgadmin3/i18n/sv_SE/pgadmin3.po
   trunk/pgadmin3/i18n/te_IN/pgadmin3.po
   trunk/pgadmin3/i18n/tl_PH/pgadmin3.po
   trunk/pgadmin3/i18n/tr_TR/pgadmin3.po
   trunk/pgadmin3/i18n/uk_UA/pgadmin3.po
   trunk/pgadmin3/i18n/ur_PK/pgadmin3.po
   trunk/pgadmin3/i18n/vi_VN/pgadmin3.po
   trunk/pgadmin3/i18n/zh_CN/pgadmin3.po
   trunk/pgadmin3/i18n/zh_TW/pgadmin3.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8319 - trunk/pgadmin3/pgadmin/frm

[svn]

Author: dpage

Date: 2010-04-29 21:51:04 +0100 (Thu, 29 Apr 2010)

New Revision: 8319

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8319&view=rev

Log:
Fix some warnings.


Modified:
   trunk/pgadmin3/pgadmin/frm/frmQuery.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by guillaume: r8320 - trunk/pgadmin3/i18n/fr_FR

[svn]

Author: guillaume

Date: 2010-04-29 22:46:37 +0100 (Thu, 29 Apr 2010)

New Revision: 8320

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8320&view=rev

Log:
Update of the french translation.



Modified:
   trunk/pgadmin3/i18n/fr_FR/pgadmin3.mo
   trunk/pgadmin3/i18n/fr_FR/pgadmin3.po

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Erwin Brandstetter]

On 29.04.2010 18:48, guilla...@lelarge.info wrote:

Le 29/04/2010 17:50, Guillaume Lelarge a écrit :
   

Le 29/04/2010 17:28, Erwin Brandstetter a écrit :
 

On 29.04.2010 15:21, guilla...@lelarge.info wrote:
   

[...]
 

What do you think of it? Should I create a ticket?

   

Well, I would like to have a better handling of the "SET STORAGE"
statement. So, yes, you can create a ticket on that, without being too
specific on the solution, which still needs some talk.

 

So we agree on "SET STORAGE". I'll create a ticket on that.

   

Yeah. I also found how to detect the "initial" value of the storage
(column typstorage in pg_catalog.pg_type). So I'll work on this right now.

 

Fixed. I can provide you a new pgAdmin3.exe quite easily if you want.
   


Cool. If you provide me with a new pgAdmin3.exe I will use it for tests.
We are moving in on a point release v1.10.3, aren't we? I found 21 
resolved bugs tagged "1.10.3" in trac - compared to 9 for v1.10.2. So we 
might call it early alpha-testing?


Regards
Erwin

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #14: Save graphical explain output

[pgAdmin Trac]

#14: Save graphical explain output
--+-
  Reporter:  mha  |   Owner:  ashesh.vashi
  Type:  feature  |  Status:  closed  
  Priority:  minor|   Milestone:  1.12
 Component:  pgadmin  | Version:  1.10
Resolution:  fixed|Keywords:  
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  new => closed
  * version:  => 1.10
  * resolution:  => fixed


Comment:

 Done in r8316.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Guillaume Lelarge]

Le 30/04/2010 00:35, Erwin Brandstetter a écrit :
> On 29.04.2010 18:48, guilla...@lelarge.info wrote:
>> Le 29/04/2010 17:50, Guillaume Lelarge a écrit :
>>   
>>> Le 29/04/2010 17:28, Erwin Brandstetter a écrit :
>>> 
 On 29.04.2010 15:21, guilla...@lelarge.info wrote:

>>> [...]
>>> 
>> What do you think of it? Should I create a ticket?
>>
>>
> Well, I would like to have a better handling of the "SET STORAGE"
> statement. So, yes, you can create a ticket on that, without being too
> specific on the solution, which still needs some talk.
>
>  
 So we agree on "SET STORAGE". I'll create a ticket on that.


>>> Yeah. I also found how to detect the "initial" value of the storage
>>> (column typstorage in pg_catalog.pg_type). So I'll work on this right
>>> now.
>>>
>>>  
>> Fixed. I can provide you a new pgAdmin3.exe quite easily if you want.
>>
> 
> Cool. If you provide me with a new pgAdmin3.exe I will use it for tests.

On it.

> We are moving in on a point release v1.10.3, aren't we? I found 21
> resolved bugs tagged "1.10.3" in trac - compared to 9 for v1.10.2. So we
> might call it early alpha-testing?
> 

Not right now. Dave is working on getting out beta 1 for pgAdmin 1.12. I
don't think he has the time to prepare a new 1.10 minor release, and I'm
not sure this is the perfect timing for it. But I hope we'll have one
before 1.12 is final.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Redundant statements

[Erwin Brandstetter]

On 30.04.2010 00:40, guilla...@lelarge.info wrote:

Le 30/04/2010 00:35, Erwin Brandstetter a écrit :
   

On 29.04.2010 18:48, guilla...@lelarge.info wrote:
 

Le 29/04/2010 17:50, Guillaume Lelarge a écrit :

   

Le 29/04/2010 17:28, Erwin Brandstetter a écrit :

 

On 29.04.2010 15:21, guilla...@lelarge.info wrote:

   

[...]

 

What do you think of it? Should I create a ticket?


   

Well, I would like to have a better handling of the "SET STORAGE"
statement. So, yes, you can create a ticket on that, without being too
specific on the solution, which still needs some talk.


 

So we agree on "SET STORAGE". I'll create a ticket on that.


   

Yeah. I also found how to detect the "initial" value of the storage
(column typstorage in pg_catalog.pg_type). So I'll work on this right
now.


 

Fixed. I can provide you a new pgAdmin3.exe quite easily if you want.

   

Cool. If you provide me with a new pgAdmin3.exe I will use it for tests.
 

On it.

   

We are moving in on a point release v1.10.3, aren't we? I found 21
resolved bugs tagged "1.10.3" in trac - compared to 9 for v1.10.2. So we
might call it early alpha-testing?

 

Not right now. Dave is working on getting out beta 1 for pgAdmin 1.12. I
don't think he has the time to prepare a new 1.10 minor release, and I'm
not sure this is the perfect timing for it. But I hope we'll have one
before 1.12 is final.
   


Either way, fine with me. As a bugfix release, 1.10.3 wouldn't need a 
lot of testing, I guess.



Good night!
Erwin

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers