Re: [pgadmin-hackers] debugging in pgadmion 1.10.3

2010-05-21 Thread Ashesh Vashi 
Yeah. You're right.

Dave,

Please find the patch to resolve the issue.
(This is valid for both REL-1_10 branch and trunk).

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company


On Wed, May 19, 2010 at 10:03 PM, fatmijumar fatmijumar <
fatmiju...@gmail.com> wrote:

> Dear Sir:
>
> I have seen in the changelog for pgadmin 1.10.3 your contribution in this
> point (www.pgadmin.org)
>
> 2010-04-22 DP  1.10.3  Don't offer debugging options to non-superusers on
>
>
>Postgres Plus Advanced Server < 8.4 which doesn't
>have support for user debugging [Ashesh Vashi]
>
> I would like to inform you that I am afraid that this is not OK. We are
> running pgadmin 1.10.3 with postgresql 8.4 (not edb), and now we are forced
> to be superusers to debug in 8.4.0, which was not the case with 1.10.2. I
> would appreciate if you can check this, please.
>
> Thanks in advance.
>
> Regards.
>
>
Index: debugger/debugger.cpp
===
--- debugger/debugger.cpp	(revision 8382)
+++ debugger/debugger.cpp	(working copy)
@@ -115,7 +115,7 @@
 return false;
 
 // EnterpriseDB 8.3 or earlier does not support debugging by the non-superuser
-if (!obj->GetServer()->GetSuperUser() && !obj->GetConnection()->EdbMinimumVersion(8, 4))
+if (!obj->GetServer()->GetSuperUser() && !obj->GetConnection()->EdbMinimumVersion(8, 4) && obj->GetConnection()->GetIsEdb())
 return false;
 
 if (!obj->IsCollection())

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: An error occurred: Error:Invalid Out Parameter... if select Debug function having IN OUT Parameter

2010-05-21 Thread Ashesh Vashi 
Hi Dave,

Small typo in previous patch related to the one...

--
Ashesh


FB15423_v2.patch
Description: Binary data


FB15423_trunk.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8383 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/debugger

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 15:27:56 +0100 (Fri, 21 May 2010)

New Revision: 8383

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8383&view=rev

Log:
Fix debugging of functions by non-superusers in PG again. [Ashesh Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/debugger/debugger.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8384 - in trunk/pgadmin3: . pgadmin/debugger

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 15:28:46 +0100 (Fri, 21 May 2010)

New Revision: 8384

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8384&view=rev

Log:
Fix debugging of functions by non-superusers in PG again. [Ashesh Vashi]


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/debugger/debugger.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] debugging in pgadmion 1.10.3

2010-05-21 Thread Dave Page 
Thanks, applied.

On Fri, May 21, 2010 at 3:28 AM, Ashesh Vashi
 wrote:
> Yeah. You're right.
> Dave,
> Please find the patch to resolve the issue.
> (This is valid for both REL-1_10 branch and trunk).
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company
>
> On Wed, May 19, 2010 at 10:03 PM, fatmijumar fatmijumar
>  wrote:
>>
>> Dear Sir:
>>
>> I have seen in the changelog for pgadmin 1.10.3 your contribution in this
>> point (www.pgadmin.org)
>>
>> 2010-04-22 DP  1.10.3  Don't offer debugging options to non-superusers on
>>
>>
>>
>>Postgres Plus Advanced Server < 8.4 which doesn't
>>have support for user debugging [Ashesh Vashi]
>>
>> I would like to inform you that I am afraid that this is not OK. We are
>> running pgadmin 1.10.3 with postgresql 8.4 (not edb), and now we are forced
>> to be superusers to debug in 8.4.0, which was not the case with 1.10.2. I
>> would appreciate if you can check this, please.
>>
>> Thanks in advance.
>>
>> Regards.
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8385 - in trunk/pgadmin3: . pgadmin/debugger

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 15:41:30 +0100 (Fri, 21 May 2010)

New Revision: 8385

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8385&view=rev

Log:
Fix a typo in the stored procedure debugger invocation code block. [Ashesh 
Vashi]


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8386 - branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/debugger

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 15:42:25 +0100 (Fri, 21 May 2010)

New Revision: 8386

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8386&view=rev

Log:
Fix a typo in the stored procedure debugger invocation code block. [Ashesh 
Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/debugger/dlgDirectDbg.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8387 - branches/REL-1_10_0_PATCHES/pgadmin3

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 15:42:25 +0100 (Fri, 21 May 2010)

New Revision: 8387

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8387&view=rev

Log:
Update changelog


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: PATCH: An error occurred: Error:Invalid Out Parameter... if select Debug function having IN OUT Parameter

2010-05-21 Thread Dave Page 
Thanks, patch applied.

On Fri, May 21, 2010 at 8:58 AM, Ashesh Vashi
 wrote:
> Hi Dave,
>
> Small typo in previous patch related to the one...
>
> --
> Ashesh



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8388 - in trunk/pgadmin3: . pgadmin/dlg

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 16:34:45 +0100 (Fri, 21 May 2010)

New Revision: 8388

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8388&view=rev

Log:
Drop package bodies correctly if they only contain whitespace. [Ashesh Vashi]


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/pgadmin/dlg/dlgPackage.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8389 - trunk/pgadmin3

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 16:34:46 +0100 (Fri, 21 May 2010)

New Revision: 8389

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8389&view=rev

Log:
Fix pasting foobar in the changelog.


Modified:
   trunk/pgadmin3/CHANGELOG

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] SVN Commit by dpage: r8390 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/dlg

2010-05-21 Thread svn 
Author: dpage

Date: 2010-05-21 16:34:55 +0100 (Fri, 21 May 2010)

New Revision: 8390

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8390&view=rev

Log:
Drop package bodies correctly if they only contain whitespace. [Ashesh Vashi]


Modified:
   branches/REL-1_10_0_PATCHES/pgadmin3/CHANGELOG
   branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/dlg/dlgPackage.cpp

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers