[pgadmin-hackers] #197 copy/paste numeric fields
Hi Dave,
I attached a patch for #197.
Please be so kind to review, if this was all about this issue.
Regards
Steffen
diff --git a/pgadmin/frm/frmEditGrid.cpp b/pgadmin/frm/frmEditGrid.cpp
index 67a28e9..d8c9e68 100644
--- a/pgadmin/frm/frmEditGrid.cpp
+++ b/pgadmin/frm/frmEditGrid.cpp
@@ -716,6 +716,11 @@ void frmEditGrid::OnPaste(wxCommandEvent &ev)
else
boolEd->Set3StateValue(wxCHK_UNDETERMINED);
}
+else if (ed->IsKindOf(CLASSINFO(wxTextCtrl)))
+ {
+ wxTextCtrl *txtEd = (wxTextCtrl *)ed;
+ txtEd->SetValue(data.GetText());
+ }
}
wxTheClipboard->Close();
}
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] #197 copy/paste numeric fields
Hi Dave,
I attached a patch for #197.
Please be so kind to review, if this was all about this issue.
Regards
Steffen
diff --git a/pgadmin/frm/frmEditGrid.cpp b/pgadmin/frm/frmEditGrid.cpp
index 67a28e9..d8c9e68 100644
--- a/pgadmin/frm/frmEditGrid.cpp
+++ b/pgadmin/frm/frmEditGrid.cpp
@@ -716,6 +716,11 @@ void frmEditGrid::OnPaste(wxCommandEvent &ev)
else
boolEd->Set3StateValue(wxCHK_UNDETERMINED);
}
+else if (ed->IsKindOf(CLASSINFO(wxTextCtrl)))
+ {
+ wxTextCtrl *txtEd = (wxTextCtrl *)ed;
+ txtEd->SetValue(data.GetText());
+ }
}
wxTheClipboard->Close();
}
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update german translation, per Steffen Kuhn.
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=579ffc5ba10c3362dca61ae28c3dfc686ea40b2c Author: Steffen Kuhn Log Message --- Update german translation, per Steffen Kuhn. Branch -- REL-1_12_0_PATCHES Modified Files -- i18n/de_DE/pgadmin3.mo | Bin 192876 -> 192877 bytes i18n/de_DE/pgadmin3.po |4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update afrikaans translation, per Petri Jooste.
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1d8a2f6a1b6629d5d716b2bfba5cf820ab1ec33b Author: Petri Jooste Log Message --- Update afrikaans translation, per Petri Jooste. Branch -- REL-1_12_0_PATCHES Modified Files -- i18n/af_ZA/pgadmin3.mo | Bin 146088 -> 155067 bytes i18n/af_ZA/pgadmin3.po |17852 2 files changed, 12004 insertions(+), 5848 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Enhance the INSTALL document
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7f2295c1920993d51d758b8e84e917d158f4c09d Author: Robert Haas Log Message --- Enhance the INSTALL document Branch -- master Modified Files -- INSTALL | 45 + 1 files changed, 37 insertions(+), 8 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] install instructions
Le 28/08/2010 03:37, Robert Haas a écrit : > Over the last couple of days, Dave Page has been kind enough to talk > me through getting a development environment set up today on both > MacOS X and Windows, which was a challenge for me because I am > basically a Linux geek, not to mention a console geek. It turns out > that we had to work around a few problems that were not mentioned in > the INSTALL file, so I thought maybe the attached patch to that file > would be helpful to the next person in a similar situation. > > The strangest thing that we ran into was that the build-wxmsw.bat > script simply didn't work. At first it didn't work because I didn't > run it from the directory that it lives in (which is the only place > from which it can be expected to work), but even after I figured out > that problem it just spewed errors when trying to convert the project > files. Dave recommended the alternate method documented here. > Great, thanks for the patch. I pushed it on our git repo. -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Quoting names is not required for unreserved keywor
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c85ef8a3d4313e157ee90705baba616da894fa2e Author: Robert Haas Log Message --- Quoting names is not required for unreserved keywords This patch brings the behavior more closely into alignment with what core PG does. Unreserved keywords are not quoted anymore. Patch from Robert Haas. Branch -- master Modified Files -- CHANGELOG |2 ++ pgadmin/utils/misc.cpp | 44 +++- 2 files changed, 9 insertions(+), 37 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] quoting behavior
Le 27/08/2010 23:18, Robert Haas a écrit : > Dave Page and I were discussing the word "name" this morning. I said > "I like to use a column called 'name' in a lot of my tables" and he > said "I don't like to do that because the quoting is really annoying" > and I said "what quoting?". Long story short, it turns out that > postgresql and pgdump do not quote the word name, but pgadmin does. > The reason for this is that pgadmin quotes all keywords, even > unreserved keywords, except for type names, when it quotes all > keywords except for a fixed list that is hardcoded into the > needsQuoting() function. > > Attached, please find a patch that brings the behavior more closely > into alignment with what core PG does. It skips quoting all > UNRESERVED_KEYWORDs, and when forTypes is true, it also skips quoting > COL_NAME_KEYWORDs. It might also be safe to skip quoting > TYPE_FUNC_NAME_KEYWORDs when forTypes is false, but I opted not to do > in this patch that because I'm less sure of whether it's safe. Not > quoting UNRESERVED_KEYWORDs seems pretty safe because an unreserved > keyword can't be used in the grammar in any place where a column name, > type name, function name, or table name can appear. There shouldn't > ever be any possibility of confusing an unreserved keyword with an > identifier, so they don't need to be quoted (see, e.g., > quote_identifier() in src/backend/utils/adt/ruleutils.c). Not quoting > COL_NAME_KEYWORDs when forTypes is true should have about the same > effect as the current hardcoded list, because basically that's just a > list of all of the buitin types that happen to also be > COL_NAME_KEYWORDs. The differences are (1) if someone happens to > define a type with the same name as a current or future > COL_NAME_KEYWORD, the new coding will avoid quoting it unnecessarily; > and (2) if the keyword ANY is used as a type name, it will be quoted, > which is a good thing, because that's required, and the inclusion of > that name into the current list appears to be an error, since any is > in fact a RESERVED_KEYWORD. > > Have mercy on me if this patch is stupid, badly formatted, submitted > incorrectly, or otherwise poorly-thought-out. I'm new here. :-) > :) Seems good to me. Applied to the master branch. Thanks again. -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
