[pgadmin-hackers] pgAdmin website commit: Carme's new email address.

[Guillaume Lelarge]

Carme's new email address.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=e3165312604df7187dd51a9466711e6c54288aaf

Modified Files
--
translation/config.php |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Carme's new email address.

[Guillaume Lelarge]

Carme's new email address.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=0eaa652f6292da1d21e6a300226e544f29aa332d

Modified Files
--
docs/cs_CZ/translation_team.html |4 ++--
docs/en_US/translation_team.html |2 +-
docs/fr_FR/translation_team.html |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Carme's new email address.

[Guillaume Lelarge]

Carme's new email address.

Branch
--
REL-1_12_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f3daaf8f20e9e0065b2bd8e230f180e92cdff25f

Modified Files
--
docs/cs_CZ/translation_team.html |4 ++--
docs/en_US/translation_team.html |2 +-
docs/fr_FR/translation_team.html |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #277: Little mistake in comment in inheriting table

[pgAdmin Trac]

#277: Little mistake in comment in inheriting table
---+
 Reporter:  Vojtěch Látal  |   Owner:  gleu
 Type:  bug|  Status:  new 
 Priority:  minor  |   Milestone:  
Component:  pgadmin| Version:  1.12
 Keywords:  table  |Platform:  all 
---+
 Just a little thing: I wanted to try inheriting. So I made a table "del"
 which inherits from table "vehicles".

 Create script follows:
 -- Table: del

 -- DROP TABLE del;

 CREATE TABLE del
 (
 -- Inherited from table del:  id integer NOT NULL DEFAULT
 nextval('vehicle_id_seq'::regclass),
 -- Inherited from table del:  vin character varying(20) NOT NULL,
 -- Inherited from table del:  licence_plate character varying(12) NOT
 NULL,
  a boolean
 )
 INHERITS (vehicles)
 WITH (
  OIDS=FALSE
 );
 ALTER TABLE del OWNER TO gary;


 It seems it should be "-- Inherited from table vehicles:" instead of
 current "-- Inherited from table del:".

 Version: 1.12.1 from Community repo
 OS: ArchLinux, kernel 2.6.35
 PostgreSQL: 9.0.1

 Steps to reproduce:
 1) (create database,) create table, put some columns into.
 2) create another table from contextual menu, select "New Table..."
 3) "New Table..." dialog opens, put some table name in, open "Inherits"
 tab
 4) select table you created in 1), click Add
 5) select "Columns" tab, add some column
 6) create table by clicking "OK"
 7) select newly created table from step 6) and in SQL pane you'll see what
 I've included.

 Thanks guys for huge piece of good work. I really appreciate what you are
 doing.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 4 spaces versus tabs

[Robert Haas]

On Tue, Nov 2, 2010 at 5:52 PM, Guillaume Lelarge
 wrote:
> Le 24/10/2010 07:49, Dave Page a écrit :
>> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge
>>  wrote:
>>> IIRC, we should use spaces and not tabs. If I look into the code, I see
>>> many tabs in it. I can of course configure my editor to display them as
>>> four tabs, but I would really like to get rid of them.
>>>
>>> Any objections? because it would be a hell of a patch (90427 replacements)
>>
>> Go for it. The project standard is for spaces.
>>
>> Though, if we're going to make such a big change, I have to wonder if
>> tabs would be a more convenient choice in hindsight...
>>
>
> Actually, I don't like tabs :)
>
> But I don't care that much. What I would like to have is a nice source
> code, and, now, it doesn't look that nice.
>
> So, if it is tabs, so be it :)

I like tabs, but that's just me, and I don't work on pgAdmin.  It
sucks trying to move back and forth between projects with different
styles, though, and pgsql uses tabs.

Another thing to consider if you're thinking about a massive fixup
commit is removing trailing whitespace.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 4 spaces versus tabs

[Guillaume Lelarge]

Le 11/11/2010 22:10, Robert Haas a écrit :
> On Tue, Nov 2, 2010 at 5:52 PM, Guillaume Lelarge
>  wrote:
>> Le 24/10/2010 07:49, Dave Page a écrit :
>>> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge
>>>  wrote:
 IIRC, we should use spaces and not tabs. If I look into the code, I see
 many tabs in it. I can of course configure my editor to display them as
 four tabs, but I would really like to get rid of them.

 Any objections? because it would be a hell of a patch (90427 replacements)
>>>
>>> Go for it. The project standard is for spaces.
>>>
>>> Though, if we're going to make such a big change, I have to wonder if
>>> tabs would be a more convenient choice in hindsight...
>>>
>>
>> Actually, I don't like tabs :)
>>
>> But I don't care that much. What I would like to have is a nice source
>> code, and, now, it doesn't look that nice.
>>
>> So, if it is tabs, so be it :)
> 
> I like tabs, but that's just me, and I don't work on pgAdmin.  It
> sucks trying to move back and forth between projects with different
> styles, though, and pgsql uses tabs.
> 

So go for it.

Just waiting to know Dave's opinion on all this before moving on.

> Another thing to consider if you're thinking about a massive fixup
> commit is removing trailing whitespace.
> 

Oh, great idea. There's probably an option for that too.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 4 spaces versus tabs

[Dave Page]

On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge
 wrote:
>
> Just waiting to know Dave's opinion on all this before moving on.

I'm leaning to tabs.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 4 spaces versus tabs

[Guillaume Lelarge]

Le 11/11/2010 22:32, Dave Page a écrit :
> On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge
>  wrote:
>>
>> Just waiting to know Dave's opinion on all this before moving on.
> 
> I'm leaning to tabs.
> 

OK. And no issue with me pushing such a huge patch?


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] 4 spaces versus tabs

[Dave Page]

On Thu, Nov 11, 2010 at 9:34 PM, Guillaume Lelarge
 wrote:
> Le 11/11/2010 22:32, Dave Page a écrit :
>> On Thu, Nov 11, 2010 at 9:24 PM, Guillaume Lelarge
>>  wrote:
>>>
>>> Just waiting to know Dave's opinion on all this before moving on.
>>
>> I'm leaning to tabs.
>>
>
> OK. And no issue with me pushing such a huge patch?

No. Please document the options you use though.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix the comment on inherited column

[Guillaume Lelarge]

Fix the comment on inherited column

The comment was wrong because it gets the child table name, and not the parent
table name. The patch fixes this.

Unfortunately, this patch still doesn't fix comments for multi-inherited table.

Fixes #277.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=16961db60b8dd28249982504618d93853242917b

Modified Files
--
CHANGELOG   |1 +
pgadmin/dlg/dlgTable.cpp|2 +-
pgadmin/schema/pgColumn.cpp |5 +++--
3 files changed, 5 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix the comment on inherited column

[Guillaume Lelarge]

Fix the comment on inherited column

The comment was wrong because it gets the child table name, and not the parent
table name. The patch fixes this.

Unfortunately, this patch still doesn't fix comments for multi-inherited table.

Fixes #277.

Branch
--
REL-1_12_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=96ac26714616ec393f45e8cf3980110b76a29e92

Modified Files
--
CHANGELOG   |1 +
pgadmin/dlg/dlgTable.cpp|2 +-
pgadmin/schema/pgColumn.cpp |5 +++--
3 files changed, 5 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #277: Little mistake in comment in inheriting table

[pgAdmin Trac]

#277: Little mistake in comment in inheriting table
+---
  Reporter:  Vojtěch Látal  |   Owner:  gleu  
  Type:  bug|  Status:  closed
  Priority:  minor  |   Milestone:  1.12.2
 Component:  pgadmin| Version:  1.12  
Resolution:  fixed  |Keywords:  table 
  Platform:  all|  
+---
Changes (by gleu):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.12.2


Comment:

 Fixed in
 
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commit;h=96ac26714616ec393f45e8cf3980110b76a29e92
 and
 
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commit;h=16961db60b8dd28249982504618d93853242917b.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers