Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build
On Thu, Feb 3, 2011 at 3:00 AM, Peter Geoghegan wrote: > > I'm going to clean up your commit from the other day per your > suggestion. I'm also going to get started on moving OGL into the tree, > and building it ourselves. OK. > I've noticed that the sample OGL applications have obvious bugs in > them, probably because of my cursory fixes to get them to work against > 2.9. I wasn't too worried about it at the time. Should I be now? I'll > certainly want to clean up numerous OGL compiler warnings. We won't be including the sample apps in our tree. Probably just headers in pgadmin/include/ogl and required source in pgadmin/ogl > I'm seeing some errors like this: > > An error has occurred: > > XRC error: file:/home/peter/pgadmin3/pgadmin/ui/dlgTable.xrc:6: > unknown style flag "wxRESIZE_BOX" > > ...and... > > An error has occurred: > > XRC error: file:/home/peter/pgadmin3/pgadmin/ui/frmHint.xrc:6: unknown > style flag "wxTHICK_FRAME" Hmm, interesting. Is that coming from wxrc, or when building xrcDialogs.cpp? > Any suggestions on a good place to attack to remove the probable AUI > related weirdness? Sometimes the "Object browser" header (i.e. where > it says object browser) isn't visible. the other panes seem unaffected > though. Object browser seems well behaved when docked anywhere other > than its default position. My first suggestion would be to select the "Default View" option, and see if that helps. Failing that, comment out the code that sets either the default or the stored perspective, and see what happens if you let the controls figure out their own default layout. > There's this too, which I see when I start the SQL editor: > > Program received signal SIGSEGV, Segmentation fault. > 0x00460063 in wxWindowBase::GetSize (this=0xd9d9abab8686) > at /usr/local/include/wx-2.9/wx/window.h:321 > 321 DoGetSize(& w, & h); > (gdb) bt > #0 0x00460063 in wxWindowBase::GetSize (this=0xd9d9abab8686) > at /usr/local/include/wx-2.9/wx/window.h:321 > #1 0x008024b1 in gqbSplitter::onVerticalSashResize (this=0x18bbb40, > event=...) at ./gqb/gqbController.cpp:596 > #2 0x7577349d in > wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, > wxEvent&) const () from /usr/local/lib/libwx_baseu-2.9.so.1 > #3 0x7598dcf1 in > wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, > wxEvtHandler*, wxEvent&) () > from /usr/local/lib/libwx_baseu-2.9.so.1 > #4 0x7598de53 in wxEventHashTable::HandleEvent(wxEvent&, > wxEvtHandler*) () from /usr/local/lib/libwx_baseu-2.9.so.1 > #5 0x7598e1e3 in wxEvtHandler::ProcessEventLocally(wxEvent&) () > from /usr/local/lib/libwx_baseu-2.9.so.1 > #6 0x7598e25d in wxEvtHandler::ProcessEvent(wxEvent&) () > from /usr/local/lib/libwx_baseu-2.9.so.1 > #7 0x765fb611 in wxSplitterWindow::DoSendEvent(wxSplitterEvent&) () > from /usr/local/lib/libwx_gtk2u_core-2.9.so.1 > #8 0x765fbce9 in wxSplitterWindow::SetSashPositionAndNotify(int) () > from /usr/local/lib/libwx_gtk2u_core-2.9.so.1 > #9 0x765fbeb9 in wxSplitterWindow::OnSize(wxSizeEvent&) () > from /usr/local/lib/libwx_gtk2u_core-2.9.so.1 Trying to get the size of something before it's drawn perhaps? > I see this, which prevents me from calling the edit table dialog: > > An error has occurred: > > XRC error: file:/home/peter/pgadmin3/pgadmin/ui/dlgTable.xrc:330: too > many children in grid sizer: 36 > 3 x 11 (consider omitting the number > of rows or columns) Probably a simple counting error. I suspect theres just one row too many. > I expect to fix quite a few bugs tomorrow. My feeling is that we're > past the worst of it though. I'd like to close phase 2 by having a > pgAdmin III that builds against 2.9 with no obvious defects, but > doesn't yet have OGL in the tree. We'll then have something to commit > before moving on to phase 3, bringing OGL into the pgAdmin tree and > building it ourselves. Thoughts? Sounds like a plan! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Fix a regression in my previous patch, which fixed
Fix a regression in my previous patch, which fixed VC++ and broke GCC builds. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b139f19bab884f83266ef539932111f2767d90f6 Modified Files -- pgadmin/debugger/dlgDirectDbg.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Implement a more reliable method for detecting chan
Implement a more reliable method for detecting changes to the focussed control on the main form, by implementing a custom wxAuiNotebook control which passes ChildFocus events to it's parent. Primarily this is used at the moment for enabling/disabling the Copy menu option, but we'll use the new control everywhere for ease of future hacking. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ac60bb573155cd24fc45aa08a41887c1bb612677 Modified Files -- pgadmin/ctl/ctlAuiNotebook.cpp | 31 ++ pgadmin/ctl/module.mk |3 +- pgadmin/debugger/ctlTabWindow.cpp |2 +- pgadmin/frm/events.cpp | 39 ++-- pgadmin/frm/frmMain.cpp | 82 ++-- pgadmin/frm/frmQuery.cpp|4 +- pgadmin/frm/frmStatus.cpp |2 +- pgadmin/gqb/gqbController.cpp |2 +- pgadmin/gqb/gqbView.cpp |2 +- pgadmin/include/ctl/ctlAuiNotebook.h| 35 +++ pgadmin/include/ctl/module.mk |1 + pgadmin/include/debugger/ctlTabWindow.h |2 +- pgadmin/include/frm/frmMain.h |4 +- pgadmin/include/frm/frmQuery.h |5 +- pgadmin/include/frm/frmStatus.h |2 +- pgadmin/include/gqb/gqbViewController.h |5 +- pgadmin/include/precomp.h |1 + pgadmin/pgAdmin3.vcproj | 170 --- 18 files changed, 236 insertions(+), 156 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Add a couple of #includes to keep GCC happy, and ru
Add a couple of #includes to keep GCC happy, and run make style. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fece0701999fda206b788edf9c4c640a007f5cc2 Modified Files -- pgadmin/ctl/ctlAuiNotebook.cpp |9 ++--- pgadmin/debugger/ctlTabWindow.cpp|1 + pgadmin/include/ctl/ctlAuiNotebook.h |2 +- 3 files changed, 8 insertions(+), 4 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: The generic list view control on the Mac doesn't fi
The generic list view control on the Mac doesn't fire focus events as it should, so we set currentControl here instead of relying on the ChildFocusEvent. The native list view does fire the events, but does weird things with multi-select items so we currently disable it (see the creation of the listviews in frmMain.cpp). Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=182d7e0d974379b96430fe857de7926254c3 Modified Files -- pgadmin/frm/events.cpp | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Trim the training newline from text copied from a l
Trim the training newline from text copied from a listview. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2be50ad0a363d54785c2ddc528020810e9f2a24e Modified Files -- pgadmin/frm/frmMain.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III: synonym support for EDBAS functions/procedures
Hi Dave, > > > I'm inclined to consider this a bug, as my failure to update this > > prior to the release of 1.12 means that our support for that feature > > is essentially broken. > > > > Does anyone object, before I commit it to 1.12? > > > > No objection here. > > > Aye from the patch submitter too :) Do we wait for more "Ayes" here or there is some feedback on which I should work on? Please let me know. Regards, Nikhils
[pgadmin-hackers] pgAdmin III: 'public' schema not selected by default for "Default Privileges" tab
Hi,
If one right clicks on database and goes to properties, there the "Default
Privileges" tab does not seem to contain the 'public' schema pre-selected.
It is so the case in the normal "Privileges" for example. This patch
pre-populates the 'public' schema for the default privileges case too.
Regards,
Nikhils
diff --git a/pgadmin/ctl/ctlDefaultSecurityPanel.cpp b/pgadmin/ctl/ctlDefaultSecurityPanel.cpp
index 870e0ba..59a8614 100644
--- a/pgadmin/ctl/ctlDefaultSecurityPanel.cpp
+++ b/pgadmin/ctl/ctlDefaultSecurityPanel.cpp
@@ -153,6 +153,8 @@ ctlDefaultPrivilegesPanel::ctlDefaultPrivilegesPanel(ctlDefaultSecurityPanel *de
stGroup = new wxStaticText(this, CTL_DEFSTATICGROUP, strGroupLabel);
itemSizer4a->Add(stGroup, 0, wxEXPAND | wxALIGN_CENTRE_VERTICAL | wxTOP | wxLEFT | wxRIGHT, 4);
cbGroups = new ctlComboBox(this, CTL_DEFCBGROUP, wxDefaultPosition, wxDefaultSize);
+ cbGroups->Append(wxT("public"));
+ cbGroups->SetSelection(0);
itemSizer4a->Add(cbGroups, wxEXPAND | wxALIGN_CENTRE_VERTICAL | wxTOP | wxLEFT | wxRIGHT);
itemSizer3->Add(itemSizer4a, 0, wxEXPAND | wxALL, 0);
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
