[pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

[Nikhil S]

Hi,

In PPAS 90, if an SPL-function has both an OUT-parameter and a return value
(which is not possible on PostgreSQL otherwise), the return value is
transformed into an extra OUT-parameter named "_retval_". Although we fixed
the normal code path a while back, the debugger still remains dazed and
confused. We need to teach it to ignore "_retval_" parameter too. PFA, patch
to do the same.

Regards,
Nikhils
diff --git a/pgadmin/debugger/dbgTargetInfo.cpp b/pgadmin/debugger/dbgTargetInfo.cpp
index 8c9b937..6a3ddfb 100644
--- a/pgadmin/debugger/dbgTargetInfo.cpp
+++ b/pgadmin/debugger/dbgTargetInfo.cpp
@@ -135,6 +135,23 @@ dbgTargetInfo::dbgTargetInfo( const wxString &target,  dbgPgConn *conn, char tar
 		if( argName.IsEmpty())
 			argName.Printf( wxT( "$%d" ), argCount );
 
+		// In EDBAS 90, if an SPL-function has both an OUT-parameter
+		// and a return value (which is not possible on PostgreSQL otherwise),
+		// the return value is transformed into an extra OUT-parameter
+		// named "_retval_"
+		if (argName == wxT("_retval_") && conn->EdbMinimumVersion(9, 0))
+		{
+			// this will be the return type for this object
+			m_returnType = types.GetNextToken();
+
+			// consume uniformly, mode will definitely be "OUT"
+			modes.GetNextToken();
+
+			// ignore OID also..
+			typeOids.GetNextToken();
+			continue;
+		}
+
 		wsArgInfo	argInfo( argName, types.GetNextToken(), modes.GetNextToken(), typeOids.GetNextToken());
 
 		if( argInfo.getMode() == wxT( "i" ))

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: In PPAS 90, if an SPL-function has both an OUT-para

[Dave Page]

In PPAS 90, if an SPL-function has both an OUT-parameter and a
return value (which is not possible on PostgreSQL otherwise),
the return value is transformed into an extra OUT-parameter named
"_retval_". Although we fixed the normal code path a while back,
the debugger still remains dazed and confused. We need to teach it
to ignore "_retval_" parameter too

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1a16e74e4efa8fb54071ac784481f0647dd99001
Author: Nikhil S 

Modified Files
--
pgadmin/debugger/dbgTargetInfo.cpp |   17 +
1 files changed, 17 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

[Dave Page]

Thanks, applied.

On Fri, Apr 1, 2011 at 12:05 PM, Nikhil S  wrote:
> Hi,
>
> In PPAS 90, if an SPL-function has both an OUT-parameter and a return value
> (which is not possible on PostgreSQL otherwise), the return value is
> transformed into an extra OUT-parameter named "_retval_". Although we fixed
> the normal code path a while back, the debugger still remains dazed and
> confused. We need to teach it to ignore "_retval_" parameter too. PFA, patch
> to do the same.
>
> Regards,
> Nikhils
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: In PPAS 90, if an SPL-function has both an OUT-para

[Dave Page]

In PPAS 90, if an SPL-function has both an OUT-parameter and a
return value (which is not possible on PostgreSQL otherwise),
the return value is transformed into an extra OUT-parameter named
"_retval_". Although we fixed the normal code path a while back,
the debugger still remains dazed and confused. We need to teach it
to ignore "_retval_" parameter too

Branch
--
REL-1_12_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2eb588f6dfeb3b20d37db27b8db2a04b85861d63
Author: Nikhil S 

Modified Files
--
pgadmin/debugger/dbgTargetInfo.cpp |   17 +
1 files changed, 17 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

[Nikhil S]

>
> Thanks, applied.
>
>
Thanks Dave. How's the lunch on the cruise? ;)

Regards,
Nikhils

Re: [pgadmin-hackers] pgAdmin III: debugger does not handle PPAS functions with OUT parameters properly

[Dave Page]

On Fri, Apr 1, 2011 at 1:45 PM, Nikhil S  wrote:
>> Thanks, applied.
>>
>
> Thanks Dave. How's the lunch on the cruise? ;)

Nom nom nom... :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #303: Support for extensions

[pgAdmin Trac]

#303: Support for extensions
+---
 Reporter:  gleu|   Owner:  gleu
 Type:  bug |  Status:  assigned
 Priority:  minor   |   Milestone:  
Component:  pgadmin | Version:  trunk   
 Keywords:  extensions 9.1  |Platform:  all 
+---
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin III] #303: Support for extensions

[pgAdmin Trac]

#303: Support for extensions
--+-
  Reporter:  gleu |   Owner:  gleu  
  Type:  feature  |  Status:  closed
  Priority:  minor|   Milestone:  1.14  
 Component:  pgadmin  | Version:  trunk 
Resolution:  fixed|Keywords:  extensions 9.1
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed
  * type:  bug => feature
  * milestone:  => 1.14


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.

[pgAdmin Trac]

#300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.
---+
 Reporter:  gleu   |   Owner:  gleu
 Type:  feature|  Status:  assigned
 Priority:  minor  |   Milestone:  
Component:  pgadmin| Version:  trunk   
 Keywords:  index 9.1  |Platform:  all 
---+
Changes (by gleu):

  * owner:  dpage => gleu
  * status:  new => assigned


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.

[pgAdmin Trac]

#300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.
--+-
  Reporter:  gleu |   Owner:  gleu 
  Type:  feature  |  Status:  closed   
  Priority:  minor|   Milestone:  1.14 
 Component:  pgadmin  | Version:  trunk
Resolution:  fixed|Keywords:  index 9.1
  Platform:  all  |  
--+-
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed
  * milestone:  => 1.14


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers