Re: [pgadmin-hackers] A question about database designer first deliverable
Sorry for delay but I almost can't work until today because I was finishing something related to a subject that I'm taking and I feel a little sick but I'm better now and I'm going to start to work again As you notice, in fact I didn't send my weekly report because I have too little to report, but here is: - Some TODO fixed yet. - Added a class to allow storing and retrieving of attributes like line size, font color, size and others user defined attributes at each figure. This is needed for future persistence creation at DD (Database Designer) and for user custom figures like tables with different colors. Today I'm going to start again to work with the database designer, and I was thinking about my last question this days and there are more than one, and because it, I'm going to clean all code with your instruction but I think that not all DD-TODO items can be done right now, because that I'll create a list of DD-TODO, that I won't accomplish right now and a solution like or a delay explanation. And then you can help me to decide what to do next. DD-TODO: xyz, it will be code in another goal of this project or need first XY Regards. Luis. On Thu, May 19, 2011 at 1:05 AM, Guillaume Lelarge wrote: > On 05/16/2011 09:28 AM, Guillaume Lelarge wrote: > > Le 05/13/2011 12:05 AM, Luis Ochoa a écrit : > >> Hi, Guillaume, I have found my first issue, I wrote at my schedule that > for > >> my first deliverable I won't create code any new features for database > >> designer class commitable status, but when I try to do all "DD-TODO" > labels, > >> I have found some things that I need to write new code to accomplish the > >> goal of delete it, I have not problem with coding it, except when that > label > >> have a big change to code, in that case can I postpone it, don't delete > that > >> label and accomplish it later (when marked at my schedule if apply)? > >> > > > > You'll need to be more precise if you want that I can give you an > > interesting answer. Which feature is it? > > > > Can you give us more informations on this? > > > -- > Guillaume > http://www.postgresql.fr > http://dalibo.com >
[pgadmin-hackers] pgAdmin III commit: So, I changed the locale on my setup to "zh_CN.UTF-
So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore into a database using a backup from earlier. When I click on "Display objects" tab, I see an error being displayed, although the actual restore happens just fine. Note that no error occurs in English locales. Took me a while to figure this one out. The issue is with frmRestore::OnEndProcess() function. It naively avoids lines containing ";" or "P" as the first letter. So in the English locale, the last line about the "Process returned exit code 0" is handled. However in other locales, this will be translated and hence the last line will be inspected leading to a spurious error. The fix is to avoid inspecting the last line. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=73df2d05995957128c666817f6f883513e50d931 Author: Nikhil S Modified Files -- pgadmin/frm/frmRestore.cpp |4 1 files changed, 4 insertions(+), 0 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: So, I changed the locale on my setup to "zh_CN.UTF-
So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore into a database using a backup from earlier. When I click on "Display objects" tab, I see an error being displayed, although the actual restore happens just fine. Note that no error occurs in English locales. Took me a while to figure this one out. The issue is with frmRestore::OnEndProcess() function. It naively avoids lines containing ";" or "P" as the first letter. So in the English locale, the last line about the "Process returned exit code 0" is handled. However in other locales, this will be translated and hence the last line will be inspected leading to a spurious error. The fix is to avoid inspecting the last line. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=69525eab38f9073a74a46fc42aef32f1d875b6dc Author: Nikhil S Modified Files -- pgadmin/frm/frmRestore.cpp |4 1 files changed, 4 insertions(+), 0 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Thanks - applied. On Wed, May 18, 2011 at 12:03 PM, Nikhil S wrote: > Please ignore the last patch. Some unwanted debug changes in there! > Please use this one. > > Regards, > Nikhils > > On Wed, May 18, 2011 at 5:28 PM, Nikhil S wrote: >> >> Hi, >> >> So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore >> into a database using a backup from earlier. When I click on "Display >> objects" tab, I see an error being displayed, although the actual restore >> happens just fine. Note that no error occurs in English locales. >> >> Took me a while to figure this one out. The issue is with >> frmRestore::OnEndProcess() function. It naively avoids lines containing ";" >> or "P" as the first letter. So in the English locale, the last line about >> the "Process returned exit code 0" is handled. However in other locales, >> this will be translated and hence the last line will be inspected leading to >> a spurious error. >> >> The fix is to avoid inspecting the last line. The attached patch does >> that. >> >> Regards, >> Nikhils > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Thanks Dave. Regards, Nikhils On Thu, May 19, 2011 at 9:15 PM, Dave Page wrote: > Thanks - applied. > > On Wed, May 18, 2011 at 12:03 PM, Nikhil S wrote: > > Please ignore the last patch. Some unwanted debug changes in there! > > Please use this one. > > > > Regards, > > Nikhils > > > > On Wed, May 18, 2011 at 5:28 PM, Nikhil S wrote: > >> > >> Hi, > >> > >> So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to > restore > >> into a database using a backup from earlier. When I click on "Display > >> objects" tab, I see an error being displayed, although the actual > restore > >> happens just fine. Note that no error occurs in English locales. > >> > >> Took me a while to figure this one out. The issue is with > >> frmRestore::OnEndProcess() function. It naively avoids lines containing > ";" > >> or "P" as the first letter. So in the English locale, the last line > about > >> the "Process returned exit code 0" is handled. However in other locales, > >> this will be translated and hence the last line will be inspected > leading to > >> a spurious error. > >> > >> The fix is to avoid inspecting the last line. The attached patch does > >> that. > >> > >> Regards, > >> Nikhils > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
