[pgadmin-hackers] pgAdmin III commit: Change DD dialogs with XRC ones

[Guillaume Lelarge]

Change DD dialogs with XRC ones

Only ddTableNameDialog and ddPrecisionScaleDialog are done yet.
ddSelectKindFksDialog is still missing.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cbebf5558270c6a8e6b26c3a78548e2d6fe20bee

Modified Files
--
.../dd/dditems/figures/ddTextTableItemFigure.cpp   |   21 +--
pgadmin/dd/dditems/tools/ddColumnTextTool.cpp  |9 +-
.../dditems/utilities/ddPrecisionScaleDialog.cpp   |  162 ++--
pgadmin/dd/dditems/utilities/ddTableNameDialog.cpp |  201 +++-
pgadmin/dd/ddmodel/ddDrawingEditor.cpp |9 +-
pgadmin/frm/frmDatabaseDesigner.cpp|7 -
.../dd/dditems/utilities/ddPrecisionScaleDialog.h  |   58 +-
.../dd/dditems/utilities/ddTableNameDialog.h   |   50 +
pgadmin/ui/ddPrecisionScaleDialog.xrc  |   98 ++
pgadmin/ui/ddTableNameDialog.xrc   |  105 ++
pgadmin/ui/module.mk   |2 +
11 files changed, 276 insertions(+), 446 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] First test of the Database Designer

[Guillaume Lelarge]

On Mon, 2011-06-27 at 09:09 +0200, Guillaume Lelarge wrote:
> On Sun, 2011-06-26 at 20:29 +0100, Dave Page wrote:
> > On Sat, Jun 25, 2011 at 3:50 PM, Guillaume Lelarge
> >  wrote:
> > > On Sat, 2011-06-25 at 15:51 +0200, Guillaume Lelarge wrote:
> > >> On Sat, 2011-06-25 at 12:18 +0200, Guillaume Lelarge wrote:
> > >> > [...]
> > >> > Dave, any objection on applying the current work of Luis? I'll work 
> > >> > this
> > >> > afternoon on the xpm files, I should be able to send a patch after 
> > >> > that.
> > >> >
> > >>
> > >> Branch available here:
> > >>
> > >> https://github.com/gleu/pgadmin3/tree/gsoc2011
> > >>
> > >> Patches attached (they will be applied as one).
> > >>
> > >
> > > And here are the changes on the VC++ project file.
> > >
> > > Waiting for comments before applying :)
> > 
> > Hi,
> > 
> > Sorry - in the late stages of my current project, so I'm swamped with
> > testing/QA/docs/you name it! I won't be able to review, but trust you
> > to do so Guillaume.
> 
> OK, thanks.
> 
> >  The one comment I would make from the thread is
> > that I don't think the code should be committed without the XRC
> > changes you mention. If that's not done before it's committed, I doubt
> > it ever will be.
> > 
> 
> I don't want that Luis lost some time working on the XRC files. And I
> don't want him to get stuck before I do it. So, I commited the patch,
> and pushed it, so that he could work from the new master. And I'll work
> on the XRC files tonight.
> 

Done partly. I still have one dialog to work on. But I need more
informations from Luis. So, it'll have to wait.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

[Thom Brown]

Hi,

I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a
foreign key on a table, a dialogue comes up saying "Foreign Key -
Foreign Key - No / Yes"

Screenshot attached.

I would expect this to say something more like "Drop foreign key? -
Are you sure you wish to drop foreign key "fk_name"? - No / Yes"

Is this a known bug?

Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<>
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

[Guillaume Lelarge]

On Sat, 2011-07-02 at 12:12 +0100, Thom Brown wrote:
> Hi,
> 
> I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a
> foreign key on a table, a dialogue comes up saying "Foreign Key -
> Foreign Key - No / Yes"
> 
> Screenshot attached.
> 
> I would expect this to say something more like "Drop foreign key? -
> Are you sure you wish to drop foreign key "fk_name"? - No / Yes"
> 
> Is this a known bug?
> 

Yeah. Better than that actually : it is a fixed bug :) Fix is available
in git since 2011-06-11, and will appear first in beta 3.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

[Thom Brown]

On 2 July 2011 13:08, Guillaume Lelarge  wrote:
> On Sat, 2011-07-02 at 12:12 +0100, Thom Brown wrote:
>> Hi,
>>
>> I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a
>> foreign key on a table, a dialogue comes up saying "Foreign Key -
>> Foreign Key - No / Yes"
>>
>> Screenshot attached.
>>
>> I would expect this to say something more like "Drop foreign key? -
>> Are you sure you wish to drop foreign key "fk_name"? - No / Yes"
>>
>> Is this a known bug?
>>
>
> Yeah. Better than that actually : it is a fixed bug :) Fix is available
> in git since 2011-06-11, and will appear first in beta 3.

Thanks Guillaume.  I'm having trouble finding these fixes by the look
of things as a search didn't show it up.  I'll have to search more
thoroughly next time. :)

Any ETA for beta 3?

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [BUG] Meaningless dialogue when deleting foreign key

[Guillaume Lelarge]

On Sat, 2011-07-02 at 13:11 +0100, Thom Brown wrote:
> On 2 July 2011 13:08, Guillaume Lelarge  wrote:
> > On Sat, 2011-07-02 at 12:12 +0100, Thom Brown wrote:
> >> Hi,
> >>
> >> I'm using PgAdmin III 1.14 beta 2 on OSX.  When attempting to delete a
> >> foreign key on a table, a dialogue comes up saying "Foreign Key -
> >> Foreign Key - No / Yes"
> >>
> >> Screenshot attached.
> >>
> >> I would expect this to say something more like "Drop foreign key? -
> >> Are you sure you wish to drop foreign key "fk_name"? - No / Yes"
> >>
> >> Is this a known bug?
> >>
> >
> > Yeah. Better than that actually : it is a fixed bug :) Fix is available
> > in git since 2011-06-11, and will appear first in beta 3.
> 
> Thanks Guillaume.  I'm having trouble finding these fixes by the look
> of things as a search didn't show it up.  I'll have to search more
> thoroughly next time. :)
> 

Good luck with that, my commit message was somewhat cryptic (Fix our
i18n support). See
https://github.com/postgres/pgadmin3/commit/6f88f423f024d9ed5d6081c66f2351249a5bd190

> Any ETA for beta 3?
> 

Nope. I could reply "at the same time than PostgreSQL 9.1 beta 3", but
this won't help you more.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

[Guillaume Lelarge]

On Thu, 2011-06-30 at 09:32 +0100, Dave Page wrote:
> On Thu, Jun 30, 2011 at 9:08 AM, Guillaume Lelarge
>  wrote:
> >
> > Could be the next thing I do. Last time we talked about it, I had done
> > some work on sphynx. IIRC, I had two main things to do:
> >
> >  * try to build on Windows, and Mac
> >  * change the build chain so that it buils automatically the manual
> >
> > Did I forgot something?
> 
> No, I think that's it.
> 

OK, I've done some work on this.

Linux prep steps

 * install Python (with your distro package manager)
 * install the python easy_install module
 * install Sphinx (should be as easy as "easy_install -U Sphinx)

Windows prop steps

 * download http://www.python.org/ftp/python/2.7.2/python-2.7.2.msi
 * install python-2.7.2.msi
 * download
http://pypi.python.org/packages/2.7/s/setuptools/setuptools-0.6c11.win32-py2.7.exe#md5=57e1e64f6b7c7f1d2eddfc9746bbaf20
 * install setuptools-0.6c11.win32-py2.7.exe
 * include C:\Python27\Scripts in %path%
 * in cmd, type "easy_install.exe -U Sphinx"

Mac OS X prep steps

I already had Python and the easy_install module, so I just had to
install Sphinx with the usual command ("easy_install -U Sphinx")

Windows Visual Studio project changes

It should be quite simple. We simply need to change the Docs project so
that it launches the "make html" command instead of the "builddocs.bat".
We'll also have to add all the rst files in this project.

Linux, and Mac OS X Makefile

This should also be quite simple. We only need to change the Makefile so
that it calls the Make in the docs directory.

If it seems good enough for you, I'll update the rst filess with the new
changes. I'll update the build system. And creates one big patch for all
of this. OK?

The remaining question is: what style do we want? do we keep the default
theme? should we code one? any idea on what that should be?


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin website commit: New roadmap.

[Guillaume Lelarge]

New roadmap.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=1323b2e7477b9a1955276d8bd518dc2d01dd5ee3

Modified Files
--
development/roadmap.php |   14 +-
1 files changed, 5 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #322: CHECK constraints with NOT VALID

[pgAdmin Trac]

#322: CHECK constraints with NOT VALID
+---
 Reporter:  gleu|   Owner:  gleu 
 Type:  feature |  Status:  new  
 Priority:  minor   |   Milestone:   
Component:  pgadmin | Version:  trunk
 Keywords:  checks domains 9.2  |Platform:  all  
+---
 9.2 feature

 
http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=897795240cfaaed724af2f53ed2c50c9862f951f

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

[Thom Brown]

Hi, me again.

I noticed that on the table properties dialogue window, the checkbox
for "Has OIDs" is disabled if there aren't any OIDs already for the
table rows.  I believe the check used for enabling this isn taking
into account that PostgreSQL versions 8.4 and above can re-enable
OIDs.

Patch attached to implement this.

While I was poking around in the section in question, I noticed that
some of the ALTER TABLE statements don't place a newline before the
SET keyword, and some do.

For example:

Those without newlines:
ALTER TABLE tablename DROP CONSTRAINT
ALTER TABLE tablename SET WITHOUT OIDS;
ALTER TABLE tablename SET TABLESPACE...

Those with newlines:
ALTER TABLE tablename
  SET (FILLFACTOR=...)
ALTER TABLE tablename
  RESET(...)

I personally prefer the ones with newlines, especially since I've been
experimenting with tables having very long names, and some of the
above statements require lots of horizontal scrolling on the SQL tab
to see what the action will be.  Could we harmonise these?  Note that
I didn't change the format for OIDs when I added the WITH OIDS
variant.

Thanks
-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/pgadmin/dlg/dlgTable.cpp b/pgadmin/dlg/dlgTable.cpp
index d3ae082..6ec4c9f 100644
--- a/pgadmin/dlg/dlgTable.cpp
+++ b/pgadmin/dlg/dlgTable.cpp
@@ -249,7 +249,8 @@ int dlgTable::Go(bool modal)
 
 		btnAddTable->Enable(connection->BackendMinimumVersion(8, 2) && cbTables->GetGuessedSelection() >= 0);
 		lbTables->Enable(connection->BackendMinimumVersion(8, 2));
-		chkHasOids->Enable(table->GetHasOids() && connection->BackendMinimumVersion(8, 0));
+		chkHasOids->Enable((connection->BackendMinimumVersion(8, 0) && table->GetHasOids())
+		   || connection->BackendMinimumVersion(8, 4));
 		cbTablespace->Enable(connection->BackendMinimumVersion(7, 5));
 
 		wxCookieType cookie;
@@ -921,11 +922,16 @@ wxString dlgTable::GetSql()
 		// Add the ADD CONSTRAINTs...
 		sql += tmpsql;
 
-		if (chkHasOids->GetValue() != table->GetHasOids())
+		if (!chkHasOids->GetValue() && table->GetHasOids())
 		{
 			sql += wxT("ALTER TABLE ") + tabname
 			   +  wxT(" SET WITHOUT OIDS;\n");
 		}
+		if (chkHasOids->GetValue() && !table->GetHasOids())
+		{
+			sql += wxT("ALTER TABLE ") + tabname
+			   +  wxT(" SET WITH OIDS;\n");
+		}
 		if (connection->BackendMinimumVersion(8, 0) && cbTablespace->GetOIDKey() != table->GetTablespaceOid())
 			sql += wxT("ALTER TABLE ") + tabname
 			   +  wxT(" SET TABLESPACE ") + qtIdent(cbTablespace->GetValue())

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix a crash bug when trying to create a new table o

[Guillaume Lelarge]

Fix a crash bug when trying to create a new table on 8.3

Instead of deleting the autovacuum notebook page, pgAdmin deleted the
constraints notebook page. So, when the user clicked OK, pgAdmin tried to find
changes in the constraints widgets which didn't exist anymore.

This bug was introduced by me when I added the new Definition tab to most of
the dialogs. Will do a complete check of "DeletePage" in each of the dialogs.

Branch
--
REL-1_14_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=46bb9e4c66947cc8edfe853c1506ceeb470f475e

Modified Files
--
pgadmin/dlg/dlgTable.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix a crash bug when trying to create a new table o

[Guillaume Lelarge]

Fix a crash bug when trying to create a new table on 8.3

Instead of deleting the autovacuum notebook page, pgAdmin deleted the
constraints notebook page. So, when the user clicked OK, pgAdmin tried to find
changes in the constraints widgets which didn't exist anymore.

This bug was introduced by me when I added the new Definition tab to most of
the dialogs. Will do a complete check of "DeletePage" in each of the dialogs.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=797b3f5c34657816e7bf07c350a3bc5ad687edc1

Modified Files
--
pgadmin/dlg/dlgTable.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Enable "Has OIDs" on 8.4+ when table is created

[Guillaume Lelarge]

Enable "Has OIDs" on 8.4+ when table is created

I noticed that on the table properties dialogue window, the checkbox
for "Has OIDs" is disabled if there aren't any OIDs already for the
table rows.  I believe the check used for enabling this isn't taking
into account that PostgreSQL versions 8.4 and above can re-enable
OIDs.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c03f033357757142bc2def508ebb29311f9c1e20
Author: Thom Brown 

Modified Files
--
CHANGELOG|2 ++
pgadmin/dlg/dlgTable.cpp |   10 --
2 files changed, 10 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

[Guillaume Lelarge]

Hi,

On Sat, 2011-07-02 at 16:18 +0100, Thom Brown wrote:
[...]
> 
> I noticed that on the table properties dialogue window, the checkbox
> for "Has OIDs" is disabled if there aren't any OIDs already for the
> table rows.  I believe the check used for enabling this isn taking
> into account that PostgreSQL versions 8.4 and above can re-enable
> OIDs.
> 
> Patch attached to implement this.
> 

Great patch. It even helped me find a bug. Anyway, commited and pushed.
Thank you.

> While I was poking around in the section in question, I noticed that
> some of the ALTER TABLE statements don't place a newline before the
> SET keyword, and some do.
> 
> For example:
> 
> Those without newlines:
> ALTER TABLE tablename DROP CONSTRAINT
> ALTER TABLE tablename SET WITHOUT OIDS;
> ALTER TABLE tablename SET TABLESPACE...
> 
> Those with newlines:
> ALTER TABLE tablename
>   SET (FILLFACTOR=...)
> ALTER TABLE tablename
>   RESET(...)
> 
> I personally prefer the ones with newlines, especially since I've been
> experimenting with tables having very long names, and some of the
> above statements require lots of horizontal scrolling on the SQL tab
> to see what the action will be.  Could we harmonise these?

Yes, we should. Could you provide a patch?

>   Note that
> I didn't change the format for OIDs when I added the WITH OIDS
> variant.
> 

No problem.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

[Thom Brown]

On 2 July 2011 20:20, Guillaume Lelarge  wrote:
> Great patch. It even helped me find a bug. Anyway, commited and pushed.
> Thank you.

Thanks for committing it. :)

>> I personally prefer the ones with newlines, especially since I've been
>> experimenting with tables having very long names, and some of the
>> above statements require lots of horizontal scrolling on the SQL tab
>> to see what the action will be.  Could we harmonise these?
>
> Yes, we should. Could you provide a patch?

Sure, I'll take a look at it.

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin website commit: More roadmap.

[Guillaume Lelarge]

More roadmap.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=7d7822a40396f53e43d461eced26a3ac1ca1a8ae

Modified Files
--
development/roadmap.php |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #323: CLUSTER in maintenance window

[pgAdmin Trac]

#323: CLUSTER in maintenance window
+---
 Reporter:  Thom Brown  |   Owner:  dpage
 Type:  feature |  Status:  new  
 Priority:  minor   |   Milestone:   
Component:  pgadmin | Version:  trunk
 Keywords:  |Platform:  all  
+---
 The CLUSTER maintenance operation is not available in pgAdmin. It would be
 interesting to have it.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #324: Generate Reports

[pgAdmin Trac]

#324: Generate Reports
--+-
 Reporter:  Boblitz John  |   Owner:  dpage
 Type:  feature   |  Status:  new  
 Priority:  minor |   Milestone:   
Component:  pgadmin   | Version:  trunk
 Keywords:|Platform:  all  
--+-
 I am currently trying to generate ddl reports of the db for my programmers
 as a reference.

 Currently I must do this for each and every table individually (right
 click -> report -> ddl report, change output file name - rinse, repeat x
 100)

 The output file is defaulted to the last generated file.

 When dealing with hundreds of tables, this can be a bit tiring ...

 It would be nice if we could have a method to generated the reports for
 all files, say per right click on Tables and be allowed to
 either group the output into one big report, or each table individually -
 name would default to the table name, possibly appended with report type
 (ddl etc...).  Lastly a generic location could be specified for the output
 ...

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Update CHANGELOG and make style.

[Guillaume Lelarge]

Update CHANGELOG and make style.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ac158b076d598748d8d9bac4afc1ae028b05d28a

Modified Files
--
CHANGELOG  |5 -
.../dditems/utilities/ddPrecisionScaleDialog.cpp   |2 +-
pgadmin/dd/dditems/utilities/ddTableNameDialog.cpp |4 ++--
.../dd/dditems/utilities/ddPrecisionScaleDialog.h  |2 +-
.../dd/dditems/utilities/ddTableNameDialog.h   |2 +-
5 files changed, 9 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Update CHANGELOG and make style.

[Thom Brown]

On 2 July 2011 23:17, Guillaume Lelarge  wrote:
> Update CHANGELOG and make style.
>
> Branch
> --
> master
>
> Details
> ---
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ac158b076d598748d8d9bac4afc1ae028b05d28a
>
> Modified Files
> --
> CHANGELOG                                          |    5 -
> .../dditems/utilities/ddPrecisionScaleDialog.cpp   |    2 +-
> pgadmin/dd/dditems/utilities/ddTableNameDialog.cpp |    4 ++--
> .../dd/dditems/utilities/ddPrecisionScaleDialog.h  |    2 +-
> .../dd/dditems/utilities/ddTableNameDialog.h       |    2 +-
> 5 files changed, 9 insertions(+), 6 deletions(-)

You appear to have added an entry for the fill factor patch twice.

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers