[pgadmin-hackers] Re: [pgAdmin III] #335: Different Behavior on Privileges and Default Privileges Tab Pages of Properties Screen of Database and Schema on pgAdmin III

2011-08-30 Thread pgAdmin Trac 
#335: Different Behavior on Privileges and Default Privileges Tab Pages of
Properties Screen of Database and Schema on pgAdmin III
+---
 Reporter:  Kashif Zeeshan  |   Owner:  gleu
 Type:  bug |  Status:  assigned
 Priority:  minor   |   Milestone:  
Component:  pgadmin | Version:  1.12
 Keywords:  properties  |Platform:  all 
+---
Changes (by gleu):

  * status:  new => assigned
  * owner:  dpage => gleu


Old description:

> Following are the differences in the behavior on Privileges and Default
> Privileges Tab Pages when adding Privileges on the Properties Sheet of
> Database and Schema on pgAdmin III.
>
> First Issue
> =
> On Privileges Tab Page when a role is added without Privileges (click on
> Add/Change button without selecting any check box in Privileges section)
> then one row is added with role name in the list and when the same role
> is changed by adding the privileges in the Privileges section then the
> same row is updated but incase of Default Privileges Tab (Table, Sequence
> and Functions sub tabs) when the same above steps are followed then two
> rows are added, one with role name and second with role name and the
> assigned privileges. One Row must be added on Default Privileges Tab same
> as on Privileges Tab.
>
> Second Issue
> ==
> After performing the steps in First Issue when the row is selected and
> remove button is pressed on Privileges Tab then the row is deleted from
> the list and now if Add/Change button is clicked (without selecting any
> check box in Privileges section) then another row is added with selected
> role. But on Default Privileges Tab (Table, Sequence and Functions sub
> tabs) afrer deleteing the added rows if Add/Change button is pressed
> (without selecting any check box in Privileges section) then no new row
> is added with selected role. The row should be added with select role on
> Default Privileges Tab same as on Privileges Tab.

New description:

 Following are the differences in the behavior on Privileges and Default
 Privileges Tab Pages when adding Privileges on the Properties Sheet of
 Database and Schema on pgAdmin III.

 First Issue
 =
 On Privileges Tab Page when a role is added without Privileges (click on
 Add/Change button without selecting any check box in Privileges section)
 then one row is added with role name in the list and when the same role is
 changed by adding the privileges in the Privileges section then the same
 row is updated but incase of Default Privileges Tab (Table, Sequence and
 Functions sub tabs) when the same above steps are followed then two rows
 are added, one with role name and second with role name and the assigned
 privileges. One Row must be added on Default Privileges Tab same as on
 Privileges Tab.

--

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #336: Different Behavior on Privileges and Default Privileges Tab Pages of Properties Screen of Database and Schema on pgAdmin III

2011-08-30 Thread pgAdmin Trac 
#336: Different Behavior on Privileges and Default Privileges Tab Pages of
Properties Screen of Database and Schema on pgAdmin III
+---
 Reporter:  Kashif Zeeshan  |   Owner:  dpage
 Type:  feature |  Status:  new  
 Priority:  minor   |   Milestone:   
Component:  pgadmin | Version:  1.12 
 Keywords:  properties  |Platform:  all  
+---
 Following are the differences in the behavior on Privileges and Default
 Privileges Tab Pages when adding Privileges on the Properties Sheet of
 Database and Schema on pgAdmin III.

 (first issue is #335)

 Second Issue
 ==
 After performing the steps in First Issue when the row is selected and
 remove button is pressed on Privileges Tab then the row is deleted from
 the list and now if Add/Change button is clicked (without selecting any
 check box in Privileges section) then another row is added with selected
 role. But on Default Privileges Tab (Table, Sequence and Functions sub
 tabs) afrer deleteing the added rows if Add/Change button is pressed
 (without selecting any check box in Privileges section) then no new row is
 added with selected role. The row should be added with select role on
 Default Privileges Tab same as on Privileges Tab.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin III] #335: Different Behavior on Privileges and Default Privileges Tab Pages of Properties Screen of Database and Schema on pgAdmin III

2011-08-30 Thread pgAdmin Trac 
#335: Different Behavior on Privileges and Default Privileges Tab Pages of
Properties Screen of Database and Schema on pgAdmin III
-+--
  Reporter:  Kashif Zeeshan  |   Owner:  gleu  
  Type:  bug |  Status:  closed
  Priority:  minor   |   Milestone:  1.14  
 Component:  pgadmin | Version:  1.12  
Resolution:  fixed   |Keywords:  properties
  Platform:  all |  
-+--
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed
  * milestone:  => 1.14


-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix two bugs in default security panel

2011-08-30 Thread Guillaume Lelarge 
Fix two bugs in default security panel

1. When a user clicks on an item in the list, there was no update on the 
combobox
and the checkboxes.

2. This one was reported by Kashif Zeeshan:
"On Privileges Tab Page when a role is added without Privileges (click on
Add/Change? button without selecting any check box in Privileges section) then
one row is added with role name in the list and when the same role is changed
by adding the privileges in the Privileges section then the same row is
updated but incase of Default Privileges Tab (Table, Sequence and Functions
sub tabs) when the same above steps are followed then two rows are added, one
with role name and second with role name and the assigned privileges. One Row
must be added on Default Privileges Tab same as on Privileges Tab."

Fixes #335

Branch
--
REL-1_14_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9a5e0b7da7da0c4a2973b3308cc8e6b903ab81dd

Modified Files
--
pgadmin/ctl/ctlDefaultSecurityPanel.cpp |   44 +-
1 files changed, 42 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix two bugs in default security panel

2011-08-30 Thread Guillaume Lelarge 
Fix two bugs in default security panel

1. When a user clicks on an item in the list, there was no update on the 
combobox
and the checkboxes.

2. This one was reported by Kashif Zeeshan:
"On Privileges Tab Page when a role is added without Privileges (click on
Add/Change? button without selecting any check box in Privileges section) then
one row is added with role name in the list and when the same role is changed
by adding the privileges in the Privileges section then the same row is
updated but incase of Default Privileges Tab (Table, Sequence and Functions
sub tabs) when the same above steps are followed then two rows are added, one
with role name and second with role name and the assigned privileges. One Row
must be added on Default Privileges Tab same as on Privileges Tab."

Fixes #335

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4559082affae56feb7c3e2db1a2db878630f95f7

Modified Files
--
pgadmin/ctl/ctlDefaultSecurityPanel.cpp |   44 +-
1 files changed, 42 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin III] #337: Ctrl-C in edit broken under Windows

2011-08-30 Thread pgAdmin Trac 
#337: Ctrl-C in edit broken under Windows
-+--
 Reporter:  brsa |   Owner:  dpage  
 Type:  bug  |  Status:  new
 Priority:  minor|   Milestone: 
Component:  pgadmin  | Version:  trunk  
 Keywords:   |Platform:  windows
-+--
 When copying with Ctrl-C the _original_ state of the textbox is copied
 instead of the actual selection.
 However, chosing "Copy" from the context menu works as expected.

 This bug has been around for a long time. At least since v1.12.

 I am testing on windows XP Pro and this may be specific to Windows or
 Windows XP, as Guillaume could not reproduce it on Linux.

 There is a thread concerning this one in -hackers:
 http://archives.postgresql.org/pgadmin-hackers/2011-04/msg00195.php


 Steps to reproduce:

 Pick any text filed in the edit grid.
 Enter edit mode
 Select a part of the field OR edit and select any part.
 Paste anywhere inside pgAdmin or in another program
 -> The whole text field in its initial state has been copied instead of
 the selection.

-- 
Ticket URL: 
pgAdmin III 
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] v1.14 beta1: Ctrl-C does not copy selected text inside a textbox in the edit grid

2011-08-30 Thread Erwin Brandstetter 

Aloha!

On 30.04.2011 09:43, Erwin Brandstetter wrote:

On 30.04.2011 09:23, Guillaume Lelarge wrote:

Le 29/04/2011 16:55, Erwin Brandstetter a écrit :

[...]
Testing pgAdmin v1.14 beta1 on Win XP Home

Concerning ..

2010-08-30 GL 1.14.0 Allow the use of Ctrl-V inside a textbox of

frmEditGrid. Patch from Steffen Kuhn.

Ctrl-V now works fine to paste text.
If I select part of the text (in edit mode) and use "Copy" from the
context menu, the selected text is copied. As expected.

However, if I press Ctrl-C, the whole text is copied instead of the
selection. This should copy the selected text as well.
The problem has been there in previous versions.


Works for me on Linux. And I don't see anything in the code that would
make it a Windows only bug. Are you sure?


A detail that might help: when copying with Ctrl-C the _original_ state of the 
textbox is copied.
Example:
A text field reads "dummy text".
I enter edit mode and change it to "11dummy11 22text22"
Then I select any part of the text and press Ctrl-C, Ctrl-V: "dummy text" is 
inserted - the original text of the field before entering edit mode.
BTW, pasting via context-menu does exactly the same as Ctrl-V. Only Ctrl-C 
deviates.


The bug is still there in v1.14.0 RC1. I have created a ticket.
http://code.pgadmin.org/trac/ticket/337

It can be a pain, because Ctrl-C and Ctrl-V are probably the most frequently 
used key combinations of all.

Regards
Erwin

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fixed Combobox for Reference columns showing droppe

2011-08-30 Thread Guillaume Lelarge 
Fixed Combobox for Reference columns showing dropped columns in FK dialog

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d382630e057e59792e44aae260a53c7a521827d7
Author: Julius Tuskenis 

Modified Files
--
pgadmin/dlg/dlgForeignKey.cpp |1 +
1 files changed, 1 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fixed Combobox for Reference columns showing droppe

2011-08-30 Thread Guillaume Lelarge 
Fixed Combobox for Reference columns showing dropped columns in FK dialog

Branch
--
REL-1_14_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fd49692da42a710c3f9d42953173712df43cd139
Author: Julius Tuskenis 

Modified Files
--
pgadmin/dlg/dlgForeignKey.cpp |1 +
1 files changed, 1 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers