[pgadmin-hackers] Option "Nulls First" in the ordering screen.
Hello, I implemented an option "Nulls First" in the ordering screen. It's just a checkbox for versions >= 8.3 of PostgreSQL. What do you think?
Re: [pgadmin-hackers] Keywords in Uppercase
Hello, > > I think that option "Keywords in Uppercase" not should stay in the > "Colours" tab, should stay in the "Query Tools" tab. > > What do you think? > > In fact, this option is very cool! > If you agree, I can send the patch. Thank You.
Re: [pgadmin-hackers] Keywords in Uppercase
On Thu, 2011-10-27 at 08:51 -0200, Vinicius Santos wrote: > Hello, > > > > > I think that option "Keywords in Uppercase" not should stay in the > > "Colours" tab, should stay in the "Query Tools" tab. > > > > What do you think? > > > > In fact, this option is very cool! > > > > > If you agree, I can send the patch. > There is no tab in 1.15. The Options dialog has been completely redesigned. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
On Thu, 2011-10-27 at 08:43 -0200, Vinicius Santos wrote: > Hello, > > I implemented an option "Nulls First" in the ordering screen. > It's just a checkbox for versions >= 8.3 of PostgreSQL. > > What do you think? Which ordering screen? -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Keywords in Uppercase
On Thu, 2011-10-27 at 17:15 -0200, Vinicius Santos wrote: > > > > There is no tab in 1.15. The Options dialog has been completely > > redesigned. > > > > > Forgiveness, is not tab. > > This option is under "Colours". > I think it should be under "Query Tool". > > What do you think? Don't answer to me only, answer to the list please. Not under "Query tool". Under "Query editor", yes, could be. I won't have any problem applying such a patch. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Keywords in Uppercase
> Don't answer to me only, answer to the list please. > Sorry, I did not realize. > > Not under "Query tool". Under "Query editor", yes, could be. I won't > have any problem applying such a patch. > Ok. I send the patch tonight. Thaks.
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
On Thu, 2011-10-27 at 17:21 -0200, Vinicius Santos wrote: > > > > > > Which ordering screen? > > > > > dlgEditGridOptions. Beside the button "wxID_REMOVE". Nope, would be better if it was a radiobox below the column name. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
Don't forget the list! On Thu, 2011-10-27 at 17:31 -0200, Vinicius Santos wrote: > > Nope, would be better if it was a radiobox below the column name. > > > > > Humm. > I did not think at radiobox, because this feature is only available from > 8.3. And? I don't get your point here. The version it first appeared doesn't affect the UI. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Fwd: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
I did not realize again ... Nope, would be better if it was a radiobox below the column name. > > Humm. I did not think at radiobox, because this feature is only available from 8.3.
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
> And? I don't get your point here. The version it first appeared doesn't > affect the UI. > Ok. But for versions < 8.3, I disable the radiobox, right? Since the query: "SELECT column FROM table ORDER BY column NULLS FIRST" would not work on these versions.
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
On Thu, 2011-10-27 at 18:47 -0200, Vinicius Santos wrote: > > > > Yes. Our UI guideline is to disable (and not hide) widgets when the > > option is not available (whatever the reason). > > > > Ok. Do you agree with implementation ? > I agree with the idea. I'll agree with the implementation once I'll read the patch :) > Can I submit the patch tomorrow? Sure. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
On Thu, 2011-10-27 at 17:39 -0200, Vinicius Santos wrote: > > And? I don't get your point here. The version it first appeared doesn't > > affect the UI. > > > > Ok. But for versions < 8.3, I disable the radiobox, right? > Yes. Our UI guideline is to disable (and not hide) widgets when the option is not available (whatever the reason). > Since the query: > "SELECT column FROM table ORDER BY column NULLS FIRST" would not work on > these versions. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Option "Nulls First" in the ordering screen.
> > Yes. Our UI guideline is to disable (and not hide) widgets when the > option is not available (whatever the reason). > Ok. Do you agree with implementation ? Can I submit the patch tomorrow?
